X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FTransactionRateLimitingCallbackTest.java;h=14783441b77e96ac837a784fbe2f923aa1ffbb86;hp=de3a78073f26cf5d72ee87998ed28a74229a28a0;hb=5f68a7764947819b184e63311770bab2ef192f93;hpb=4a114730dfc6b5fd914582020a55601ea288a498 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/TransactionRateLimitingCallbackTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/TransactionRateLimitingCallbackTest.java index de3a78073f..14783441b7 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/TransactionRateLimitingCallbackTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/TransactionRateLimitingCallbackTest.java @@ -7,7 +7,7 @@ */ package org.opendaylight.controller.cluster.datastore; -import static org.junit.Assert.fail; +import static org.junit.Assert.assertThrows; import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.anyLong; import static org.mockito.Mockito.doReturn; @@ -19,8 +19,9 @@ import com.google.common.base.Ticker; import java.util.concurrent.TimeUnit; import org.junit.Before; import org.junit.Test; +import org.junit.runner.RunWith; import org.mockito.Mock; -import org.mockito.MockitoAnnotations; +import org.mockito.junit.MockitoJUnitRunner; import org.opendaylight.controller.cluster.datastore.utils.ActorUtils; /** @@ -28,14 +29,12 @@ import org.opendaylight.controller.cluster.datastore.utils.ActorUtils; * * @author Thomas Pantelis */ +@RunWith(MockitoJUnitRunner.StrictStubs.class) public class TransactionRateLimitingCallbackTest { - @Mock ActorUtils mockContext; - @Mock Timer mockTimer; - @Mock Ticker mockTicker; @@ -43,7 +42,6 @@ public class TransactionRateLimitingCallbackTest { @Before public void setUp() { - MockitoAnnotations.initMocks(this); doReturn(mockTimer).when(mockContext).getOperationTimer(ActorUtils.COMMIT); callback = new TransactionRateLimitingCallback(mockContext); TransactionRateLimitingCallback.setTicker(mockTicker); @@ -85,12 +83,7 @@ public class TransactionRateLimitingCallbackTest { @Test public void testSuccessWithoutRun() { - try { - callback.success(); - fail("Expected IllegalStateException"); - } catch (IllegalStateException e) { - // expected - } + final var ex = assertThrows(IllegalStateException.class, callback::success); verify(mockTimer, never()).update(anyLong(), any(TimeUnit.class)); }