X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fmessages%2FCommitTransactionTest.java;h=ca3b2be670bc071f3aa8d0aa3f06de561963e1e7;hp=0f46c585db32f1105921b0ad1c375f5f4771af5d;hb=057b787289f7b909d7013c22ac73a1c91c860af8;hpb=5a4560d475f0ed328275f1a5c7a5dae292acfb02 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CommitTransactionTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CommitTransactionTest.java index 0f46c585db..ca3b2be670 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CommitTransactionTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CommitTransactionTest.java @@ -8,50 +8,35 @@ package org.opendaylight.controller.cluster.datastore.messages; import static org.junit.Assert.assertEquals; + import java.io.Serializable; import org.apache.commons.lang.SerializationUtils; import org.junit.Test; +import org.opendaylight.controller.cluster.datastore.AbstractTest; import org.opendaylight.controller.cluster.datastore.DataStoreVersions; -import org.opendaylight.controller.protobuff.messages.cohort3pc.ThreePhaseCommitCohortMessages; /** * Unit tests for CommitTransaction. * * @author Thomas Pantelis */ -public class CommitTransactionTest { +public class CommitTransactionTest extends AbstractTest { @Test public void testSerialization() { - CommitTransaction expected = new CommitTransaction("txId", DataStoreVersions.CURRENT_VERSION); + CommitTransaction expected = new CommitTransaction(nextTransactionId(), DataStoreVersions.CURRENT_VERSION); Object serialized = expected.toSerializable(); assertEquals("Serialized type", CommitTransaction.class, serialized.getClass()); CommitTransaction actual = CommitTransaction.fromSerializable( SerializationUtils.clone((Serializable) serialized)); - assertEquals("getTransactionID", expected.getTransactionID(), actual.getTransactionID()); + assertEquals("getTransactionID", expected.getTransactionId(), actual.getTransactionId()); assertEquals("getVersion", DataStoreVersions.CURRENT_VERSION, actual.getVersion()); } - @Test - public void testSerializationWithPreBoronVersion() { - CommitTransaction expected = new CommitTransaction("txId", DataStoreVersions.LITHIUM_VERSION); - - Object serialized = expected.toSerializable(); - assertEquals("Serialized type", ThreePhaseCommitCohortMessages.CommitTransaction.class, serialized.getClass()); - - CommitTransaction actual = CommitTransaction.fromSerializable( - SerializationUtils.clone((Serializable) serialized)); - assertEquals("getTransactionID", expected.getTransactionID(), actual.getTransactionID()); - assertEquals("getVersion", DataStoreVersions.LITHIUM_VERSION, actual.getVersion()); - } - @Test public void testIsSerializedType() { - assertEquals("isSerializedType", true, CommitTransaction.isSerializedType( - ThreePhaseCommitCohortMessages.CommitTransaction.newBuilder().setTransactionId("").build())); - assertEquals("isSerializedType", true, CommitTransaction.isSerializedType(new CommitTransaction())); assertEquals("isSerializedType", false, CommitTransaction.isSerializedType(new Object())); }