X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fmessages%2FReadDataReplyTest.java;h=caf55737be8df8e294fd8eba801edf986d0078eb;hp=7ad45a61702607cdaf03a61b23573575d54830cd;hb=9bce68c4712d00951d121be68b09578bc6e09151;hpb=dc5eceede07e499e5c5e0ab60d7ce42bc596fcc0 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/ReadDataReplyTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/ReadDataReplyTest.java index 7ad45a6170..caf55737be 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/ReadDataReplyTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/ReadDataReplyTest.java @@ -8,12 +8,14 @@ package org.opendaylight.controller.cluster.datastore.messages; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertTrue; + import java.io.Serializable; import org.apache.commons.lang.SerializationUtils; import org.junit.Test; import org.opendaylight.controller.cluster.datastore.DataStoreVersions; import org.opendaylight.controller.md.cluster.datastore.model.TestModel; -import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNodes; @@ -28,9 +30,9 @@ public class ReadDataReplyTest { @Test public void testSerialization() { - NormalizedNode data = ImmutableContainerNodeBuilder.create().withNodeIdentifier( - new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)). - withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); + NormalizedNode data = ImmutableContainerNodeBuilder.create() + .withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)) + .withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); ReadDataReply expected = new ReadDataReply(data, DataStoreVersions.CURRENT_VERSION); @@ -45,29 +47,7 @@ public class ReadDataReplyTest { @Test public void testIsSerializedType() { - assertEquals("isSerializedType", true, ReadDataReply.isSerializedType( - ShardTransactionMessages.ReadDataReply.newBuilder().build())); - assertEquals("isSerializedType", true, ReadDataReply.isSerializedType(new ReadDataReply())); - assertEquals("isSerializedType", false, ReadDataReply.isSerializedType(new Object())); - } - - /** - * Tests backwards compatible serialization/deserialization of a ReadDataReply message with the - * base and R1 Helium versions, which used the protobuff ReadDataReply message. - */ - @Test - public void testSerializationWithHeliumR1Version() throws Exception { - NormalizedNode data = ImmutableContainerNodeBuilder.create().withNodeIdentifier( - new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)). - withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); - - ReadDataReply expected = new ReadDataReply(data, DataStoreVersions.HELIUM_1_VERSION); - - Object serialized = expected.toSerializable(); - assertEquals("Serialized type", ShardTransactionMessages.ReadDataReply.class, serialized.getClass()); - - ReadDataReply actual = ReadDataReply.fromSerializable(SerializationUtils.clone( - (Serializable) serialized)); - assertEquals("getNormalizedNode", expected.getNormalizedNode(), actual.getNormalizedNode()); + assertTrue("isSerializedType", ReadDataReply.isSerializedType(new ReadDataReply())); + assertFalse("isSerializedType", ReadDataReply.isSerializedType(new Object())); } }