X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-dom-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Fdom%2Fapi%2FDOMRpcIdentifier.java;h=60fae6781e5bfa971d0a6eefdac6aff3f97e3934;hp=4e6c7a5f7f2964dc8b4655c7a3d73d508409ae5a;hb=refs%2Fchanges%2F26%2F69326%2F3;hpb=769a4060e445ef39ed1c125bdc2c48ce59d1fbf9 diff --git a/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMRpcIdentifier.java b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMRpcIdentifier.java index 4e6c7a5f7f..60fae6781e 100644 --- a/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMRpcIdentifier.java +++ b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMRpcIdentifier.java @@ -22,6 +22,7 @@ import org.opendaylight.yangtools.yang.model.api.SchemaPath; * contexts concurrently. */ public abstract class DOMRpcIdentifier { + private static final class Global extends DOMRpcIdentifier { private Global(final @Nonnull SchemaPath type) { super(type); @@ -29,7 +30,7 @@ public abstract class DOMRpcIdentifier { @Override public YangInstanceIdentifier getContextReference() { - return null; + return YangInstanceIdentifier.EMPTY; } } @@ -70,12 +71,12 @@ public abstract class DOMRpcIdentifier { * @param contextReference Context reference, null means a global RPC identifier. * @return A global RPC identifier, guaranteed to be non-null. */ - public static @Nonnull DOMRpcIdentifier create(final @Nonnull SchemaPath type, final @Nullable YangInstanceIdentifier contextReference) { - if (contextReference == null) { + public static @Nonnull DOMRpcIdentifier create(final @Nonnull SchemaPath type, + final @Nullable YangInstanceIdentifier contextReference) { + if (contextReference == null || contextReference.isEmpty()) { return new Global(type); - } else { - return new Local(type, contextReference); } + return new Local(type, contextReference); } /** @@ -92,14 +93,14 @@ public abstract class DOMRpcIdentifier { * * @return RPC context reference. */ - public abstract @Nullable YangInstanceIdentifier getContextReference(); + public abstract @Nonnull YangInstanceIdentifier getContextReference(); @Override public final int hashCode() { final int prime = 31; int result = 1; result = prime * result + type.hashCode(); - result = prime * result + (getContextReference() == null ? 0 : getContextReference().hashCode()); + result = prime * result + getContextReference().hashCode(); return result; } @@ -120,6 +121,7 @@ public abstract class DOMRpcIdentifier { @Override public final String toString() { - return MoreObjects.toStringHelper(this).omitNullValues().add("type", type).add("contextReference", getContextReference()).toString(); + return MoreObjects.toStringHelper(this).omitNullValues().add("type", type).add("contextReference", + getContextReference()).toString(); } }