X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-dom-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fconfig%2Fyang%2Fmd%2Fsal%2Fdom%2Fimpl%2FDomInmemoryDataBrokerModule.java;h=88336526e9746facb01bf5473a6243c9d1996c81;hp=8664e8910b46bda523951f22961d59c13cbaec42;hb=a008ebde3f8e966da98798191e11006071bfd2c9;hpb=ac732369c7ddaaf60faef5eda22fa9c41aad391e diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/DomInmemoryDataBrokerModule.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/DomInmemoryDataBrokerModule.java index 8664e8910b..88336526e9 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/DomInmemoryDataBrokerModule.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/DomInmemoryDataBrokerModule.java @@ -7,16 +7,18 @@ */ package org.opendaylight.controller.config.yang.md.sal.dom.impl; -import java.util.concurrent.Executor; +import java.util.EnumMap; +import java.util.Map; import java.util.concurrent.ExecutorService; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitDeadlockException; +import org.opendaylight.controller.md.sal.common.util.jmx.ThreadExecutorStatsMXBeanImpl; import org.opendaylight.controller.md.sal.dom.broker.impl.DOMDataBrokerImpl; +import org.opendaylight.controller.md.sal.dom.broker.impl.jmx.CommitStatsMXBeanImpl; import org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMDataStoreFactory; import org.opendaylight.controller.sal.core.spi.data.DOMStore; import org.opendaylight.yangtools.util.concurrent.DeadlockDetectingListeningExecutorService; import org.opendaylight.yangtools.util.concurrent.SpecialExecutors; -import com.google.common.collect.ImmutableMap; /** * @@ -24,6 +26,8 @@ import com.google.common.collect.ImmutableMap; public final class DomInmemoryDataBrokerModule extends org.opendaylight.controller.config.yang.md.sal.dom.impl.AbstractDomInmemoryDataBrokerModule { + private static final String JMX_BEAN_TYPE = "DOMDataBroker"; + public DomInmemoryDataBrokerModule(final org.opendaylight.controller.config.api.ModuleIdentifier identifier, final org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { super(identifier, dependencyResolver); @@ -55,9 +59,10 @@ public final class DomInmemoryDataBrokerModule extends //we will default to InMemoryDOMDataStore creation configStore = InMemoryDOMDataStoreFactory.create("DOM-CFG", getSchemaServiceDependency()); } - ImmutableMap datastores = ImmutableMap - . builder().put(LogicalDatastoreType.OPERATIONAL, operStore) - .put(LogicalDatastoreType.CONFIGURATION, configStore).build(); + + final Map datastores = new EnumMap<>(LogicalDatastoreType.class); + datastores.put(LogicalDatastoreType.OPERATIONAL, operStore); + datastores.put(LogicalDatastoreType.CONFIGURATION, configStore); /* * We use a single-threaded executor for commits with a bounded queue capacity. If the @@ -78,15 +83,38 @@ public final class DomInmemoryDataBrokerModule extends * nothing on success. The executor queue capacity is bounded and, if the capacity is * reached, subsequent submitted tasks will block the caller. */ - Executor listenableFutureExecutor = SpecialExecutors.newBlockingBoundedCachedThreadPool( + ExecutorService listenableFutureExecutor = SpecialExecutors.newBlockingBoundedCachedThreadPool( getMaxDataBrokerFutureCallbackPoolSize(), getMaxDataBrokerFutureCallbackQueueSize(), "CommitFutures"); DOMDataBrokerImpl newDataBroker = new DOMDataBrokerImpl(datastores, new DeadlockDetectingListeningExecutorService(commitExecutor, - TransactionCommitDeadlockException.DEADLOCK_EXECUTOR_FUNCTION, + TransactionCommitDeadlockException.DEADLOCK_EXCEPTION_SUPPLIER, listenableFutureExecutor)); + final CommitStatsMXBeanImpl commitStatsMXBean = new CommitStatsMXBeanImpl( + newDataBroker.getCommitStatsTracker(), JMX_BEAN_TYPE); + commitStatsMXBean.registerMBean(); + + final ThreadExecutorStatsMXBeanImpl commitExecutorStatsMXBean = + new ThreadExecutorStatsMXBeanImpl(commitExecutor, "CommitExecutorStats", + JMX_BEAN_TYPE, null); + commitExecutorStatsMXBean.registerMBean(); + + final ThreadExecutorStatsMXBeanImpl commitFutureStatsMXBean = + new ThreadExecutorStatsMXBeanImpl(listenableFutureExecutor, + "CommitFutureExecutorStats", JMX_BEAN_TYPE, null); + commitFutureStatsMXBean.registerMBean(); + + newDataBroker.setCloseable(new AutoCloseable() { + @Override + public void close() { + commitStatsMXBean.unregisterMBean(); + commitExecutorStatsMXBean.unregisterMBean(); + commitFutureStatsMXBean.unregisterMBean(); + } + }); + return newDataBroker; } }