X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-dom-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Fdom%2Fbroker%2Fimpl%2FDOMNotificationRouter.java;h=64c6b9e1fd1791a4e29e5868e64cf89975b9a2dd;hp=aac425b3d400ca9ed530230a0359740f4f3db74c;hb=dceb9db7853dabfbd4abdfb3d886a79871097831;hpb=bd8beb1bfee9f421ad8f2d07b1424b21038234a2 diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMNotificationRouter.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMNotificationRouter.java index aac425b3d4..64c6b9e1fd 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMNotificationRouter.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMNotificationRouter.java @@ -9,6 +9,7 @@ package org.opendaylight.controller.md.sal.dom.broker.impl; import com.google.common.base.Preconditions; import com.google.common.base.Predicate; +import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMultimap; import com.google.common.collect.ImmutableMultimap.Builder; import com.google.common.collect.Multimap; @@ -17,12 +18,14 @@ import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture; import com.lmax.disruptor.EventHandler; import com.lmax.disruptor.InsufficientCapacityException; -import com.lmax.disruptor.SleepingWaitStrategy; +import com.lmax.disruptor.PhasedBackoffWaitStrategy; import com.lmax.disruptor.WaitStrategy; import com.lmax.disruptor.dsl.Disruptor; import com.lmax.disruptor.dsl.ProducerType; import java.util.Arrays; import java.util.Collection; +import java.util.List; +import java.util.Set; import java.util.concurrent.ExecutorService; import java.util.concurrent.Executors; import java.util.concurrent.TimeUnit; @@ -30,9 +33,14 @@ import org.opendaylight.controller.md.sal.dom.api.DOMNotification; import org.opendaylight.controller.md.sal.dom.api.DOMNotificationListener; import org.opendaylight.controller.md.sal.dom.api.DOMNotificationPublishService; import org.opendaylight.controller.md.sal.dom.api.DOMNotificationService; +import org.opendaylight.controller.md.sal.dom.spi.DOMNotificationSubscriptionListener; +import org.opendaylight.controller.md.sal.dom.spi.DOMNotificationSubscriptionListenerRegistry; import org.opendaylight.yangtools.concepts.AbstractListenerRegistration; import org.opendaylight.yangtools.concepts.ListenerRegistration; +import org.opendaylight.yangtools.util.ListenerRegistry; import org.opendaylight.yangtools.yang.model.api.SchemaPath; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * Joint implementation of {@link DOMNotificationPublishService} and {@link DOMNotificationService}. Provides @@ -48,9 +56,12 @@ import org.opendaylight.yangtools.yang.model.api.SchemaPath; * are realized using the Disruptor's native operations. The bounded-blocking {@link #offerNotification(DOMNotification, long, TimeUnit)} * is realized by arming a background wakeup interrupt. */ -public final class DOMNotificationRouter implements AutoCloseable, DOMNotificationPublishService, DOMNotificationService { +public final class DOMNotificationRouter implements AutoCloseable, DOMNotificationPublishService, + DOMNotificationService, DOMNotificationSubscriptionListenerRegistry { + + private static final Logger LOG = LoggerFactory.getLogger(DOMNotificationRouter.class); private static final ListenableFuture NO_LISTENERS = Futures.immediateFuture(null); - private static final WaitStrategy DEFAULT_STRATEGY = new SleepingWaitStrategy(); + private static final WaitStrategy DEFAULT_STRATEGY = PhasedBackoffWaitStrategy.withLock(1L, 30L, TimeUnit.MILLISECONDS); private static final EventHandler DISPATCH_NOTIFICATIONS = new EventHandler() { @Override public void onEvent(final DOMNotificationRouterEvent event, final long sequence, final boolean endOfBatch) throws Exception { @@ -68,21 +79,31 @@ public final class DOMNotificationRouter implements AutoCloseable, DOMNotificati private final Disruptor disruptor; private final ExecutorService executor; private volatile Multimap> listeners = ImmutableMultimap.of(); + private final ListenerRegistry subscriptionListeners = ListenerRegistry.create(); - private DOMNotificationRouter(final ExecutorService executor, final Disruptor disruptor) { + @SuppressWarnings("unchecked") + private DOMNotificationRouter(final ExecutorService executor, final int queueDepth, final WaitStrategy strategy) { this.executor = Preconditions.checkNotNull(executor); - this.disruptor = Preconditions.checkNotNull(disruptor); + + disruptor = new Disruptor<>(DOMNotificationRouterEvent.FACTORY, queueDepth, executor, ProducerType.MULTI, strategy); + disruptor.handleEventsWith(DISPATCH_NOTIFICATIONS); + disruptor.after(DISPATCH_NOTIFICATIONS).handleEventsWith(NOTIFY_FUTURE); + disruptor.start(); } - @SuppressWarnings("unchecked") public static DOMNotificationRouter create(final int queueDepth) { final ExecutorService executor = Executors.newCachedThreadPool(); - final Disruptor disruptor = new Disruptor<>(DOMNotificationRouterEvent.FACTORY, queueDepth, executor, ProducerType.MULTI, DEFAULT_STRATEGY); - disruptor.after(DISPATCH_NOTIFICATIONS).handleEventsWith(NOTIFY_FUTURE); - disruptor.start(); + return new DOMNotificationRouter(executor, queueDepth, DEFAULT_STRATEGY); + } + + public static DOMNotificationRouter create(final int queueDepth, final long spinTime, final long parkTime, final TimeUnit unit) { + Preconditions.checkArgument(Long.lowestOneBit(queueDepth) == Long.highestOneBit(queueDepth), + "Queue depth %s is not power-of-two", queueDepth); + final ExecutorService executor = Executors.newCachedThreadPool(); + final WaitStrategy strategy = PhasedBackoffWaitStrategy.withLock(spinTime, parkTime, unit); - return new DOMNotificationRouter(executor, disruptor); + return new DOMNotificationRouter(executor, queueDepth, strategy); } @Override @@ -93,12 +114,12 @@ public final class DOMNotificationRouter implements AutoCloseable, DOMNotificati final ListenerRegistration me = this; synchronized (DOMNotificationRouter.this) { - listeners = ImmutableMultimap.copyOf(Multimaps.filterValues(listeners, new Predicate>() { + replaceListeners(ImmutableMultimap.copyOf(Multimaps.filterValues(listeners, new Predicate>() { @Override public boolean apply(final ListenerRegistration input) { return input != me; } - })); + }))); } } }; @@ -107,11 +128,11 @@ public final class DOMNotificationRouter implements AutoCloseable, DOMNotificati final Builder> b = ImmutableMultimap.builder(); b.putAll(listeners); - for (SchemaPath t : types) { + for (final SchemaPath t : types) { b.put(t, reg); } - listeners = b.build(); + replaceListeners(b.build()); } return reg; @@ -122,6 +143,48 @@ public final class DOMNotificationRouter implements AutoCloseable, DOMNotificati return registerNotificationListener(listener, Arrays.asList(types)); } + /** + * Swaps registered listeners and triggers notification update + * + * @param newListeners + */ + private void replaceListeners( + final Multimap> newListeners) { + listeners = newListeners; + notifyListenerTypesChanged(newListeners.keySet()); + } + + private void notifyListenerTypesChanged(final Set typesAfter) { + final List> listenersAfter =ImmutableList.copyOf(subscriptionListeners.getListeners()); + executor.submit(new Runnable() { + + @Override + public void run() { + for (final ListenerRegistration subListener : listenersAfter) { + try { + subListener.getInstance().onSubscriptionChanged(typesAfter); + } catch (final Exception e) { + LOG.warn("Uncaught exception during invoking listener {}", subListener.getInstance(), e); + } + } + } + }); + } + + @Override + public ListenerRegistration registerSubscriptionListener( + final L listener) { + final Set initialTypes = listeners.keySet(); + executor.submit(new Runnable() { + + @Override + public void run() { + listener.onSubscriptionChanged(initialTypes); + } + }); + return subscriptionListeners.registerWithType(listener); + } + private ListenableFuture publish(final long seq, final DOMNotification notification, final Collection> subscribers) { final DOMNotificationRouterEvent event = disruptor.get(seq); final ListenableFuture future = event.initialize(notification, subscribers); @@ -144,7 +207,7 @@ public final class DOMNotificationRouter implements AutoCloseable, DOMNotificati final long seq; try { seq = disruptor.getRingBuffer().tryNext(); - } catch (InsufficientCapacityException e) { + } catch (final InsufficientCapacityException e) { return DOMNotificationPublishService.REJECTED; }