X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-dom-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Fdom%2Fbroker%2Fimpl%2Fcompat%2FBackwardsCompatibleTransaction.java;h=70baaae33939c59d4f1cf4336aed30c29b48826a;hp=27e322f23baf265a046d04317f2bfbf78ab2f74c;hb=0eb621d29daaf08979c356e2148e99c48458e169;hpb=03ee21b4d6ae3dd6fd3a6991253e877dc96fabf5 diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/compat/BackwardsCompatibleTransaction.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/compat/BackwardsCompatibleTransaction.java index 27e322f23b..70baaae339 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/compat/BackwardsCompatibleTransaction.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/compat/BackwardsCompatibleTransaction.java @@ -21,6 +21,7 @@ import java.util.concurrent.Future; import org.opendaylight.controller.md.sal.common.api.TransactionStatus; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; +import org.opendaylight.controller.md.sal.common.impl.service.AbstractDataTransaction; import org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationException; import org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation; import org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizer; @@ -32,8 +33,8 @@ import org.opendaylight.yangtools.concepts.Delegator; import org.opendaylight.yangtools.concepts.ListenerRegistration; import org.opendaylight.yangtools.yang.common.RpcResult; import org.opendaylight.yangtools.yang.data.api.CompositeNode; -import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier; -import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier.PathArgument; +import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; +import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.PathArgument; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -89,9 +90,9 @@ DataModificationTransaction, Delegator { }; @Override - public CompositeNode readConfigurationData(final InstanceIdentifier legacyPath) { + public CompositeNode readConfigurationData(final YangInstanceIdentifier legacyPath) { - InstanceIdentifier normalizedPath = normalizer.toNormalized(legacyPath); + YangInstanceIdentifier normalizedPath = normalizer.toNormalized(legacyPath); ListenableFuture>> normalizedData = asyncTx.read( LogicalDatastoreType.CONFIGURATION, normalizedPath); @@ -104,8 +105,8 @@ DataModificationTransaction, Delegator { } @Override - public CompositeNode readOperationalData(final InstanceIdentifier legacyPath) { - InstanceIdentifier normalizedPath = normalizer.toNormalized(legacyPath); + public CompositeNode readOperationalData(final YangInstanceIdentifier legacyPath) { + YangInstanceIdentifier normalizedPath = normalizer.toNormalized(legacyPath); ListenableFuture>> normalizedData = asyncTx.read( LogicalDatastoreType.OPERATIONAL, normalizedPath); @@ -123,62 +124,62 @@ DataModificationTransaction, Delegator { } @Override - public Map getCreatedConfigurationData() { + public Map getCreatedConfigurationData() { return Collections.emptyMap(); } @Override - public Map getCreatedOperationalData() { + public Map getCreatedOperationalData() { return Collections.emptyMap(); } @Override - public Map getOriginalConfigurationData() { + public Map getOriginalConfigurationData() { return Collections.emptyMap(); } @Override - public Map getOriginalOperationalData() { + public Map getOriginalOperationalData() { return Collections.emptyMap(); } @Override - public Set getRemovedConfigurationData() { + public Set getRemovedConfigurationData() { return Collections.emptySet(); } @Override - public Set getRemovedOperationalData() { + public Set getRemovedOperationalData() { return Collections.emptySet(); } @Override - public Map getUpdatedConfigurationData() { + public Map getUpdatedConfigurationData() { return Collections.emptyMap(); } @Override - public Map getUpdatedOperationalData() { + public Map getUpdatedOperationalData() { return Collections.emptyMap(); } @Override - public void putConfigurationData(final InstanceIdentifier path, final CompositeNode data) { + public void putConfigurationData(final YangInstanceIdentifier path, final CompositeNode data) { throw new UnsupportedOperationException(); } @Override - public void putOperationalData(final InstanceIdentifier path, final CompositeNode data) { + public void putOperationalData(final YangInstanceIdentifier path, final CompositeNode data) { throw new UnsupportedOperationException(); } @Override - public void removeConfigurationData(final InstanceIdentifier path) { + public void removeConfigurationData(final YangInstanceIdentifier path) { throw new UnsupportedOperationException(); } @Override - public void removeOperationalData(final InstanceIdentifier path) { + public void removeOperationalData(final YangInstanceIdentifier path) { throw new UnsupportedOperationException(); } @@ -204,26 +205,26 @@ DataModificationTransaction, Delegator { public Future> commit() { Preconditions.checkState(status == TransactionStatus.NEW); status = TransactionStatus.SUBMITED; - return getDelegate().commit(); + return AbstractDataTransaction.convertToLegacyCommitFuture(getDelegate().submit()); } @Override - public void putConfigurationData(final InstanceIdentifier legacyPath, final CompositeNode legacyData) { + public void putConfigurationData(final YangInstanceIdentifier legacyPath, final CompositeNode legacyData) { checkNotNull(legacyPath, "Path MUST NOT be null."); checkNotNull(legacyData, "Data for path %s MUST NOT be null",legacyData); - Entry> normalizedData = getNormalizer().toNormalized(legacyPath, legacyData); + Entry> normalizedData = getNormalizer().toNormalized(legacyPath, legacyData); putWithEnsuredParents(LogicalDatastoreType.CONFIGURATION, normalizedData.getKey(), normalizedData.getValue()); } @Override - public void putOperationalData(final InstanceIdentifier legacyPath, final CompositeNode legacyData) { + public void putOperationalData(final YangInstanceIdentifier legacyPath, final CompositeNode legacyData) { checkNotNull(legacyPath, "Path MUST NOT be null."); checkNotNull(legacyData, "Data for path %s MUST NOT be null",legacyData); - Entry> normalizedData = getNormalizer().toNormalized(legacyPath, legacyData); + Entry> normalizedData = getNormalizer().toNormalized(legacyPath, legacyData); putWithEnsuredParents(LogicalDatastoreType.OPERATIONAL, normalizedData.getKey(), normalizedData.getValue()); } - private void putWithEnsuredParents(final LogicalDatastoreType store, final InstanceIdentifier normalizedPath, + private void putWithEnsuredParents(final LogicalDatastoreType store, final YangInstanceIdentifier normalizedPath, final NormalizedNode normalizedData) { LOG.trace("write {}:{} ",store,normalizedPath); @@ -239,7 +240,7 @@ DataModificationTransaction, Delegator { throw new IllegalArgumentException(String.format("Invalid child encountered in path %s", normalizedPath), e); } currentArguments.add(currentArg); - InstanceIdentifier currentPath = InstanceIdentifier.create(currentArguments); + YangInstanceIdentifier currentPath = YangInstanceIdentifier.create(currentArguments); boolean isPresent = getDelegate().read(store, currentPath).get().isPresent(); if(isPresent == false && iterator.hasNext()) { getDelegate().merge(store, currentPath, currentOp.createDefault(currentArg)); @@ -253,13 +254,13 @@ DataModificationTransaction, Delegator { } @Override - public void removeConfigurationData(final InstanceIdentifier legacyPath) { + public void removeConfigurationData(final YangInstanceIdentifier legacyPath) { checkNotNull(legacyPath, "Path MUST NOT be null."); getDelegate().delete(LogicalDatastoreType.CONFIGURATION, getNormalizer().toNormalized(legacyPath)); } @Override - public void removeOperationalData(final InstanceIdentifier legacyPath) { + public void removeOperationalData(final YangInstanceIdentifier legacyPath) { checkNotNull(legacyPath, "Path MUST NOT be null."); getDelegate().delete(LogicalDatastoreType.OPERATIONAL, getNormalizer().toNormalized(legacyPath)); }