X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-dom-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fsal%2Fdom%2Fbroker%2FBrokerImpl.java;h=33fc2446196d5473f9742883155b92d25110fc77;hp=03fbb18cae31eefbb56d6c8db19e10cc44464bed;hb=329dc0e33bd86edbf02b37090fc431607af9b47e;hpb=38990707b6e998d0808b4f2c5a1a845d489c34a9 diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.java index 03fbb18cae..33fc244619 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.java @@ -38,7 +38,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; public class BrokerImpl implements Broker, DOMRpcProviderService, DOMRpcService, AutoCloseable { - private final static Logger log = LoggerFactory.getLogger(BrokerImpl.class); + private static final Logger LOG = LoggerFactory.getLogger(BrokerImpl.class); // Broker Generic Context private final Set sessions = Collections @@ -46,17 +46,23 @@ public class BrokerImpl implements Broker, DOMRpcProviderService, DOMRpcService, private final Set providerSessions = Collections .synchronizedSet(new HashSet()); - private AutoCloseable deactivator = null; + private AutoCloseable deactivator; - private DOMRpcRouter router = null; + private final DOMRpcService rpcService; + private final DOMRpcProviderService rpcProvider; private final ClassToInstanceMap services; - public BrokerImpl(final DOMRpcRouter router,final ClassToInstanceMap services) { - this.router = Preconditions.checkNotNull(router, "RPC Router must not be null"); - this.services = ImmutableClassToInstanceMap.copyOf(services); + public BrokerImpl(final DOMRpcRouter router,final ClassToInstanceMap services) { + this(router, router, services); } + public BrokerImpl(final DOMRpcService rpcService, final DOMRpcProviderService rpcProvider, + final ClassToInstanceMap services) { + this.rpcService = Preconditions.checkNotNull(rpcService, "DOMRpcService must not be null"); + this.rpcProvider = Preconditions.checkNotNull(rpcProvider, "DOMRpcProviderService must not be null"); + this.services = ImmutableClassToInstanceMap.copyOf(services); + } @Override public ConsumerSession registerConsumer(final Consumer consumer, @@ -130,21 +136,6 @@ public class BrokerImpl implements Broker, DOMRpcProviderService, DOMRpcService, this.deactivator = deactivator; } - /** - * @return the router - */ - public DOMRpcRouter getRouter() { - return router; - } - - /** - * @param router - * the router to set - */ - public void setRouter(final DOMRpcRouter router) { - this.router = router; - } - protected Optional getGlobalService(final Class service) { return Optional.fromNullable(services.getInstance(service)); } @@ -153,7 +144,7 @@ public class BrokerImpl implements Broker, DOMRpcProviderService, DOMRpcService, @Override public ConsumerSession registerConsumer(final Consumer consumer) { checkPredicates(consumer); - log.trace("Registering consumer {}", consumer); + LOG.trace("Registering consumer {}", consumer); final ConsumerContextImpl session = newSessionFor(consumer); consumer.onSessionInitiated(session); sessions.add(session); @@ -174,24 +165,24 @@ public class BrokerImpl implements Broker, DOMRpcProviderService, DOMRpcService, @Nonnull @Override public DOMRpcImplementationRegistration registerRpcImplementation(@Nonnull final T implementation, @Nonnull final DOMRpcIdentifier... rpcs) { - return router.registerRpcImplementation(implementation, rpcs); + return rpcProvider.registerRpcImplementation(implementation, rpcs); } @Nonnull @Override public DOMRpcImplementationRegistration registerRpcImplementation(@Nonnull final T implementation, @Nonnull final Set rpcs) { - return router.registerRpcImplementation(implementation, rpcs); + return rpcProvider.registerRpcImplementation(implementation, rpcs); } @Nonnull @Override public CheckedFuture invokeRpc(@Nonnull final SchemaPath type, @Nullable final NormalizedNode input) { - return router.invokeRpc(type, input); + return rpcService.invokeRpc(type, input); } @Nonnull @Override public ListenerRegistration registerRpcListener(@Nonnull final T listener) { - return router.registerRpcListener(listener); + return rpcService.registerRpcListener(listener); } }