X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-dom-broker%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Fdom%2Fbroker%2Fimpl%2FDOMConcurrentDataCommitCoordinatorTest.java;h=efc461a0c2500a6a6e565d3ad271ef3a19b8a003;hp=25d7df17d16d3d95ce3560ffafb1c5e049a73108;hb=18cefe8da04b98855683d75be276b9f0e8f3ae73;hpb=0eba94d9411ea40945ddc8c732640c0cc004599f diff --git a/opendaylight/md-sal/sal-dom-broker/src/test/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMConcurrentDataCommitCoordinatorTest.java b/opendaylight/md-sal/sal-dom-broker/src/test/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMConcurrentDataCommitCoordinatorTest.java index 25d7df17d1..efc461a0c2 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/test/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMConcurrentDataCommitCoordinatorTest.java +++ b/opendaylight/md-sal/sal-dom-broker/src/test/java/org/opendaylight/controller/md/sal/dom/broker/impl/DOMConcurrentDataCommitCoordinatorTest.java @@ -10,10 +10,18 @@ package org.opendaylight.controller.md.sal.dom.broker.impl; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertSame; import static org.junit.Assert.fail; -import static org.mockito.Mockito.mock; -import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.doAnswer; +import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.inOrder; +import static org.mockito.Mockito.mock; +import com.google.common.collect.ImmutableMap; +import com.google.common.util.concurrent.CheckedFuture; +import com.google.common.util.concurrent.FutureCallback; +import com.google.common.util.concurrent.Futures; +import com.google.common.util.concurrent.ListenableFuture; +import com.google.common.util.concurrent.MoreExecutors; +import com.google.common.util.concurrent.SettableFuture; +import com.google.common.util.concurrent.Uninterruptibles; import java.util.Arrays; import java.util.concurrent.CountDownLatch; import java.util.concurrent.SynchronousQueue; @@ -27,15 +35,12 @@ import org.junit.Test; import org.mockito.InOrder; import org.mockito.invocation.InvocationOnMock; import org.mockito.stubbing.Answer; +import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException; import org.opendaylight.controller.md.sal.dom.api.DOMDataWriteTransaction; +import org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMDataStore; +import org.opendaylight.controller.sal.core.spi.data.DOMStore; import org.opendaylight.controller.sal.core.spi.data.DOMStoreThreePhaseCommitCohort; -import com.google.common.util.concurrent.CheckedFuture; -import com.google.common.util.concurrent.FutureCallback; -import com.google.common.util.concurrent.Futures; -import com.google.common.util.concurrent.ListenableFuture; -import com.google.common.util.concurrent.SettableFuture; -import com.google.common.util.concurrent.Uninterruptibles; /** * Unit tests for DOMConcurrentDataCommitCoordinator. @@ -49,12 +54,16 @@ public class DOMConcurrentDataCommitCoordinatorTest { private final DOMStoreThreePhaseCommitCohort mockCohort2 = mock(DOMStoreThreePhaseCommitCohort.class); private final ThreadPoolExecutor futureExecutor = new ThreadPoolExecutor(0, 1, 5, TimeUnit.SECONDS, new SynchronousQueue()); - private final DOMConcurrentDataCommitCoordinator coordinator = - new DOMConcurrentDataCommitCoordinator(futureExecutor); + private ConcurrentDOMDataBroker coordinator; @Before public void setup() { doReturn("tx").when(transaction).getIdentifier(); + + DOMStore store = new InMemoryDOMDataStore("OPER", + MoreExecutors.sameThreadExecutor()); + + coordinator = new ConcurrentDOMDataBroker(ImmutableMap.of(LogicalDatastoreType.OPERATIONAL, store), futureExecutor); } @After @@ -76,7 +85,7 @@ public class DOMConcurrentDataCommitCoordinatorTest { final CountDownLatch asyncCanCommitContinue = new CountDownLatch(1); Answer> asyncCanCommit = new Answer>() { @Override - public ListenableFuture answer(InvocationOnMock invocation) { + public ListenableFuture answer(final InvocationOnMock invocation) { final SettableFuture future = SettableFuture.create(); if(doAsync) { new Thread() { @@ -110,12 +119,12 @@ public class DOMConcurrentDataCommitCoordinatorTest { final AtomicReference caughtEx = new AtomicReference<>(); Futures.addCallback(future, new FutureCallback() { @Override - public void onSuccess(Void result) { + public void onSuccess(final Void result) { doneLatch.countDown(); } @Override - public void onFailure(Throwable t) { + public void onFailure(final Throwable t) { caughtEx.set(t); doneLatch.countDown(); } @@ -158,8 +167,8 @@ public class DOMConcurrentDataCommitCoordinatorTest { assertFailure(future, null, mockCohort1, mockCohort2, mockCohort3); } - private void assertFailure(CheckedFuture future, - Exception expCause, DOMStoreThreePhaseCommitCohort... mockCohorts) + private void assertFailure(final CheckedFuture future, + final Exception expCause, final DOMStoreThreePhaseCommitCohort... mockCohorts) throws Exception { try { future.checkedGet(5, TimeUnit.SECONDS);