X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-netconf-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fsal%2Fconnect%2Fnetconf%2Fsal%2Ftx%2FWriteCandidateTx.java;h=cad65ff0bea0edebf56aa0dcaba174224e14a95b;hp=f9bf3c75fd0a0691bd00148c6a18eb164b262739;hb=8ce853c0627e829d40fe18e550bc807efbcbafee;hpb=35d50d7b5b69ebb08c753a699bf0aa1e645027fe diff --git a/opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/tx/WriteCandidateTx.java b/opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/tx/WriteCandidateTx.java index f9bf3c75fd..cad65ff0be 100644 --- a/opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/tx/WriteCandidateTx.java +++ b/opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/sal/tx/WriteCandidateTx.java @@ -15,7 +15,7 @@ import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture; import org.opendaylight.controller.md.sal.common.api.TransactionStatus; import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException; -import org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizer; +import org.opendaylight.controller.md.sal.dom.api.DOMRpcResult; import org.opendaylight.controller.netconf.api.NetconfDocumentedException; import org.opendaylight.controller.sal.connect.netconf.listener.NetconfSessionPreferences; import org.opendaylight.controller.sal.connect.netconf.util.NetconfBaseOps; @@ -24,9 +24,9 @@ import org.opendaylight.controller.sal.connect.util.RemoteDeviceId; import org.opendaylight.yangtools.yang.common.RpcError; import org.opendaylight.yangtools.yang.common.RpcResult; import org.opendaylight.yangtools.yang.common.RpcResultBuilder; -import org.opendaylight.yangtools.yang.data.api.CompositeNode; import org.opendaylight.yangtools.yang.data.api.ModifyAction; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; +import org.opendaylight.yangtools.yang.data.api.schema.DataContainerChild; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -53,10 +53,10 @@ public class WriteCandidateTx extends AbstractWriteTx { private static final Logger LOG = LoggerFactory.getLogger(WriteCandidateTx.class); - private static final Function, RpcResult> RPC_RESULT_TO_TX_STATUS = new Function, RpcResult>() { + private static final Function> RPC_RESULT_TO_TX_STATUS = new Function>() { @Override - public RpcResult apply(final RpcResult input) { - if (input.isSuccessful()) { + public RpcResult apply(final DOMRpcResult input) { + if (isSuccess(input)) { return RpcResultBuilder.success(TransactionStatus.COMMITED).build(); } else { final RpcResultBuilder failed = RpcResultBuilder.failed(); @@ -69,8 +69,8 @@ public class WriteCandidateTx extends AbstractWriteTx { } }; - public WriteCandidateTx(final RemoteDeviceId id, final NetconfBaseOps rpc, final DataNormalizer normalizer, final NetconfSessionPreferences netconfSessionPreferences) { - super(rpc, id, normalizer, netconfSessionPreferences); + public WriteCandidateTx(final RemoteDeviceId id, final NetconfBaseOps rpc, final NetconfSessionPreferences netconfSessionPreferences) { + super(rpc, id, netconfSessionPreferences); } @Override @@ -94,9 +94,9 @@ public class WriteCandidateTx extends AbstractWriteTx { private void lock() throws NetconfDocumentedException { try { - invokeBlocking("Lock candidate", new Function>>() { + invokeBlocking("Lock candidate", new Function>() { @Override - public ListenableFuture> apply(final NetconfBaseOps input) { + public ListenableFuture apply(final NetconfBaseOps input) { return input.lockCandidate(new NetconfRpcFutureCallback("Lock candidate", id)); } }); @@ -152,16 +152,16 @@ public class WriteCandidateTx extends AbstractWriteTx { @Override public synchronized ListenableFuture> performCommit() { - final ListenableFuture> rpcResult = netOps.commit(new NetconfRpcFutureCallback("Commit", id) { + final ListenableFuture rpcResult = netOps.commit(new NetconfRpcFutureCallback("Commit", id) { @Override - public void onSuccess(final RpcResult result) { + public void onSuccess(final DOMRpcResult result) { super.onSuccess(result); LOG.debug("{}: Write successful, transaction: {}. Unlocking", id, getIdentifier()); cleanupOnSuccess(); } @Override - protected void onUnsuccess(final RpcResult result) { + protected void onUnsuccess(final DOMRpcResult result) { LOG.error("{}: Write failed, transaction {}, discarding changes, unlocking: {}", id, getIdentifier(), result.getErrors()); cleanup(); } @@ -181,10 +181,10 @@ public class WriteCandidateTx extends AbstractWriteTx { } @Override - protected void editConfig(final CompositeNode editStructure, final Optional defaultOperation) throws NetconfDocumentedException { - invokeBlocking("Edit candidate", new Function>>() { + protected void editConfig(final DataContainerChild editStructure, final Optional defaultOperation) throws NetconfDocumentedException { + invokeBlocking("Edit candidate", new Function>() { @Override - public ListenableFuture> apply(final NetconfBaseOps input) { + public ListenableFuture apply(final NetconfBaseOps input) { return defaultOperation.isPresent() ? input.editConfigCandidate(new NetconfRpcFutureCallback("Edit candidate", id), editStructure, defaultOperation.get(), netconfSessionPreferences.isRollbackSupported())