X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-remoterpc-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fremote%2Frpc%2FRemoteRpcImplementation.java;h=2886fd987918a99cbe90b5144914439d9d1dc1be;hp=7d7dbf0f3a58bc404882ad78186340d8eef2aba9;hb=168591eb3dfc298b631e8dc51e25b0331c105cfc;hpb=4ef563c481b83e360e688a59ac346b8328870d58 diff --git a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RemoteRpcImplementation.java b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RemoteRpcImplementation.java index 7d7dbf0f3a..2886fd9879 100644 --- a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RemoteRpcImplementation.java +++ b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RemoteRpcImplementation.java @@ -1,98 +1,79 @@ package org.opendaylight.controller.remote.rpc; import static akka.pattern.Patterns.ask; + import akka.actor.ActorRef; import akka.dispatch.OnComplete; -import akka.util.Timeout; - -import com.google.common.util.concurrent.ListenableFuture; -import com.google.common.util.concurrent.SettableFuture; - -import org.opendaylight.controller.remote.rpc.messages.InvokeRpc; -import org.opendaylight.controller.remote.rpc.messages.RpcResponse; -import org.opendaylight.controller.remote.rpc.utils.ActorUtil; -import org.opendaylight.controller.xml.codec.XmlUtils; -import org.opendaylight.controller.sal.core.api.RoutedRpcDefaultImplementation; -import org.opendaylight.controller.sal.core.api.RpcImplementation; -import org.opendaylight.yangtools.yang.common.QName; -import org.opendaylight.yangtools.yang.common.RpcResult; -import org.opendaylight.yangtools.yang.common.RpcResultBuilder; -import org.opendaylight.yangtools.yang.common.RpcError.ErrorType; -import org.opendaylight.yangtools.yang.data.api.CompositeNode; -import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; -import org.opendaylight.yangtools.yang.model.api.SchemaContext; +import akka.japi.Pair; +import com.google.common.util.concurrent.CheckedFuture; +import com.google.common.util.concurrent.Futures; +import java.util.List; +import org.opendaylight.controller.md.sal.dom.api.DOMRpcException; +import org.opendaylight.controller.md.sal.dom.api.DOMRpcIdentifier; +import org.opendaylight.controller.md.sal.dom.api.DOMRpcImplementation; +import org.opendaylight.controller.md.sal.dom.api.DOMRpcImplementationNotAvailableException; +import org.opendaylight.controller.md.sal.dom.api.DOMRpcResult; +import org.opendaylight.controller.remote.rpc.messages.ExecuteRpc; +import org.opendaylight.controller.remote.rpc.registry.RpcRegistry; +import org.opendaylight.controller.remote.rpc.registry.RpcRegistry.Messages.FindRoutersReply; +import org.opendaylight.controller.remote.rpc.utils.LatestEntryRoutingLogic; +import org.opendaylight.controller.sal.connector.api.RpcRouter; +import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.slf4j.Logger; import org.slf4j.LoggerFactory; - import scala.concurrent.ExecutionContext; +import scala.concurrent.Future; -import java.util.Collections; -import java.util.Set; - -public class RemoteRpcImplementation implements RpcImplementation, RoutedRpcDefaultImplementation { +public class RemoteRpcImplementation implements DOMRpcImplementation { private static final Logger LOG = LoggerFactory.getLogger(RemoteRpcImplementation.class); - private final ActorRef rpcBroker; - private final SchemaContext schemaContext; - public RemoteRpcImplementation(ActorRef rpcBroker, SchemaContext schemaContext) { - this.rpcBroker = rpcBroker; - this.schemaContext = schemaContext; - } - - @Override - public ListenableFuture> invokeRpc(QName rpc, - YangInstanceIdentifier identifier, CompositeNode input) { - InvokeRpc rpcMsg = new InvokeRpc(rpc, identifier, input); - - return executeMsg(rpcMsg); - } + private final ActorRef rpcRegistry; + private final RemoteRpcProviderConfig config; - @Override - public Set getSupportedRpcs() { - // TODO : check if we need to get this from routing registry - return Collections.emptySet(); + public RemoteRpcImplementation(final ActorRef rpcRegistry, final RemoteRpcProviderConfig config) { + this.config = config; + this.rpcRegistry = rpcRegistry; } @Override - public ListenableFuture> invokeRpc(QName rpc, CompositeNode input) { - InvokeRpc rpcMsg = new InvokeRpc(rpc, null, input); - return executeMsg(rpcMsg); - } - - private ListenableFuture> executeMsg(InvokeRpc rpcMsg) { - - final SettableFuture> listenableFuture = SettableFuture.create(); - - scala.concurrent.Future future = ask(rpcBroker, rpcMsg, - new Timeout(ActorUtil.ASK_DURATION)); + public CheckedFuture invokeRpc(final DOMRpcIdentifier rpc, + final NormalizedNode input) { + if (input instanceof RemoteRpcInput) { + LOG.warn("Rpc {} was removed during execution or there is loop present. Failing received rpc.", rpc); + return Futures + .immediateFailedCheckedFuture(new DOMRpcImplementationNotAvailableException( + "Rpc implementation for {} was removed during processing.", rpc)); + } + final RemoteDOMRpcFuture frontEndFuture = RemoteDOMRpcFuture.create(rpc.getType().getLastComponent()); + findRouteAsync(rpc).onComplete(new OnComplete() { - OnComplete onComplete = new OnComplete() { @Override - public void onComplete(Throwable failure, Object reply) throws Throwable { - if(failure != null) { - LOG.error("InvokeRpc failed", failure); - - RpcResult rpcResult; - if(failure instanceof RpcErrorsException) { - rpcResult = RpcResultBuilder.failed().withRpcErrors( - ((RpcErrorsException)failure).getRpcErrors()).build(); + public void onComplete(final Throwable error, final FindRoutersReply routes) throws Throwable { + if (error != null) { + frontEndFuture.failNow(error); + } else { + final List> routePairs = routes.getRouterWithUpdateTime(); + if (routePairs == null || routePairs.isEmpty()) { + frontEndFuture.failNow(new DOMRpcImplementationNotAvailableException( + "No local or remote implementation available for rpc %s", rpc.getType(), error)); } else { - rpcResult = RpcResultBuilder.failed().withError( - ErrorType.RPC, failure.getMessage(), failure).build(); + final ActorRef remoteImplRef = new LatestEntryRoutingLogic(routePairs).select(); + final Object executeRpcMessage = ExecuteRpc.from(rpc, input); + LOG.debug("Found remote actor {} for rpc {} - sending {}", remoteImplRef, rpc.getType(), executeRpcMessage); + frontEndFuture.completeWith(ask(remoteImplRef, executeRpcMessage, config.getAskDuration())); } - - listenableFuture.set(rpcResult); - return; } - - RpcResponse rpcReply = (RpcResponse)reply; - CompositeNode result = XmlUtils.xmlToCompositeNode(rpcReply.getResultCompositeNode()); - listenableFuture.set(RpcResultBuilder.success(result).build()); } - }; - - future.onComplete(onComplete, ExecutionContext.Implicits$.MODULE$.global()); + }, ExecutionContext.Implicits$.MODULE$.global()); + return frontEndFuture; + } - return listenableFuture; + @SuppressWarnings({"unchecked", "rawtypes"}) + private Future findRouteAsync(final DOMRpcIdentifier rpc) { + // FIXME: Refactor routeId and message to use DOMRpcIdentifier directly. + final RpcRouter.RouteIdentifier routeId = + new RouteIdentifierImpl(null, rpc.getType().getLastComponent(), rpc.getContextReference()); + final RpcRegistry.Messages.FindRouters findMsg = new RpcRegistry.Messages.FindRouters(routeId); + return (Future) ask(rpcRegistry, findMsg, config.getAskDuration()); } }