X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-rest-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fsal%2Frest%2Fimpl%2FJsonMapper.java;h=36b46a171cde4706a1b7e22d17ed4c7e00ccdc90;hp=351ae6ebbee085614943d7608ec51669a204f1ff;hb=a8e8f161be05a865c5ae364b57e76521944c13cf;hpb=76925347a1925c00c8d479f455783565c0caaaa0 diff --git a/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/JsonMapper.java b/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/JsonMapper.java index 351ae6ebbe..36b46a171c 100644 --- a/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/JsonMapper.java +++ b/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/JsonMapper.java @@ -47,13 +47,27 @@ class JsonMapper { checkNotNull(parent); checkNotNull(parentSchema); + List longestPathToElementViaChoiceCase = new ArrayList<>(); for (Node child : parent.getChildren()) { - DataSchemaNode childSchema = findFirstSchemaForNode(child, parentSchema.getChildNodes()); - if (childSchema == null) { - throw new UnsupportedDataTypeException("Probably the data node \"" + child.getNodeType().getLocalName() - + "\" is not conform to schema"); + Deque choiceCasePathStack = new ArrayDeque<>(longestPathToElementViaChoiceCase); + SchemaLocation schemaLocation = findFirstSchemaForNode(child, parentSchema.getChildNodes(), + choiceCasePathStack); + + if (schemaLocation == null) { + if (!choiceCasePathStack.isEmpty()) { + throw new UnsupportedDataTypeException("On choice-case path " + choiceCasePathStack + + " wasn't found data schema for " + child.getNodeType().getLocalName()); + } else { + throw new UnsupportedDataTypeException("Probably the data node \"" + + child.getNodeType().getLocalName() + "\" is not conform to schema"); + } } + longestPathToElementViaChoiceCase = resolveLongerPath(longestPathToElementViaChoiceCase, + schemaLocation.getLocation()); + + DataSchemaNode childSchema = schemaLocation.getSchema(); + if (childSchema instanceof ContainerSchemaNode) { Preconditions.checkState(child instanceof CompositeNode, "Data representation of Container should be CompositeNode - " + child.getNodeType()); @@ -83,7 +97,10 @@ class JsonMapper { } for (Node child : parent.getChildren()) { - DataSchemaNode childSchema = findFirstSchemaForNode(child, parentSchema.getChildNodes()); + SchemaLocation schemaLocation = findFirstSchemaForNode(child, parentSchema.getChildNodes(), + new ArrayDeque<>(longestPathToElementViaChoiceCase)); + + DataSchemaNode childSchema = schemaLocation.getSchema(); if (childSchema instanceof LeafListSchemaNode) { foundLeafLists.remove((LeafListSchemaNode) childSchema); } else if (childSchema instanceof ListSchemaNode) { @@ -92,10 +109,45 @@ class JsonMapper { } } - private DataSchemaNode findFirstSchemaForNode(Node node, Set dataSchemaNode) { + private List resolveLongerPath(List l1, List l2) { + return l1.size() > l2.size() ? l1 : l2; + } + + private SchemaLocation findFirstSchemaForNode(Node node, Set dataSchemaNode, + Deque pathIterator) { + Map choiceSubnodes = new HashMap<>(); for (DataSchemaNode dsn : dataSchemaNode) { - if (node.getNodeType().getLocalName().equals(dsn.getQName().getLocalName())) { - return dsn; + if (dsn instanceof ChoiceNode) { + choiceSubnodes.put(dsn.getQName().getLocalName(), (ChoiceNode) dsn); + } else if (node.getNodeType().getLocalName().equals(dsn.getQName().getLocalName())) { + return new SchemaLocation(dsn); + } + } + + for (ChoiceNode choiceSubnode : choiceSubnodes.values()) { + if ((!pathIterator.isEmpty() && pathIterator.peekLast().equals(choiceSubnode.getQName().getLocalName())) + || pathIterator.isEmpty()) { + String pathPartChoice = pathIterator.pollLast(); + for (ChoiceCaseNode concreteCase : choiceSubnode.getCases()) { + if ((!pathIterator.isEmpty() && pathIterator.peekLast().equals( + concreteCase.getQName().getLocalName())) + || pathIterator.isEmpty()) { + String pathPartCase = pathIterator.pollLast(); + SchemaLocation schemaLocation = findFirstSchemaForNode(node, concreteCase.getChildNodes(), + pathIterator); + if (schemaLocation != null) { + schemaLocation.addPathPart(concreteCase.getQName().getLocalName()); + schemaLocation.addPathPart(choiceSubnode.getQName().getLocalName()); + return schemaLocation; + } + if (pathPartCase != null) { + pathIterator.addLast(pathPartCase); + } + } + } + if (pathPartChoice != null) { + pathIterator.addLast(pathPartChoice); + } } } return null;