X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-rest-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fsal%2Frestconf%2Fimpl%2FControllerContext.java;h=28e6a3c2472ee3b8723c82dc5d1050215c209bee;hp=1c076d1e2e76291f999384ccc2704a910400812e;hb=3b721d88ed1083a463ecb73a6050de4bfedf1a78;hpb=3b57f8f6b29cd8e63e20ad81ba87fdc24828f7ab diff --git a/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/ControllerContext.java b/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/ControllerContext.java index 1c076d1e2e..28e6a3c247 100644 --- a/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/ControllerContext.java +++ b/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/ControllerContext.java @@ -18,7 +18,6 @@ import com.google.common.collect.BiMap; import com.google.common.collect.FluentIterable; import com.google.common.collect.HashBiMap; import com.google.common.collect.Iterables; -import com.google.common.collect.Lists; import java.io.UnsupportedEncodingException; import java.net.URI; @@ -38,11 +37,10 @@ import javax.ws.rs.core.Response.Status; import org.opendaylight.controller.sal.core.api.mount.MountInstance; import org.opendaylight.controller.sal.core.api.mount.MountService; +import org.opendaylight.controller.sal.rest.api.Draft02; import org.opendaylight.controller.sal.rest.impl.RestUtil; -import org.opendaylight.controller.sal.rest.impl.RestconfProvider; -import org.opendaylight.controller.sal.restconf.impl.InstanceIdWithSchemaNode; -import org.opendaylight.controller.sal.restconf.impl.ResponseException; -import org.opendaylight.controller.sal.restconf.impl.RestCodec; +import org.opendaylight.controller.sal.restconf.impl.RestconfError.ErrorTag; +import org.opendaylight.controller.sal.restconf.impl.RestconfError.ErrorType; import org.opendaylight.yangtools.concepts.Codec; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier; @@ -50,11 +48,13 @@ import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier.InstanceIdent import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier.NodeIdentifier; import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier.NodeIdentifierWithPredicates; import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier.PathArgument; +import org.opendaylight.yangtools.yang.model.api.AnyXmlSchemaNode; import org.opendaylight.yangtools.yang.model.api.ChoiceCaseNode; import org.opendaylight.yangtools.yang.model.api.ChoiceNode; import org.opendaylight.yangtools.yang.model.api.ContainerSchemaNode; import org.opendaylight.yangtools.yang.model.api.DataNodeContainer; import org.opendaylight.yangtools.yang.model.api.DataSchemaNode; +import org.opendaylight.yangtools.yang.model.api.GroupingDefinition; import org.opendaylight.yangtools.yang.model.api.LeafListSchemaNode; import org.opendaylight.yangtools.yang.model.api.LeafSchemaNode; import org.opendaylight.yangtools.yang.model.api.ListSchemaNode; @@ -82,6 +82,10 @@ public class ControllerContext implements SchemaContextListener { private final static String URI_ENCODING_CHAR_SET = "ISO-8859-1"; + private static final Splitter SLASH_SPLITTER = Splitter.on('/'); + + private static final Splitter COLON_SPLITTER = Splitter.on(':'); + private final BiMap uriToModuleName = HashBiMap. create(); private final Map moduleNameToUri = uriToModuleName.inverse(); @@ -108,7 +112,7 @@ public class ControllerContext implements SchemaContextListener { private void checkPreconditions() { if( globalSchema == null ) { - throw new ResponseException( Status.SERVICE_UNAVAILABLE, RestconfProvider.NOT_INITALIZED_MSG ); + throw new RestconfDocumentedException( Status.SERVICE_UNAVAILABLE ); } } @@ -125,13 +129,11 @@ public class ControllerContext implements SchemaContextListener { } private InstanceIdWithSchemaNode toIdentifier( final String restconfInstance, - final boolean toMountPointIdentifier ) { + final boolean toMountPointIdentifier ) { this.checkPreconditions(); - Iterable split = Splitter.on( "/" ).split( restconfInstance ); - final ArrayList encodedPathArgs = Lists. newArrayList( split ); - final List pathArgs = this.urlPathArgsDecode( encodedPathArgs ); - this.omitFirstAndLastEmptyString( pathArgs ); + final List pathArgs = urlPathArgsDecode( SLASH_SPLITTER.split( restconfInstance ) ); + omitFirstAndLastEmptyString( pathArgs ); if( pathArgs.isEmpty() ) { return null; } @@ -139,23 +141,25 @@ public class ControllerContext implements SchemaContextListener { String first = pathArgs.iterator().next(); final String startModule = ControllerContext.toModuleName( first ); if( startModule == null ) { - throw new ResponseException( Status.BAD_REQUEST, - "First node in URI has to be in format \"moduleName:nodeName\"" ); + throw new RestconfDocumentedException( + "First node in URI has to be in format \"moduleName:nodeName\"", + ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE ); } InstanceIdentifierBuilder builder = InstanceIdentifier.builder(); Module latestModule = this.getLatestModule( globalSchema, startModule ); InstanceIdWithSchemaNode iiWithSchemaNode = this.collectPathArguments( builder, pathArgs, - latestModule, null, toMountPointIdentifier ); + latestModule, null, toMountPointIdentifier ); if( iiWithSchemaNode == null ) { - throw new ResponseException( Status.BAD_REQUEST, "URI has bad format" ); + throw new RestconfDocumentedException( + "URI has bad format", ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE ); } return iiWithSchemaNode; } - private List omitFirstAndLastEmptyString( final List list ) { + private static List omitFirstAndLastEmptyString( final List list ) { if( list.isEmpty() ) { return list; } @@ -183,7 +187,7 @@ public class ControllerContext implements SchemaContextListener { Predicate filter = new Predicate() { @Override - public boolean apply( Module m ) { + public boolean apply( final Module m ) { return Objects.equal( m.getName(), moduleName ); } }; @@ -228,14 +232,14 @@ public class ControllerContext implements SchemaContextListener { final SchemaContext mountPointSchema = mountPoint.getSchemaContext(); Set moduleSchemas = mountPointSchema == null ? null : - mountPointSchema.findModuleByNamespace( namespace ); + mountPointSchema.findModuleByNamespace( namespace ); return moduleSchemas == null ? null : this.filterLatestModule( moduleSchemas ); } public Module findModuleByNameAndRevision( final QName module ) { this.checkPreconditions(); Preconditions.checkArgument( module != null && module.getLocalName() != null && - module.getRevision() != null ); + module.getRevision() != null ); return globalSchema.findModuleByName( module.getLocalName(), module.getRevision() ); } @@ -243,17 +247,17 @@ public class ControllerContext implements SchemaContextListener { public Module findModuleByNameAndRevision( final MountInstance mountPoint, final QName module ) { this.checkPreconditions(); Preconditions.checkArgument( module != null && module.getLocalName() != null && - module.getRevision() != null && mountPoint != null ); + module.getRevision() != null && mountPoint != null ); SchemaContext schemaContext = mountPoint.getSchemaContext(); return schemaContext == null ? null : - schemaContext.findModuleByName( module.getLocalName(), module.getRevision() ); + schemaContext.findModuleByName( module.getLocalName(), module.getRevision() ); } public DataNodeContainer getDataNodeContainerFor( final InstanceIdentifier path ) { this.checkPreconditions(); - final List elements = path.getPath(); + final Iterable elements = path.getPathArguments(); PathArgument head = elements.iterator().next(); final QName startQName = head.getNodeType(); final Module initialModule = globalSchema.findModuleByNamespaceAndRevision( @@ -274,7 +278,7 @@ public class ControllerContext implements SchemaContextListener { public String toFullRestconfIdentifier( final InstanceIdentifier path ) { this.checkPreconditions(); - final List elements = path.getPath(); + final Iterable elements = path.getPathArguments(); final StringBuilder builder = new StringBuilder(); PathArgument head = elements.iterator().next(); final QName startQName = head.getNodeType(); @@ -350,7 +354,7 @@ public class ControllerContext implements SchemaContextListener { String module = this.uriToModuleName.get( qname.getNamespace() ); if( module == null ) { final Module moduleSchema = globalSchema.findModuleByNamespaceAndRevision( - qname.getNamespace(), qname.getRevision() ); + qname.getNamespace(), qname.getRevision() ); if( moduleSchema == null ) { return null; } @@ -374,7 +378,7 @@ public class ControllerContext implements SchemaContextListener { SchemaContext schemaContext = mountPoint.getSchemaContext(); final Module moduleSchema = schemaContext.findModuleByNamespaceAndRevision( - qname.getNamespace(), qname.getRevision() ); + qname.getNamespace(), qname.getRevision() ); if( moduleSchema == null ) { return null; } @@ -386,6 +390,112 @@ public class ControllerContext implements SchemaContextListener { return builder.toString(); } + public Module getRestconfModule() { + return findModuleByNameAndRevision( Draft02.RestConfModule.IETF_RESTCONF_QNAME ); + } + + public DataSchemaNode getRestconfModuleErrorsSchemaNode() { + Module restconfModule = getRestconfModule(); + if( restconfModule == null ) { + return null; + } + + Set groupings = restconfModule.getGroupings(); + + final Predicate filter = new Predicate() { + @Override + public boolean apply(final GroupingDefinition g) { + return Objects.equal(g.getQName().getLocalName(), + Draft02.RestConfModule.ERRORS_GROUPING_SCHEMA_NODE); + } + }; + + Iterable filteredGroups = Iterables.filter(groupings, filter); + + final GroupingDefinition restconfGrouping = Iterables.getFirst(filteredGroups, null); + + List instanceDataChildrenByName = + this.findInstanceDataChildrenByName(restconfGrouping, + Draft02.RestConfModule.ERRORS_CONTAINER_SCHEMA_NODE); + return Iterables.getFirst(instanceDataChildrenByName, null); + } + + public DataSchemaNode getRestconfModuleRestConfSchemaNode( final Module inRestconfModule, + final String schemaNodeName ) { + Module restconfModule = inRestconfModule; + if( restconfModule == null ) { + restconfModule = getRestconfModule(); + } + + if( restconfModule == null ) { + return null; + } + + Set groupings = restconfModule.getGroupings(); + + final Predicate filter = new Predicate() { + @Override + public boolean apply(final GroupingDefinition g) { + return Objects.equal(g.getQName().getLocalName(), + Draft02.RestConfModule.RESTCONF_GROUPING_SCHEMA_NODE); + } + }; + + Iterable filteredGroups = Iterables.filter(groupings, filter); + + final GroupingDefinition restconfGrouping = Iterables.getFirst(filteredGroups, null); + + List instanceDataChildrenByName = + this.findInstanceDataChildrenByName(restconfGrouping, + Draft02.RestConfModule.RESTCONF_CONTAINER_SCHEMA_NODE); + final DataSchemaNode restconfContainer = Iterables.getFirst(instanceDataChildrenByName, null); + + if (Objects.equal(schemaNodeName, Draft02.RestConfModule.OPERATIONS_CONTAINER_SCHEMA_NODE)) { + List instances = + this.findInstanceDataChildrenByName(((DataNodeContainer) restconfContainer), + Draft02.RestConfModule.OPERATIONS_CONTAINER_SCHEMA_NODE); + return Iterables.getFirst(instances, null); + } + else if(Objects.equal(schemaNodeName, Draft02.RestConfModule.STREAMS_CONTAINER_SCHEMA_NODE)) { + List instances = + this.findInstanceDataChildrenByName(((DataNodeContainer) restconfContainer), + Draft02.RestConfModule.STREAMS_CONTAINER_SCHEMA_NODE); + return Iterables.getFirst(instances, null); + } + else if(Objects.equal(schemaNodeName, Draft02.RestConfModule.STREAM_LIST_SCHEMA_NODE)) { + List instances = + this.findInstanceDataChildrenByName(((DataNodeContainer) restconfContainer), + Draft02.RestConfModule.STREAMS_CONTAINER_SCHEMA_NODE); + final DataSchemaNode modules = Iterables.getFirst(instances, null); + instances = this.findInstanceDataChildrenByName(((DataNodeContainer) modules), + Draft02.RestConfModule.STREAM_LIST_SCHEMA_NODE); + return Iterables.getFirst(instances, null); + } + else if(Objects.equal(schemaNodeName, Draft02.RestConfModule.MODULES_CONTAINER_SCHEMA_NODE)) { + List instances = + this.findInstanceDataChildrenByName(((DataNodeContainer) restconfContainer), + Draft02.RestConfModule.MODULES_CONTAINER_SCHEMA_NODE); + return Iterables.getFirst(instances, null); + } + else if(Objects.equal(schemaNodeName, Draft02.RestConfModule.MODULE_LIST_SCHEMA_NODE)) { + List instances = + this.findInstanceDataChildrenByName(((DataNodeContainer) restconfContainer), + Draft02.RestConfModule.MODULES_CONTAINER_SCHEMA_NODE); + final DataSchemaNode modules = Iterables.getFirst(instances, null); + instances = this.findInstanceDataChildrenByName(((DataNodeContainer) modules), + Draft02.RestConfModule.MODULE_LIST_SCHEMA_NODE); + return Iterables.getFirst(instances, null); + } + else if(Objects.equal(schemaNodeName, Draft02.RestConfModule.STREAMS_CONTAINER_SCHEMA_NODE)) { + List instances = + this.findInstanceDataChildrenByName(((DataNodeContainer) restconfContainer), + Draft02.RestConfModule.STREAMS_CONTAINER_SCHEMA_NODE); + return Iterables.getFirst(instances, null); + } + + return null; + } + private static DataSchemaNode childByQName( final ChoiceNode container, final QName name ) { for( final ChoiceCaseNode caze : container.getCases() ) { final DataSchemaNode ret = ControllerContext.childByQName( caze, name ); @@ -435,7 +545,7 @@ public class ControllerContext implements SchemaContextListener { private String toUriString( final Object object ) throws UnsupportedEncodingException { return object == null ? "" : - URLEncoder.encode( object.toString(), ControllerContext.URI_ENCODING_CHAR_SET ); + URLEncoder.encode( object.toString(), ControllerContext.URI_ENCODING_CHAR_SET ); } private InstanceIdWithSchemaNode collectPathArguments( final InstanceIdentifierBuilder builder, @@ -449,39 +559,42 @@ public class ControllerContext implements SchemaContextListener { if( strings.isEmpty() ) { return new InstanceIdWithSchemaNode( builder.toInstance(), - ((DataSchemaNode) parentNode), mountPoint ); + ((DataSchemaNode) parentNode), mountPoint ); } String head = strings.iterator().next(); - final String nodeName = this.toNodeName( head ); + final String nodeName = toNodeName( head ); final String moduleName = ControllerContext.toModuleName( head ); DataSchemaNode targetNode = null; if( !Strings.isNullOrEmpty( moduleName ) ) { if( Objects.equal( moduleName, ControllerContext.MOUNT_MODULE ) && - Objects.equal( nodeName, ControllerContext.MOUNT_NODE ) ) { + Objects.equal( nodeName, ControllerContext.MOUNT_NODE ) ) { if( mountPoint != null ) { - throw new ResponseException( Status.BAD_REQUEST, - "Restconf supports just one mount point in URI." ); + throw new RestconfDocumentedException( + "Restconf supports just one mount point in URI.", + ErrorType.APPLICATION, ErrorTag.OPERATION_NOT_SUPPORTED ); } if( mountService == null ) { - throw new ResponseException( Status.SERVICE_UNAVAILABLE, - "MountService was not found. Finding behind mount points does not work." ); + throw new RestconfDocumentedException( + "MountService was not found. Finding behind mount points does not work.", + ErrorType.APPLICATION, ErrorTag.OPERATION_NOT_SUPPORTED ); } final InstanceIdentifier partialPath = builder.toInstance(); final MountInstance mount = mountService.getMountPoint( partialPath ); if( mount == null ) { LOG.debug( "Instance identifier to missing mount point: {}", partialPath ); - throw new ResponseException( Status.BAD_REQUEST, - "Mount point does not exist." ); + throw new RestconfDocumentedException( + "Mount point does not exist.", ErrorType.PROTOCOL, ErrorTag.UNKNOWN_ELEMENT ); } final SchemaContext mountPointSchema = mount.getSchemaContext(); if( mountPointSchema == null ) { - throw new ResponseException( Status.BAD_REQUEST, - "Mount point does not contain any schema with modules." ); + throw new RestconfDocumentedException( + "Mount point does not contain any schema with modules.", + ErrorType.APPLICATION, ErrorTag.UNKNOWN_ELEMENT ); } if( returnJustMountPoint ) { @@ -496,82 +609,85 @@ public class ControllerContext implements SchemaContextListener { final String moduleNameBehindMountPoint = toModuleName( strings.get( 1 ) ); if( moduleNameBehindMountPoint == null ) { - throw new ResponseException( Status.BAD_REQUEST, - "First node after mount point in URI has to be in format \"moduleName:nodeName\"" ); + throw new RestconfDocumentedException( + "First node after mount point in URI has to be in format \"moduleName:nodeName\"", + ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE ); } final Module moduleBehindMountPoint = this.getLatestModule( mountPointSchema, - moduleNameBehindMountPoint ); + moduleNameBehindMountPoint ); if( moduleBehindMountPoint == null ) { - throw new ResponseException( Status.BAD_REQUEST, - "URI has bad format. \"" + moduleName + - "\" module does not exist in mount point." ); + throw new RestconfDocumentedException( + "\"" +moduleName + "\" module does not exist in mount point.", + ErrorType.PROTOCOL, ErrorTag.UNKNOWN_ELEMENT ); } List subList = strings.subList( 1, strings.size() ); return this.collectPathArguments( InstanceIdentifier.builder(), subList, moduleBehindMountPoint, - mount, returnJustMountPoint ); + mount, returnJustMountPoint ); } Module module = null; if( mountPoint == null ) { module = this.getLatestModule( globalSchema, moduleName ); if( module == null ) { - throw new ResponseException( Status.BAD_REQUEST, - "URI has bad format. \"" + moduleName + "\" module does not exist." ); + throw new RestconfDocumentedException( + "\"" + moduleName + "\" module does not exist.", + ErrorType.PROTOCOL, ErrorTag.UNKNOWN_ELEMENT ); } } else { SchemaContext schemaContext = mountPoint.getSchemaContext(); module = schemaContext == null ? null : - this.getLatestModule( schemaContext, moduleName ); + this.getLatestModule( schemaContext, moduleName ); if( module == null ) { - throw new ResponseException( Status.BAD_REQUEST, - "URI has bad format. \"" + moduleName + - "\" module does not exist in mount point." ); + throw new RestconfDocumentedException( + "\"" + moduleName + "\" module does not exist in mount point.", + ErrorType.PROTOCOL, ErrorTag.UNKNOWN_ELEMENT ); } } targetNode = this.findInstanceDataChildByNameAndNamespace( - parentNode, nodeName, module.getNamespace() );; + parentNode, nodeName, module.getNamespace() ); if( targetNode == null ) { - throw new ResponseException( Status.BAD_REQUEST, - "URI has bad format. Possible reasons:\n" + - "1. \"" + head + "\" was not found in parent data node.\n" + - "2. \"" + head + "\" is behind mount point. Then it should be in format \"/" + - MOUNT + "/" + head + "\"." ); + throw new RestconfDocumentedException( + "URI has bad format. Possible reasons:\n" + + " 1. \"" + head + "\" was not found in parent data node.\n" + + " 2. \"" + head + "\" is behind mount point. Then it should be in format \"/" + + MOUNT + "/" + head + "\".", ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE ); } } else { final List potentialSchemaNodes = - this.findInstanceDataChildrenByName( parentNode, nodeName ); + this.findInstanceDataChildrenByName( parentNode, nodeName ); if( potentialSchemaNodes.size() > 1 ) { final StringBuilder strBuilder = new StringBuilder(); for( final DataSchemaNode potentialNodeSchema : potentialSchemaNodes ) { strBuilder.append( " " ) - .append( potentialNodeSchema.getQName().getNamespace() ) - .append( "\n" ); + .append( potentialNodeSchema.getQName().getNamespace() ) + .append( "\n" ); } - throw new ResponseException( Status.BAD_REQUEST, + throw new RestconfDocumentedException( "URI has bad format. Node \"" + nodeName + "\" is added as augment from more than one module. " + "Therefore the node must have module name and it has to be in format \"moduleName:nodeName\"." + "\nThe node is added as augment from modules with namespaces:\n" + - strBuilder.toString() ); + strBuilder.toString(), ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE ); } if( potentialSchemaNodes.isEmpty() ) { - throw new ResponseException( Status.BAD_REQUEST, "URI has bad format. \"" + nodeName + - "\" was not found in parent data node.\n" ); + throw new RestconfDocumentedException( + "\"" + nodeName + "\" in URI was not found in parent data node", + ErrorType.PROTOCOL, ErrorTag.UNKNOWN_ELEMENT ); } targetNode = potentialSchemaNodes.iterator().next(); } if( !this.isListOrContainer( targetNode ) ) { - throw new ResponseException( Status.BAD_REQUEST, - "URI has bad format. Node \"" + head + - "\" must be Container or List yang type." ); + throw new RestconfDocumentedException( + "URI has bad format. Node \"" + head + "\" must be Container or List yang type.", + ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE ); } int consumed = 1; @@ -579,8 +695,9 @@ public class ControllerContext implements SchemaContextListener { final ListSchemaNode listNode = ((ListSchemaNode) targetNode); final int keysSize = listNode.getKeyDefinition().size(); if( (strings.size() - consumed) < keysSize ) { - throw new ResponseException( Status.BAD_REQUEST, "Missing key for list \"" + - listNode.getQName().getLocalName() + "\"." ); + throw new RestconfDocumentedException( + "Missing key value for list element '" + listNode.getQName().getLocalName() + "' in the URI.", + ErrorType.PROTOCOL, ErrorTag.DATA_MISSING ); } final List uriKeyValues = strings.subList( consumed, consumed + keysSize ); @@ -590,13 +707,14 @@ public class ControllerContext implements SchemaContextListener { { final String uriKeyValue = uriKeyValues.get( i ); if( uriKeyValue.equals( NULL_VALUE ) ) { - throw new ResponseException( Status.BAD_REQUEST, - "URI has bad format. List \"" + listNode.getQName().getLocalName() + - "\" cannot contain \"null\" value as a key." ); + throw new RestconfDocumentedException( + "URI has bad format. List \"" + listNode.getQName().getLocalName() + + "\" cannot contain \"null\" value as a key.", + ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE ); } this.addKeyValue( keyValues, listNode.getDataChildByName( key ), - uriKeyValue, mountPoint ); + uriKeyValue, mountPoint ); i++; } } @@ -611,7 +729,7 @@ public class ControllerContext implements SchemaContextListener { if( (targetNode instanceof DataNodeContainer) ) { final List remaining = strings.subList( consumed, strings.size() ); return this.collectPathArguments( builder, remaining, - ((DataNodeContainer) targetNode), mountPoint, returnJustMountPoint ); + ((DataNodeContainer) targetNode), mountPoint, returnJustMountPoint ); } return new InstanceIdWithSchemaNode( builder.toInstance(), targetNode, mountPoint ); @@ -625,7 +743,7 @@ public class ControllerContext implements SchemaContextListener { Predicate filter = new Predicate() { @Override - public boolean apply( DataSchemaNode node ) { + public boolean apply( final DataSchemaNode node ) { return Objects.equal( node.getQName().getNamespace(), namespace ); } }; @@ -635,7 +753,7 @@ public class ControllerContext implements SchemaContextListener { } public List findInstanceDataChildrenByName( final DataNodeContainer container, - final String name ) { + final String name ) { Preconditions. checkNotNull( container ); Preconditions. checkNotNull( name ); @@ -651,7 +769,7 @@ public class ControllerContext implements SchemaContextListener { Predicate filter = new Predicate() { @Override - public boolean apply( DataSchemaNode node ) { + public boolean apply( final DataSchemaNode node ) { return Objects.equal( node.getQName().getLocalName(), name ); } }; @@ -667,7 +785,7 @@ public class ControllerContext implements SchemaContextListener { } Iterable choiceNodes = Iterables. filter( container.getChildNodes(), - ChoiceNode.class ); + ChoiceNode.class ); final Function> choiceFunction = new Function>() { @@ -678,7 +796,7 @@ public class ControllerContext implements SchemaContextListener { }; Iterable> map = Iterables.> transform( - choiceNodes, choiceFunction ); + choiceNodes, choiceFunction ); final Iterable allCases = Iterables. concat( map ); for( final ChoiceCaseNode caze : allCases ) { @@ -688,11 +806,12 @@ public class ControllerContext implements SchemaContextListener { public boolean isInstantiatedDataSchema( final DataSchemaNode node ) { return node instanceof LeafSchemaNode || node instanceof LeafListSchemaNode || - node instanceof ContainerSchemaNode || node instanceof ListSchemaNode; + node instanceof ContainerSchemaNode || node instanceof ListSchemaNode || + node instanceof AnyXmlSchemaNode; } private void addKeyValue( final HashMap map, final DataSchemaNode node, - final String uriValue, final MountInstance mountPoint ) { + final String uriValue, final MountInstance mountPoint ) { Preconditions. checkNotNull( uriValue ); Preconditions.checkArgument( (node instanceof LeafSchemaNode) ); @@ -711,8 +830,9 @@ public class ControllerContext implements SchemaContextListener { } if( decoded == null ) { - throw new ResponseException( Status.BAD_REQUEST, uriValue + " from URI can\'t be resolved. " + - additionalInfo ); + throw new RestconfDocumentedException( + uriValue + " from URI can't be resolved. " + additionalInfo, + ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE ); } map.put( node.getQName(), decoded ); @@ -720,20 +840,20 @@ public class ControllerContext implements SchemaContextListener { private static String toModuleName( final String str ) { Preconditions. checkNotNull( str ); - if( str.contains( ":" ) ) { - final String[] args = str.split( ":" ); - if( args.length == 2 ) { - return args[0]; + if( str.indexOf( ':' ) != -1 ) { + final Iterable args = COLON_SPLITTER.split( str ); + if( Iterables.size( args ) == 2 ) { + return args.iterator().next(); } } return null; } - private String toNodeName( final String str ) { - if( str.contains( ":" ) ) { - final String[] args = str.split( ":" ); - if( args.length == 2 ) { - return args[1]; + private static String toNodeName( final String str ) { + if( str.indexOf( ':' ) != -1 ) { + final Iterable args = COLON_SPLITTER.split( str ); + if( Iterables.size( args ) == 2 ) { + return Iterables.get( args, 1 ); } } return str; @@ -741,7 +861,7 @@ public class ControllerContext implements SchemaContextListener { private QName toQName( final String name ) { final String module = toModuleName( name ); - final String node = this.toNodeName( name ); + final String node = toNodeName( name ); Set modules = globalSchema.getModules(); final Comparator comparator = new Comparator() { @@ -769,8 +889,8 @@ public class ControllerContext implements SchemaContextListener { }; Optional namespace = FluentIterable.from( sorted ) - .transform( transform ) - .firstMatch( findFirst ); + .transform( transform ) + .firstMatch( findFirst ); return namespace.isPresent() ? QName.create( namespace.get(), node ) : null; } @@ -797,7 +917,7 @@ public class ControllerContext implements SchemaContextListener { } } - public List urlPathArgsDecode( final List strings ) { + public static List urlPathArgsDecode( final Iterable strings ) { try { List decodedPathArgs = new ArrayList(); for( final String pathArg : strings ) { @@ -807,8 +927,9 @@ public class ControllerContext implements SchemaContextListener { return decodedPathArgs; } catch( UnsupportedEncodingException e ) { - throw new ResponseException( Status.BAD_REQUEST, - "Invalid URL path '" + strings + "': " + e.getMessage() ); + throw new RestconfDocumentedException( + "Invalid URL path '" + strings + "': " + e.getMessage(), + ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE ); } } @@ -818,8 +939,9 @@ public class ControllerContext implements SchemaContextListener { return URLDecoder.decode( pathArg, URI_ENCODING_CHAR_SET ); } catch( UnsupportedEncodingException e ) { - throw new ResponseException( Status.BAD_REQUEST, - "Invalid URL path arg '" + pathArg + "': " + e.getMessage() ); + throw new RestconfDocumentedException( + "Invalid URL path arg '" + pathArg + "': " + e.getMessage(), + ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE ); } } @@ -827,7 +949,7 @@ public class ControllerContext implements SchemaContextListener { } private CharSequence convertToRestconfIdentifier( final PathArgument argument, - final DataNodeContainer node ) { + final DataNodeContainer node ) { if( argument instanceof NodeIdentifier && node instanceof ContainerSchemaNode ) { return convertToRestconfIdentifier( (NodeIdentifier) argument, (ContainerSchemaNode) node ); } @@ -836,7 +958,7 @@ public class ControllerContext implements SchemaContextListener { } else if( argument != null && node != null ) { throw new IllegalArgumentException( - "Conversion of generic path argument is not supported" ); + "Conversion of generic path argument is not supported" ); } else { throw new IllegalArgumentException( "Unhandled parameter types: " @@ -845,7 +967,7 @@ public class ControllerContext implements SchemaContextListener { } private CharSequence convertToRestconfIdentifier( final NodeIdentifier argument, - final ContainerSchemaNode node ) { + final ContainerSchemaNode node ) { StringBuilder builder = new StringBuilder(); builder.append( "/" ); QName nodeType = argument.getNodeType(); @@ -854,7 +976,7 @@ public class ControllerContext implements SchemaContextListener { } private CharSequence convertToRestconfIdentifier( final NodeIdentifierWithPredicates argument, - final ListSchemaNode node ) { + final ListSchemaNode node ) { QName nodeType = argument.getNodeType(); final CharSequence nodeIdentifier = this.toRestconfIdentifier( nodeType ); final Map keyValues = argument.getKeyValues(); @@ -877,7 +999,7 @@ public class ControllerContext implements SchemaContextListener { try { builder.append( this.toUriString( keyValues.get( key ) ) ); } catch( UnsupportedEncodingException e ) { - LOG.error( "Error parsing URI: " + keyValues.get( key ), e ); + LOG.error( "Error parsing URI: {}", keyValues.get( key ), e ); return null; } }