X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-rest-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fsal%2Frestconf%2Fimpl%2FRestconfImpl.java;h=5f5b9bafe10239dc9eb3df60e6435b916b54bd8a;hp=82ac862843b78db99d1707dce5ac701b139185e8;hb=06e889c9c78457590b6a0b62d89a6b9f44242a9f;hpb=f55f03931ef55344b0fb71b75fb0cb577fa89d54 diff --git a/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/RestconfImpl.java b/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/RestconfImpl.java index 82ac862843..5f5b9bafe1 100644 --- a/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/RestconfImpl.java +++ b/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/restconf/impl/RestconfImpl.java @@ -549,16 +549,14 @@ public class RestconfImpl implements RestconfService { final DOMRpcResult result = checkRpcResponse(response); - DataSchemaNode resultNodeSchema = null; - NormalizedNode resultData = null; + RpcDefinition resultNodeSchema = null; + final NormalizedNode resultData = result.getResult(); if (result != null && result.getResult() != null) { - resultData = result.getResult(); - final ContainerSchemaNode rpcDataSchemaNode = SchemaContextUtil.getRpcDataSchema(schemaContext, type); - resultNodeSchema = rpcDataSchemaNode.getDataChildByName(result.getResult().getNodeType()); + resultNodeSchema = (RpcDefinition) payload.getInstanceIdentifierContext().getSchemaNode(); } - return new NormalizedNodeContext(new InstanceIdentifierContext(null, resultNodeSchema, mountPoint, - schemaContext), resultData); + return new NormalizedNodeContext(new InstanceIdentifierContext(null, + resultNodeSchema, mountPoint, schemaContext), resultData); } private DOMRpcResult checkRpcResponse(final CheckedFuture response) { @@ -601,7 +599,7 @@ public class RestconfImpl implements RestconfService { } } - private void validateInput(final DataSchemaNode inputSchema, final NormalizedNodeContext payload) { + private void validateInput(final SchemaNode inputSchema, final NormalizedNodeContext payload) { if (inputSchema != null && payload.getData() == null) { // expected a non null payload throw new RestconfDocumentedException("Input is required.", ErrorType.PROTOCOL, ErrorTag.MALFORMED_MESSAGE); @@ -643,7 +641,7 @@ public class RestconfImpl implements RestconfService { private CheckedFuture invokeSalRemoteRpcSubscribeRPC(final NormalizedNodeContext payload) { final ContainerNode value = (ContainerNode) payload.getData(); final QName rpcQName = payload.getInstanceIdentifierContext().getSchemaNode().getQName(); - Optional> path = value.getChild(new NodeIdentifier( + final Optional> path = value.getChild(new NodeIdentifier( QName.create(payload.getInstanceIdentifierContext().getSchemaNode().getQName(), "path"))); final Object pathValue = path.isPresent() ? path.get().getValue() : null; @@ -674,18 +672,18 @@ public class RestconfImpl implements RestconfService { ErrorType.PROTOCOL, ErrorTag.INVALID_VALUE); } - QName outputQname = QName.create(rpcQName, "output"); - QName streamNameQname = QName.create(rpcQName, "stream-name"); + final QName outputQname = QName.create(rpcQName, "output"); + final QName streamNameQname = QName.create(rpcQName, "stream-name"); - ContainerNode output = ImmutableContainerNodeBuilder.create().withNodeIdentifier(new NodeIdentifier(outputQname)) + final ContainerNode output = ImmutableContainerNodeBuilder.create().withNodeIdentifier(new NodeIdentifier(outputQname)) .withChild(ImmutableNodes.leafNode(streamNameQname, streamName)).build(); if (!Notificator.existListenerFor(streamName)) { - YangInstanceIdentifier normalizedPathIdentifier = controllerContext.toNormalized(pathIdentifier); + final YangInstanceIdentifier normalizedPathIdentifier = controllerContext.toNormalized(pathIdentifier); Notificator.createListener(normalizedPathIdentifier, streamName); } - DOMRpcResult defaultDOMRpcResult = new DefaultDOMRpcResult(output); + final DOMRpcResult defaultDOMRpcResult = new DefaultDOMRpcResult(output); return Futures.immediateCheckedFuture(defaultDOMRpcResult); } @@ -733,7 +731,7 @@ public class RestconfImpl implements RestconfService { if (rpc.getInput() != null) { // FIXME : find a correct Error from specification - throw new IllegalStateException("RPC " + rpc + " needs input value!"); + throw new IllegalStateException("RPC " + rpc + " does'n need input value!"); } final CheckedFuture response; @@ -872,15 +870,17 @@ public class RestconfImpl implements RestconfService { final InstanceIdentifierContext iiWithData = controllerContext.toInstanceIdentifier(identifier); final DOMMountPoint mountPoint = iiWithData.getMountPoint(); NormalizedNode data = null; - YangInstanceIdentifier normalizedII; + final YangInstanceIdentifier normalizedII = iiWithData.getInstanceIdentifier(); if (mountPoint != null) { - normalizedII = new DataNormalizer(mountPoint.getSchemaContext()).toNormalized(iiWithData - .getInstanceIdentifier()); data = broker.readConfigurationData(mountPoint, normalizedII); } else { - normalizedII = controllerContext.toNormalized(iiWithData.getInstanceIdentifier()); data = broker.readConfigurationData(normalizedII); } + if(data == null) { + throw new RestconfDocumentedException( + "Request could not be completed because the relevant data model content does not exist.", + ErrorType.APPLICATION, ErrorTag.DATA_MISSING); + } return new NormalizedNodeContext(iiWithData, data); } @@ -931,16 +931,17 @@ public class RestconfImpl implements RestconfService { final InstanceIdentifierContext iiWithData = controllerContext.toInstanceIdentifier(identifier); final DOMMountPoint mountPoint = iiWithData.getMountPoint(); NormalizedNode data = null; - YangInstanceIdentifier normalizedII; + final YangInstanceIdentifier normalizedII = iiWithData.getInstanceIdentifier(); if (mountPoint != null) { - normalizedII = new DataNormalizer(mountPoint.getSchemaContext()).toNormalized(iiWithData - .getInstanceIdentifier()); data = broker.readOperationalData(mountPoint, normalizedII); } else { - normalizedII = controllerContext.toNormalized(iiWithData.getInstanceIdentifier()); data = broker.readOperationalData(normalizedII); } - + if(data == null) { + throw new RestconfDocumentedException( + "Request could not be completed because the relevant data model content does not exist.", + ErrorType.APPLICATION, ErrorTag.DATA_MISSING); + } return new NormalizedNodeContext(iiWithData, data); } @@ -952,7 +953,8 @@ public class RestconfImpl implements RestconfService { @Override public Response updateConfigurationData(final String identifier, final NormalizedNodeContext payload) { Preconditions.checkNotNull(identifier); - final InstanceIdentifierContext iiWithData = controllerContext.toInstanceIdentifier(identifier); + final InstanceIdentifierContext iiWithData = + (InstanceIdentifierContext) payload.getInstanceIdentifierContext(); validateInput(iiWithData.getSchemaNode(), payload); validateTopLevelNodeName(payload, iiWithData.getInstanceIdentifier()); @@ -1062,7 +1064,7 @@ public class RestconfImpl implements RestconfService { * if key values or key count in payload and URI isn't equal * */ - private void validateListKeysEqualityInPayloadAndUri(final InstanceIdentifierContext iiWithData, + private void validateListKeysEqualityInPayloadAndUri(final InstanceIdentifierContext iiWithData, final NormalizedNode payload) { if (iiWithData.getSchemaNode() instanceof ListSchemaNode) { final List keyDefinitions = ((ListSchemaNode) iiWithData.getSchemaNode()).getKeyDefinition(); @@ -1158,43 +1160,7 @@ public class RestconfImpl implements RestconfService { @Override public Response createConfigurationData(final String identifier, final NormalizedNodeContext payload, final UriInfo uriInfo) { - if (payload == null) { - throw new RestconfDocumentedException("Input is required.", ErrorType.PROTOCOL, ErrorTag.MALFORMED_MESSAGE); - } - - final URI payloadNS = payload.getData().getNodeType().getNamespace(); - if (payloadNS == null) { - throw new RestconfDocumentedException( - "Data has bad format. Root element node must have namespace (XML format) or module name(JSON format)", - ErrorType.PROTOCOL, ErrorTag.UNKNOWN_NAMESPACE); - } - - final DOMMountPoint mountPoint = payload.getInstanceIdentifierContext().getMountPoint(); - - final InstanceIdentifierContext iiWithData = mountPoint != null - ? controllerContext.toMountPointIdentifier(identifier) - : controllerContext.toInstanceIdentifier(identifier); - final YangInstanceIdentifier normalizedII = iiWithData.getInstanceIdentifier(); - - try { - if (mountPoint != null) { - broker.commitConfigurationDataPost(mountPoint, normalizedII, payload.getData()); - } else { - broker.commitConfigurationDataPost(normalizedII, payload.getData()); - } - } catch(final RestconfDocumentedException e) { - throw e; - } catch (final Exception e) { - throw new RestconfDocumentedException("Error creating data", e); - } - - - final ResponseBuilder responseBuilder = Response.status(Status.NO_CONTENT); - final URI location = resolveLocation(uriInfo, "config", mountPoint, normalizedII); - if (location != null) { - responseBuilder.location(location); - } - return responseBuilder.build(); + return createConfigurationData(payload, uriInfo); } // FIXME create RestconfIdetifierHelper and move this method there @@ -1241,9 +1207,9 @@ public class RestconfImpl implements RestconfService { } final DOMMountPoint mountPoint = payload.getInstanceIdentifierContext().getMountPoint(); - final InstanceIdentifierContext iiWithData = payload.getInstanceIdentifierContext(); + final InstanceIdentifierContext iiWithData = (InstanceIdentifierContext) payload.getInstanceIdentifierContext(); final YangInstanceIdentifier normalizedII = iiWithData.getInstanceIdentifier(); - + final YangInstanceIdentifier resultII; try { if (mountPoint != null) { broker.commitConfigurationDataPost(mountPoint, normalizedII, payload.getData()); @@ -1258,6 +1224,7 @@ public class RestconfImpl implements RestconfService { } final ResponseBuilder responseBuilder = Response.status(Status.NO_CONTENT); + // FIXME: Provide path to result. final URI location = resolveLocation(uriInfo, "", mountPoint, normalizedII); if (location != null) { responseBuilder.location(location); @@ -1279,17 +1246,14 @@ public class RestconfImpl implements RestconfService { @Override public Response deleteConfigurationData(final String identifier) { - final InstanceIdentifierContext iiWithData = controllerContext.toInstanceIdentifier(identifier); + final InstanceIdentifierContext iiWithData = controllerContext.toInstanceIdentifier(identifier); final DOMMountPoint mountPoint = iiWithData.getMountPoint(); - YangInstanceIdentifier normalizedII; + final YangInstanceIdentifier normalizedII = iiWithData.getInstanceIdentifier(); try { if (mountPoint != null) { - normalizedII = new DataNormalizer(mountPoint.getSchemaContext()).toNormalized(iiWithData - .getInstanceIdentifier()); broker.commitConfigurationDataDelete(mountPoint, normalizedII); } else { - normalizedII = controllerContext.toNormalized(iiWithData.getInstanceIdentifier()); broker.commitConfigurationDataDelete(normalizedII).get(); } } catch (final Exception e) { @@ -1364,7 +1328,7 @@ public class RestconfImpl implements RestconfService { final String paramName) { final QNameModule salRemoteAugment = QNameModule.create(NAMESPACE_EVENT_SUBSCRIPTION_AUGMENT, EVENT_SUBSCRIPTION_AUGMENT_REVISION); - Optional> enumNode = value.getChild(new NodeIdentifier( + final Optional> enumNode = value.getChild(new NodeIdentifier( QName.create(salRemoteAugment, paramName))); if (!enumNode.isPresent()) { return null;