X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fnetconf%2Fconfig-persister-impl%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fnetconf%2Fpersist%2Fimpl%2FCapabilityStrippingConfigSnapshotHolderTest.java;h=b22924a722878ca455ee1631793cb4aa9466cbe7;hp=d91712f3475fe2dde61692368a85e813b67c048c;hb=8d9cdd0223be6d550d6f44dcb42fe7366bce3cf9;hpb=49bfc449558d0306f0b6550bc5bdf41e5cafca44 diff --git a/opendaylight/netconf/config-persister-impl/src/test/java/org/opendaylight/controller/netconf/persist/impl/CapabilityStrippingConfigSnapshotHolderTest.java b/opendaylight/netconf/config-persister-impl/src/test/java/org/opendaylight/controller/netconf/persist/impl/CapabilityStrippingConfigSnapshotHolderTest.java index d91712f347..b22924a722 100644 --- a/opendaylight/netconf/config-persister-impl/src/test/java/org/opendaylight/controller/netconf/persist/impl/CapabilityStrippingConfigSnapshotHolderTest.java +++ b/opendaylight/netconf/config-persister-impl/src/test/java/org/opendaylight/controller/netconf/persist/impl/CapabilityStrippingConfigSnapshotHolderTest.java @@ -7,47 +7,32 @@ */ package org.opendaylight.controller.netconf.persist.impl; +import static org.junit.Assert.assertEquals; + import com.google.common.collect.Sets; +import java.io.IOException; +import java.util.HashSet; +import java.util.Set; import org.apache.commons.io.IOUtils; import org.junit.Test; -import org.opendaylight.controller.netconf.persist.impl.osgi.ConfigPersisterActivator; import org.opendaylight.controller.netconf.util.xml.XmlUtil; import org.w3c.dom.Element; -import java.io.IOException; -import java.util.Collections; -import java.util.HashSet; -import java.util.Set; -import java.util.regex.Pattern; - -import static org.junit.Assert.assertEquals; - public class CapabilityStrippingConfigSnapshotHolderTest { @Test - public void testCapabilityStripping() throws Exception { + public void testCapabilityStripping() throws Exception { Set allCapabilities = readLines("/capabilities-all.txt"); Set expectedCapabilities = readLines("/capabilities-stripped.txt"); String snapshotAsString = readToString("/snapshot.xml"); Element element = XmlUtil.readXmlToElement(snapshotAsString); - { - CapabilityStrippingConfigSnapshotHolder tested = new CapabilityStrippingConfigSnapshotHolder( - element, allCapabilities, Pattern.compile( - ConfigPersisterActivator.DEFAULT_IGNORED_REGEX - )); - assertEquals(expectedCapabilities, tested.getCapabilities()); - assertEquals(Collections.emptySet(), tested.getMissingNamespaces()); - } - { - // test regex - CapabilityStrippingConfigSnapshotHolder tested = new CapabilityStrippingConfigSnapshotHolder( - element, allCapabilities, Pattern.compile( - "^bar" - )); - assertEquals(expectedCapabilities, tested.getCapabilities()); - assertEquals(Sets.newHashSet(ConfigPersisterActivator.DEFAULT_IGNORED_REGEX.substring(1)), - tested.getMissingNamespaces()); - } + CapabilityStrippingConfigSnapshotHolder tested = new CapabilityStrippingConfigSnapshotHolder( + element, allCapabilities); + assertEquals(expectedCapabilities, tested.getCapabilities()); + + Set obsoleteCapabilities = Sets.difference(allCapabilities, expectedCapabilities); + + assertEquals(obsoleteCapabilities, tested.getObsoleteCapabilities()); } private Set readLines(String fileName) throws IOException {