X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fnetconf%2Fnetconf-it%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fnetconf%2Fit%2Fpax%2FIdentityRefNetconfTest.java;h=981f1148e48520f300e6af00810054380285f31c;hp=c54285bc908c817157287022d5dcc92011b0d145;hb=89d7fe2df7cef882f71e1fcdb46d2a44811f0ad3;hpb=56d545c4a73d0d87c0d25ba20cfa4b398c87c511 diff --git a/opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/pax/IdentityRefNetconfTest.java b/opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/pax/IdentityRefNetconfTest.java index c54285bc90..981f1148e4 100644 --- a/opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/pax/IdentityRefNetconfTest.java +++ b/opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/pax/IdentityRefNetconfTest.java @@ -19,8 +19,9 @@ import static org.ops4j.pax.exam.CoreOptions.options; import static org.ops4j.pax.exam.CoreOptions.streamBundle; import static org.ops4j.pax.exam.CoreOptions.systemPackages; import static org.ops4j.pax.exam.CoreOptions.systemProperty; -import io.netty.channel.nio.NioEventLoopGroup; +import io.netty.util.HashedWheelTimer; +import io.netty.util.Timer; import java.io.IOException; import java.net.InetSocketAddress; import java.util.concurrent.ExecutionException; @@ -34,11 +35,15 @@ import org.junit.Test; import org.junit.matchers.JUnitMatchers; import org.junit.runner.RunWith; import org.opendaylight.controller.netconf.api.NetconfMessage; -import org.opendaylight.controller.netconf.client.NetconfClientDispatcher; +import org.opendaylight.controller.netconf.client.NetconfClientDispatcherImpl; +import org.opendaylight.controller.netconf.client.SimpleNetconfClientSessionListener; +import org.opendaylight.controller.netconf.client.conf.NetconfClientConfiguration; +import org.opendaylight.controller.netconf.client.conf.NetconfClientConfigurationBuilder; import org.opendaylight.controller.netconf.client.test.TestingNetconfClient; import org.opendaylight.controller.netconf.util.test.XmlFileLoader; import org.opendaylight.controller.netconf.util.xml.XmlUtil; import org.opendaylight.controller.sal.binding.api.BindingAwareBroker; +import org.opendaylight.protocol.framework.NeverReconnectStrategy; import org.ops4j.pax.exam.Configuration; import org.ops4j.pax.exam.Option; import org.ops4j.pax.exam.junit.PaxExam; @@ -51,6 +56,9 @@ import org.xml.sax.SAXException; import com.google.common.base.Preconditions; import com.google.common.base.Throwables; +import io.netty.channel.nio.NioEventLoopGroup; +import io.netty.util.concurrent.GlobalEventExecutor; + @Ignore @RunWith(PaxExam.class) public class IdentityRefNetconfTest { @@ -104,8 +112,8 @@ public class IdentityRefNetconfTest { mavenBundle("org.slf4j", "log4j-over-slf4j").versionAsInProject(), mavenBundle("ch.qos.logback", "logback-core").versionAsInProject(), mavenBundle("ch.qos.logback", "logback-classic").versionAsInProject(), - mavenBundle("org.opendaylight.controller.thirdparty", "nagasena").versionAsInProject(), - mavenBundle("org.opendaylight.controller.thirdparty", "nagasena-rta").versionAsInProject()); + mavenBundle("org.openexi", "nagasena").versionAsInProject(), + mavenBundle("org.openexi", "nagasena-rta").versionAsInProject()); } @@ -121,15 +129,15 @@ public class IdentityRefNetconfTest { public void testIdRef() throws Exception { Preconditions.checkNotNull(broker, "Controller not initialized"); - NioEventLoopGroup nettyThreadgroup = new NioEventLoopGroup(); - NetconfClientDispatcher clientDispatcher = new NetconfClientDispatcher(nettyThreadgroup, nettyThreadgroup, - CLIENT_CONNECTION_TIMEOUT_MILLIS); NetconfMessage edit = xmlFileToNetconfMessage("netconfMessages/editConfig_identities.xml"); NetconfMessage commit = xmlFileToNetconfMessage("netconfMessages/commit.xml"); NetconfMessage getConfig = xmlFileToNetconfMessage("netconfMessages/getConfig.xml"); - try (TestingNetconfClient netconfClient = new TestingNetconfClient("client", tcpAddress, CLIENT_CONNECTION_TIMEOUT_MILLIS, clientDispatcher)) { + NioEventLoopGroup nettyThreadgroup = new NioEventLoopGroup(); + Timer timer = new HashedWheelTimer(); + NetconfClientDispatcherImpl clientDispatcher = new NetconfClientDispatcherImpl(nettyThreadgroup, nettyThreadgroup, timer); + try (TestingNetconfClient netconfClient = new TestingNetconfClient("client", clientDispatcher, getClientConfiguration(tcpAddress))) { sendMessage(edit, netconfClient); sendMessage(commit, netconfClient); sendMessage(getConfig, netconfClient, "id-test", @@ -141,6 +149,9 @@ public class IdentityRefNetconfTest { clientDispatcher.close(); } catch (Exception e) { fail(Throwables.getStackTraceAsString(e)); + } finally { + nettyThreadgroup.shutdownGracefully().get(); + timer.stop(); } } @@ -160,4 +171,14 @@ public class IdentityRefNetconfTest { ParserConfigurationException { return XmlFileLoader.xmlFileToNetconfMessage(fileName); } + + public NetconfClientConfiguration getClientConfiguration(final InetSocketAddress tcpAddress) { + final NetconfClientConfigurationBuilder b = NetconfClientConfigurationBuilder.create(); + b.withAddress(tcpAddress); + b.withSessionListener(new SimpleNetconfClientSessionListener()); + b.withReconnectStrategy(new NeverReconnectStrategy(GlobalEventExecutor.INSTANCE, + CLIENT_CONNECTION_TIMEOUT_MILLIS)); + b.withConnectionTimeoutMillis(CLIENT_CONNECTION_TIMEOUT_MILLIS); + return b.build(); + } }