X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fnetconf%2Fnetconf-monitoring%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fnetconf%2Fmonitoring%2FGet.java;h=fa78fa4bd3983c7eee4cb166e54bc5692f0bad54;hp=0b923f6c5ab9dcce928039ad60070580da6632c7;hb=ebd9aba9e844229de613a2b60b5d21119fcee968;hpb=ac65af650d550ae56dd02b660e1c5eef24b78740 diff --git a/opendaylight/netconf/netconf-monitoring/src/main/java/org/opendaylight/controller/netconf/monitoring/Get.java b/opendaylight/netconf/netconf-monitoring/src/main/java/org/opendaylight/controller/netconf/monitoring/Get.java index 0b923f6c5a..fa78fa4bd3 100644 --- a/opendaylight/netconf/netconf-monitoring/src/main/java/org/opendaylight/controller/netconf/monitoring/Get.java +++ b/opendaylight/netconf/netconf-monitoring/src/main/java/org/opendaylight/controller/netconf/monitoring/Get.java @@ -8,16 +8,16 @@ package org.opendaylight.controller.netconf.monitoring; import com.google.common.collect.Maps; + import org.opendaylight.controller.netconf.api.NetconfDocumentedException; -import org.opendaylight.controller.netconf.api.NetconfOperationRouter; import org.opendaylight.controller.netconf.api.monitoring.NetconfMonitoringService; -import org.opendaylight.controller.netconf.mapping.api.NetconfOperationFilter; -import org.opendaylight.controller.netconf.mapping.api.NetconfOperationFilterChain; +import org.opendaylight.controller.netconf.api.xml.XmlNetconfConstants; +import org.opendaylight.controller.netconf.mapping.api.HandlingPriority; +import org.opendaylight.controller.netconf.mapping.api.NetconfOperationChainedExecution; import org.opendaylight.controller.netconf.monitoring.xml.JaxBSerializer; import org.opendaylight.controller.netconf.monitoring.xml.model.NetconfState; import org.opendaylight.controller.netconf.util.mapping.AbstractNetconfOperation; import org.opendaylight.controller.netconf.util.xml.XmlElement; -import org.opendaylight.controller.netconf.util.xml.XmlNetconfConstants; import org.opendaylight.controller.netconf.util.xml.XmlUtil; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -26,30 +26,52 @@ import org.w3c.dom.Element; import java.util.Map; -public class Get implements NetconfOperationFilter { +public class Get extends AbstractNetconfOperation { private static final Logger logger = LoggerFactory.getLogger(Get.class); private final NetconfMonitoringService netconfMonitor; public Get(NetconfMonitoringService netconfMonitor) { + super(MonitoringConstants.MODULE_NAME); this.netconfMonitor = netconfMonitor; } - @Override - public Document doFilter(Document message, NetconfOperationRouter operationRouter, - NetconfOperationFilterChain filterChain) throws NetconfDocumentedException { - AbstractNetconfOperation.OperationNameAndNamespace operationNameAndNamespace = new AbstractNetconfOperation.OperationNameAndNamespace( - message); - if (canHandle(operationNameAndNamespace)) { - return handle(message, operationRouter, filterChain); + private Element getPlaceholder(Document innerResult) throws NetconfDocumentedException { + try { + XmlElement rootElement = null; + rootElement = XmlElement.fromDomElementWithExpected(innerResult.getDocumentElement(), + XmlNetconfConstants.RPC_REPLY_KEY, XmlNetconfConstants.RFC4741_TARGET_NAMESPACE); + return rootElement.getOnlyChildElement(XmlNetconfConstants.DATA_KEY).getDomElement(); + } catch (RuntimeException e) { + throw new IllegalArgumentException(String.format( + "Input xml in wrong format, Expecting root element %s with child element %s, but was %s", + XmlNetconfConstants.RPC_REPLY_KEY, XmlNetconfConstants.DATA_KEY, + XmlUtil.toString(innerResult.getDocumentElement())), e); } - return filterChain.execute(message, operationRouter); } - private Document handle(Document message, NetconfOperationRouter operationRouter, - NetconfOperationFilterChain filterChain) throws NetconfDocumentedException { + @Override + protected String getOperationName() { + return XmlNetconfConstants.GET; + } + + @Override + protected HandlingPriority getHandlingPriority() { + return HandlingPriority.HANDLE_WITH_DEFAULT_PRIORITY.increasePriority(1); + } + + @Override + public Document handle(Document requestMessage, NetconfOperationChainedExecution subsequentOperation) + throws NetconfDocumentedException { + if (subsequentOperation.isExecutionTermination()){ + throw new NetconfDocumentedException(String.format("Subsequent netconf operation expected by %s", this), + NetconfDocumentedException.ErrorType.application, + NetconfDocumentedException.ErrorTag.operation_failed, + NetconfDocumentedException.ErrorSeverity.error); + } + try { - Document innerResult = filterChain.execute(message, operationRouter); + Document innerResult = subsequentOperation.execute(requestMessage); NetconfState netconfMonitoring = new NetconfState(netconfMonitor); Element monitoringXmlElement = new JaxBSerializer().toXml(netconfMonitoring); @@ -70,35 +92,9 @@ public class Get implements NetconfOperationFilter { } } - private Element getPlaceholder(Document innerResult) { - try { - XmlElement rootElement = XmlElement.fromDomElementWithExpected(innerResult.getDocumentElement(), - XmlNetconfConstants.RPC_REPLY_KEY, XmlNetconfConstants.RFC4741_TARGET_NAMESPACE); - return rootElement.getOnlyChildElement(XmlNetconfConstants.DATA_KEY).getDomElement(); - } catch (RuntimeException e) { - throw new IllegalArgumentException(String.format( - "Input xml in wrong format, Expecting root element %s with child element %s, but was %s", - XmlNetconfConstants.RPC_REPLY_KEY, XmlNetconfConstants.DATA_KEY, - XmlUtil.toString(innerResult.getDocumentElement())), e); - } - } - - private boolean canHandle(AbstractNetconfOperation.OperationNameAndNamespace operationNameAndNamespace) { - if (operationNameAndNamespace.getOperationName().equals(XmlNetconfConstants.GET) == false) - return false; - return operationNameAndNamespace.getNamespace().equals( - XmlNetconfConstants.URN_IETF_PARAMS_XML_NS_NETCONF_BASE_1_0); - } - @Override - public int getSortingOrder() { - // FIXME filters for different operations cannot have same order - return 1; + protected Element handle(Document document, XmlElement message, NetconfOperationChainedExecution subsequentOperation) + throws NetconfDocumentedException { + throw new UnsupportedOperationException("Never gets called"); } - - @Override - public int compareTo(NetconfOperationFilter o) { - return Integer.compare(getSortingOrder(), o.getSortingOrder()); - } - }