Code Review / controller.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: f1e4796) | patch
Make RequestVote immutable and change AbstractRPC#term to private 08/33008/3
authorTom Pantelis <tpanteli@brocade.com>
Mon, 18 Jan 2016 10:16:40 +0000 (05:16 -0500)
committerGerrit Code Review <gerrit@opendaylight.org>
Wed, 20 Jan 2016 21:37:38 +0000 (21:37 +0000)
commit1554d7b1c046ec16505f291c0fd7bfd162935f8f
tree25e81309734fc8e3c2fbeaccd886adbd7663edf6tree | snapshot
parentf1e4796a07ad925697db5e3b672e2b46980cd408commit | diff
Make RequestVote immutable and change AbstractRPC#term to private

RequestVote has setters which aren't used. This class should be
immutable with final fields.

RequestVote also overrides getTerm from AbstractRPC as do a couple other
classes. This is unnecessary. Also AbstractRPC#term was changed from
protected to private.

Change-Id: Ie8891b49a37c9580abe7e52e288861c37de26fcd
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AbstractRaftRPC.java diff | blob | history
opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntriesReply.java diff | blob | history
opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshot.java diff | blob | history
opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java diff | blob | history
opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestVote.java diff | blob | history
opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestVoteReply.java diff | blob | history
OpenDaylight controller