Clean up to remove controller/opendaylight/commons/checkstyle 89/45589/3
authorMichael Vorburger <vorburger@redhat.com>
Wed, 14 Sep 2016 15:20:20 +0000 (17:20 +0200)
committerTom Pantelis <tpanteli@brocade.com>
Tue, 4 Oct 2016 11:11:06 +0000 (11:11 +0000)
commitc046d016935736db9d80647ca6cfb86a34a4cd06
treea5ec3eff80b651fa20367159c2e23993d0505f33
parent65482327ec4e76ebce71b572ad69a648fe3ef014
Clean up to remove controller/opendaylight/commons/checkstyle

Main reason for finally doing this longer overdue clean-up now is that
it appears that the odlparent Checkstyle rules are not effective (in-IDE
and likely also on CLI, not tested) for controller projects such as
md-sal/binding-broker (where a number of violations should have shown
but didn't); and I suspect this may because of a precedence conflict
with these (old) Checkstyle rules, which now are not needed anymore.

Unless I'm missing something, normally (hopefully) this should have no
remaining impact anywhere outside of controller; I have done a
(relatively quick) grep for all 3 of "commons.checkstyle.version" &
"<artifactId>checkstyle" & "checkstyle-logging.xml" (all of which this
removes) in all of autorelease, and have found a few references in 3 old
projects (lacp, alto, netconf; note that netide, ttp used to have
dependencies to controller's checkstyle, but those project have
meanwhile cleaned that up themselves), which the linked changes
will have removed, so... should now be OK.

Change-Id: If6484abd36b01c49c5da5bf277809fb053da0001
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
opendaylight/commons/checkstyle/pom.xml [deleted file]
opendaylight/commons/checkstyle/src/main/resources/controller/checkstyle.xml [deleted file]
opendaylight/commons/opendaylight/pom.xml
pom.xml

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.