Make constants really constant 61/22761/2
authorRobert Varga <rovarga@cisco.com>
Tue, 16 Jun 2015 19:23:21 +0000 (21:23 +0200)
committerGerrit Code Review <gerrit@opendaylight.org>
Wed, 1 Jul 2015 14:39:49 +0000 (14:39 +0000)
commitd4fee4eb690d46f879d05765a41825ac7018fe49
treef156c6518378ad595247bad7f73eb5aeba6e93f5
parent308b41963b2964a4e1faa882bce26bee2d86b810
Make constants really constant

This triggers a major sonar warning, and is insecure as these fields could
get modified by anyone, throwing the system out of whack.

Also optimize comparison and make sure the netconf QNameModule is cached.
Also prevent unneeded QName instantiation.
Also use an immutable list to hold arguments, preventing a copy in
builders.

Change-Id: I74647c444ec273066fc4727618b35c92386ba77c
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit fc48504605170d4d37346738602de388daa36f25)
opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/util/NetconfMessageTransformUtil.java

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.