Make constants really constant 24/22724/5
authorRobert Varga <rovarga@cisco.com>
Tue, 16 Jun 2015 19:23:21 +0000 (21:23 +0200)
committerGerrit Code Review <gerrit@opendaylight.org>
Wed, 17 Jun 2015 07:57:34 +0000 (07:57 +0000)
commitfc48504605170d4d37346738602de388daa36f25
tree7d518dec628ea0ed7ee6f6092fc6c505dc5be16c
parent84d24ef9f9ae83db5e96c979d986e7afea9c2bef
Make constants really constant

This triggers a major sonar warning, and is insecure as these fields could
get modified by anyone, throwing the system out of whack.

Also optimize comparison and make sure the netconf QNameModule is cached.
Also prevent unneeded QName instantiation.
Also use an immutable list to hold arguments, preventing a copy in
builders.

Change-Id: I74647c444ec273066fc4727618b35c92386ba77c
Signed-off-by: Robert Varga <rovarga@cisco.com>
opendaylight/md-sal/sal-netconf-connector/src/main/java/org/opendaylight/controller/sal/connect/netconf/util/NetconfMessageTransformUtil.java

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.