Code Review / controller.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 94b968f) | patch
Do not catch Throwables, but rather Exceptions 39/5339/6
authorRobert Varga <rovarga@cisco.com>
Fri, 14 Feb 2014 23:08:05 +0000 (00:08 +0100)
committerRobert Varga <rovarga@cisco.com>
Wed, 19 Mar 2014 13:06:00 +0000 (13:06 +0000)
commitbfa2b4e3f1a93b97a7f4575116e67a2d20b53c75
treed8b502f11cd6beac482aa8cf51c1aca293491cbetree | snapshot
parent94b968f7454a2d677b1ac8fc4a81c10ecca03fa3commit | diff
Do not catch Throwables, but rather Exceptions

This turns catch Throwable into catch Exception, as doing the former
catches Errors, which are documented to be pretty much irrecoverable
conditions. Looking at
http://docs.oracle.com/javase/7/docs/api/java/lang/Error.html non of
these call sites can recover from an Error happening, so they should
never catch them.

Change-Id: I85237594f307a5a8778fb5a63f9dad4d120fc9d7
Signed-off-by: Robert Varga <rovarga@cisco.com>
opendaylight/netconf/netconf-ssh/src/main/java/org/opendaylight/controller/netconf/ssh/threads/SocketThread.java diff | blob | history
opendaylight/northbound/networkconfiguration/bridgedomain/src/main/java/org/opendaylight/controller/networkconfig/bridgedomain/northbound/BridgeDomainNorthbound.java diff | blob | history
OpenDaylight controller