Improve aborted transaction logging 15/80415/2
authorRobert Varga <robert.varga@pantheon.tech>
Wed, 20 Feb 2019 13:47:12 +0000 (14:47 +0100)
committerTom Pantelis <tompantelis@gmail.com>
Wed, 20 Feb 2019 16:55:15 +0000 (16:55 +0000)
commit21eed79684671b9a44e34edbd589419cb9bb6087
treeca0c117a36151c64e741106a57024bad511121c3
parent7ad6a27e9b98861d9286977320198375a44a38f1
Improve aborted transaction logging

The fact that a snapshot is recorded does not mean it has not been
closed -- in fact write-aspect transactions do not actively remove
themselves.

When we prune recorded snapshots on transaction chain close, we need
to pay attention to the return value of abort(), as that is
indicating whether we should in fact warn about an unclosed
transaction.

This means that the actual set of transactions we warn about cannot
be determined until we have traversed all recorded snapshots, hence
modify the logic to record the identifiers that were in fact aborted
and report all of them in a single message along with a stack trace
so the offender may be identifier.

Change-Id: I8b176f1990c9aa9c056cd03203ea50fb9b9549a0
JIRA: CONTROLLER-1886
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/ClientBackedTransactionChain.java

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.