Fix checkstyle warnings in logback-config-loader. 97/12997/6
authorMarian Dubai <mdubai@cisco.com>
Thu, 20 Nov 2014 10:05:06 +0000 (11:05 +0100)
committerMarian Dubai <mdubai@cisco.com>
Wed, 26 Nov 2014 09:07:40 +0000 (09:07 +0000)
Change-Id: If926826e233000f771518d966493ee8b100a76e4
Signed-off-by: Marian Dubai <mdubai@cisco.com>
opendaylight/config/logback-config-loader/src/main/java/org/opendaylight/controller/logback/config/loader/Activator.java
opendaylight/config/logback-config-loader/src/main/java/org/opendaylight/controller/logback/config/loader/impl/LogbackConfigUtil.java
opendaylight/config/logback-config-loader/src/main/java/org/opendaylight/controller/logback/config/loader/impl/LogbackConfigurationLoader.java
opendaylight/config/logback-config-loader/src/test/java/org/opendaylight/controller/logback/config/loader/test/LogbackConfigurationLoaderTest.java
opendaylight/config/logback-config-loader/src/test/java/org/opendaylight/controller/logback/config/loader/test/TestAppender.java
opendaylight/config/logback-config-loader/src/test/java/org/opendaylight/controller/logback/config/loader/test/logwork/Debugger.java
opendaylight/config/logback-config-loader/src/test/java/org/opendaylight/controller/logback/config/loader/test/logwork/Errorer.java
opendaylight/config/logback-config-loader/src/test/java/org/opendaylight/controller/logback/config/loader/test/logwork/Informer.java
opendaylight/config/logback-config-loader/src/test/java/org/opendaylight/controller/logback/config/loader/test/logwork/Tracer.java
opendaylight/config/logback-config-loader/src/test/java/org/opendaylight/controller/logback/config/loader/test/logwork/Warner.java

index 99866d576727eb7149290aa5e74cc01071a00d9b..fa670098581e9108088ed7b81ca3b9e156a88b67 100644 (file)
@@ -9,7 +9,6 @@ package org.opendaylight.controller.logback.config.loader;
 
 import java.io.File;
 import java.util.List;
-
 import org.opendaylight.controller.logback.config.loader.impl.LogbackConfigUtil;
 import org.opendaylight.controller.logback.config.loader.impl.LogbackConfigurationLoader;
 import org.osgi.framework.BundleActivator;
@@ -27,7 +26,7 @@ public class Activator implements BundleActivator {
      * logback configurations
      */
     private static final String LOGBACK_CONFIG_D = "logback.config.d";
-    private static Logger LOG = LoggerFactory.getLogger(Activator.class);
+    private static final Logger LOG = LoggerFactory.getLogger(Activator.class);
 
     @Override
     public void start(BundleContext context) {
index 2aa6b1a3484e4d8c53fb1132378403b54b2ea92b..accb6e1d038d21fb30c93b9a52b40adf78885549 100644 (file)
@@ -7,18 +7,16 @@
  */
 package org.opendaylight.controller.logback.config.loader.impl;
 
+import ch.qos.logback.classic.LoggerContext;
+import ch.qos.logback.classic.joran.JoranConfigurator;
+import ch.qos.logback.core.joran.spi.JoranException;
+import ch.qos.logback.core.util.StatusPrinter;
 import java.io.File;
 import java.net.URL;
-
 import org.slf4j.ILoggerFactory;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import ch.qos.logback.classic.LoggerContext;
-import ch.qos.logback.classic.joran.JoranConfigurator;
-import ch.qos.logback.core.joran.spi.JoranException;
-import ch.qos.logback.core.util.StatusPrinter;
-
 /**
  * Logback configuration loader.
  * Strategy:
index adbb9f4cd63db212df666a68101f61459f76733f..44a84b7a9ed7a19577abe271cb14869a1994fd06 100644 (file)
@@ -10,7 +10,6 @@ package org.opendaylight.controller.logback.config.loader.test;
 import java.io.File;
 import java.util.ArrayList;
 import java.util.List;
-
 import org.junit.Assert;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -33,7 +32,7 @@ public class LogbackConfigurationLoaderTest {
 
     /** logback config root */
     private static final String LOGBACK_D = "/logback.d";
-    private static Logger LOG = LoggerFactory
+    private static final Logger LOG = LoggerFactory
             .getLogger(LogbackConfigurationLoaderTest.class);
 
     /**
index b273d2777ceb79312ce3c76044ffd409cda867d5..a950c818fe992eebffa9380c27db1d6a0725382c 100644 (file)
@@ -7,9 +7,6 @@
  */
 package org.opendaylight.controller.logback.config.loader.test;
 
-import java.util.ArrayList;
-import java.util.List;
-
 import ch.qos.logback.classic.spi.LoggingEvent;
 import ch.qos.logback.core.Appender;
 import ch.qos.logback.core.Context;
@@ -17,6 +14,8 @@ import ch.qos.logback.core.LogbackException;
 import ch.qos.logback.core.filter.Filter;
 import ch.qos.logback.core.spi.FilterReply;
 import ch.qos.logback.core.status.Status;
+import java.util.ArrayList;
+import java.util.List;
 
 /**
  * dummy appender for collecting log messages
index a8052f71c94828c5cda097848bb9b33d7973f566..ec10ae9fa699602839566045d507a966c8a56b72 100644 (file)
@@ -15,7 +15,7 @@ import org.slf4j.LoggerFactory;
  */
 public class Debugger {
 
-    private static Logger LOG = LoggerFactory.getLogger(Debugger.class);
+    private static final Logger LOG = LoggerFactory.getLogger(Debugger.class);
 
     /**
      * all logging
index 0bcd830ad10a83283e2245b6b6b8065d6b91e715..e33b7f9d15097bc91876900ef74c4bb9cbff097c 100644 (file)
@@ -15,7 +15,7 @@ import org.slf4j.LoggerFactory;
  */
 public class Errorer {
 
-    private static Logger LOG = LoggerFactory.getLogger(Errorer.class);
+    private static final Logger LOG = LoggerFactory.getLogger(Errorer.class);
 
     /**
      * all logging
index 44f09315cff09f4696d8e7e2e3164cb8170a90f6..06c518349c9ba4cfb90a5b5970da2710066144f9 100644 (file)
@@ -15,7 +15,7 @@ import org.slf4j.LoggerFactory;
  */
 public class Informer {
 
-    private static Logger LOG = LoggerFactory.getLogger(Informer.class);
+    private static final Logger LOG = LoggerFactory.getLogger(Informer.class);
 
     /**
      * all logging
index 70df607d8dbca275ec24fe94d84f3e2b0a7b0924..c842c1a26037e3b53d50ea39b6e71823a73c38e4 100644 (file)
@@ -15,7 +15,7 @@ import org.slf4j.LoggerFactory;
  */
 public class Tracer {
 
-    private static Logger LOG = LoggerFactory.getLogger(Tracer.class);
+    private static final Logger LOG = LoggerFactory.getLogger(Tracer.class);
 
     /**
      * all logging
index 8093180a8b94a321ca8156d09885a971fde37947..aae0c34512ea084939f7480b3a9e1997d8d15b21 100644 (file)
@@ -15,7 +15,7 @@ import org.slf4j.LoggerFactory;
  */
 public class Warner {
 
-    private static Logger LOG = LoggerFactory.getLogger(Warner.class);
+    private static final Logger LOG = LoggerFactory.getLogger(Warner.class);
 
     /**
      * all logging