The null check is wrong here, as instanceof will evaluate to a boolean,
which will always result in a non-null reference. Fix this by using
checkArgument().
Change-Id: I9c5c1795227cafafc4393ea86aa464287cd96df2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
package org.opendaylight.controller.cluster.datastore.messages;
package org.opendaylight.controller.cluster.datastore.messages;
-import com.google.common.base.Preconditions;
+import static com.google.common.base.Preconditions.checkArgument;
+import static java.util.Objects.requireNonNull;
+
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
public CreateTransactionReply(final String transactionPath, final TransactionIdentifier transactionId,
final short version) {
super(version);
public CreateTransactionReply(final String transactionPath, final TransactionIdentifier transactionId,
final short version) {
super(version);
- this.transactionPath = Preconditions.checkNotNull(transactionPath);
- this.transactionId = Preconditions.checkNotNull(transactionId);
+ this.transactionPath = requireNonNull(transactionPath);
+ this.transactionId = requireNonNull(transactionId);
}
public String getTransactionPath() {
}
public String getTransactionPath() {
}
public static CreateTransactionReply fromSerializable(Object serializable) {
}
public static CreateTransactionReply fromSerializable(Object serializable) {
- Preconditions.checkNotNull(serializable instanceof CreateTransactionReply);
+ checkArgument(serializable instanceof CreateTransactionReply);
return (CreateTransactionReply)serializable;
}
return (CreateTransactionReply)serializable;
}