Remove redundant class members, turn others to local variables. (sonar)

Change-Id: I90c1c9cea67bd62900876ee373c86a33eb80765d
Signed-off-by: Alissa Bonas <abonas@redhat.com>

diff --git a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/utils/ReadFromFile.java b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/utils/ReadFromFile.java
index 1d31eaa65b44e605d42b09711b6ef4f93bc4f5ff..a9c9e3ec91bf0b3972ac0a4174dfeb98c4134976 100644 (file)
--- a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/utils/ReadFromFile.java
+++ b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/utils/ReadFromFile.java
@@ -20,20 +20,16 @@ import java.io.*;
  */
 public class ReadFromFile {
     private FileInputStream fileStream;
  */
 public class ReadFromFile {
     private FileInputStream fileStream;

-    private DataInputStream dataInput;
-    private BufferedReader bufferedReader;
-    private String fileName;

     private File filePointer;
 
     private File filePointer;
 

-    public ReadFromFile(String name) throws FileNotFoundException {
-        fileName = name;
-        fileStream = new FileInputStream(this.fileName);
+    public ReadFromFile(String fileName) throws FileNotFoundException {
+        fileStream = new FileInputStream(fileName);

         filePointer = new File(fileName); //needed to allow file deletion
     }
 
     public ArrayList<String> readFile() throws IOException {
         filePointer = new File(fileName); //needed to allow file deletion
     }
 
     public ArrayList<String> readFile() throws IOException {

-        dataInput = new DataInputStream(this.fileStream);
-        bufferedReader = new BufferedReader(new InputStreamReader(dataInput));
+        DataInputStream dataInput = new DataInputStream(this.fileStream);
+        BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(dataInput));

 
         ArrayList<String> lineList = new ArrayList<String>();
         String line;
 
         ArrayList<String> lineList = new ArrayList<String>();
         String line;

diff --git a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/utils/WriteToFile.java b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/utils/WriteToFile.java
index b4624323ae88a38539614dab6d16733fa3b78a83..2717c942287ff42932159d95c2b0957a9c4dfb67 100644 (file)
--- a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/utils/WriteToFile.java
+++ b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/utils/WriteToFile.java
@@ -26,10 +26,8 @@ public class WriteToFile {
     .getLogger(WriteToFile.class);
     private FileWriter fstream;
     private BufferedWriter bufferOut;
     .getLogger(WriteToFile.class);
     private FileWriter fstream;
     private BufferedWriter bufferOut;

-    private String fileName;

 
 

-    public WriteToFile(String name) throws IOException {
-        fileName = name;
+    public WriteToFile(String fileName) throws IOException {

         fstream = new FileWriter(fileName);
         bufferOut = new BufferedWriter(fstream);
     }
         fstream = new FileWriter(fileName);
         bufferOut = new BufferedWriter(fstream);
     }