BUG-614: degrade NotifyTask to Runnable 64/7564/2
authorRobert Varga <rovarga@cisco.com>
Sun, 1 Jun 2014 09:00:48 +0000 (11:00 +0200)
committerRobert Varga <rovarga@cisco.com>
Sun, 1 Jun 2014 17:38:35 +0000 (19:38 +0200)
The call() method always returned null anyway, so we might as well make it
Runnable.

Change-Id: I6be36490aba33ba1bf4b205ba4d9b0aa8160dbdf
Signed-off-by: Robert Varga <rovarga@cisco.com>
opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/NotifyTask.java

index b0dd2a9..5f0de6b 100644 (file)
@@ -7,8 +7,6 @@
  */
 package org.opendaylight.controller.sal.binding.impl;
 
  */
 package org.opendaylight.controller.sal.binding.impl;
 
-import java.util.concurrent.Callable;
-
 import org.opendaylight.controller.sal.binding.api.NotificationListener;
 import org.opendaylight.yangtools.yang.binding.Notification;
 import org.slf4j.Logger;
 import org.opendaylight.controller.sal.binding.api.NotificationListener;
 import org.opendaylight.yangtools.yang.binding.Notification;
 import org.slf4j.Logger;
@@ -17,7 +15,7 @@ import org.slf4j.LoggerFactory;
 import com.google.common.base.Objects;
 import com.google.common.base.Preconditions;
 
 import com.google.common.base.Objects;
 import com.google.common.base.Preconditions;
 
-class NotifyTask implements Callable<Object> {
+class NotifyTask implements Runnable {
     private static final Logger LOG = LoggerFactory.getLogger(NotifyTask.class);
 
     private final NotificationListener<?> listener;
     private static final Logger LOG = LoggerFactory.getLogger(NotifyTask.class);
 
     private final NotificationListener<?> listener;
@@ -34,7 +32,7 @@ class NotifyTask implements Callable<Object> {
     }
 
     @Override
     }
 
     @Override
-    public Object call() {
+    public void run() {
         if (LOG.isDebugEnabled()) {
             LOG.debug("Delivering notification {} to {}", notification, listener);
         } else {
         if (LOG.isDebugEnabled()) {
             LOG.debug("Delivering notification {} to {}", notification, listener);
         } else {
@@ -52,8 +50,6 @@ class NotifyTask implements Callable<Object> {
         } else {
             LOG.trace("Notification delivered {} to {}", notification.getClass().getName(), listener);
         }
         } else {
             LOG.trace("Notification delivered {} to {}", notification.getClass().getName(), listener);
         }
-
-        return null;
     }
 
     @Override
     }
 
     @Override