Code Review
/
controller.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
(from parent 1:
79eba11
)
Merge "Remove redundant expression true:false"
author
Madhu Venugopal
<mavenugo@gmail.com>
Thu, 9 Jan 2014 08:12:14 +0000
(08:12 +0000)
committer
Gerrit Code Review
<gerrit@opendaylight.org>
Thu, 9 Jan 2014 08:12:14 +0000
(08:12 +0000)
opendaylight/forwardingrulesmanager/api/src/main/java/org/opendaylight/controller/forwardingrulesmanager/FlowEntry.java
patch
|
blob
|
history
opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java
patch
|
blob
|
history
diff --git
a/opendaylight/forwardingrulesmanager/api/src/main/java/org/opendaylight/controller/forwardingrulesmanager/FlowEntry.java
b/opendaylight/forwardingrulesmanager/api/src/main/java/org/opendaylight/controller/forwardingrulesmanager/FlowEntry.java
index 83106a391cb7bdc00ff0911fa703e7dee1c1c2f4..d9a0891c2ad812b855641c48155235633328ff51 100644
(file)
--- a/
opendaylight/forwardingrulesmanager/api/src/main/java/org/opendaylight/controller/forwardingrulesmanager/FlowEntry.java
+++ b/
opendaylight/forwardingrulesmanager/api/src/main/java/org/opendaylight/controller/forwardingrulesmanager/FlowEntry.java
@@
-122,7
+122,7
@@
public class FlowEntry implements Cloneable, Serializable {
}
if (flow == null) {
- return
(other.flow == null) ? true : false
;
+ return
other.flow == null
;
} else if (other.flow == null) {
return false;
}
diff --git
a/opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java
b/opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java
index 1e7e93f8aa27e165d79dfcbaa82b91b841ffc80f..cabfb0ee5a1e98e27194cb244f445ca8ba3ca40d 100644
(file)
--- a/
opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java
+++ b/
opendaylight/northbound/integrationtest/src/test/java/org/opendaylight/controller/northbound/integrationtest/NorthboundIT.java
@@
-1126,7
+1126,7
@@
public class NorthboundIT {
} else {
JSONObject ja = json.getJSONObject("hostConfig");
String na = ja.getString("networkAddress");
- return
(na.equalsIgnoreCase(hostIp)) ? true : false
;
+ return
na.equalsIgnoreCase(hostIp)
;
}
}