Reuse odlparent common features 10/79010/3
authorRobert Varga <robert.varga@pantheon.tech>
Sun, 23 Dec 2018 07:57:13 +0000 (08:57 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 24 Dec 2018 23:47:21 +0000 (00:47 +0100)
Rather than packaging commons-lang3 ourselves, use odlparent-provided
feature. Same goes for servlet-api and commons-text.

Change-Id: Icdd20a83cb98242e22f77dd7d8108699f1f30887
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
features/mdsal/odl-mdsal-clustering-commons/pom.xml
features/mdsal/odl-mdsal-clustering-commons/src/main/feature/feature.xml
features/mdsal/odl-mdsal-distributed-datastore/pom.xml
features/mdsal/odl-mdsal-distributed-datastore/src/main/feature/feature.xml [new file with mode: 0644]
opendaylight/md-sal/sal-clustering-commons/pom.xml

index 211d232a96568ba911dd896a24eaf32122f6d767..a046a3924bc07198656ecab54fa0effe6ba3f615 100644 (file)
             <type>xml</type>
             <classifier>features</classifier>
         </dependency>
+        <dependency>
+            <groupId>org.opendaylight.odlparent</groupId>
+            <artifactId>odl-apache-commons-lang3</artifactId>
+            <type>xml</type>
+            <classifier>features</classifier>
+        </dependency>
+        <dependency>
+            <groupId>org.opendaylight.odlparent</groupId>
+            <artifactId>odl-servlet-api</artifactId>
+            <type>xml</type>
+            <classifier>features</classifier>
+        </dependency>
         <dependency>
             <groupId>${project.groupId}</groupId>
             <artifactId>sal-clustering-commons</artifactId>
index bb5c552cf625ac46b449698db4d09dcf984c432a..faa27f8585c33e2b55d720d8c03f7c6bb81116f0 100644 (file)
@@ -11,5 +11,7 @@
         <feature version="[4,5)">odl-akka-system-2.5</feature>
         <feature version="[4,5)">odl-akka-persistence-2.5</feature>
         <feature version="[4,5)">odl-akka-clustering-2.5</feature>
+        <feature version="[4,5)">odl-apache-commons-lang3</feature>
+        <feature version="[4,5)">odl-servlet-api</feature>
     </feature>
 </features>
index 3912616ba7e4b62de4f1a8c59541ab070eb704b9..5f3e1012fa7490d27c30aaab63ae2e4ac1c75004 100644 (file)
             <type>xml</type>
             <classifier>features</classifier>
         </dependency>
+        <dependency>
+            <groupId>org.opendaylight.odlparent</groupId>
+            <artifactId>odl-apache-commons-text</artifactId>
+            <type>xml</type>
+            <classifier>features</classifier>
+        </dependency>
         <dependency>
             <groupId>${project.groupId}</groupId>
             <artifactId>odl-mdsal-clustering-commons</artifactId>
diff --git a/features/mdsal/odl-mdsal-distributed-datastore/src/main/feature/feature.xml b/features/mdsal/odl-mdsal-distributed-datastore/src/main/feature/feature.xml
new file mode 100644 (file)
index 0000000..7716205
--- /dev/null
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Copyright © 2017 Red Hat, Inc. and others.
+  ~
+  ~ This program and the accompanying materials are made available under the
+  ~ terms of the Eclipse Public License v1.0 which accompanies this distribution,
+  ~ and is available at http://www.eclipse.org/legal/epl-v10.html
+  -->
+<features xmlns="http://karaf.apache.org/xmlns/features/v1.4.0" name="odl-controller-${project.version}">
+    <feature name="odl-mdsal-distributed-datastore" version="${project.version}">
+        <feature version="[4,5)">odl-apache-commons-text</feature>
+    </feature>
+</features>
index 2b79a3879069813e312c06cee00961f8188d9f31..c503434dc08a65b09eaab80990e252614f5b6064 100644 (file)
@@ -73,6 +73,7 @@
     </dependency>
     <dependency>
       <!-- Enforce Netty’s optional dependency on servlet API -->
+      <!-- FIXME: is this really needed ? -->
       <groupId>javax.servlet</groupId>
       <artifactId>javax.servlet-api</artifactId>
     </dependency>