Remove explicit default super-constructor calls 20/63620/1
authorDavid Suarez <david.suarez.fuentes@gmail.com>
Wed, 27 Sep 2017 13:23:16 +0000 (15:23 +0200)
committerDavid Suarez <david.suarez.fuentes@gmail.com>
Wed, 27 Sep 2017 13:23:16 +0000 (15:23 +0200)
The default constructor is called by default (hence its name), no need
to call it explicitly.

Change-Id: I0f4ac3bf4a1d582b7a9d50beeaa1de6d2f107499
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
27 files changed:
opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Ethernet.java
opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDP.java
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/ConflictingVersionException.java
opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/rpc/Rpcs.java
opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/dynamicmbean/ReadOnlyAtomicBoolean.java
opendaylight/config/netty-threadgroup-config/src/main/java/org/opendaylight/controller/config/yang/netty/threadgroup/NioEventLoopGroupCloseable.java
opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Constructor.java
opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/Header.java
opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/model/TypeDeclaration.java
opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/AbstractEntry.java
opendaylight/md-sal/mdsal-trace/dom-impl/src/main/java/org/opendaylight/controller/md/sal/trace/closetracker/impl/CloseTrackedRegistryReportEntry.java
opendaylight/md-sal/sal-akka-raft-example/src/main/java/org/opendaylight/controller/cluster/example/ExampleRoleChangeListener.java
opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/LeaderTest.java
opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadOnlyTransaction.java
opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingReadWriteTransaction.java
opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/md/sal/binding/api/ForwardingWriteTransaction.java
opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/rpc/RpcContextIdentifier.java
opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMAdapterLoader.java
opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMRpcServiceAdapter.java
opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/LazySerializedDOMNotification.java
opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/md/sal/binding/test/ConstantSchemaAbstractDataBrokerTest.java
opendaylight/md-sal/sal-common-impl/src/main/java/org/opendaylight/controller/md/sal/common/impl/util/compat/DataNormalizationOperation.java
opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/QueuedNotificationManagerStats.java
opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/RpcErrors.java
opendaylight/md-sal/sal-connector-api/src/main/java/org/opendaylight/controller/sal/connector/api/BindingAwareRpcRouter.java
opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/RpcRoutingContext.java
opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/SchemaContextProviders.java

index 2cdf9a5ae04c1c810e5eef4ee59a29d2a4ff8443..a78ff6a1d1026438f67e67df0adfcde52b6f6630 100644 (file)
@@ -44,7 +44,6 @@ public class Ethernet extends Packet {
      * Default constructor that creates and sets the HashMap
      */
     public Ethernet() {
      * Default constructor that creates and sets the HashMap
      */
     public Ethernet() {
-        super();
         fieldValues = new HashMap<>();
         hdrFieldCoordMap = fieldCoordinates;
         hdrFieldsMap = fieldValues;
         fieldValues = new HashMap<>();
         hdrFieldCoordMap = fieldCoordinates;
         hdrFieldsMap = fieldValues;
index dfd8ca42e5e7b2271faf7a571515b506ca6000ed..7ed1ede781b8cf99c372bd6100ce2841c5a86764 100644 (file)
@@ -34,7 +34,6 @@ public class LLDP extends Packet {
      * Default constructor that creates the tlvList LinkedHashMap
      */
     public LLDP() {
      * Default constructor that creates the tlvList LinkedHashMap
      */
     public LLDP() {
-        super();
         init();
     }
 
         init();
     }
 
index bb0256174c25f28ec30e32db61e5d406cee7503d..9e3c5016ce7fa54c98b7ae1bbe3989d1cd960aed 100644 (file)
@@ -18,7 +18,6 @@ public class ConflictingVersionException extends Exception {
     private static final long serialVersionUID = 1L;
 
     public ConflictingVersionException() {
     private static final long serialVersionUID = 1L;
 
     public ConflictingVersionException() {
-        super();
     }
 
     public ConflictingVersionException(final String message, final Throwable cause) {
     }
 
     public ConflictingVersionException(final String message, final Throwable cause) {
index 5180ab83e327306bda26134a84d10e7b01685098..f409ee25ea9aa4648263f39c11c17258d5ec31f4 100644 (file)
@@ -15,7 +15,6 @@ public class Rpcs {
     private final Map<String, Map<String, ModuleRpcs>> mappedRpcs;
 
     public Rpcs(Map<String, Map<String, ModuleRpcs>> mappedRpcs) {
     private final Map<String, Map<String, ModuleRpcs>> mappedRpcs;
 
     public Rpcs(Map<String, Map<String, ModuleRpcs>> mappedRpcs) {
-        super();
         this.mappedRpcs = mappedRpcs;
     }
 
         this.mappedRpcs = mappedRpcs;
     }
 
index 8abb635755e64136df06548c82656a5d017f3329..8b66ad7563361c7140b59b2aa9448895b10a6f68 100644 (file)
@@ -17,7 +17,6 @@ public interface ReadOnlyAtomicBoolean {
         private final AtomicBoolean atomicBoolean;
 
         public ReadOnlyAtomicBooleanImpl(final AtomicBoolean atomicBoolean) {
         private final AtomicBoolean atomicBoolean;
 
         public ReadOnlyAtomicBooleanImpl(final AtomicBoolean atomicBoolean) {
-            super();
             this.atomicBoolean = atomicBoolean;
         }
 
             this.atomicBoolean = atomicBoolean;
         }
 
index 8e8ee64f3e2bbc62636b2cd5ee11813c9529458f..5f92f943e38253b2dad493b14343749393d5a162 100644 (file)
@@ -16,7 +16,6 @@ public class NioEventLoopGroupCloseable extends NioEventLoopGroup implements Aut
     }
 
     private NioEventLoopGroupCloseable() {
     }
 
     private NioEventLoopGroupCloseable() {
-        super();
     }
 
     @Override
     }
 
     @Override
index 91c1cc396632dcfaf6468a9bd8810ad31c4760d8..915e8c57539237302de9448c66fea40745d31096 100644 (file)
@@ -13,7 +13,6 @@ public class Constructor {
     private final boolean isPublic;
 
     public Constructor(String typeName, String body, boolean isPublic) {
     private final boolean isPublic;
 
     public Constructor(String typeName, String body, boolean isPublic) {
-        super();
         this.typeName = typeName;
         this.body = body;
         this.isPublic = isPublic;
         this.typeName = typeName;
         this.body = body;
         this.isPublic = isPublic;
index b9a628495d71f8a8f2210d1178aa4ed85badf8ac..f8f58d073fe4332c142ecf86402e2a63229740c7 100644 (file)
@@ -11,7 +11,6 @@ public class Header {
     private final String yangModuleName, yangModuleLocalName;
 
     public Header(String yangModuleName, String yangModuleLocalName) {
     private final String yangModuleName, yangModuleLocalName;
 
     public Header(String yangModuleName, String yangModuleLocalName) {
-        super();
         this.yangModuleName = yangModuleName;
         this.yangModuleLocalName = yangModuleLocalName;
     }
         this.yangModuleName = yangModuleName;
         this.yangModuleLocalName = yangModuleLocalName;
     }
index 1c44040708ce8213628367c736524ab457c73dd5..be917dfdda49bba506e955967b2ea22796e125e1 100644 (file)
@@ -17,7 +17,6 @@ public class TypeDeclaration {
 
     public TypeDeclaration(String type, String name, List<String> extended,
             List<String> implemented, boolean isAbstract, boolean isFinal) {
 
     public TypeDeclaration(String type, String name, List<String> extended,
             List<String> implemented, boolean isAbstract, boolean isFinal) {
-        super();
         this.type = type;
         this.name = name;
         this.extended = extended;
         this.type = type;
         this.name = name;
         this.extended = extended;
index 0b27218ff31efe0fa253dded8dd11659ce696a5a..c61229a80e173d448726c467838bfd4680e7173f 100644 (file)
@@ -16,7 +16,6 @@ public class AbstractEntry {
     private String yangModuleLocalname;
 
     public AbstractEntry() {
     private String yangModuleLocalname;
 
     public AbstractEntry() {
-        super();
     }
 
     protected void setYangModuleName(String name) {
     }
 
     protected void setYangModuleName(String name) {
index 1681eb8d1a464c2b9dde13e89f25d9dee3609d0a..2dd161a5ff58fab2c39ce957af6feec1056e0500 100644 (file)
@@ -24,7 +24,6 @@ public class CloseTrackedRegistryReportEntry<T extends CloseTracked<T>> {
 
     public CloseTrackedRegistryReportEntry(CloseTracked<T> exampleCloseTracked, long numberAddedNotRemoved,
             List<StackTraceElement> stackTraceElements) {
 
     public CloseTrackedRegistryReportEntry(CloseTracked<T> exampleCloseTracked, long numberAddedNotRemoved,
             List<StackTraceElement> stackTraceElements) {
-        super();
         this.exampleCloseTracked = requireNonNull(exampleCloseTracked, "closeTracked");
         this.numberAddedNotRemoved = requireNonNull(numberAddedNotRemoved, "numberAddedNotRemoved");
         this.stackTraceElements = requireNonNull(stackTraceElements, "stackTraceElements");
         this.exampleCloseTracked = requireNonNull(exampleCloseTracked, "closeTracked");
         this.numberAddedNotRemoved = requireNonNull(numberAddedNotRemoved, "numberAddedNotRemoved");
         this.stackTraceElements = requireNonNull(stackTraceElements, "stackTraceElements");
index 3336ad9b3b0b1b0b642d451f11c075e81d1485f7..6e89ca7110e2bbe31444b4113831f8b45a7fbb5d 100644 (file)
@@ -45,7 +45,6 @@ public class ExampleRoleChangeListener extends AbstractUntypedActor implements A
     private static final String[] shardsToMonitor = new String[] {"example"};
 
     public ExampleRoleChangeListener(String memberName) {
     private static final String[] shardsToMonitor = new String[] {"example"};
 
     public ExampleRoleChangeListener(String memberName) {
-        super();
         scheduleRegistrationListener(schedulerDuration);
         this.memberName = memberName;
         populateRegistry(memberName);
         scheduleRegistrationListener(schedulerDuration);
         this.memberName = memberName;
         populateRegistry(memberName);
index 00a2fcd9f09f5430636e6171545e273c335c064c..7ad5812f64250ccbe25a95d25e5e824d264b966f 100644 (file)
@@ -2389,7 +2389,6 @@ public class LeaderTest extends AbstractLeaderTest<Leader> {
         private final int snapshotChunkSize;
 
         MockConfigParamsImpl(final long electionTimeOutIntervalMillis, final int snapshotChunkSize) {
         private final int snapshotChunkSize;
 
         MockConfigParamsImpl(final long electionTimeOutIntervalMillis, final int snapshotChunkSize) {
-            super();
             this.electionTimeOutIntervalMillis = electionTimeOutIntervalMillis;
             this.snapshotChunkSize = snapshotChunkSize;
         }
             this.electionTimeOutIntervalMillis = electionTimeOutIntervalMillis;
             this.snapshotChunkSize = snapshotChunkSize;
         }
index bc7d18c8d1161ead657f81ba3a78be446ba076ce..a8fad515607fb00d99dbb32760dbe2c7bbef67f4 100644 (file)
@@ -25,7 +25,6 @@ public class ForwardingReadOnlyTransaction extends ForwardingObject implements R
     private final ReadOnlyTransaction delegate;
 
     protected ForwardingReadOnlyTransaction(ReadOnlyTransaction delegate) {
     private final ReadOnlyTransaction delegate;
 
     protected ForwardingReadOnlyTransaction(ReadOnlyTransaction delegate) {
-        super();
         this.delegate = delegate;
     }
 
         this.delegate = delegate;
     }
 
index ae7446b1b201e9ca49ae6d9c1404e82bd742ba60..97a6db64195454f997d34c6cb55079472f35c477 100644 (file)
@@ -29,7 +29,6 @@ public class ForwardingReadWriteTransaction extends ForwardingObject implements
     private final ReadWriteTransaction delegate;
 
     protected ForwardingReadWriteTransaction(ReadWriteTransaction delegate) {
     private final ReadWriteTransaction delegate;
 
     protected ForwardingReadWriteTransaction(ReadWriteTransaction delegate) {
-        super();
         this.delegate = delegate;
     }
 
         this.delegate = delegate;
     }
 
index 81193afe50c8f0582e1c55d5202f1ef17b1ec1b5..e6027430cec17b665bb74601f6d846434de2b1ee 100644 (file)
@@ -28,7 +28,6 @@ public class ForwardingWriteTransaction extends ForwardingObject implements Writ
     private final WriteTransaction delegate;
 
     protected ForwardingWriteTransaction(WriteTransaction delegate) {
     private final WriteTransaction delegate;
 
     protected ForwardingWriteTransaction(WriteTransaction delegate) {
-        super();
         this.delegate = delegate;
     }
 
         this.delegate = delegate;
     }
 
index e3bedd33f9a2307bf9e76437e48729765698c763..b4bd6eb6a7782af3aeeb98aec5f88aad3256b232 100644 (file)
@@ -17,7 +17,6 @@ public final  class RpcContextIdentifier implements Immutable{
     public final Class<? extends BaseIdentity> routingContext;
 
     private RpcContextIdentifier(Class<? extends RpcService> rpcService, Class<? extends BaseIdentity> routingContext) {
     public final Class<? extends BaseIdentity> routingContext;
 
     private RpcContextIdentifier(Class<? extends RpcService> rpcService, Class<? extends BaseIdentity> routingContext) {
-        super();
         this.rpcService = rpcService;
         this.routingContext = routingContext;
     }
         this.rpcService = rpcService;
         this.routingContext = routingContext;
     }
index 96108ee1f0aa8ba3978f478dc63536d21477d228..d8afdeb150e8484be36366bba168793c84e2156a 100644 (file)
@@ -33,7 +33,6 @@ public abstract class BindingDOMAdapterLoader extends AdapterLoader<BindingServi
     private final BindingToNormalizedNodeCodec codec;
 
     public BindingDOMAdapterLoader(final BindingToNormalizedNodeCodec codec) {
     private final BindingToNormalizedNodeCodec codec;
 
     public BindingDOMAdapterLoader(final BindingToNormalizedNodeCodec codec) {
-        super();
         this.codec = codec;
     }
 
         this.codec = codec;
     }
 
index 26e696d1c75bf3d22811bc9f0e64ac24f2417fed..6504341d930cea322c6537c4dcd6f877691c8e76 100644 (file)
@@ -40,7 +40,6 @@ public class BindingDOMRpcServiceAdapter implements RpcConsumerRegistry {
     private final BindingToNormalizedNodeCodec codec;
 
     public BindingDOMRpcServiceAdapter(final DOMRpcService domService, final BindingToNormalizedNodeCodec codec) {
     private final BindingToNormalizedNodeCodec codec;
 
     public BindingDOMRpcServiceAdapter(final DOMRpcService domService, final BindingToNormalizedNodeCodec codec) {
-        super();
         this.domService = domService;
         this.codec = codec;
     }
         this.domService = domService;
         this.codec = codec;
     }
index 8eba75ad7e753342e1610eea8446d0aba9a3d7d7..ffab566e68e03c8dda5cbddcb418accbc47a7476 100644 (file)
@@ -30,7 +30,6 @@ public final class LazySerializedDOMNotification implements DOMNotification {
     private ContainerNode domBody;
 
     private LazySerializedDOMNotification(final BindingNormalizedNodeSerializer codec, final Notification data, final SchemaPath type) {
     private ContainerNode domBody;
 
     private LazySerializedDOMNotification(final BindingNormalizedNodeSerializer codec, final Notification data, final SchemaPath type) {
-        super();
         this.codec = codec;
         this.data = data;
         this.type = type;
         this.codec = codec;
         this.data = data;
         this.type = type;
index ba646c48589d3eb876a6af5a63989126484396e4..7e245a3b15c079422864aaf5b00cc9221fef1fe8 100644 (file)
@@ -19,7 +19,6 @@ import org.opendaylight.yangtools.yang.model.api.SchemaContext;
 public class ConstantSchemaAbstractDataBrokerTest extends AbstractConcurrentDataBrokerTest {
 
     public ConstantSchemaAbstractDataBrokerTest() {
 public class ConstantSchemaAbstractDataBrokerTest extends AbstractConcurrentDataBrokerTest {
 
     public ConstantSchemaAbstractDataBrokerTest() {
-        super();
     }
 
     public ConstantSchemaAbstractDataBrokerTest(final boolean useMTDataTreeChangeListenerExecutor) {
     }
 
     public ConstantSchemaAbstractDataBrokerTest(final boolean useMTDataTreeChangeListenerExecutor) {
index bbe366016342a7998c961e5028538e56a4b57f9b..ca344aa578794a3033575914916502c5474027fa 100644 (file)
@@ -56,7 +56,6 @@ public abstract class DataNormalizationOperation<T extends PathArgument> impleme
     }
 
     protected DataNormalizationOperation(final T identifier, final SchemaNode schema) {
     }
 
     protected DataNormalizationOperation(final T identifier, final SchemaNode schema) {
-        super();
         this.identifier = identifier;
         if(schema instanceof DataSchemaNode) {
             this.dataSchemaNode = Optional.of((DataSchemaNode) schema);
         this.identifier = identifier;
         if(schema instanceof DataSchemaNode) {
             this.dataSchemaNode = Optional.of((DataSchemaNode) schema);
@@ -328,7 +327,6 @@ public abstract class DataNormalizationOperation<T extends PathArgument> impleme
     private static final class AugmentationNormalization extends DataContainerNormalizationOperation<AugmentationIdentifier> {
 
         public AugmentationNormalization(final AugmentationSchema augmentation, final DataNodeContainer schema) {
     private static final class AugmentationNormalization extends DataContainerNormalizationOperation<AugmentationIdentifier> {
 
         public AugmentationNormalization(final AugmentationSchema augmentation, final DataNodeContainer schema) {
-            //super();
             super(augmentationIdentifierFrom(augmentation), augmentationProxy(augmentation,schema),null);
         }
 
             super(augmentationIdentifierFrom(augmentation), augmentationProxy(augmentation,schema),null);
         }
 
index c6e50060a151c6ff24b2f91397f20477a5e19b0b..1cc62f40650c67a535e426bedb1503b1d7cb878b 100644 (file)
@@ -31,9 +31,8 @@ public class QueuedNotificationManagerStats {
     private final List<ListenerNotificationQueueStats> currentListenerQueueStats;
 
     @ConstructorProperties({"maxListenerQueueSize","currentListenerQueueStats"})
     private final List<ListenerNotificationQueueStats> currentListenerQueueStats;
 
     @ConstructorProperties({"maxListenerQueueSize","currentListenerQueueStats"})
-    public QueuedNotificationManagerStats( int maxListenerQueueSize,
-            List<ListenerNotificationQueueStats> currentListenerQueueStats ) {
-        super();
+    public QueuedNotificationManagerStats(int maxListenerQueueSize,
+            List<ListenerNotificationQueueStats> currentListenerQueueStats) {
         this.maxListenerQueueSize = maxListenerQueueSize;
         this.currentListenerQueueStats = currentListenerQueueStats;
     }
         this.maxListenerQueueSize = maxListenerQueueSize;
         this.currentListenerQueueStats = currentListenerQueueStats;
     }
index cacb167f6f54f962c4f7bb49b39452ed140186e1..28133c5b69770daa895cf49697d1988fe2983663 100644 (file)
@@ -55,7 +55,6 @@ public class RpcErrors {
          */
         protected RpcErrorTO(String applicationTag, String tag, String info,
                 ErrorSeverity severity, String message, ErrorType errorType, Throwable cause) {
          */
         protected RpcErrorTO(String applicationTag, String tag, String info,
                 ErrorSeverity severity, String message, ErrorType errorType, Throwable cause) {
-            super();
             this.applicationTag = applicationTag;
             this.tag = tag;
             this.info = info;
             this.applicationTag = applicationTag;
             this.tag = tag;
             this.info = info;
index c242e0c96797549528a1e8dd733424b4908db8ab..17221bc0af4fe1894022d6db05af3400d8c0aeb9 100644 (file)
@@ -23,7 +23,6 @@ public interface BindingAwareRpcRouter extends RpcRouter<String, String, String,
         private final byte[] payload;
 
         public BindingAwareRequest(BindingAwareRouteIdentifier routingInformation, byte[] payload) {
         private final byte[] payload;
 
         public BindingAwareRequest(BindingAwareRouteIdentifier routingInformation, byte[] payload) {
-            super();
             this.routingInformation = routingInformation;
             this.payload = payload;
         }
             this.routingInformation = routingInformation;
             this.payload = payload;
         }
@@ -45,7 +44,6 @@ public interface BindingAwareRpcRouter extends RpcRouter<String, String, String,
         private final String content;
 
         public BindingAwareRouteIdentifier(String type, String route, String content) {
         private final String content;
 
         public BindingAwareRouteIdentifier(String type, String route, String content) {
-            super();
             this.type = type;
             this.route = route;
             this.content = content;
             this.type = type;
             this.route = route;
             this.content = content;
index 66d290f531aa41f5346d970c92bba1963094f28f..ff3bb890924bfa06157a6e8cceb28173d98bb344 100644 (file)
@@ -24,7 +24,6 @@ public class RpcRoutingContext implements Immutable, Serializable {
 
 
     private RpcRoutingContext(QName context, QName rpc) {
 
 
     private RpcRoutingContext(QName context, QName rpc) {
-        super();
         this.context = context;
         this.rpc = rpc;
     }
         this.context = context;
         this.rpc = rpc;
     }
index 6806c5d4a42069af9d2a3f9802d9238abe40c12c..e312e3da805aef21932143db3c7a04cb7e944b60 100644 (file)
@@ -30,7 +30,6 @@ public class SchemaContextProviders {
         private final SchemaService service;
 
         public SchemaServiceAdapter(final SchemaService service) {
         private final SchemaService service;
 
         public SchemaServiceAdapter(final SchemaService service) {
-            super();
             this.service = service;
         }
 
             this.service = service;
         }