Deprecate common.util.Arguments for removal

The method hosted is used only in 6 call sites across all
downstreams. Deprecate it for removal, so they can come up with
a replacement.

Change-Id: Iddfc75ef40710944e8f6e5a420dd0c467d973671
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Arguments.java b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Arguments.java
index d09024aea0ccf73a50006c9c28bdca4e3b7a9aa1..6d8081edb6415a92f3bf898ea14245d74b6f9c9e 100644 (file)
--- a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Arguments.java
+++ b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Arguments.java
@@ -7,8 +7,8 @@
  */
 package org.opendaylight.controller.sal.common.util;
 
  */
 package org.opendaylight.controller.sal.common.util;
 

+@Deprecated(forRemoval = true)

 public final class Arguments {
 public final class Arguments {

-

     private Arguments() {
         throw new UnsupportedOperationException("Utility class");
     }
     private Arguments() {
         throw new UnsupportedOperationException("Utility class");
     }


@@ -19,12 +19,14 @@ public final class Arguments {
      * @param value Value to check
      * @param type Type to check
      * @return Reference which was checked
      * @param value Value to check
      * @param type Type to check
      * @return Reference which was checked

+     * @deprecated This utility is not used in this project, please brew your own or
+     *             use {@code Preconditions.checkArgument()}.

      */
      */

-    @SuppressWarnings("unchecked")
-    public static <T> T checkInstanceOf(Object value, Class<T> type) {
+    @Deprecated(forRemoval = true)
+    public static <T> T checkInstanceOf(final Object value, final Class<T> type) {

         if (!type.isInstance(value)) {
             throw new IllegalArgumentException(String.format("Value %s is not of type %s", value, type));
         }
         if (!type.isInstance(value)) {
             throw new IllegalArgumentException(String.format("Value %s is not of type %s", value, type));
         }

-        return (T) value;
+        return type.cast(value);

     }
 }
     }
 }