Fix logging messages 60/81260/5
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 28 Mar 2019 13:32:44 +0000 (14:32 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 28 Mar 2019 16:33:41 +0000 (17:33 +0100)
Upgraded spotbugs is finding more violations, fix them up.

Change-Id: I8956c5b7a6eef38286f4c2b6fb07ca6a775e6965
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java
opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/selectionstrategy/EntityOwnerSelectionStrategyConfigReader.java
opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java

index c3f61c6..d234532 100644 (file)
@@ -74,7 +74,7 @@ public class MeteredBoundedMailbox implements MailboxType,
             registry.register(fullName, metric);
         } catch (IllegalArgumentException e) {
             // already registered - shouldn't happen here since we check above...
-            LOG.debug("Unable to register '{}' in metrics registry: {}", e);
+            LOG.debug("Unable to register '{}' in metrics registry", fullName);
         }
     }
 
index 4ac28a6..2d504cd 100644 (file)
@@ -50,7 +50,7 @@ public final class EntityOwnerSelectionStrategyConfigReader {
         for (final Entry<Object, Object> entry : properties.entrySet()) {
             final String key = (String) entry.getKey();
             if (!key.startsWith(ENTITY_TYPE_PREFIX)) {
-                LOG.debug("Ignoring non-conforming property key : {}");
+                LOG.debug("Ignoring non-conforming property key : {}", key);
                 continue;
             }
 
index 5d1e4b5..ba061ee 100644 (file)
@@ -201,7 +201,7 @@ public class DistributedShardChangePublisher
             try {
                 DataTreeCandidates.applyToModification(modification, change);
             } catch (SchemaValidationFailedException e) {
-                LOG.error("Validation failed {}", e);
+                LOG.error("Validation failed", e);
             }
         }
 

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.