Fix logging messages

Upgraded spotbugs is finding more violations, fix them up.

Change-Id: I8956c5b7a6eef38286f4c2b6fb07ca6a775e6965
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java
index c3f61c66fef8389e7f06d6bfcbd38cc38aa1cb48..d234532751e94d871162a82b00d7d051e101ab6c 100644 (file)
--- a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java
+++ b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java
@@ -74,7 +74,7 @@ public class MeteredBoundedMailbox implements MailboxType,
             registry.register(fullName, metric);
         } catch (IllegalArgumentException e) {
             // already registered - shouldn't happen here since we check above...
             registry.register(fullName, metric);
         } catch (IllegalArgumentException e) {
             // already registered - shouldn't happen here since we check above...

-            LOG.debug("Unable to register '{}' in metrics registry: {}", e);
+            LOG.debug("Unable to register '{}' in metrics registry", fullName);

         }
     }
 
         }
     }
 

diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/selectionstrategy/EntityOwnerSelectionStrategyConfigReader.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/selectionstrategy/EntityOwnerSelectionStrategyConfigReader.java
index 4ac28a6719a07f0c4d368d354625f533e0f4983c..2d504cd6aab2652d2deed6355820a1a0d54ab2f2 100644 (file)
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/selectionstrategy/EntityOwnerSelectionStrategyConfigReader.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/selectionstrategy/EntityOwnerSelectionStrategyConfigReader.java
@@ -50,7 +50,7 @@ public final class EntityOwnerSelectionStrategyConfigReader {
         for (final Entry<Object, Object> entry : properties.entrySet()) {
             final String key = (String) entry.getKey();
             if (!key.startsWith(ENTITY_TYPE_PREFIX)) {
         for (final Entry<Object, Object> entry : properties.entrySet()) {
             final String key = (String) entry.getKey();
             if (!key.startsWith(ENTITY_TYPE_PREFIX)) {

-                LOG.debug("Ignoring non-conforming property key : {}");
+                LOG.debug("Ignoring non-conforming property key : {}", key);

                 continue;
             }
 
                 continue;
             }
 

diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java
index 5d1e4b5cfdb6cee2187456d22ec9ab38589a58a2..ba061ee400536377e7f418214fd36e4b0f2ca2a7 100644 (file)
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java
@@ -201,7 +201,7 @@ public class DistributedShardChangePublisher
             try {
                 DataTreeCandidates.applyToModification(modification, change);
             } catch (SchemaValidationFailedException e) {
             try {
                 DataTreeCandidates.applyToModification(modification, change);
             } catch (SchemaValidationFailedException e) {

-                LOG.error("Validation failed {}", e);
+                LOG.error("Validation failed", e);

             }
         }
 
             }
         }