Merge "Add serialVersionUID to Serializable classes"
authorTony Tkacik <ttkacik@cisco.com>
Mon, 10 Nov 2014 10:45:00 +0000 (10:45 +0000)
committerGerrit Code Review <gerrit@opendaylight.org>
Mon, 10 Nov 2014 10:45:00 +0000 (10:45 +0000)
1  2 
opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorTest.java
opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java

index b0a144c7b3b60d32a1ae5d180306f5a06cf614d7,90827fcc819df4c6cf4ade471b5c25f9a9744403..9eb2fb757bd2da0c6b2ce48ebbfeb72471ef48c1
@@@ -85,6 -85,7 +85,7 @@@ public class RaftActorTest extends Abst
          private final RaftActor delegate;
  
          public static final class MockRaftActorCreator implements Creator<MockRaftActor> {
+             private static final long serialVersionUID = 1L;
              private final Map<String, String> peerAddresses;
              private final String id;
              private final Optional<ConfigParams> config;
              super(actorSystem);
  
              raftActor = this.getSystem().actorOf(MockRaftActor.props(actorName,
 -                    Collections.EMPTY_MAP, Optional.<ConfigParams>absent()), actorName);
 +                    Collections.<String,String>emptyMap(), Optional.<ConfigParams>absent()), actorName);
  
          }
  
              config.setHeartBeatInterval(new FiniteDuration(1, TimeUnit.DAYS));
  
              ActorRef followerActor = getSystem().actorOf(MockRaftActor.props(persistenceId,
 -                    Collections.EMPTY_MAP, Optional.<ConfigParams>of(config)), persistenceId);
 +                    Collections.<String,String>emptyMap(), Optional.<ConfigParams>of(config)), persistenceId);
  
              watch(followerActor);
  
  
              //reinstate the actor
              TestActorRef<MockRaftActor> ref = TestActorRef.create(getSystem(),
 -                    MockRaftActor.props(persistenceId, Collections.EMPTY_MAP,
 +                    MockRaftActor.props(persistenceId, Collections.<String,String>emptyMap(),
                              Optional.<ConfigParams>of(config)));
  
              ref.underlyingActor().waitForRecoveryComplete();
                  config.setHeartBeatInterval(new FiniteDuration(1, TimeUnit.DAYS));
  
                  TestActorRef<MockRaftActor> mockActorRef = TestActorRef.create(getSystem(), MockRaftActor.props(persistenceId,
 -                        Collections.EMPTY_MAP, Optional.<ConfigParams>of(config)), persistenceId);
 +                        Collections.<String,String>emptyMap(), Optional.<ConfigParams>of(config)), persistenceId);
  
                  MockRaftActor mockRaftActor = mockActorRef.underlyingActor();
  
                  config.setHeartBeatInterval(new FiniteDuration(1, TimeUnit.DAYS));
  
                  TestActorRef<MockRaftActor> mockActorRef = TestActorRef.create(getSystem(), MockRaftActor.props(persistenceId,
 -                        Collections.EMPTY_MAP, Optional.<ConfigParams>of(config), new DataPersistenceProviderMonitor()), persistenceId);
 +                        Collections.<String,String>emptyMap(), Optional.<ConfigParams>of(config), new DataPersistenceProviderMonitor()), persistenceId);
  
                  MockRaftActor mockRaftActor = mockActorRef.underlyingActor();
  
                  dataPersistenceProviderMonitor.setPersistLatch(persistLatch);
  
                  TestActorRef<MockRaftActor> mockActorRef = TestActorRef.create(getSystem(), MockRaftActor.props(persistenceId,
 -                        Collections.EMPTY_MAP, Optional.<ConfigParams>of(config), dataPersistenceProviderMonitor), persistenceId);
 +                        Collections.<String,String>emptyMap(), Optional.<ConfigParams>of(config), dataPersistenceProviderMonitor), persistenceId);
  
                  MockRaftActor mockRaftActor = mockActorRef.underlyingActor();
  
                  DataPersistenceProvider dataPersistenceProvider = mock(DataPersistenceProvider.class);
  
                  TestActorRef<MockRaftActor> mockActorRef = TestActorRef.create(getSystem(), MockRaftActor.props(persistenceId,
 -                        Collections.EMPTY_MAP, Optional.<ConfigParams>of(config), dataPersistenceProvider), persistenceId);
 +                        Collections.<String,String>emptyMap(), Optional.<ConfigParams>of(config), dataPersistenceProvider), persistenceId);
  
                  MockRaftActor mockRaftActor = mockActorRef.underlyingActor();
  
                  DataPersistenceProvider dataPersistenceProvider = mock(DataPersistenceProvider.class);
  
                  TestActorRef<MockRaftActor> mockActorRef = TestActorRef.create(getSystem(), MockRaftActor.props(persistenceId,
 -                        Collections.EMPTY_MAP, Optional.<ConfigParams>of(config), dataPersistenceProvider), persistenceId);
 +                        Collections.<String,String>emptyMap(), Optional.<ConfigParams>of(config), dataPersistenceProvider), persistenceId);
  
                  MockRaftActor mockRaftActor = mockActorRef.underlyingActor();
  
                  DataPersistenceProvider dataPersistenceProvider = mock(DataPersistenceProvider.class);
  
                  TestActorRef<MockRaftActor> mockActorRef = TestActorRef.create(getSystem(), MockRaftActor.props(persistenceId,
 -                        Collections.EMPTY_MAP, Optional.<ConfigParams>of(config), dataPersistenceProvider), persistenceId);
 +                        Collections.<String,String>emptyMap(), Optional.<ConfigParams>of(config), dataPersistenceProvider), persistenceId);
  
                  MockRaftActor mockRaftActor = mockActorRef.underlyingActor();
  
                  DataPersistenceProvider dataPersistenceProvider = mock(DataPersistenceProvider.class);
  
                  TestActorRef<MockRaftActor> mockActorRef = TestActorRef.create(getSystem(),
 -                    MockRaftActor.props(persistenceId,Collections.EMPTY_MAP,
 +                    MockRaftActor.props(persistenceId,Collections.<String,String>emptyMap(),
                          Optional.<ConfigParams>of(config), dataPersistenceProvider), persistenceId);
  
                  MockRaftActor mockRaftActor = mockActorRef.underlyingActor();
                  DataPersistenceProvider dataPersistenceProvider = mock(DataPersistenceProvider.class);
  
                  TestActorRef<MockRaftActor> mockActorRef = TestActorRef.create(getSystem(), MockRaftActor.props(persistenceId,
 -                        Collections.EMPTY_MAP, Optional.<ConfigParams>of(config), dataPersistenceProvider), persistenceId);
 +                        Collections.<String,String>emptyMap(), Optional.<ConfigParams>of(config), dataPersistenceProvider), persistenceId);
  
                  MockRaftActor mockRaftActor = mockActorRef.underlyingActor();
  
                  DataPersistenceProvider dataPersistenceProvider = mock(DataPersistenceProvider.class);
  
                  TestActorRef<MockRaftActor> mockActorRef = TestActorRef.create(getSystem(), MockRaftActor.props(persistenceId,
 -                        Collections.EMPTY_MAP, Optional.<ConfigParams>of(config), dataPersistenceProvider), persistenceId);
 +                        Collections.<String,String>emptyMap(), Optional.<ConfigParams>of(config), dataPersistenceProvider), persistenceId);
  
                  MockRaftActor mockRaftActor = mockActorRef.underlyingActor();
  
                  DataPersistenceProviderMonitor dataPersistenceProviderMonitor = new DataPersistenceProviderMonitor();
  
                  TestActorRef<MockRaftActor> mockActorRef = TestActorRef.create(getSystem(), MockRaftActor.props(persistenceId,
 -                        Collections.EMPTY_MAP, Optional.<ConfigParams>of(config), dataPersistenceProviderMonitor), persistenceId);
 +                        Collections.<String,String>emptyMap(), Optional.<ConfigParams>of(config), dataPersistenceProviderMonitor), persistenceId);
  
                  MockRaftActor mockRaftActor = mockActorRef.underlyingActor();
  
                  DataPersistenceProviderMonitor dataPersistenceProviderMonitor = new DataPersistenceProviderMonitor();
  
                  TestActorRef<MockRaftActor> mockActorRef = TestActorRef.create(getSystem(), MockRaftActor.props(persistenceId,
 -                        Collections.EMPTY_MAP, Optional.<ConfigParams>of(config), dataPersistenceProviderMonitor), persistenceId);
 +                        Collections.<String,String>emptyMap(), Optional.<ConfigParams>of(config), dataPersistenceProviderMonitor), persistenceId);
  
                  MockRaftActor mockRaftActor = mockActorRef.underlyingActor();
  
index 7517efeb9028f5df15349a62e74eadb4bf91f15e,2a6735abd00f9a115bf83aeae4b9c9f3a51eae69..f1a78194a95c9430c35eaf5e3cf398a8287a370f
@@@ -55,7 -55,7 +55,7 @@@ public class MeteredBoundedMailbox impl
              return; //there's no actor to monitor
          }
          String actorName = owner.get().path().toStringWithoutAddress();
 -        String metricName = registry.name(actorName, QUEUE_SIZE);
 +        String metricName = MetricRegistry.name(actorName, QUEUE_SIZE);
  
          if (registry.getMetrics().containsKey(metricName))
              return; //already registered
@@@ -66,6 -66,7 +66,7 @@@
  
  
      public static class MeteredMessageQueue extends BoundedDequeBasedMailbox.MessageQueue {
+         private static final long serialVersionUID = 1L;
  
          public MeteredMessageQueue(int capacity, FiniteDuration pushTimeOut) {
              super(capacity, pushTimeOut);