There is no need to instantiate the Joiner everytime we format
a map, as the instance is immmutable and thread-safe. Cache
a single object, allowing for slightly faster access.
Change-Id: Idff936f6525059d0e9abd6eae1370fd3066996a4
Signed-off-by: Robert Varga <rovarga@cisco.com>
import akka.pattern.Patterns;
import akka.util.Timeout;
import com.google.common.base.Joiner;
import akka.pattern.Patterns;
import akka.util.Timeout;
import com.google.common.base.Joiner;
+import com.google.common.base.Joiner.MapJoiner;
import com.google.common.base.Stopwatch;
import com.google.common.cache.Cache;
import com.google.common.cache.CacheBuilder;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.List;
import com.google.common.base.Stopwatch;
import com.google.common.cache.Cache;
import com.google.common.cache.CacheBuilder;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.List;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
import javax.annotation.Nullable;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
import javax.annotation.Nullable;
private static final Cache<String, OnDemandRaftState> ONDEMAND_RAFT_STATE_CACHE =
CacheBuilder.newBuilder().expireAfterWrite(2, TimeUnit.SECONDS).build();
private static final Cache<String, OnDemandRaftState> ONDEMAND_RAFT_STATE_CACHE =
CacheBuilder.newBuilder().expireAfterWrite(2, TimeUnit.SECONDS).build();
+ private static final MapJoiner MAP_JOINER = Joiner.on(", ").withKeyValueSeparator(": ");
+
private long committedTransactionsCount;
private long readOnlyTransactionCount;
private long committedTransactionsCount;
private long readOnlyTransactionCount;
@Override
public String getPeerVotingStates() {
@Override
public String getPeerVotingStates() {
- return toStringMap(getOnDemandRaftState().getPeerVotingStates());
+ return MAP_JOINER.join(getOnDemandRaftState().getPeerVotingStates());
@Override
public String getPeerAddresses() {
@Override
public String getPeerAddresses() {
- return toStringMap(getOnDemandRaftState().getPeerAddresses());
- }
-
- private static String toStringMap(Map<?, ?> map) {
- return Joiner.on(", ").withKeyValueSeparator(": ").join(map);
+ return MAP_JOINER.join(getOnDemandRaftState().getPeerAddresses());