summary |
shortlog |
log |
commit | commitdiff |
review |
tree
raw |
patch |
inline | side by side (from parent 1:
ea13216)
Broker-related interfaces are no longer used, as we are activating
via blueprint. Remove references to them.
Change-Id: I67552c986c31e0214cb35d8fc2b60cca536ecbb5
Signed-off-by: Robert Varga <rovarga@cisco.com>
import akka.actor.ActorSystem;
import akka.actor.PoisonPill;
import com.google.common.base.Preconditions;
import akka.actor.ActorSystem;
import akka.actor.PoisonPill;
import com.google.common.base.Preconditions;
-import com.google.common.collect.ImmutableSet;
-import java.util.Collection;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcProviderService;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcService;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcProviderService;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcService;
-import org.opendaylight.controller.sal.core.api.Broker;
-import org.opendaylight.controller.sal.core.api.Provider;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
* This is the base class which initialize all the actors, listeners and
* default RPc implementation so remote invocation of rpcs.
*/
* This is the base class which initialize all the actors, listeners and
* default RPc implementation so remote invocation of rpcs.
*/
-public class RemoteRpcProvider implements AutoCloseable, Provider {
+public class RemoteRpcProvider implements AutoCloseable {
private static final Logger LOG = LoggerFactory.getLogger(RemoteRpcProvider.class);
private final DOMRpcProviderService rpcProvisionRegistry;
private final RemoteRpcProviderConfig config;
private final ActorSystem actorSystem;
private static final Logger LOG = LoggerFactory.getLogger(RemoteRpcProvider.class);
private final DOMRpcProviderService rpcProvisionRegistry;
private final RemoteRpcProviderConfig config;
private final ActorSystem actorSystem;
+ private final DOMRpcService rpcService;
- private DOMRpcService rpcService;
private ActorRef rpcManager;
public RemoteRpcProvider(final ActorSystem actorSystem, final DOMRpcProviderService rpcProvisionRegistry,
private ActorRef rpcManager;
public RemoteRpcProvider(final ActorSystem actorSystem, final DOMRpcProviderService rpcProvisionRegistry,
- final RemoteRpcProviderConfig config) {
- this.actorSystem = actorSystem;
- this.rpcProvisionRegistry = rpcProvisionRegistry;
+ final DOMRpcService rpcService, final RemoteRpcProviderConfig config) {
+ this.actorSystem = Preconditions.checkNotNull(actorSystem);
+ this.rpcProvisionRegistry = Preconditions.checkNotNull(rpcProvisionRegistry);
+ this.rpcService = Preconditions.checkNotNull(rpcService);
this.config = Preconditions.checkNotNull(config);
}
this.config = Preconditions.checkNotNull(config);
}
- public void setRpcService(final DOMRpcService rpcService) {
- this.rpcService = rpcService;
- }
-
@Override
public void close() {
if (rpcManager != null) {
@Override
public void close() {
if (rpcManager != null) {
- @Override
- public void onSessionInitiated(final Broker.ProviderSession session) {
- rpcService = session.getService(DOMRpcService.class);
- start();
- }
-
- @Override
- public Collection<ProviderFunctionality> getProviderFunctionality() {
- return ImmutableSet.of();
- }
-
public void start() {
LOG.info("Starting Remote RPC service...");
rpcManager = actorSystem.actorOf(RpcManager.props(rpcProvisionRegistry, rpcService, config),
public void start() {
LOG.info("Starting Remote RPC service...");
rpcManager = actorSystem.actorOf(RpcManager.props(rpcProvisionRegistry, rpcService, config),
import akka.actor.ActorSystem;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcProviderService;
import akka.actor.ActorSystem;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcProviderService;
+import org.opendaylight.controller.md.sal.dom.api.DOMRpcService;
public class RemoteRpcProviderFactory {
public static RemoteRpcProvider createInstance(final DOMRpcProviderService rpcProviderService,
public class RemoteRpcProviderFactory {
public static RemoteRpcProvider createInstance(final DOMRpcProviderService rpcProviderService,
- final ActorSystem actorSystem, final RemoteRpcProviderConfig config) {
+ final DOMRpcService rpcService, final ActorSystem actorSystem, final RemoteRpcProviderConfig config) {
- return new RemoteRpcProvider(actorSystem, rpcProviderService, config);
+ return new RemoteRpcProvider(actorSystem, rpcProviderService, rpcService, config);
<bean id="remoteRpcProvider" class="org.opendaylight.controller.remote.rpc.RemoteRpcProviderFactory"
factory-method="createInstance" init-method="start" destroy-method="close">
<argument ref="domRpcRegistry"/>
<bean id="remoteRpcProvider" class="org.opendaylight.controller.remote.rpc.RemoteRpcProviderFactory"
factory-method="createInstance" init-method="start" destroy-method="close">
<argument ref="domRpcRegistry"/>
+ <argument ref="domRpcService"/>
<argument ref="actorSystem"/>
<argument ref="remoteRpcProviderConfig"/>
<argument ref="actorSystem"/>
<argument ref="remoteRpcProviderConfig"/>
- <property name="rpcService" ref="domRpcService"/>
import org.opendaylight.controller.md.sal.dom.api.DOMRpcIdentifier;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcResult;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcService;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcIdentifier;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcResult;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcService;
-import org.opendaylight.controller.sal.core.api.Broker;
import org.opendaylight.yangtools.yang.common.QName;
import org.opendaylight.yangtools.yang.common.RpcError;
import org.opendaylight.yangtools.yang.common.RpcError.ErrorSeverity;
import org.opendaylight.yangtools.yang.common.QName;
import org.opendaylight.yangtools.yang.common.RpcError;
import org.opendaylight.yangtools.yang.common.RpcError.ErrorSeverity;
protected JavaTestKit rpcRegistry1Probe;
protected ActorRef rpcInvoker2;
protected JavaTestKit rpcRegistry2Probe;
protected JavaTestKit rpcRegistry1Probe;
protected ActorRef rpcInvoker2;
protected JavaTestKit rpcRegistry2Probe;
- protected Broker.ProviderSession brokerSession;
protected SchemaContext schemaContext;
protected RemoteRpcImplementation remoteRpcImpl1;
protected RemoteRpcImplementation remoteRpcImpl2;
protected SchemaContext schemaContext;
protected RemoteRpcImplementation remoteRpcImpl1;
protected RemoteRpcImplementation remoteRpcImpl2;
package org.opendaylight.controller.remote.rpc;
import static org.mockito.Mockito.mock;
package org.opendaylight.controller.remote.rpc;
import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
import akka.actor.ActorRef;
import akka.actor.ActorSystem;
import akka.actor.ActorRef;
import akka.actor.ActorSystem;
import org.junit.Test;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcProviderService;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcService;
import org.junit.Test;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcProviderService;
import org.opendaylight.controller.md.sal.dom.api.DOMRpcService;
-import org.opendaylight.controller.sal.core.api.Broker;
import scala.concurrent.Await;
import scala.concurrent.duration.Duration;
import scala.concurrent.Await;
import scala.concurrent.duration.Duration;
@Test
public void testRemoteRpcProvider() throws Exception {
try (final RemoteRpcProvider rpcProvider = new RemoteRpcProvider(system, mock(DOMRpcProviderService.class),
@Test
public void testRemoteRpcProvider() throws Exception {
try (final RemoteRpcProvider rpcProvider = new RemoteRpcProvider(system, mock(DOMRpcProviderService.class),
- new RemoteRpcProviderConfig(system.settings().config()))) {
- final Broker.ProviderSession session = mock(Broker.ProviderSession.class);
- when(session.getService(DOMRpcService.class)).thenReturn(mock(DOMRpcService.class));
+ mock(DOMRpcService.class), new RemoteRpcProviderConfig(system.settings().config()))) {
- rpcProvider.onSessionInitiated(session);
final ActorRef actorRef = Await.result(
system.actorSelection(moduleConfig.getRpcManagerPath()).resolveOne(
final ActorRef actorRef = Await.result(
system.actorSelection(moduleConfig.getRpcManagerPath()).resolveOne(