Fix NPE in OF plugin Topology Service shim 30/1730/2
authorYevgeny Khodorkovsky <ykhodork@cisco.com>
Mon, 7 Oct 2013 17:25:56 +0000 (10:25 -0700)
committerGerrit Code Review <gerrit@opendaylight.org>
Tue, 8 Oct 2013 21:28:25 +0000 (21:28 +0000)
This fixes a NPE that occurs in cluster mode with multiple containers

Change-Id: Ic852cb41f6f65ef5812f9d3f1729434533ce0f5a
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
opendaylight/protocol_plugins/openflow/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/internal/TopologyServiceShim.java

index 86583ace0a0f540b5347accdeb3992dcb30961fd..bb5681b2dff0dbc988407885fa6b65599617617a 100644 (file)
@@ -131,8 +131,11 @@ public class TopologyServiceShim implements IDiscoveryListener,
                     if (notifyListeners) {
                         for (String container : teuMap.keySet()) {
                             // notify the listener
-                            topologyServiceShimListeners.get(container)
-                                    .edgeUpdate(teuMap.get(container));
+                            ITopologyServiceShimListener l = topologyServiceShimListeners.get(container);
+                            // container topology service may not have come up yet
+                            if (l != null) {
+                                l.edgeUpdate(teuMap.get(container));
+                            }
                         }
                     }