Use instanceof pattern 17/101217/1
authorRobert Varga <robert.varga@pantheon.tech>
Wed, 18 May 2022 09:41:03 +0000 (11:41 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Wed, 18 May 2022 09:41:03 +0000 (11:41 +0200)
We have a few places where we check-and-cast, use an instanceof pattern
for that.

Change-Id: I6acba1b1b2167e4e81a33efad4621ba5973ca66b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java

index 2778a11a2703927fc760c634e705c09b520e7ce7..c82ed8b78e5fc98282de45e6953ade1aa225bf57 100644 (file)
@@ -493,8 +493,7 @@ public abstract class AbstractLeader extends AbstractRaftActorBehavior {
             return this;
         }
 
-        if (message instanceof RaftRPC) {
-            RaftRPC rpc = (RaftRPC) message;
+        if (message instanceof RaftRPC rpc) {
             // If RPC request or response contains term T > currentTerm:
             // set currentTerm = T, convert to follower (ยง5.1)
             // This applies to all RPC messages and responses
@@ -525,8 +524,7 @@ public abstract class AbstractLeader extends AbstractRaftActorBehavior {
             beforeSendHeartbeat();
             sendHeartBeat();
             scheduleHeartBeat(context.getConfigParams().getHeartBeatInterval());
-        } else if (message instanceof SendInstallSnapshot) {
-            SendInstallSnapshot sendInstallSnapshot = (SendInstallSnapshot) message;
+        } else if (message instanceof SendInstallSnapshot sendInstallSnapshot) {
             setSnapshotHolder(new SnapshotHolder(sendInstallSnapshot.getSnapshot(),
                 sendInstallSnapshot.getSnapshotBytes()));
             sendInstallSnapshot();