Add a private modifiers to command arguments in clustering-test-app 90/97490/2
authorDominik Vrbovsky <dominik.vrbovsky@pantheon.tech>
Tue, 14 Sep 2021 14:07:12 +0000 (16:07 +0200)
committerRobert Varga <nite@hq.sk>
Wed, 15 Sep 2021 10:03:54 +0000 (10:03 +0000)
Change-Id: I29e188d39a7dc507c0f9f61f086e699522757dc5
Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>
18 files changed:
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/RegisterOwnershipCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/StressTestCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/UnregisterOwnershipCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/car/purchase/BuyCarCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/AddShardReplicaCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/CheckPublishNotificationsCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterBoundConstantCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterConstantCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterDefaultConstantCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RegisterSingletonConstantCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/RemoveShardReplicaCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/ShutdownShardReplicaCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/StartPublishNotificationsCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/SubscribeYnlCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/UnregisterBoundConstantCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/UnsubscribeYnlCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/odl/mdsal/lowlevel/control/WriteTransactionsCommand.java
opendaylight/md-sal/samples/clustering-test-app/karaf-cli/src/main/java/org/opendaylight/clustering/it/karaf/cli/people/AddPersonCommand.java

index 60cc0989d94f3f9278b28d5fc6634310d46790eb..5af5cd66d9e2420e148a754e48cf7901741d9797 100644 (file)
@@ -24,7 +24,7 @@ public class RegisterOwnershipCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "car-id", required = true)
-    String carId;
+    private String carId;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index 6b9e64ad7392cfb83cf6fe47e2734480e4ccbd25..f3bf816d6f46a445b2c51a309afd5617aa286187 100644 (file)
@@ -26,9 +26,9 @@ public class StressTestCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "rate", required = true)
-    int rate;
+    private int rate;
     @Argument(index = 1, name = "count", required = true)
-    long count;
+    private long count;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index e699139738336bad4da05c8c2c371b5c558655fa..bb8bf0e14a5dfac7b6908153f62374dd7e772023 100644 (file)
@@ -25,7 +25,7 @@ public class UnregisterOwnershipCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "car-id", required = true)
-    String carId;
+    private String carId;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index f06d71f0dbb1450148f350aa4fe2c37778e19569..3290f9de82f7deb2e7a7e4acd5b5ca8be04d63a8 100644 (file)
@@ -32,9 +32,9 @@ public class BuyCarCommand extends AbstractRpcAction {
     @Argument(index = 0, name = "person-ref", required = true)
     String personRef;
     @Argument(index = 1, name = "car-id", required = true)
-    CarId carId;
+    private CarId carId;
     @Argument(index = 2, name = "person-id", required = true)
-    PersonId personId;
+    private PersonId personId;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index 3280a5cc50c4366e633c4af6612d3878e553fd99..4169f70de063248a043e3f911e5a100f0f4f80a1 100644 (file)
@@ -24,7 +24,7 @@ public class AddShardReplicaCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "shard-name", required = true)
-    String shardName;
+    private String shardName;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index 818a9f9d5597a9deeb8e6b32c8257a7ac875f024..fe8cf7e1a1eb1940d1a4f053c773ac8c3e54cc76 100644 (file)
@@ -25,7 +25,7 @@ public class CheckPublishNotificationsCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "id", required = true)
-    String id;
+    private String id;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index 9fc92a3b19237948360a99162d98be1bec0bc62b..ff9105304cb541e9f2024a3532a8ee995fd0fb5b 100644 (file)
@@ -27,9 +27,9 @@ public class RegisterBoundConstantCommand extends AbstractRpcAction {
     @Reference
     private InstanceIdentifierSupport iidSupport;
     @Argument(index =  0, name = "context", required = true)
-    String context;
+    private String context;
     @Argument(index =  1, name = "constant", required = true)
-    String constant;
+    private String constant;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index e9a9ce938f0925fd1ec09e7391c1ec75bd85732c..b1149493973adcf6e724c201d1643c0595f4e91d 100644 (file)
@@ -24,7 +24,7 @@ public class RegisterConstantCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index =  0, name = "constant", required = true)
-    String constant;
+    private String constant;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index 8aac81265d60d3bdf54b25a9e7dde5d7e136a2e9..4095c3c29f5f4e86e67e4efa3f529c1aa5f363f3 100644 (file)
@@ -24,7 +24,7 @@ public class RegisterDefaultConstantCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index =  0, name = "constant", required = true)
-    String constant;
+    private String constant;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index d5054c069c4237c3f2fb685ad7bfd00dab1ff3f7..64be2ed57711721ff7526f1d5516b9b3767ef23a 100644 (file)
@@ -25,7 +25,7 @@ public class RegisterSingletonConstantCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "constant", required = true)
-    String constant;
+    private String constant;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index fad24dda027d8dc99eeaf5275906d8990a8a487b..2565156812814441352c3977dcd6bcc7751db5b3 100644 (file)
@@ -24,7 +24,7 @@ public class RemoveShardReplicaCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "shard-name", required = true)
-    String shardName;
+    private String shardName;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index 1a75b5b9f16b5b4d528cf24cb69a39ccedc0fc21..f8f025370e7b8a906a847648984f15237896e0c7 100644 (file)
@@ -24,7 +24,7 @@ public class ShutdownShardReplicaCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "shard-name", required = true)
-    String shardName;
+    private String shardName;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index bf1770840160befef5a525449bb43f8c77fedac4..68be7e30be4ec361062bab552730122cdb61aeda 100644 (file)
@@ -26,11 +26,11 @@ public class StartPublishNotificationsCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "id", required = true)
-    String id;
+    private String id;
     @Argument(index = 1, name = "seconds", required = true)
-    long seconds;
+    private long seconds;
     @Argument(index = 2, name = "notifications-per-second", required = true)
-    long notificationsPerSecond;
+    private long notificationsPerSecond;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index 523650ec782f75ddd5e431530ef54058d0da5354..00e6fa4c15f14069a8237786c328868737324015 100644 (file)
@@ -24,7 +24,7 @@ public class SubscribeYnlCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "id", required = true)
-    String id;
+    private String id;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index 76dc4d50f4cd2cb8a54860d669f2d5831fc5daaf..3cc086efa677bd1a874357399e8b42c6e5c83138 100644 (file)
@@ -27,7 +27,7 @@ public class UnregisterBoundConstantCommand extends AbstractRpcAction {
     @Reference
     private InstanceIdentifierSupport iidSupport;
     @Argument(index = 0, name = "context", required = true)
-    String context;
+    private String context;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index e9d110425823347bada9db227ed6b030a8ee8251..cd01e0cc1d99d9a9c4e11425e81f0b3179764b6c 100644 (file)
@@ -24,7 +24,7 @@ public class UnsubscribeYnlCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "id", required = true)
-    String id;
+    private String id;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index 60288cdc196b9a43091822f43f2b6f210ef6aced..ad90f8733a8f326a653d2527b962c565e8f169e8 100644 (file)
@@ -25,13 +25,13 @@ public class WriteTransactionsCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "id", required = true)
-    String id;
+    private String id;
     @Argument(index = 1, name = "seconds", required = true)
-    long seconds;
+    private long seconds;
     @Argument(index = 2, name = "trasactions-per-second", required = true)
-    long transactionsPerSecond;
+    private long transactionsPerSecond;
     @Argument(index = 3, name = "chained-transations", required = true)
-    boolean chainedTransactions;
+    private boolean chainedTransactions;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {
index 037b122a83fc969229bddb14825411013cfe78a2..b6697f5659047e8056d77447b994779a4a6c4ca3 100644 (file)
@@ -26,15 +26,15 @@ public class AddPersonCommand extends AbstractRpcAction {
     @Reference
     private RpcConsumerRegistry rpcService;
     @Argument(index = 0, name = "id", required = true)
-    PersonId id;
+    private PersonId id;
     @Argument(index = 1, name = "gender", required = true)
-    String gender;
+    private String gender;
     @Argument(index = 2, name = "age", required = true)
-    long age;
+    private long age;
     @Argument(index = 3, name = "address", required = true)
-    String address;
+    private String address;
     @Argument(index = 4, name = "contactNo", required = true)
-    String contactNo;
+    private String contactNo;
 
     @Override
     protected ListenableFuture<? extends RpcResult<?>> invokeRpc() {