Fix for validity check of Action field in FlowConfig 57/1757/2
authorPramila Singh <pramisin@cisco.com>
Tue, 8 Oct 2013 22:49:33 +0000 (15:49 -0700)
committerGerrit Code Review <gerrit@opendaylight.org>
Wed, 9 Oct 2013 15:38:40 +0000 (15:38 +0000)
Change-Id: I9ec131df550a5242227c049ec813c022829d1b4d
Signed-off-by: Pramila Singh <pramisin@cisco.com>
opendaylight/forwardingrulesmanager/api/src/main/java/org/opendaylight/controller/forwardingrulesmanager/FlowConfig.java

index c57dca2a88c368185c81d8d2c82476e37dc4f968..43b0252df7b5c8aa83df94866632887286b44252 100644 (file)
@@ -22,7 +22,6 @@ import javax.xml.bind.annotation.XmlAccessorType;
 import javax.xml.bind.annotation.XmlElement;
 import javax.xml.bind.annotation.XmlRootElement;
 
-import org.opendaylight.controller.forwardingrulesmanager.FlowEntry;
 import org.opendaylight.controller.sal.action.Action;
 import org.opendaylight.controller.sal.action.ActionType;
 import org.opendaylight.controller.sal.action.Controller;
@@ -862,6 +861,9 @@ public class FlowConfig implements Serializable {
                                     return new Status(StatusCode.BADREQUEST, msg);
                                 }
                             }
+                        } else {
+                            String msg = String.format("Output port %s is not valid", t);
+                            return new Status(StatusCode.BADREQUEST, msg);
                         }
                     }
                     continue;