return "null";
}
- String ret = "";
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
for (int i = 0; i < bytes.length; i++) {
- if (i > 0) {
- ret += ":";
- }
short u8byte = (short) (bytes[i] & 0xff);
String tmp = Integer.toHexString(u8byte);
if (tmp.length() == 1) {
}
buf.append(tmp);
}
- ret = buf.toString();
- return ret;
+ return buf.toString();
}
public static String longToHexString(final long val) {
char arr[] = Long.toHexString(val).toCharArray();
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
// prepend the right number of leading zeros
int i = 0;
for (; i < (16 - arr.length); i++) {
if (bytes == null) {
return "null";
}
- String ret = "";
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
for (int i = 0; i < bytes.length; i++) {
if (i > 0) {
buf.append(":");
}
buf.append(tmp);
}
- ret = buf.toString();
- return ret;
+ return buf.toString();
}
}
--- /dev/null
+/*
+ * Copyright (c) 2013 Cisco Systems, Inc. and others. All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ */
+package org.opendaylight.controller.liblldp;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class HexEncodeTest {
+ @Test
+ public void testbytesToHexString() {
+ byte[] bytes1 = { (byte) 0x01, (byte) 0x02, (byte) 0x03 };
+ String str1 = HexEncode.bytesToHexString(bytes1);
+ Assert.assertTrue(str1.equals("010203"));
+
+ byte[] bytes2 = { (byte) 0x11, (byte) 0x22, (byte) 0x33 };
+ String str2 = HexEncode.bytesToHexString(bytes2);
+ Assert.assertFalse(str2.equals("010203"));
+
+ }
+
+ @Test
+ public void testLongToHexString() {
+ long value1 = 12345678L;
+ String str1 = HexEncode.longToHexString(value1);
+ Assert.assertTrue(str1.equals("00:00:00:00:00:bc:61:4e"));
+
+ long value2 = 98765432L;
+ String str2 = HexEncode.longToHexString(value2);
+ Assert.assertFalse(str2.equals("00:44:33:22:11:bc:61:4e"));
+
+ }
+
+ @Test
+ public void testBytesFromHexString() {
+ String byteStr1 = "00:11:22:33:44:55";
+ byte byteArray1[] = HexEncode.bytesFromHexString(byteStr1);
+
+ Assert.assertTrue(byteArray1[0] == (byte) 0x0);
+ Assert.assertTrue(byteArray1[1] == (byte) 0x11);
+ Assert.assertTrue(byteArray1[2] == (byte) 0x22);
+ Assert.assertTrue(byteArray1[3] == (byte) 0x33);
+ Assert.assertTrue(byteArray1[4] == (byte) 0x44);
+ Assert.assertTrue(byteArray1[5] == (byte) 0x55);
+
+ String byteStr2 = "00:11:22:33:44:55";
+ byte byteArray2[] = HexEncode.bytesFromHexString(byteStr2);
+
+ Assert.assertFalse(byteArray2[0] == (byte) 0x55);
+ Assert.assertFalse(byteArray2[1] == (byte) 0x44);
+ Assert.assertFalse(byteArray2[2] == (byte) 0x33);
+ Assert.assertFalse(byteArray2[3] == (byte) 0x22);
+ Assert.assertFalse(byteArray2[4] == (byte) 0x11);
+ Assert.assertFalse(byteArray2[5] == (byte) 0x0);
+
+ }
+}
@Override
public String toString() {
- final StringBuffer sb = new StringBuffer("CommitJMXNotification{");
- sb.append('}');
- return sb.toString();
+ return "CommitJMXNotification{}";
}
/**
@Override
public String toString() {
- final StringBuffer sb = new StringBuffer("MappedDependency{");
+ final StringBuilder sb = new StringBuilder("MappedDependency{");
sb.append("namespace='").append(namespace).append('\'');
sb.append(", serviceName='").append(serviceName).append('\'');
sb.append(", refName='").append(refName).append('\'');
private Map<String, Map.Entry<ModuleFactory, BundleContext>> factories;
public HardcodedModuleFactoriesResolver(final BundleContext bundleContext, final ModuleFactory... list) {
- List<ModuleFactory> factoryList = Arrays.asList(list);
- this.factories = new HashMap<>(factoryList.size());
+ this.factories = new HashMap<>(list.length);
for (ModuleFactory moduleFactory : list) {
- StringBuffer errors = new StringBuffer();
String moduleName = moduleFactory.getImplementationName();
if (moduleName == null || moduleName.isEmpty()) {
throw new IllegalStateException(
"Invalid implementation name for " + moduleFactory);
}
- String error = null;
Map.Entry<ModuleFactory, BundleContext> conflicting = factories.get(moduleName);
- if (conflicting != null) {
- error = String
- .format("Module name is not unique. Found two conflicting factories with same name '%s': " +
- "\n\t%s\n\t%s\n", moduleName, conflicting.getKey(), moduleFactory);
-
- }
-
- if (error == null) {
- factories.put(moduleName, new AbstractMap.SimpleEntry<>(moduleFactory,
- bundleContext));
+ if (conflicting == null) {
+ factories.put(moduleName, new AbstractMap.SimpleEntry<>(moduleFactory, bundleContext));
} else {
- errors.append(error);
- }
- if (errors.length() > 0) {
- throw new IllegalArgumentException(errors.toString());
+ throw new IllegalArgumentException(String.format(
+ "Module name is not unique. Found two conflicting factories with same name '%s':\n\t%s\n\t%s\n",
+ moduleName, conflicting.getKey(), moduleFactory));
}
}
}
@Override
public String toString() {
- final StringBuffer sb = new StringBuffer("XmlDirectoryPersister{");
- sb.append("storage=").append(storage);
- sb.append('}');
- return sb.toString();
+ return "XmlDirectoryPersister{storage=" + storage + "}";
}
}
\ No newline at end of file
@Override
public String toString() {
- final StringBuffer sb = new StringBuffer();
+ final StringBuilder sb = new StringBuilder();
sb.append(type).append(' ');
sb.append(name).append('(');
@Override
public String toString() {
- final StringBuffer sb = new StringBuffer();
- sb.append(type).append(' ');
- sb.append(name);
- return sb.toString();
+ return type + " " + name;
}
}
}
* @return
*/
public static String wildcardToRegex(final String wildcard){
- final StringBuffer s = new StringBuffer(wildcard.length());
+ final StringBuilder s = new StringBuilder(wildcard.length());
s.append('^');
for (final char c : wildcard.toCharArray()) {
switch(c) {
Code Review / controller.git / commitdiff