Fix checkstyle warnings in config-api 91/12991/1
authorMarian Dubai <mdubai@cisco.com>
Thu, 20 Nov 2014 09:51:24 +0000 (10:51 +0100)
committerMarian Dubai <mdubai@cisco.com>
Thu, 20 Nov 2014 14:21:43 +0000 (15:21 +0100)
Change-Id: I56eedb15f3c5892731a757bdb06c34d9d15efab7
Signed-off-by: Marian Dubai <mdubai@cisco.com>
16 files changed:
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/ConfigRegistry.java
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/ConfigTransactionController.java
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/DynamicMBeanWithInstance.java
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/IdentityAttributeRef.java
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/LookupRegistry.java
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/ServiceReferenceReadableRegistry.java
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/jmx/CommitStatus.java
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/jmx/ObjectNameUtil.java
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/spi/Module.java
opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/spi/ModuleFactory.java
opendaylight/config/config-api/src/test/java/org/opendaylight/controller/config/api/IdentityAttributeRefTest.java
opendaylight/config/config-api/src/test/java/org/opendaylight/controller/config/api/JmxAttributeTest.java
opendaylight/config/config-api/src/test/java/org/opendaylight/controller/config/api/JmxAttributeValidationExceptionTest.java
opendaylight/config/config-api/src/test/java/org/opendaylight/controller/config/api/ModuleIdentifierTest.java
opendaylight/config/config-api/src/test/java/org/opendaylight/controller/config/api/ValidationExceptionTest.java
opendaylight/config/config-api/src/test/java/org/opendaylight/controller/config/api/jmx/ObjectNameUtilTest.java

index d81c48a6020b6854cc75603a0513a27f8c41da9b..5c9ed8767c38986587052ea5d588e3b079338979 100644 (file)
@@ -9,9 +9,7 @@ package org.opendaylight.controller.config.api;
 
 import java.util.List;
 import java.util.Set;
-
 import javax.management.ObjectName;
-
 import org.opendaylight.controller.config.api.jmx.CommitStatus;
 import org.opendaylight.controller.config.api.jmx.constants.ConfigRegistryConstants;
 
index 264751318c3570415f412a82b4df7d992853c451..8afc80a4f36971edbf1bd562e68dd684506ff7ad 100644 (file)
@@ -8,7 +8,6 @@
 package org.opendaylight.controller.config.api;
 
 import java.util.Set;
-
 import javax.management.InstanceAlreadyExistsException;
 import javax.management.InstanceNotFoundException;
 import javax.management.ObjectName;
index 48aa6ae64667f502a39cb636ae319ef7617db478..e1462b6b703d046a7c46f72611840220f514ed8e 100644 (file)
@@ -7,9 +7,8 @@
  */
 package org.opendaylight.controller.config.api;
 
-import org.opendaylight.yangtools.yang.binding.BaseIdentity;
-
 import java.beans.ConstructorProperties;
+import org.opendaylight.yangtools.yang.binding.BaseIdentity;
 
 public final class IdentityAttributeRef {
 
index 376ecdb52a2f7324a1c5a9d02e2c9dea3f871a80..b90fc9c034753f467cd41a927c8afa3dbdf493a3 100644 (file)
@@ -7,9 +7,9 @@
  */
 package org.opendaylight.controller.config.api;
 
+import java.util.Set;
 import javax.management.InstanceNotFoundException;
 import javax.management.ObjectName;
-import java.util.Set;
 
 public interface LookupRegistry {
 
index d7e94e8a7631d64a55eb43729cfc83d6bd823e6a..a364e54bff584363405b2b88337b65301a000add 100644 (file)
@@ -7,10 +7,10 @@
  */
 package org.opendaylight.controller.config.api;
 
-import javax.management.InstanceNotFoundException;
-import javax.management.ObjectName;
 import java.util.Map;
 import java.util.Set;
+import javax.management.InstanceNotFoundException;
+import javax.management.ObjectName;
 
 public interface ServiceReferenceReadableRegistry {
 
index 4f9ea7ac6b57521697f85ca7e4cde7930601ad1e..3b724e8ebe271a32aaca781144fc4fc5eba9fe35 100644 (file)
@@ -7,16 +7,16 @@
  */
 package org.opendaylight.controller.config.api.jmx;
 
-import javax.annotation.concurrent.Immutable;
-import javax.management.ObjectName;
 import java.beans.ConstructorProperties;
 import java.util.Collections;
 import java.util.List;
+import javax.annotation.concurrent.Immutable;
+import javax.management.ObjectName;
 
 @Immutable
 public class CommitStatus {
     private final List<ObjectName> newInstances, reusedInstances,
-            recreatedInstances;
+    recreatedInstances;
 
     /**
      * @param newInstances       newly created instances
index c23a0cbf69850f364113a93579e79d9dc952ae5c..ee23206eebf35fba353d82581f3513e5ffb7f808 100644 (file)
@@ -7,12 +7,6 @@
  */
 package org.opendaylight.controller.config.api.jmx;
 
-import org.opendaylight.controller.config.api.ModuleIdentifier;
-import org.opendaylight.controller.config.api.jmx.constants.ConfigRegistryConstants;
-
-import javax.annotation.concurrent.ThreadSafe;
-import javax.management.MalformedObjectNameException;
-import javax.management.ObjectName;
 import java.util.Arrays;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -20,6 +14,11 @@ import java.util.Hashtable;
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Set;
+import javax.annotation.concurrent.ThreadSafe;
+import javax.management.MalformedObjectNameException;
+import javax.management.ObjectName;
+import org.opendaylight.controller.config.api.ModuleIdentifier;
+import org.opendaylight.controller.config.api.jmx.constants.ConfigRegistryConstants;
 
 /**
  * Provides ObjectName creation. Each created ObjectName consists of domain that
index 1b16ec828432624b120228c4cacfd91479a0406e..b557108d4d00a39b988d7f82e5e4bb3bc41957b3 100644 (file)
@@ -7,11 +7,10 @@
  */
 package org.opendaylight.controller.config.spi;
 
+import javax.annotation.concurrent.NotThreadSafe;
 import org.opendaylight.controller.config.api.ModuleIdentifier;
 import org.opendaylight.yangtools.concepts.Identifiable;
 
-import javax.annotation.concurrent.NotThreadSafe;
-
 
 /**
  * Represents one service that is to be configured. These methods need to be
index c86b38149377733fdc59d3281f97a49d31dcd3d6..e28608a198f2ea6346397fa86f28b2cf833d5db6 100644 (file)
@@ -7,14 +7,13 @@
  */
 package org.opendaylight.controller.config.spi;
 
+import java.util.Set;
 import org.opendaylight.controller.config.api.DependencyResolver;
 import org.opendaylight.controller.config.api.DependencyResolverFactory;
 import org.opendaylight.controller.config.api.DynamicMBeanWithInstance;
 import org.opendaylight.controller.config.api.annotations.AbstractServiceInterface;
 import org.osgi.framework.BundleContext;
 
-import java.util.Set;
-
 /**
  * Factory which creates {@link Module instances. An instance of this interface
  * needs to be exported into the OSGi Service Registry. Such an instance
index 91e1f14849c03364f57f67b28eee5ff2d6017f8c..9cb64c5cc8987d85584f8ada4640edfe2406ad21 100644 (file)
@@ -4,6 +4,7 @@ import static org.mockito.Mockito.doNothing;
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
+
 import org.junit.Assert;
 import org.junit.Test;
 import org.opendaylight.yangtools.yang.binding.BaseIdentity;
index 39609a0e16d606171eff825fa57d7a75739d90a0..d82d8f99a0e850aa0f4386f1375af9c553e31e81 100644 (file)
@@ -1,11 +1,11 @@
 package org.opendaylight.controller.config.api;
 
-import org.junit.Test;
-
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotEquals;
 import static org.junit.Assert.assertNotNull;
 
+import org.junit.Test;
+
 public class JmxAttributeTest {
 
     @Test
index 9ff74052579f14f70be71d9df771d61fccd06eb4..313b225f986ed535c454fac757920f3745361d1c 100644 (file)
@@ -2,6 +2,7 @@ package org.opendaylight.controller.config.api;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertThat;
+
 import com.google.common.collect.Lists;
 import java.nio.file.AccessDeniedException;
 import java.util.ArrayList;
index 2771b407f46725461088d99e9e1a1d1c8dd7a82e..c37b61d997b789a2cf1924010cb5ccbde1a6edf0 100644 (file)
@@ -2,6 +2,7 @@ package org.opendaylight.controller.config.api;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotEquals;
+
 import org.junit.Test;
 
 public class ModuleIdentifierTest {
index 8b4f2fe25875149bae70d0d80157961549939c80..bc9a8c71ba0f6605b19785b50dc89447825d2a31 100644 (file)
@@ -5,6 +5,7 @@ import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertThat;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
+
 import com.google.common.collect.Lists;
 import java.util.Map;
 import org.junit.Assert;
index e69ff921ccc4975994d8c542a738d84f33f96c34..ad1a53a5436b8572184275c473f47d7b1f11502b 100644 (file)
@@ -11,6 +11,7 @@ import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
+
 import com.google.common.base.Throwables;
 import com.google.common.collect.Maps;
 import java.util.HashMap;