Remove ABIVersion.MAGNESIUM 95/103495/12
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 1 Dec 2022 15:13:17 +0000 (16:13 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Wed, 10 May 2023 14:55:12 +0000 (16:55 +0200)
This ABI versions is quite inefficient in its serialization and has been
deprecated in the previous release. This patch completes its removal.

JIRA: CONTROLLER-2062
Change-Id: I03be0d6561c4db2893e6eb0fd95e3a35e655b76e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
128 files changed:
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/ABIVersion.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalHistoryRequestProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadPathTransactionRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionRequestProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientFailure.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientFailureProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccess.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CreateLocalHistoryRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CreateLocalHistoryRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ETS.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccess.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ITSS.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceSuccess.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceSuccessProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailure.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccess.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/MTS.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionSuccess.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionSuccessProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/RTS.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccess.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/STS.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsRequestV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsResponse.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsResponseProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TAS.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TCCS.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TCS.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TPCS.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TPS.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccess.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccess.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccess.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailure.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccess.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeRequest.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeRequestProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponse.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponseProxyV1.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractEnvelopeProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractMessageProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractRequestFailureProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractRequestProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseEnvelopeProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractSuccessProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Envelope.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelope.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Message.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RE.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelope.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelopeProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SE.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelope.java
opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelopeProxy.java [deleted file]
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/ABIVersionTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/AbortLocalTransactionRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalTransactionRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/AbstractRequestFailureTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/AbstractRequestSuccessTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/CommitLocalTransactionRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ConnectClientFailureTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestEmptyTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionSuccessTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessNoDataTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsResponseTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponseTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/AbstractRequestTest.java
opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeTest.java
opendaylight/md-sal/cds-access-client/src/test/java/org/opendaylight/controller/cluster/access/client/ConnectingClientConnectionTest.java
opendaylight/md-sal/cds-access-client/src/test/java/org/opendaylight/controller/cluster/access/client/ConnectionEntryTest.java
opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/AbstractShardBackendResolver.java

index 365af8ce0f078c8937e9fbb890b0fe2374fe6e41..119d477cc6e77df384c1807af1490094e084fb1a 100644 (file)
@@ -39,22 +39,11 @@ public enum ABIVersion implements WritableObject {
     // BORON was 5
     // NEON_SR2 was 6
     // SODIUM_SR1 was 7
+    // MAGNESIUM was 8
+
     /**
-     * Oldest ABI version we support. The messages remain the same as {@code BORON}, but messages bearing QNames in any
-     * shape are using {@link NormalizedNodeStreamVersion#MAGNESIUM}, which improves encoding.
-     *
-     * @deprecated Support for this version is going to be removed in the next major version.
-     */
-    @Deprecated(since = "7.0.0", forRemoval = true)
-    MAGNESIUM(8) {
-        @Override
-        public NormalizedNodeStreamVersion getStreamVersion() {
-            return NormalizedNodeStreamVersion.MAGNESIUM;
-        }
-    },
-    /**
-     * Revised ABI version. The messages remain the same as {@link #MAGNESIUM}, the serialization proxies in use are
-     * flat objects without any superclasses.
+     * Oldest ABI version we support. The messages remain the same as {@code MAGNESIUM}, the serialization proxies in
+     * use are flat objects without any superclasses.
      */
     CHLORINE_SR2(9) {
         @Override
@@ -113,8 +102,7 @@ public enum ABIVersion implements WritableObject {
      */
     public static @NonNull ABIVersion valueOf(final short value) throws FutureVersionException, PastVersionException {
         return switch (Short.toUnsignedInt(value)) {
-            case 0, 1, 2, 3, 4, 6, 7 -> throw new PastVersionException(value, MAGNESIUM);
-            case 8 -> MAGNESIUM;
+            case 0, 1, 2, 3, 4, 6, 7, 8 -> throw new PastVersionException(value, CHLORINE_SR2);
             case 9 -> CHLORINE_SR2;
             default -> throw new FutureVersionException(value, CHLORINE_SR2);
         };
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalHistoryRequestProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalHistoryRequestProxy.java
deleted file mode 100644 (file)
index 0033e16..0000000
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-import org.opendaylight.controller.cluster.access.concepts.AbstractRequestProxy;
-import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier;
-
-/**
- * Abstract base class for serialization proxies associated with {@link LocalHistoryRequest}s.
- *
- * @param <T> Message type
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-abstract class AbstractLocalHistoryRequestProxy<T extends LocalHistoryRequest<T>>
-        extends AbstractRequestProxy<LocalHistoryIdentifier, T> implements LocalHistoryRequest.SerialForm<T> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    protected AbstractLocalHistoryRequestProxy() {
-        // For Externalizable
-    }
-
-    AbstractLocalHistoryRequestProxy(final T request) {
-        super(request);
-    }
-}
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadPathTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadPathTransactionRequestProxyV1.java
deleted file mode 100644 (file)
index 2df22ff..0000000
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * Copyright (c) 2017 Pantheon Technologies, s.r.o. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Abstract base class for serialization proxies associated with {@link AbstractReadTransactionRequest}s. It implements
- * the initial (Boron) serialization format.
- *
- * @param <T> Message type
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-abstract class AbstractReadPathTransactionRequestProxyV1<T extends AbstractReadPathTransactionRequest<T>>
-        extends AbstractReadTransactionRequestProxyV1<T> implements AbstractReadPathTransactionRequest.SerialForm<T> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    protected AbstractReadPathTransactionRequestProxyV1() {
-        // For Externalizable
-    }
-
-    AbstractReadPathTransactionRequestProxyV1(final T request) {
-        super(request);
-    }
-}
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequestProxyV1.java
deleted file mode 100644 (file)
index 5986482..0000000
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Abstract base class for serialization proxies associated with {@link AbstractReadTransactionRequest}s. It implements
- * the initial (Boron) serialization format.
- *
- * @param <T> Message type
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-abstract class AbstractReadTransactionRequestProxyV1<T extends AbstractReadTransactionRequest<T>>
-        extends AbstractTransactionRequestProxy<T> implements AbstractReadTransactionRequest.SerialForm<T> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    protected AbstractReadTransactionRequestProxyV1() {
-        // For Externalizable
-    }
-
-    AbstractReadTransactionRequestProxyV1(final T request) {
-        super(request);
-    }
-}
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionRequestProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionRequestProxy.java
deleted file mode 100644 (file)
index df14a37..0000000
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-import org.opendaylight.controller.cluster.access.concepts.AbstractRequestProxy;
-import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
-
-/**
- * Abstract base class for serialization proxies associated with {@link TransactionRequest}s.
- *
- * @param <T> Message type
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-abstract class AbstractTransactionRequestProxy<T extends TransactionRequest<T>>
-        extends AbstractRequestProxy<TransactionIdentifier, T> implements TransactionRequest.SerialForm<T> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    AbstractTransactionRequestProxy() {
-        // For Externalizable
-    }
-
-    AbstractTransactionRequestProxy(final T request) {
-        super(request);
-    }
-}
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessProxy.java
deleted file mode 100644 (file)
index 65405b5..0000000
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-import org.opendaylight.controller.cluster.access.concepts.AbstractSuccessProxy;
-import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
-
-/**
- * Abstract base class for serialization proxies associated with {@link TransactionSuccess}es.
- *
- * @param <T> Message type
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-abstract class AbstractTransactionSuccessProxy<T extends TransactionSuccess<T>>
-        extends AbstractSuccessProxy<TransactionIdentifier, T> implements TransactionSuccess.SerialForm<T> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    AbstractTransactionSuccessProxy() {
-        // For Externalizable
-    }
-
-    AbstractTransactionSuccessProxy(final T request) {
-        super(request);
-    }
-}
index aa93708cd4d6a342e9a43aa6a786bc54874171d5..1157d1b6f888fc596e1cd42dcd2ca9796a889348 100644 (file)
@@ -44,7 +44,7 @@ public final class ConnectClientFailure extends RequestFailure<ClientIdentifier,
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new CCF(this) : new ConnectClientFailureProxyV1(this);
+        return new CCF(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientFailureProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientFailureProxyV1.java
deleted file mode 100644 (file)
index b718c8a..0000000
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-import org.opendaylight.controller.cluster.access.concepts.AbstractRequestFailureProxy;
-import org.opendaylight.controller.cluster.access.concepts.ClientIdentifier;
-
-/**
- * Serialization proxy for use with {@link ConnectClientFailure}. This class implements initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class ConnectClientFailureProxyV1 extends AbstractRequestFailureProxy<ClientIdentifier, ConnectClientFailure>
-        implements ConnectClientFailure.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 2688639416324657256L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public ConnectClientFailureProxyV1() {
-        // For Externalizable
-    }
-
-    ConnectClientFailureProxyV1(final ConnectClientFailure failure) {
-        super(failure);
-    }
-}
index 12fb0181d5f7e35be9424b8384deb07cd061d0a8..953fafefa89078871c7c207100199f5779af6f22 100644 (file)
@@ -90,7 +90,7 @@ public final class ConnectClientRequest extends Request<ClientIdentifier, Connec
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new CCR(this) : new ConnectClientRequestProxyV1(this);
+        return new CCR(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequestProxyV1.java
deleted file mode 100644 (file)
index 77575eb..0000000
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-import org.opendaylight.controller.cluster.access.concepts.AbstractRequestProxy;
-import org.opendaylight.controller.cluster.access.concepts.ClientIdentifier;
-
-/**
- * Externalizable proxy for use with {@link ConnectClientRequest}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class ConnectClientRequestProxyV1 extends AbstractRequestProxy<ClientIdentifier, ConnectClientRequest>
-        implements ConnectClientRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 8439729661327852159L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public ConnectClientRequestProxyV1() {
-        // for Externalizable
-    }
-
-    ConnectClientRequestProxyV1(final ConnectClientRequest request) {
-        super(request);
-    }
-}
index 72dd51d616d9f56deb925fcbe1a22389f2c96a8f..a96404511e1175efe4971a5554cc1855a9164496 100644 (file)
@@ -129,7 +129,7 @@ public final class ConnectClientSuccess extends RequestSuccess<ClientIdentifier,
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new CCS(this) : new ConnectClientSuccessProxyV1(this);
+        return new CCS(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessProxyV1.java
deleted file mode 100644 (file)
index be72166..0000000
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-import org.opendaylight.controller.cluster.access.concepts.AbstractSuccessProxy;
-import org.opendaylight.controller.cluster.access.concepts.ClientIdentifier;
-
-/**
- * Externalizable proxy for use with {@link ConnectClientSuccess}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class ConnectClientSuccessProxyV1 extends AbstractSuccessProxy<ClientIdentifier, ConnectClientSuccess>
-        implements ConnectClientSuccess.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public ConnectClientSuccessProxyV1() {
-        // For Externalizable
-    }
-
-    ConnectClientSuccessProxyV1(final ConnectClientSuccess success) {
-        super(success);
-    }
-}
index 2520aeefd4b4d1e639430cd9131dad98b5294800..b627bafa438cf005f723146fb316c91a3a0b1e90 100644 (file)
@@ -41,7 +41,7 @@ public final class CreateLocalHistoryRequest extends LocalHistoryRequest<CreateL
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new CHR(this) : new CreateLocalHistoryRequestProxyV1(this);
+        return new CHR(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CreateLocalHistoryRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CreateLocalHistoryRequestProxyV1.java
deleted file mode 100644 (file)
index 55d8f83..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link CreateLocalHistoryRequest}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class CreateLocalHistoryRequestProxyV1 extends AbstractLocalHistoryRequestProxy<CreateLocalHistoryRequest>
-        implements CreateLocalHistoryRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public CreateLocalHistoryRequestProxyV1() {
-        // For Externalizable
-    }
-
-    CreateLocalHistoryRequestProxyV1(final CreateLocalHistoryRequest request) {
-        super(request);
-    }
-}
index e70bd53654884e6fc5ca4b59c225dc75e6963047..5add5eb05451e9df6002b82772576780b3476abe 100644 (file)
@@ -38,7 +38,7 @@ public final class DestroyLocalHistoryRequest extends LocalHistoryRequest<Destro
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new DHR(this) : new DestroyLocalHistoryRequestProxyV1(this);
+        return new DHR(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequestProxyV1.java
deleted file mode 100644 (file)
index 06b49e3..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link DestroyLocalHistoryRequest}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class DestroyLocalHistoryRequestProxyV1 extends AbstractLocalHistoryRequestProxy<DestroyLocalHistoryRequest>
-        implements DestroyLocalHistoryRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public DestroyLocalHistoryRequestProxyV1() {
-        // For Externalizable
-    }
-
-    DestroyLocalHistoryRequestProxyV1(final DestroyLocalHistoryRequest request) {
-        super(request);
-    }
-}
index 8cfc5e29d84532d06787b359bacd98038d06edd3..ad8564b33a278bcf30a14011ee146926f571f056 100644 (file)
@@ -10,11 +10,16 @@ package org.opendaylight.controller.cluster.access.commands;
 import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 
+import java.io.IOException;
+import java.io.ObjectInput;
+import java.io.ObjectOutput;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+
 /**
  * Externalizable proxy for use with {@link ExistsTransactionSuccess}. It implements the Chlorine SR2 serialization
  * format.
  */
-final class ETS implements ExistsTransactionSuccess.SerialForm {
+final class ETS implements TransactionSuccess.SerialForm<ExistsTransactionSuccess> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -39,6 +44,17 @@ final class ETS implements ExistsTransactionSuccess.SerialForm {
         this.message = requireNonNull(message);
     }
 
+    @Override
+    public void writeExternal(final ObjectOutput out, final ExistsTransactionSuccess msg) throws IOException {
+        out.writeBoolean(msg.getExists());
+    }
+
+    @Override
+    public ExistsTransactionSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
+            final long sequence) throws IOException {
+        return new ExistsTransactionSuccess(target, sequence, in.readBoolean());
+    }
+
     @Override
     public Object readResolve() {
         return message();
index 1d16186af0b9f522e0ed392413b67c443cc4b7ae..06c2797ca41d8d7bd6f4e745902aa7e553859e55 100644 (file)
@@ -47,6 +47,6 @@ public final class ExistsTransactionRequest extends AbstractReadPathTransactionR
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new ETR(this) : new ExistsTransactionRequestProxyV1(this);
+        return new ETR(this);
     }
 }
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestProxyV1.java
deleted file mode 100644 (file)
index 09c1e0a..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link ExistsTransactionRequest}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class ExistsTransactionRequestProxyV1 extends AbstractReadPathTransactionRequestProxyV1<ExistsTransactionRequest>
-        implements ExistsTransactionRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public ExistsTransactionRequestProxyV1() {
-        // For Externalizable
-    }
-
-    ExistsTransactionRequestProxyV1(final ExistsTransactionRequest request) {
-        super(request);
-    }
-}
index ca5377051a4d5db83b969500d57b4eb873d29542..72dee3aefa365fd4a4fbee999e786574e4db6a31 100644 (file)
@@ -8,9 +8,6 @@
 package org.opendaylight.controller.cluster.access.commands;
 
 import com.google.common.base.MoreObjects.ToStringHelper;
-import java.io.IOException;
-import java.io.ObjectInput;
-import java.io.ObjectOutput;
 import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 
@@ -19,19 +16,6 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier
  * {@link #getExists()}.
  */
 public final class ExistsTransactionSuccess extends TransactionSuccess<ExistsTransactionSuccess> {
-    interface SerialForm extends TransactionSuccess.SerialForm<ExistsTransactionSuccess> {
-        @Override
-        default ExistsTransactionSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
-                final long sequence) throws IOException {
-            return new ExistsTransactionSuccess(target, sequence, in.readBoolean());
-        }
-
-        @Override
-        default void writeExternal(final ObjectOutput out, final ExistsTransactionSuccess msg) throws IOException {
-            out.writeBoolean(msg.getExists());
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -52,8 +36,8 @@ public final class ExistsTransactionSuccess extends TransactionSuccess<ExistsTra
     }
 
     @Override
-    protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new ETS(this) : new ExistsTransactionSuccessProxyV1(this);
+    protected ETS externalizableProxy(final ABIVersion version) {
+        return new ETS(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessProxyV1.java
deleted file mode 100644 (file)
index ce92ff4..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link ExistsTransactionSuccess}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class ExistsTransactionSuccessProxyV1 extends AbstractTransactionSuccessProxy<ExistsTransactionSuccess>
-        implements ExistsTransactionSuccess.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public ExistsTransactionSuccessProxyV1() {
-        // For Externalizable
-    }
-
-    ExistsTransactionSuccessProxyV1(final ExistsTransactionSuccess request) {
-        super(request);
-    }
-}
index 178992ab815a73e78ee4956c7bd6d0782692e9d7..7252d58a614477b070fca985e9fb5d0b6a8ed696 100644 (file)
@@ -10,11 +10,14 @@ package org.opendaylight.controller.cluster.access.commands;
 import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 
+import java.io.ObjectInput;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+
 /**
  * Externalizable proxy for use with {@link IncrementTransactionSequenceSuccess}. It implements the Chlorine SR2
  * serialization format.
  */
-final class ITSS implements IncrementTransactionSequenceSuccess.SerialForm {
+final class ITSS implements TransactionSuccess.SerialForm<IncrementTransactionSequenceSuccess> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -39,6 +42,12 @@ final class ITSS implements IncrementTransactionSequenceSuccess.SerialForm {
         this.message = requireNonNull(message);
     }
 
+    @Override
+    public IncrementTransactionSequenceSuccess readExternal(final ObjectInput it, final TransactionIdentifier target,
+            final long sequence) {
+        return new IncrementTransactionSequenceSuccess(target, sequence);
+    }
+
     @Override
     public Object readResolve() {
         return message();
index 55a435beeec09d1a280940b8f9a45cd05741ad3d..5695860e17cd7b0ba48d3dada038baf63c7620d8 100644 (file)
@@ -70,7 +70,7 @@ public final class IncrementTransactionSequenceRequest extends
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new ITSR(this) : new IncrementTransactionSequenceRequestProxyV1(this);
+        return new ITSR(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceRequestProxyV1.java
deleted file mode 100644 (file)
index d021c42..0000000
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * Copyright (c) 2017 Pantheon Technologies, s.r.o. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class IncrementTransactionSequenceRequestProxyV1
-        extends AbstractReadTransactionRequestProxyV1<IncrementTransactionSequenceRequest>
-        implements IncrementTransactionSequenceRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = -7345885599575376005L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public IncrementTransactionSequenceRequestProxyV1() {
-        // For Externalizable
-    }
-
-    IncrementTransactionSequenceRequestProxyV1(final IncrementTransactionSequenceRequest request) {
-        super(request);
-    }
-}
index e462edc4d80acca0a604c3b8ae3c25bd86c79e66..4f27f76563f7649594e067799580f2c1ea60d0bc 100644 (file)
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.controller.cluster.access.commands;
 
-import java.io.ObjectInput;
 import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 
@@ -15,14 +14,6 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier
  * Successful reply to an {@link IncrementTransactionSequenceRequest}.
  */
 public final class IncrementTransactionSequenceSuccess extends TransactionSuccess<IncrementTransactionSequenceSuccess> {
-    interface SerialForm extends TransactionSuccess.SerialForm<IncrementTransactionSequenceSuccess> {
-        @Override
-        default IncrementTransactionSequenceSuccess readExternal(final ObjectInput it,
-                final TransactionIdentifier target, final long sequence) {
-            return new IncrementTransactionSequenceSuccess(target, sequence);
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -36,8 +27,8 @@ public final class IncrementTransactionSequenceSuccess extends TransactionSucces
     }
 
     @Override
-    protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new ITSS(this) : new IncrementTransactionSequenceSuccessProxyV1(this);
+    protected ITSS externalizableProxy(final ABIVersion version) {
+        return new ITSS(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceSuccessProxyV1.java
deleted file mode 100644 (file)
index a4e7ad3..0000000
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link IncrementTransactionSequenceSuccess}. It implements the initial (Boron)
- * serialization format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class IncrementTransactionSequenceSuccessProxyV1
-        extends AbstractTransactionSuccessProxy<IncrementTransactionSequenceSuccess>
-        implements IncrementTransactionSequenceSuccess.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public IncrementTransactionSequenceSuccessProxyV1() {
-        // For Externalizable
-    }
-
-    IncrementTransactionSequenceSuccessProxyV1(final IncrementTransactionSequenceSuccess request) {
-        super(request);
-    }
-}
index 6f2eda8ba6b9d501c06854e542d1a180e8acc5d0..fc24d8aedacbf3bf5105d7ecb6b9b7f836f6dcc2 100644 (file)
@@ -49,6 +49,6 @@ public final class LocalHistoryFailure extends RequestFailure<LocalHistoryIdenti
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new HF(this) : new LocalHistoryFailureProxyV1(this);
+        return new HF(this);
     }
 }
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureProxyV1.java
deleted file mode 100644 (file)
index ab6a30a..0000000
+++ /dev/null
@@ -1,34 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-import org.opendaylight.controller.cluster.access.concepts.AbstractRequestFailureProxy;
-import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier;
-
-/**
- * Externalizable proxy for use with {@link LocalHistoryFailure}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class LocalHistoryFailureProxyV1
-        extends AbstractRequestFailureProxy<LocalHistoryIdentifier, LocalHistoryFailure>
-        implements LocalHistoryFailure.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public LocalHistoryFailureProxyV1() {
-        // For Externalizable
-    }
-
-    LocalHistoryFailureProxyV1(final LocalHistoryFailure failure) {
-        super(failure);
-    }
-}
index a36994937b1aafd443d7fde204ac462a3a5fffff..7c0e1865c12585f75736d42dc6e54b8ffdd14e40 100644 (file)
@@ -49,6 +49,6 @@ public final class LocalHistorySuccess extends RequestSuccess<LocalHistoryIdenti
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new HS(this) : new LocalHistorySuccessProxyV1(this);
+        return new HS(this);
     }
 }
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessProxyV1.java
deleted file mode 100644 (file)
index 1dad6f4..0000000
+++ /dev/null
@@ -1,32 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-import org.opendaylight.controller.cluster.access.concepts.AbstractSuccessProxy;
-import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier;
-
-/**
- * Serialization proxy associated with {@link LocalHistorySuccess}.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class LocalHistorySuccessProxyV1 extends AbstractSuccessProxy<LocalHistoryIdentifier, LocalHistorySuccess>
-        implements LocalHistorySuccess.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public LocalHistorySuccessProxyV1() {
-        // For Externalizable
-    }
-
-    LocalHistorySuccessProxyV1(final LocalHistorySuccess success) {
-        super(success);
-    }
-}
index 3a46a8a9432f3c3fcfa72a47fc8c46b40372deaf..ee7e8768eaeeddd03aaa2ca572d2e3242d006817 100644 (file)
@@ -10,11 +10,15 @@ package org.opendaylight.controller.cluster.access.commands;
 import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 
+import java.io.IOException;
+import java.io.ObjectInput;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+
 /**
  * Externalizable proxy for use with {@link ModifyTransactionSuccess}. It implements the Chlorine SR2 serialization
  * format.
  */
-final class MTS implements ModifyTransactionSuccess.SerialForm {
+final class MTS implements TransactionSuccess.SerialForm<ModifyTransactionSuccess> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -39,6 +43,12 @@ final class MTS implements ModifyTransactionSuccess.SerialForm {
         this.message = requireNonNull(message);
     }
 
+    @Override
+    public ModifyTransactionSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
+            final long sequence) throws IOException {
+        return new ModifyTransactionSuccess(target, sequence);
+    }
+
     @Override
     public Object readResolve() {
         return message();
index efa8a77f3d400bff643efc40fc432af6f0334ad3..c83289570d1174ce8a735fe509b77abde466e464 100644 (file)
@@ -109,7 +109,7 @@ public final class ModifyTransactionRequest extends TransactionRequest<ModifyTra
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new MTR(this) : new ModifyTransactionRequestProxyV1(this);
+        return new MTR(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestProxyV1.java
deleted file mode 100644 (file)
index de5c9d6..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link ExistsTransactionRequest}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class ModifyTransactionRequestProxyV1 extends AbstractTransactionRequestProxy<ModifyTransactionRequest>
-        implements ModifyTransactionRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public ModifyTransactionRequestProxyV1() {
-        // For Externalizable
-    }
-
-    ModifyTransactionRequestProxyV1(final ModifyTransactionRequest request) {
-        super(request);
-    }
-}
index c1620a86664f2fe6e68e02bcbc975e304909790f..38adf787b96c64116414b8cc290ed67ecd38a2c8 100644 (file)
@@ -7,8 +7,6 @@
  */
 package org.opendaylight.controller.cluster.access.commands;
 
-import java.io.IOException;
-import java.io.ObjectInput;
 import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 
@@ -16,14 +14,6 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier
  * Response to a {@link ModifyTransactionRequest} which does not have a {@link PersistenceProtocol}.
  */
 public final class ModifyTransactionSuccess extends TransactionSuccess<ModifyTransactionSuccess> {
-    interface SerialForm extends TransactionSuccess.SerialForm<ModifyTransactionSuccess> {
-        @Override
-        default ModifyTransactionSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
-                final long sequence) throws IOException {
-            return new ModifyTransactionSuccess(target, sequence);
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -36,8 +26,8 @@ public final class ModifyTransactionSuccess extends TransactionSuccess<ModifyTra
     }
 
     @Override
-    protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new MTS(this) : new ModifyTransactionSuccessProxyV1(this);
+    protected MTS externalizableProxy(final ABIVersion version) {
+        return new MTS(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionSuccessProxyV1.java
deleted file mode 100644 (file)
index ed0992c..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link ModifyTransactionSuccess}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class ModifyTransactionSuccessProxyV1 extends AbstractTransactionSuccessProxy<ModifyTransactionSuccess>
-        implements ModifyTransactionSuccess.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public ModifyTransactionSuccessProxyV1() {
-        // For Externalizable
-    }
-
-    ModifyTransactionSuccessProxyV1(final ModifyTransactionSuccess success) {
-        super(success);
-    }
-}
index 81c632f715a3703b68e87160e3bbcaeb67d6cdca..c9dc5dc1e7c3a8343c99eae7918b76b9e80670e9 100644 (file)
@@ -38,7 +38,7 @@ public final class PurgeLocalHistoryRequest extends LocalHistoryRequest<PurgeLoc
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new PHR(this) : new PurgeLocalHistoryRequestProxyV1(this);
+        return new PHR(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequestProxyV1.java
deleted file mode 100644 (file)
index 22f288a..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link PurgeLocalHistoryRequest}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class PurgeLocalHistoryRequestProxyV1 extends AbstractLocalHistoryRequestProxy<PurgeLocalHistoryRequest>
-        implements PurgeLocalHistoryRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public PurgeLocalHistoryRequestProxyV1() {
-        // For Externalizable
-    }
-
-    PurgeLocalHistoryRequestProxyV1(final PurgeLocalHistoryRequest request) {
-        super(request);
-    }
-}
index bcf09f80ba8b5be73a946d1fe151f3fbb62b9ea2..2c808349ea2cea55013f9fc58e707b3da629ba8f 100644 (file)
@@ -10,11 +10,19 @@ package org.opendaylight.controller.cluster.access.commands;
 import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 
+import java.io.IOException;
+import java.io.ObjectInput;
+import java.io.ObjectOutput;
+import java.util.Optional;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
+import org.opendaylight.yangtools.yang.data.codec.binfmt.NormalizedNodeDataInput;
+
 /**
  * Externalizable proxy for use with {@link ReadTransactionSuccess}. It implements the Chlorine SR2 serialization
  * format.
  */
-final class RTS implements ReadTransactionSuccess.SerialForm {
+final class RTS implements TransactionSuccess.SerialForm<ReadTransactionSuccess> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -39,6 +47,33 @@ final class RTS implements ReadTransactionSuccess.SerialForm {
         this.message = requireNonNull(message);
     }
 
+    @Override
+    public ReadTransactionSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
+            final long sequence) throws IOException {
+        final Optional<NormalizedNode> data;
+        if (in.readBoolean()) {
+            data = Optional.of(NormalizedNodeDataInput.newDataInput(in).readNormalizedNode());
+        } else {
+            data = Optional.empty();
+        }
+        return new ReadTransactionSuccess(target, sequence, data);
+    }
+
+    @Override
+    public void writeExternal(final ObjectOutput out, final ReadTransactionSuccess msg) throws IOException {
+        TransactionSuccess.SerialForm.super.writeExternal(out, msg);
+
+        final var data = msg.getData();
+        if (data.isPresent()) {
+            out.writeBoolean(true);
+            try (var nnout = msg.getVersion().getStreamVersion().newDataOutput(out)) {
+                nnout.writeNormalizedNode(data.orElseThrow());
+            }
+        } else {
+            out.writeBoolean(false);
+        }
+    }
+
     @Override
     public Object readResolve() {
         return message();
index 00ae65b469e4b92f74eefbfa6cc90858b4f5bb9c..292496b7b43667f217177f4aa253f16206c039a9 100644 (file)
@@ -47,6 +47,6 @@ public final class ReadTransactionRequest extends AbstractReadPathTransactionReq
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new RTR(this) : new ReadTransactionRequestProxyV1(this);
+        return new RTR(this);
     }
 }
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestProxyV1.java
deleted file mode 100644 (file)
index 8cdbeb0..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link ReadTransactionRequest}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class ReadTransactionRequestProxyV1 extends AbstractReadPathTransactionRequestProxyV1<ReadTransactionRequest>
-        implements ReadTransactionRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public ReadTransactionRequestProxyV1() {
-        // For Externalizable
-    }
-
-    ReadTransactionRequestProxyV1(final ReadTransactionRequest request) {
-        super(request);
-    }
-}
index b65473aa381516f7fafc3d53af00113ea239d161..4f9734f060d4e51272366ed22c7bdec95e0d8b7e 100644 (file)
@@ -10,15 +10,11 @@ package org.opendaylight.controller.cluster.access.commands;
 import static java.util.Objects.requireNonNull;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-import java.io.IOException;
-import java.io.ObjectInput;
-import java.io.ObjectOutput;
 import java.util.Optional;
 import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.SliceableMessage;
 import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
-import org.opendaylight.yangtools.yang.data.codec.binfmt.NormalizedNodeDataInput;
 
 /**
  * Successful reply to an {@link ReadTransactionRequest}. It indicates presence of requested data via
@@ -26,35 +22,6 @@ import org.opendaylight.yangtools.yang.data.codec.binfmt.NormalizedNodeDataInput
  */
 public final class ReadTransactionSuccess extends TransactionSuccess<ReadTransactionSuccess>
         implements SliceableMessage {
-    interface SerialForm extends TransactionSuccess.SerialForm<ReadTransactionSuccess> {
-        @Override
-        default ReadTransactionSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
-                final long sequence) throws IOException {
-            final Optional<NormalizedNode> data;
-            if (in.readBoolean()) {
-                data = Optional.of(NormalizedNodeDataInput.newDataInput(in).readNormalizedNode());
-            } else {
-                data = Optional.empty();
-            }
-            return new ReadTransactionSuccess(target, sequence, data);
-        }
-
-        @Override
-        default void writeExternal(final ObjectOutput out, final ReadTransactionSuccess msg) throws IOException {
-            TransactionSuccess.SerialForm.super.writeExternal(out, msg);
-
-            final var data = msg.getData();
-            if (data.isPresent()) {
-                out.writeBoolean(true);
-                try (var nnout = msg.getVersion().getStreamVersion().newDataOutput(out)) {
-                    nnout.writeNormalizedNode(data.orElseThrow());
-                }
-            } else {
-                out.writeBoolean(false);
-            }
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -77,8 +44,8 @@ public final class ReadTransactionSuccess extends TransactionSuccess<ReadTransac
     }
 
     @Override
-    protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new RTS(this) : new ReadTransactionSuccessProxyV1(this);
+    protected RTS externalizableProxy(final ABIVersion version) {
+        return new RTS(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessProxyV1.java
deleted file mode 100644 (file)
index c1459a9..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link ReadTransactionSuccess}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class ReadTransactionSuccessProxyV1 extends AbstractTransactionSuccessProxy<ReadTransactionSuccess>
-        implements ReadTransactionSuccess.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public ReadTransactionSuccessProxyV1() {
-        // For Externalizable
-    }
-
-    ReadTransactionSuccessProxyV1(final ReadTransactionSuccess request) {
-        super(request);
-    }
-}
index c548a4fc45bdfe29fa411e0977df11acc490015b..54897090f52db4a8ae70920a9c00282b38eed4d2 100644 (file)
@@ -10,11 +10,14 @@ package org.opendaylight.controller.cluster.access.commands;
 import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 
+import java.io.ObjectInput;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+
 /**
  * Externalizable proxy for use with {@link SkipTransactionsResponse}. It implements the Chlorine SR2 serialization
  * format.
  */
-final class STS implements SkipTransactionsResponse.SerialForm {
+final class STS implements TransactionSuccess.SerialForm<SkipTransactionsResponse> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -39,6 +42,12 @@ final class STS implements SkipTransactionsResponse.SerialForm {
         this.message = requireNonNull(message);
     }
 
+    @Override
+    public SkipTransactionsResponse readExternal(final ObjectInput in, final TransactionIdentifier target,
+            final long sequence) {
+        return new SkipTransactionsResponse(target, sequence);
+    }
+
     @Override
     public Object readResolve() {
         return message();
index 54fdfc581a7d0b4c595b66853bc9be589c1dce2d..a2c037f784753ca19babfad0e6416888c3f8248c 100644 (file)
@@ -103,7 +103,7 @@ public final class SkipTransactionsRequest extends TransactionRequest<SkipTransa
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new STR(this) : new SkipTransactionsRequestV1(this);
+        return new STR(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsRequestV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsRequestV1.java
deleted file mode 100644 (file)
index 7924d72..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2021 PANTHEON.tech, s.r.o. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link SkipTransactionsRequest}. It implements the initial
- * (Phosphorus SR1) serialization format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class SkipTransactionsRequestV1 extends AbstractTransactionRequestProxy<SkipTransactionsRequest>
-        implements SkipTransactionsRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = -7493419007644462643L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public SkipTransactionsRequestV1() {
-        // For Externalizable
-    }
-
-    SkipTransactionsRequestV1(final SkipTransactionsRequest request) {
-        super(request);
-    }
-}
index b2fbc7142154a22b3e0edac019db294c2a870427..9f3d54d9a61a990052c7f66b01b957df6dd32055 100644 (file)
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.controller.cluster.access.commands;
 
-import java.io.ObjectInput;
 import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 
@@ -16,14 +15,6 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier
  */
 // FIXME: rename to SkipTransactionsSuccess
 public final class SkipTransactionsResponse extends TransactionSuccess<SkipTransactionsResponse> {
-    interface SerialForm extends TransactionSuccess.SerialForm<SkipTransactionsResponse> {
-        @Override
-        default SkipTransactionsResponse readExternal(final ObjectInput in, final TransactionIdentifier target,
-                final long sequence) {
-            return new SkipTransactionsResponse(target, sequence);
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -36,8 +27,8 @@ public final class SkipTransactionsResponse extends TransactionSuccess<SkipTrans
     }
 
     @Override
-    protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new STS(this) : new SkipTransactionsResponseProxyV1(this);
+    protected STS externalizableProxy(final ABIVersion version) {
+        return new STS(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsResponseProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsResponseProxyV1.java
deleted file mode 100644 (file)
index 30effc3..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2021 PANTHEON.tech, s.r.o. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link SkipTransactionsResponse}. It implements the initial (Phosphorus SR1)
- * serialization format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class SkipTransactionsResponseProxyV1 extends AbstractTransactionSuccessProxy<SkipTransactionsResponse>
-        implements SkipTransactionsResponse.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public SkipTransactionsResponseProxyV1() {
-        // For Externalizable
-    }
-
-    SkipTransactionsResponseProxyV1(final SkipTransactionsResponse success) {
-        super(success);
-    }
-}
index c34323bf75d7e26166a93b3058bb603d07625cdf..daeee070465e7ce1c2d1892407abb27bce46d4f0 100644 (file)
@@ -10,11 +10,14 @@ package org.opendaylight.controller.cluster.access.commands;
 import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 
+import java.io.ObjectInput;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+
 /**
  * Externalizable proxy for use with {@link TransactionAbortSuccess}. It implements the Chlorine SR2 serialization
  * format.
  */
-final class TAS implements TransactionAbortSuccess.SerialForm {
+final class TAS implements TransactionSuccess.SerialForm<TransactionAbortSuccess> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -39,6 +42,12 @@ final class TAS implements TransactionAbortSuccess.SerialForm {
         this.message = requireNonNull(message);
     }
 
+    @Override
+    public TransactionAbortSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
+            final long sequence) {
+        return new TransactionAbortSuccess(target, sequence);
+    }
+
     @Override
     public Object readResolve() {
         return message();
index ab094b3054b7a2b1796758bee48ae4a31f312bcb..22a8a84a3a2496305ac706bd3d82d3ec7acb0c74 100644 (file)
@@ -10,11 +10,14 @@ package org.opendaylight.controller.cluster.access.commands;
 import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 
+import java.io.ObjectInput;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+
 /**
  * Externalizable proxy for use with {@link TransactionCanCommitSuccess}. It implements the Chlorine SR2 serialization
  * format.
  */
-final class TCCS implements TransactionCanCommitSuccess.SerialForm {
+final class TCCS implements TransactionSuccess.SerialForm<TransactionCanCommitSuccess> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -39,6 +42,12 @@ final class TCCS implements TransactionCanCommitSuccess.SerialForm {
         this.message = requireNonNull(message);
     }
 
+    @Override
+    public TransactionCanCommitSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
+            final long sequence) {
+        return new TransactionCanCommitSuccess(target, sequence);
+    }
+
     @Override
     public Object readResolve() {
         return message();
index 5e0265da33cad4b0252790d401b1c13b7b918c7b..7f897d82f757cf6d8f7610ca1babb5feaac1e624 100644 (file)
@@ -10,11 +10,14 @@ package org.opendaylight.controller.cluster.access.commands;
 import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 
+import java.io.ObjectInput;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+
 /**
  * Externalizable proxy for use with {@link TransactionCommitSuccess}. It implements the Chlorine SR2 serialization
  * format.
  */
-final class TCS implements TransactionCommitSuccess.SerialForm {
+final class TCS implements TransactionSuccess.SerialForm<TransactionCommitSuccess> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -39,6 +42,12 @@ final class TCS implements TransactionCommitSuccess.SerialForm {
         this.message = requireNonNull(message);
     }
 
+    @Override
+    public TransactionCommitSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
+            final long sequence) {
+        return new TransactionCommitSuccess(target, sequence);
+    }
+
     @Override
     public Object readResolve() {
         return message();
index 28c0e95bc392cf8fdfd57495aaf8f3fcf7cb1425..a64efa1f951f3eef12fc98398a8d0420e78730f2 100644 (file)
@@ -10,11 +10,15 @@ package org.opendaylight.controller.cluster.access.commands;
 import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 
+import java.io.IOException;
+import java.io.ObjectInput;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+
 /**
  * Externalizable proxy for use with {@link TransactionPreCommitSuccess}. It implements the Chlorine SR2 serialization
  * format.
  */
-final class TPCS implements TransactionPreCommitSuccess.SerialForm {
+final class TPCS implements TransactionSuccess.SerialForm<TransactionPreCommitSuccess> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -39,6 +43,12 @@ final class TPCS implements TransactionPreCommitSuccess.SerialForm {
         this.message = requireNonNull(message);
     }
 
+    @Override
+    public TransactionPreCommitSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
+            final long sequence) throws IOException {
+        return new TransactionPreCommitSuccess(target, sequence);
+    }
+
     @Override
     public Object readResolve() {
         return message();
index cff3891a67b457e8dc59a136365e1918da0c29dc..1b2f94a74ed6f4d3dd2a07efdce49a66102e250c 100644 (file)
@@ -10,11 +10,14 @@ package org.opendaylight.controller.cluster.access.commands;
 import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 
+import java.io.ObjectInput;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+
 /**
  * Externalizable proxy for use with {@link TransactionPurgeResponse}. It implements the Chlorine SR2 serialization
  * format.
  */
-final class TPS implements TransactionPurgeResponse.SerialForm {
+final class TPS implements TransactionSuccess.SerialForm<TransactionPurgeResponse> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -39,6 +42,12 @@ final class TPS implements TransactionPurgeResponse.SerialForm {
         this.message = requireNonNull(message);
     }
 
+    @Override
+    public TransactionPurgeResponse readExternal(final ObjectInput in, final TransactionIdentifier target,
+            final long sequence) {
+        return new TransactionPurgeResponse(target, sequence);
+    }
+
     @Override
     public Object readResolve() {
         return message();
index 6ad73ef427afa9f19e855cd6abd855934bda2a65..c9238ab9af80bcac87185aab1082e33bd8078290 100644 (file)
@@ -37,7 +37,7 @@ public final class TransactionAbortRequest extends TransactionRequest<Transactio
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new TAR(this) : new TransactionAbortRequestProxyV1(this);
+        return new TAR(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestProxyV1.java
deleted file mode 100644 (file)
index 8cbd832..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link TransactionAbortRequest}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class TransactionAbortRequestProxyV1 extends AbstractTransactionRequestProxy<TransactionAbortRequest>
-        implements TransactionAbortRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public TransactionAbortRequestProxyV1() {
-        // For Externalizable
-    }
-
-    TransactionAbortRequestProxyV1(final TransactionAbortRequest request) {
-        super(request);
-    }
-}
index 9f2c4c967b82655376801750169c7052e6dd908e..db92890b1b94df332a36dcd70e1a44d1ded39b16 100644 (file)
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.controller.cluster.access.commands;
 
-import java.io.ObjectInput;
 import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 
@@ -18,14 +17,6 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier
  * @author Robert Varga
  */
 public final class TransactionAbortSuccess extends TransactionSuccess<TransactionAbortSuccess> {
-    interface SerialForm extends TransactionSuccess.SerialForm<TransactionAbortSuccess> {
-        @Override
-        default TransactionAbortSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
-                final long sequence) {
-            return new TransactionAbortSuccess(target, sequence);
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -38,8 +29,8 @@ public final class TransactionAbortSuccess extends TransactionSuccess<Transactio
     }
 
     @Override
-    protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new TAS(this) : new TransactionAbortSuccessProxyV1(this);
+    protected TAS externalizableProxy(final ABIVersion version) {
+        return new TAS(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessProxyV1.java
deleted file mode 100644 (file)
index 6dfe56f..0000000
+++ /dev/null
@@ -1,32 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link TransactionAbortSuccess}. It implements the initial (Boron)
- * serialization format.
- *
- * @author Robert Varga
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class TransactionAbortSuccessProxyV1 extends AbstractTransactionSuccessProxy<TransactionAbortSuccess>
-        implements TransactionAbortSuccess.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public TransactionAbortSuccessProxyV1() {
-        // For Externalizable
-    }
-
-    TransactionAbortSuccessProxyV1(final TransactionAbortSuccess success) {
-        super(success);
-    }
-}
index 5e9e74f81bdb70248f12fc6c7ebcb0db54764384..55c5cdb2d61641d3cc2b3224c04a88feccde7708 100644 (file)
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.controller.cluster.access.commands;
 
-import java.io.ObjectInput;
 import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 
@@ -18,14 +17,6 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier
  * @author Robert Varga
  */
 public final class TransactionCanCommitSuccess extends TransactionSuccess<TransactionCanCommitSuccess> {
-    interface SerialForm extends TransactionSuccess.SerialForm<TransactionCanCommitSuccess> {
-        @Override
-        default TransactionCanCommitSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
-                final long sequence) {
-            return new TransactionCanCommitSuccess(target, sequence);
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -38,8 +29,8 @@ public final class TransactionCanCommitSuccess extends TransactionSuccess<Transa
     }
 
     @Override
-    protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new TCCS(this) : new TransactionCanCommitSuccessProxyV1(this);
+    protected TCCS externalizableProxy(final ABIVersion version) {
+        return new TCCS(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java
deleted file mode 100644 (file)
index 74e0e5c..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link TransactionCanCommitSuccess}. It implements the initial (Boron)
- * serialization format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class TransactionCanCommitSuccessProxyV1 extends AbstractTransactionSuccessProxy<TransactionCanCommitSuccess>
-        implements TransactionCanCommitSuccess.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public TransactionCanCommitSuccessProxyV1() {
-        // For Externalizable
-    }
-
-    TransactionCanCommitSuccessProxyV1(final TransactionCanCommitSuccess success) {
-        super(success);
-    }
-}
index a91fe5c9bfa5ef20b51190aaa3ad42681366063e..1fc06da9c988685027ffb7ae18515e805f4a2b6d 100644 (file)
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.controller.cluster.access.commands;
 
-import java.io.ObjectInput;
 import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 
@@ -18,14 +17,6 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier
  * @author Robert Varga
  */
 public final class TransactionCommitSuccess extends TransactionSuccess<TransactionCommitSuccess> {
-    interface SerialForm extends TransactionSuccess.SerialForm<TransactionCommitSuccess> {
-        @Override
-        default TransactionCommitSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
-                final long sequence) {
-            return new TransactionCommitSuccess(target, sequence);
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -38,8 +29,8 @@ public final class TransactionCommitSuccess extends TransactionSuccess<Transacti
     }
 
     @Override
-    protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new TCS(this) : new TransactionCommitSuccessProxyV1(this);
+    protected TCS externalizableProxy(final ABIVersion version) {
+        return new TCS(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessProxyV1.java
deleted file mode 100644 (file)
index 9c48cb0..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link TransactionCommitSuccess}. It implements the initial (Boron)
- * serialization format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class TransactionCommitSuccessProxyV1 extends AbstractTransactionSuccessProxy<TransactionCommitSuccess>
-        implements TransactionCommitSuccess.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public TransactionCommitSuccessProxyV1() {
-        // For Externalizable
-    }
-
-    TransactionCommitSuccessProxyV1(final TransactionCommitSuccess success) {
-        super(success);
-    }
-}
index 9ba1f1d48fd4290c1162a2553aaa7a7182053cae..ad7ffad146a0f5a05215cd21a3af0b9655acd1f8 100644 (file)
@@ -37,7 +37,7 @@ public final class TransactionDoCommitRequest extends TransactionRequest<Transac
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new TDCR(this) : new TransactionDoCommitRequestProxyV1(this);
+        return new TDCR(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestProxyV1.java
deleted file mode 100644 (file)
index 8ace6dc..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link TransactionDoCommitRequest}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class TransactionDoCommitRequestProxyV1 extends AbstractTransactionRequestProxy<TransactionDoCommitRequest>
-        implements TransactionDoCommitRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public TransactionDoCommitRequestProxyV1() {
-        // For Externalizable
-    }
-
-    TransactionDoCommitRequestProxyV1(final TransactionDoCommitRequest request) {
-        super(request);
-    }
-}
index af8509601a98848fe294b0d8a43269ffbf1c2852..288a90ee3c3d89e8e75c1db17b4285d6f2e7655f 100644 (file)
@@ -49,6 +49,6 @@ public final class TransactionFailure extends RequestFailure<TransactionIdentifi
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new TF(this) : new TransactionFailureProxyV1(this);
+        return new TF(this);
     }
 }
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureProxyV1.java
deleted file mode 100644 (file)
index 0d02bff..0000000
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-import org.opendaylight.controller.cluster.access.concepts.AbstractRequestFailureProxy;
-import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
-
-/**
- * Externalizable proxy for use with {@link TransactionFailure}. It implements the initial (Boron) serialization
- * format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class TransactionFailureProxyV1 extends AbstractRequestFailureProxy<TransactionIdentifier, TransactionFailure>
-        implements TransactionFailure.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public TransactionFailureProxyV1() {
-        // For Externalizable
-    }
-
-    TransactionFailureProxyV1(final TransactionFailure failure) {
-        super(failure);
-    }
-}
index 406f659b965ffdc41acdf1eb600b0a1e9c8b7813..3172842f7667551502f8248ca30374081895a562 100644 (file)
@@ -38,7 +38,7 @@ public final class TransactionPreCommitRequest extends TransactionRequest<Transa
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new TPCR(this) : new TransactionPreCommitRequestProxyV1(this);
+        return new TPCR(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestProxyV1.java
deleted file mode 100644 (file)
index b40ba97..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link TransactionPreCommitRequest}. It implements the initial (Boron)
- * serialization format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class TransactionPreCommitRequestProxyV1 extends AbstractTransactionRequestProxy<TransactionPreCommitRequest>
-        implements TransactionPreCommitRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public TransactionPreCommitRequestProxyV1() {
-        // For Externalizable
-    }
-
-    TransactionPreCommitRequestProxyV1(final TransactionPreCommitRequest request) {
-        super(request);
-    }
-}
index 635573ba51d739116325fb7c1ff70395cf1909a6..695d2615120a3612eb3161575828bd053c1b941f 100644 (file)
@@ -7,8 +7,6 @@
  */
 package org.opendaylight.controller.cluster.access.commands;
 
-import java.io.IOException;
-import java.io.ObjectInput;
 import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 
@@ -18,14 +16,6 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier
  * @author Robert Varga
  */
 public final class TransactionPreCommitSuccess extends TransactionSuccess<TransactionPreCommitSuccess> {
-    interface SerialForm extends TransactionSuccess.SerialForm<TransactionPreCommitSuccess> {
-        @Override
-        default TransactionPreCommitSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
-                final long sequence) throws IOException {
-            return new TransactionPreCommitSuccess(target, sequence);
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -38,8 +28,8 @@ public final class TransactionPreCommitSuccess extends TransactionSuccess<Transa
     }
 
     @Override
-    protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new TPCS(this) : new TransactionPreCommitSuccessProxyV1(this);
+    protected TPCS externalizableProxy(final ABIVersion version) {
+        return new TPCS(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessProxyV1.java
deleted file mode 100644 (file)
index d2f1d72..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link TransactionPreCommitSuccess}. It implements the initial (Boron)
- * serialization format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class TransactionPreCommitSuccessProxyV1 extends AbstractTransactionSuccessProxy<TransactionPreCommitSuccess>
-        implements TransactionPreCommitSuccess.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public TransactionPreCommitSuccessProxyV1() {
-        // For Externalizable
-    }
-
-    TransactionPreCommitSuccessProxyV1(final TransactionPreCommitSuccess success) {
-        super(success);
-    }
-}
index dd26df2529f7db0490877c94d02b3e0e55be63f0..757c8134a24d2dda1c8cfccc07f7b6cc119290b1 100644 (file)
@@ -39,7 +39,7 @@ public final class TransactionPurgeRequest extends TransactionRequest<Transactio
 
     @Override
     protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new TPR(this) : new TransactionPurgeRequestProxyV1(this);
+        return new TPR(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeRequestProxyV1.java
deleted file mode 100644 (file)
index 3709c67..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2017 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link TransactionPurgeRequest}. It implements the initial (Boron)
- * serialization format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class TransactionPurgeRequestProxyV1 extends AbstractTransactionRequestProxy<TransactionPurgeRequest>
-        implements TransactionPurgeRequest.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public TransactionPurgeRequestProxyV1() {
-        // For Externalizable
-    }
-
-    TransactionPurgeRequestProxyV1(final TransactionPurgeRequest request) {
-        super(request);
-    }
-}
index 5b650e60f91af9a816c4be6c8fc069f30619b15b..558e414d12991d5f31379193668d86de3f2d1da8 100644 (file)
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.controller.cluster.access.commands;
 
-import java.io.ObjectInput;
 import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 
@@ -16,14 +15,6 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier
  */
 // FIXME: rename to TransactionPurgeSuccess
 public final class TransactionPurgeResponse extends TransactionSuccess<TransactionPurgeResponse> {
-    interface SerialForm extends TransactionSuccess.SerialForm<TransactionPurgeResponse> {
-        @Override
-        default TransactionPurgeResponse readExternal(final ObjectInput in, final TransactionIdentifier target,
-                final long sequence) {
-            return new TransactionPurgeResponse(target, sequence);
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -36,8 +27,8 @@ public final class TransactionPurgeResponse extends TransactionSuccess<Transacti
     }
 
     @Override
-    protected SerialForm externalizableProxy(final ABIVersion version) {
-        return ABIVersion.MAGNESIUM.lt(version) ? new TPS(this) : new TransactionPurgeResponseProxyV1(this);
+    protected TPS externalizableProxy(final ABIVersion version) {
+        return new TPS(this);
     }
 
     @Override
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponseProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponseProxyV1.java
deleted file mode 100644 (file)
index 1927c07..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (c) 2017 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.commands;
-
-/**
- * Externalizable proxy for use with {@link TransactionPurgeResponse}. It implements the initial (Boron)
- * serialization format.
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class TransactionPurgeResponseProxyV1 extends AbstractTransactionSuccessProxy<TransactionPurgeResponse>
-        implements TransactionPurgeResponse.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public TransactionPurgeResponseProxyV1() {
-        // For Externalizable
-    }
-
-    TransactionPurgeResponseProxyV1(final TransactionPurgeResponse success) {
-        super(success);
-    }
-}
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractEnvelopeProxy.java
deleted file mode 100644 (file)
index 4de2426..0000000
+++ /dev/null
@@ -1,43 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.concepts;
-
-import static com.google.common.base.Verify.verifyNotNull;
-import static java.util.Objects.requireNonNull;
-
-@Deprecated(since = "7.0.0", forRemoval = true)
-abstract class AbstractEnvelopeProxy<T extends Message<?, ?>, E extends Envelope<T>>
-        implements Envelope.SerialForm<T, E> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    private E envelope;
-
-    AbstractEnvelopeProxy() {
-        // for Externalizable
-    }
-
-    AbstractEnvelopeProxy(final E envelope) {
-        this.envelope = requireNonNull(envelope);
-    }
-
-    @Override
-    public final E envelope() {
-        return verifyNotNull(envelope);
-    }
-
-    @Override
-    public final void setEnvelope(final E envelope) {
-        this.envelope = requireNonNull(envelope);
-    }
-
-    @Override
-    public final Object readResolve() {
-        return envelope();
-    }
-}
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractMessageProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractMessageProxy.java
deleted file mode 100644 (file)
index 23deb3b..0000000
+++ /dev/null
@@ -1,52 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.concepts;
-
-import static com.google.common.base.Verify.verifyNotNull;
-import static java.util.Objects.requireNonNull;
-
-import org.eclipse.jdt.annotation.NonNull;
-import org.opendaylight.yangtools.concepts.WritableIdentifier;
-
-/**
- * Abstract Externalizable proxy for use with {@link Message} subclasses.
- *
- * @param <T> Target identifier type
- * @param <C> Message class
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-abstract class AbstractMessageProxy<T extends WritableIdentifier, C extends Message<T, C>>
-        implements Message.SerialForm<T, C> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    private C message;
-
-    protected AbstractMessageProxy() {
-        // For Externalizable
-    }
-
-    AbstractMessageProxy(final @NonNull C message) {
-        this.message = requireNonNull(message);
-    }
-
-    @Override
-    public final C message() {
-        return verifyNotNull(message);
-    }
-
-    @Override
-    public final void setMessage(final C message) {
-        this.message = requireNonNull(message);
-    }
-
-    @Override
-    public final Object readResolve() {
-        return message();
-    }
-}
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractRequestFailureProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractRequestFailureProxy.java
deleted file mode 100644 (file)
index 4cad8a9..0000000
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.concepts;
-
-import org.eclipse.jdt.annotation.NonNull;
-import org.opendaylight.yangtools.concepts.WritableIdentifier;
-
-/**
- * Abstract Externalizable proxy for use with {@link RequestFailure} subclasses.
- *
- * @param <T> Target identifier type
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-public abstract class AbstractRequestFailureProxy<T extends WritableIdentifier, C extends RequestFailure<T, C>>
-        extends AbstractResponseProxy<T, C> implements RequestFailure.SerialForm<T, C> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    protected AbstractRequestFailureProxy() {
-        // For Externalizable
-    }
-
-    protected AbstractRequestFailureProxy(final @NonNull C failure) {
-        super(failure);
-    }
-}
\ No newline at end of file
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractRequestProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractRequestProxy.java
deleted file mode 100644 (file)
index 4f0e85f..0000000
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.concepts;
-
-import org.eclipse.jdt.annotation.NonNull;
-import org.opendaylight.yangtools.concepts.WritableIdentifier;
-
-/**
- * Abstract Externalizable proxy for use with {@link Request} subclasses.
- *
- * @param <T> Target identifier type
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-public abstract class AbstractRequestProxy<T extends WritableIdentifier, C extends Request<T, C>>
-        extends AbstractMessageProxy<T, C> implements Request.SerialForm<T, C> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    protected AbstractRequestProxy() {
-        // For Externalizable
-    }
-
-    protected AbstractRequestProxy(final @NonNull C request) {
-        super(request);
-    }
-}
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseEnvelopeProxy.java
deleted file mode 100644 (file)
index 07ea084..0000000
+++ /dev/null
@@ -1,23 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.concepts;
-
-@Deprecated(since = "7.0.0", forRemoval = true)
-abstract class AbstractResponseEnvelopeProxy<T extends Response<?, ?>, E extends ResponseEnvelope<T>>
-        extends AbstractEnvelopeProxy<T, E> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    AbstractResponseEnvelopeProxy() {
-        // for Externalizable
-    }
-
-    AbstractResponseEnvelopeProxy(final E envelope) {
-        super(envelope);
-    }
-}
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseProxy.java
deleted file mode 100644 (file)
index 22b8000..0000000
+++ /dev/null
@@ -1,34 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.concepts;
-
-import org.eclipse.jdt.annotation.NonNull;
-import org.opendaylight.yangtools.concepts.WritableIdentifier;
-
-/**
- * Abstract Externalizable proxy class to use with {@link Response} subclasses.
- *
- * @author Robert Varga
- *
- * @param <T> Target identifier type
- * @param <C> Message class
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-abstract class AbstractResponseProxy<T extends WritableIdentifier, C extends Response<T, C>>
-        extends AbstractMessageProxy<T, C> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    protected AbstractResponseProxy() {
-        // for Externalizable
-    }
-
-    AbstractResponseProxy(final @NonNull C response) {
-        super(response);
-    }
-}
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractSuccessProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractSuccessProxy.java
deleted file mode 100644 (file)
index 598fa83..0000000
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.concepts;
-
-import org.eclipse.jdt.annotation.NonNull;
-import org.opendaylight.yangtools.concepts.WritableIdentifier;
-
-/**
- * Abstract Externalizable proxy for use with {@link RequestSuccess} subclasses.
- *
- * @param <T> Target identifier type
- */
-@Deprecated(since = "7.0.0", forRemoval = true)
-public abstract class AbstractSuccessProxy<T extends WritableIdentifier, C extends RequestSuccess<T, C>>
-        extends AbstractResponseProxy<T, C> {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    protected AbstractSuccessProxy() {
-        // For Externalizable
-    }
-
-    protected AbstractSuccessProxy(final @NonNull C success) {
-        super(success);
-    }
-}
index 7524985d4f38a898535505f237378ab0dce1195d..eed7b5374113a4bf4b91d53fb576281d667259e6 100644 (file)
@@ -16,7 +16,6 @@ import java.io.ObjectInput;
 import java.io.ObjectOutput;
 import java.io.Serializable;
 import org.eclipse.jdt.annotation.NonNull;
-import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.yangtools.concepts.Immutable;
 import org.opendaylight.yangtools.concepts.WritableObjects;
 
@@ -101,11 +100,8 @@ public abstract class Envelope<T extends Message<?, ?>> implements Immutable, Se
 
     @java.io.Serial
     final Object writeReplace() {
-        return ABIVersion.MAGNESIUM.lt(message.getVersion()) ? createProxy() : legacyProxy();
+        return createProxy();
     }
 
     abstract @NonNull SerialForm<T, ?> createProxy();
-
-    @Deprecated(since = "7.0.0", forRemoval = true)
-    abstract @NonNull AbstractEnvelopeProxy<T, ?> legacyProxy();
 }
index 4de13ac8f812205078d438d9af31dce3ddb9b164..5342d05f5eb989e38787b90d8b8a4edc9ca151e9 100644 (file)
@@ -7,17 +7,7 @@
  */
 package org.opendaylight.controller.cluster.access.concepts;
 
-import java.io.ObjectInput;
-
 public final class FailureEnvelope extends ResponseEnvelope<RequestFailure<?, ?>> {
-    interface SerialForm extends ResponseEnvelope.SerialForm<RequestFailure<?, ?>, FailureEnvelope> {
-        @Override
-        default FailureEnvelope readExternal(final ObjectInput in, final long sessionId, final long txSequence,
-                final RequestFailure<?, ?> message, final long executionTimeNanos) {
-            return new FailureEnvelope(message, sessionId, txSequence, executionTimeNanos);
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -30,9 +20,4 @@ public final class FailureEnvelope extends ResponseEnvelope<RequestFailure<?, ?>
     FE createProxy() {
         return new FE(this);
     }
-
-    @Override
-    FailureEnvelopeProxy legacyProxy() {
-        return new FailureEnvelopeProxy(this);
-    }
 }
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeProxy.java
deleted file mode 100644 (file)
index a41c109..0000000
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.concepts;
-
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class FailureEnvelopeProxy extends AbstractResponseEnvelopeProxy<RequestFailure<?, ?>, FailureEnvelope>
-        implements FailureEnvelope.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to be
-    // able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public FailureEnvelopeProxy() {
-        // for Externalizable
-    }
-
-    FailureEnvelopeProxy(final FailureEnvelope envelope) {
-        super(envelope);
-    }
-}
index 537b391de91544d3704e3fac95cfa070130f95fe..ec10da1c653c4b22e2b4441c28bef7369005bc98 100644 (file)
@@ -151,7 +151,7 @@ public abstract class Message<T extends WritableIdentifier, C extends Message<T,
         }
 
         return switch (toVersion) {
-            case MAGNESIUM, CHLORINE_SR2 -> verifyNotNull(cloneAsVersion(toVersion));
+            case CHLORINE_SR2 -> verifyNotNull(cloneAsVersion(toVersion));
             default -> throw new IllegalArgumentException("Unhandled ABI version " + toVersion);
         };
     }
index 455e00e5581d3c6716e6e7306aafe0fb1528d8c6..27bf8255263fc31963489a0829d7ce26e3ee8d10 100644 (file)
@@ -10,10 +10,12 @@ package org.opendaylight.controller.cluster.access.concepts;
 import static com.google.common.base.Verify.verifyNotNull;
 import static java.util.Objects.requireNonNull;
 
+import java.io.ObjectInput;
+
 /**
  * Serialization proxy for {@link RequestEnvelope}.
  */
-final class RE implements RequestEnvelope.SerialForm {
+final class RE implements Envelope.SerialForm<Request<?, ?>, RequestEnvelope> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -38,6 +40,12 @@ final class RE implements RequestEnvelope.SerialForm {
         this.envelope = requireNonNull(envelope);
     }
 
+    @Override
+    public RequestEnvelope readExternal(final ObjectInput in, final long sessionId, final long txSequence,
+            final Request<?, ?> message) {
+        return new RequestEnvelope(message, sessionId, txSequence);
+    }
+
     @Override
     public Object readResolve() {
         return envelope();
index 5648846fd93792178bb57eaf5ec307e7a889e3f3..e8983697cf659e56ad99fa347278d8c0df58e596 100644 (file)
@@ -8,17 +8,8 @@
 package org.opendaylight.controller.cluster.access.concepts;
 
 import akka.actor.ActorRef;
-import java.io.ObjectInput;
 
 public final class RequestEnvelope extends Envelope<Request<?, ?>> {
-    interface SerialForm extends Envelope.SerialForm<Request<?, ?>, RequestEnvelope> {
-        @Override
-        default RequestEnvelope readExternal(final ObjectInput in, final long sessionId, final long txSequence,
-                final Request<?, ?> message) {
-            return new RequestEnvelope(message, sessionId, txSequence);
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -31,11 +22,6 @@ public final class RequestEnvelope extends Envelope<Request<?, ?>> {
         return new RE(this);
     }
 
-    @Override
-    RequestEnvelopeProxy legacyProxy() {
-        return new RequestEnvelopeProxy(this);
-    }
-
     /**
      * Respond to this envelope with a {@link RequestFailure} caused by specified {@link RequestException}.
      *
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelopeProxy.java
deleted file mode 100644 (file)
index 486441b..0000000
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.concepts;
-
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class RequestEnvelopeProxy extends AbstractEnvelopeProxy<Request<?, ?>, RequestEnvelope>
-        implements RequestEnvelope.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public RequestEnvelopeProxy() {
-        // for Externalizable
-    }
-
-    RequestEnvelopeProxy(final RequestEnvelope envelope) {
-        super(envelope);
-    }
-}
index 59615a474cd12cec63771f3a129f26ea9d4a48b7..3e8ce6f25607d619b0ad7c8a83f8b1906a9c7df7 100644 (file)
@@ -15,7 +15,7 @@ import java.io.ObjectInput;
 /**
  * Serialization proxy for {@link SuccessEnvelope}.
  */
-final class SE implements SuccessEnvelope.SerialForm {
+final class SE implements ResponseEnvelope.SerialForm<RequestSuccess<?, ?>, SuccessEnvelope> {
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
index 0c6ed7a1123de42e6251b7d139864f8351081210..2644c6ff0f8856a550ec8cdacbe227e4afa538ca 100644 (file)
@@ -7,17 +7,7 @@
  */
 package org.opendaylight.controller.cluster.access.concepts;
 
-import java.io.ObjectInput;
-
 public final class SuccessEnvelope extends ResponseEnvelope<RequestSuccess<?, ?>> {
-    interface SerialForm extends ResponseEnvelope.SerialForm<RequestSuccess<?, ?>, SuccessEnvelope> {
-        @Override
-        default SuccessEnvelope readExternal(final ObjectInput in, final long sessionId, final long txSequence,
-                final RequestSuccess<?, ?> message, final long executionTimeNanos) {
-            return new SuccessEnvelope(message, sessionId, txSequence, executionTimeNanos);
-        }
-    }
-
     @java.io.Serial
     private static final long serialVersionUID = 1L;
 
@@ -30,10 +20,4 @@ public final class SuccessEnvelope extends ResponseEnvelope<RequestSuccess<?, ?>
     SE createProxy() {
         return new SE(this);
     }
-
-    @Override
-    SuccessEnvelopeProxy legacyProxy() {
-        return new SuccessEnvelopeProxy(this);
-    }
-
 }
diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelopeProxy.java
deleted file mode 100644 (file)
index ebaec25..0000000
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * Copyright (c) 2016 Cisco Systems, Inc. and others.  All rights reserved.
- *
- * This program and the accompanying materials are made available under the
- * terms of the Eclipse Public License v1.0 which accompanies this distribution,
- * and is available at http://www.eclipse.org/legal/epl-v10.html
- */
-package org.opendaylight.controller.cluster.access.concepts;
-
-@Deprecated(since = "7.0.0", forRemoval = true)
-final class SuccessEnvelopeProxy extends AbstractResponseEnvelopeProxy<RequestSuccess<?, ?>, SuccessEnvelope>
-        implements SuccessEnvelope.SerialForm {
-    @java.io.Serial
-    private static final long serialVersionUID = 1L;
-
-    // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
-    // be able to create instances via reflection.
-    @SuppressWarnings("checkstyle:RedundantModifier")
-    public SuccessEnvelopeProxy() {
-        // for Externalizable
-    }
-
-    SuccessEnvelopeProxy(final SuccessEnvelope envelope) {
-        super(envelope);
-    }
-}
index 8c2ff3bbb7576ee4eee51245a1fa361a6e12ff5b..a48e83d1b7d2b84a6714e30828d0bb81bf7a3a18 100644 (file)
@@ -10,7 +10,7 @@ package org.opendaylight.controller.cluster.access;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertThrows;
 import static org.junit.Assert.assertTrue;
-import static org.opendaylight.controller.cluster.access.ABIVersion.MAGNESIUM;
+import static org.opendaylight.controller.cluster.access.ABIVersion.CHLORINE_SR2;
 import static org.opendaylight.controller.cluster.access.ABIVersion.TEST_FUTURE_VERSION;
 import static org.opendaylight.controller.cluster.access.ABIVersion.TEST_PAST_VERSION;
 
@@ -23,15 +23,15 @@ public class ABIVersionTest {
     @Test
     public void testInvalidVersions() {
         assertTrue(TEST_PAST_VERSION.compareTo(TEST_FUTURE_VERSION) < 0);
-        assertTrue(TEST_PAST_VERSION.compareTo(MAGNESIUM) < 0);
-        assertTrue(TEST_FUTURE_VERSION.compareTo(MAGNESIUM) > 0);
+        assertTrue(TEST_PAST_VERSION.compareTo(CHLORINE_SR2) < 0);
+        assertTrue(TEST_FUTURE_VERSION.compareTo(CHLORINE_SR2) > 0);
     }
 
     @Test
     public void testMagnesiumVersion() throws Exception {
-        assertEquals((short)8, MAGNESIUM.shortValue());
-        assertEquals(MAGNESIUM, ABIVersion.valueOf(MAGNESIUM.shortValue()));
-        assertEquals(MAGNESIUM, ABIVersion.readFrom(ByteStreams.newDataInput(writeVersion(MAGNESIUM))));
+        assertEquals((short)9, CHLORINE_SR2.shortValue());
+        assertEquals(CHLORINE_SR2, ABIVersion.valueOf(CHLORINE_SR2.shortValue()));
+        assertEquals(CHLORINE_SR2, ABIVersion.readFrom(ByteStreams.newDataInput(writeVersion(CHLORINE_SR2))));
     }
 
     @Test
index 5fa55d8062e09913263e7fbc328db4fa514b302b..48465208e21a27007fbe9512cfd1c63a200e213e 100644 (file)
@@ -27,7 +27,7 @@ public class AbortLocalTransactionRequestTest
     private static final AbortLocalTransactionRequest OBJECT = new AbortLocalTransactionRequest(TRANSACTION, ACTOR_REF);
 
     public AbortLocalTransactionRequestTest() {
-        super(OBJECT, 0, 0);
+        super(OBJECT);
     }
 
     @Override
index fbd8489a9671ac73e204a8fa6ad657b67354112f..1cb9af38a01330d74bccf98e667d7771db275542 100644 (file)
@@ -20,13 +20,13 @@ import org.opendaylight.controller.cluster.access.ABIVersion;
 
 public abstract class AbstractLocalTransactionRequestTest<T extends AbstractLocalTransactionRequest<T>>
         extends AbstractTransactionRequestTest<T> {
-    protected AbstractLocalTransactionRequestTest(final T object, final int baseSize, final int legacySize) {
-        super(object, baseSize, legacySize);
+    protected AbstractLocalTransactionRequestTest(final T object) {
+        super(object, -1);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        assertSame(object(), object().cloneAsVersion(ABIVersion.MAGNESIUM));
+        assertSame(object(), object().cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION));
     }
 
     @Override
index 78d7fabdf7a3ceea98c8caf3cb44a81785132e0c..df8407b3f0e686365668f2777e3fb9ffdbfc7f5e 100644 (file)
@@ -20,8 +20,8 @@ public abstract class AbstractReadTransactionRequestTest<T extends AbstractReadP
     protected static final YangInstanceIdentifier PATH = YangInstanceIdentifier.empty();
     protected static final boolean SNAPSHOT_ONLY = true;
 
-    protected AbstractReadTransactionRequestTest(final T object, final int baseSize, final int legacySize) {
-        super(object, baseSize, legacySize);
+    protected AbstractReadTransactionRequestTest(final T object, final int baseSize) {
+        super(object, baseSize);
     }
 
     @Test
index 8d60e7f2a8135e3427c293977d090e7317f54798..78456b246afaf9014776b047ac33dfec48952bed 100644 (file)
@@ -13,7 +13,6 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import org.apache.commons.lang3.SerializationUtils;
 import org.junit.Test;
-import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.ClientIdentifier;
 import org.opendaylight.controller.cluster.access.concepts.FrontendIdentifier;
 import org.opendaylight.controller.cluster.access.concepts.FrontendType;
@@ -37,12 +36,10 @@ public abstract class AbstractRequestFailureTest<T extends RequestFailure<?, T>>
 
     private final T object;
     private final int expectedSize;
-    private final int legacySize;
 
-    protected AbstractRequestFailureTest(final T object, final int baseSize, final int legacySize) {
+    protected AbstractRequestFailureTest(final T object, final int baseSize) {
         this.object = requireNonNull(object);
         this.expectedSize = baseSize + CAUSE_SIZE;
-        this.legacySize = legacySize + CAUSE_SIZE;
     }
 
     @Test
@@ -59,7 +56,6 @@ public abstract class AbstractRequestFailureTest<T extends RequestFailure<?, T>>
     public void serializationTest() {
         final var bytes = SerializationUtils.serialize(object);
         assertEquals(expectedSize, bytes.length);
-        assertEquals(legacySize, SerializationUtils.serialize(object.toVersion(ABIVersion.MAGNESIUM)).length);
 
         @SuppressWarnings("unchecked")
         final var deserialize = (T) SerializationUtils.deserialize(bytes);
index 771ef213e276978f02c0dc73394ad3429837876a..b0038758c787e75033d67ddd72d339603e9a44fc 100644 (file)
@@ -13,7 +13,6 @@ import static org.junit.Assert.assertEquals;
 import org.apache.commons.lang3.SerializationUtils;
 import org.eclipse.jdt.annotation.NonNull;
 import org.junit.Test;
-import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.ClientIdentifier;
 import org.opendaylight.controller.cluster.access.concepts.FrontendIdentifier;
 import org.opendaylight.controller.cluster.access.concepts.FrontendType;
@@ -29,19 +28,16 @@ public abstract class AbstractRequestSuccessTest<T extends RequestSuccess<?, T>>
 
     private final @NonNull T object;
     private final int expectedSize;
-    private final int legacySize;
 
-    protected AbstractRequestSuccessTest(final T object, final int expectedSize, final int legacySize) {
+    protected AbstractRequestSuccessTest(final T object, final int expectedSize) {
         this.object = requireNonNull(object);
         this.expectedSize = expectedSize;
-        this.legacySize = legacySize;
     }
 
     @Test
     public void serializationTest() {
         final var bytes = SerializationUtils.serialize(object);
         assertEquals(expectedSize, bytes.length);
-        assertEquals(legacySize, SerializationUtils.serialize(object.toVersion(ABIVersion.MAGNESIUM)).length);
 
         @SuppressWarnings("unchecked")
         final var deserialize = (T) SerializationUtils.deserialize(bytes);
index b07bee69f5a3b6d980ecd3792809f4e486f060ee..f276ac3937763895d0c13ec74fb0b7ded97ad985 100644 (file)
@@ -29,8 +29,8 @@ public abstract class AbstractTransactionRequestTest<T extends TransactionReques
     protected static final TransactionIdentifier TRANSACTION_IDENTIFIER = new TransactionIdentifier(
             HISTORY_IDENTIFIER, 0);
 
-    protected AbstractTransactionRequestTest(final T object, final int baseSize, final int legacySize) {
-        super(object, baseSize, legacySize);
+    protected AbstractTransactionRequestTest(final T object, final int baseSize) {
+        super(object, baseSize);
     }
 
     @Test
index 43e72509e4913ad07edfd02dbb4d26149196fd66..4f00501750f55120599002bb63b3c03088928a0d 100644 (file)
@@ -14,7 +14,7 @@ public abstract class AbstractTransactionSuccessTest<T extends TransactionSucces
     protected static final TransactionIdentifier TRANSACTION_IDENTIFIER = new TransactionIdentifier(HISTORY_IDENTIFIER,
         0);
 
-    protected AbstractTransactionSuccessTest(final T object, final int expectedSize, final int legacySize) {
-        super(object, expectedSize, legacySize);
+    protected AbstractTransactionSuccessTest(final T object, final int expectedSize) {
+        super(object, expectedSize);
     }
 }
index 8d9649cbd913994ae47bcc28480b254d0227ccf3..f1df2d882f80132a138b7061feeb7f7b050d2789 100644 (file)
@@ -37,7 +37,7 @@ public class CommitLocalTransactionRequestTest
         ACTOR_REF, MODIFICATION, null, COORDINATED);
 
     public CommitLocalTransactionRequestTest() {
-        super(OBJECT, 0, 0);
+        super(OBJECT);
     }
 
     @Test
index 63eb50bee78f95a7c9f19002ead92240ae301b9b..2278195d826574f8061390fcdf5cfa623bd2ad2e 100644 (file)
@@ -16,7 +16,7 @@ public class ConnectClientFailureTest extends AbstractRequestFailureTest<Connect
     private static final ConnectClientFailure OBJECT = new ConnectClientFailure(CLIENT_IDENTIFIER, 0, CAUSE);
 
     public ConnectClientFailureTest() {
-        super(OBJECT, 99, 392);
+        super(OBJECT, 99);
     }
 
     @Test
index 97d80ad31f67911ee0dc18834c8fbfec749d95ce..3bf1951e5037bd4d1e1978b69ef3f5a597f809f7 100644 (file)
@@ -34,7 +34,7 @@ public class ConnectClientRequestTest extends AbstractRequestTest<ConnectClientR
             CLIENT_IDENTIFIER, 0, ACTOR_REF, MIN_VERSION, MAX_VERSION);
 
     public ConnectClientRequestTest() {
-        super(OBJECT, 112, 310);
+        super(OBJECT, 112);
     }
 
     @Test
@@ -56,9 +56,9 @@ public class ConnectClientRequestTest extends AbstractRequestTest<ConnectClientR
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertNotNull(clone);
-        assertEquals(ABIVersion.MAGNESIUM, clone.getVersion());
+        assertEquals(ABIVersion.TEST_FUTURE_VERSION, clone.getVersion());
     }
 
     @Test
index 46a2b633811c05232f7dcb6a9f11995ddd5f8c3b..0267b8eb273191155f499920700ab2b90523db06 100644 (file)
@@ -33,7 +33,6 @@ public class ConnectClientSuccessTest extends AbstractRequestSuccessTest<Connect
         DataTreeConfiguration.DEFAULT_OPERATIONAL);
     private static final ActorSystem SYSTEM = ActorSystem.create("test");
     private static final ActorRef ACTOR_REF = TestProbe.apply(SYSTEM).ref();
-    private static final int ACTOR_REF_SIZE = ACTOR_REF.path().toSerializationFormat().length();
     private static final ActorSelection ACTOR_SELECTION =  ActorSelection.apply(ACTOR_REF, "foo");
     private static final List<ActorSelection> ALTERNATES = ImmutableList.of(ACTOR_SELECTION);
     private static final int MAX_MESSAGES = 10;
@@ -41,7 +40,7 @@ public class ConnectClientSuccessTest extends AbstractRequestSuccessTest<Connect
         ALTERNATES, TREE, MAX_MESSAGES);
 
     public ConnectClientSuccessTest() {
-        super(OBJECT, 146 + ACTOR_REF_SIZE, 432 + ACTOR_REF_SIZE);
+        super(OBJECT, 146 + ACTOR_REF.path().toSerializationFormat().length());
     }
 
     @Before
@@ -74,7 +73,7 @@ public class ConnectClientSuccessTest extends AbstractRequestSuccessTest<Connect
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getAlternates(), clone.getAlternates());
index 7f5bc7ac6efee07f3e8d67cfef530d1439c0b6fc..f3e8aa0db6f91a751f328bdbd0104aef364b2581 100644 (file)
@@ -17,7 +17,7 @@ public class ExistsTransactionRequestTest extends AbstractReadTransactionRequest
         ACTOR_REF, PATH, SNAPSHOT_ONLY);
 
     public ExistsTransactionRequestTest() {
-        super(OBJECT, 108, 620);
+        super(OBJECT, 108);
     }
 
     @Test
index 41587aadcbe8b200662c463648778fd125fbc616..e8ce28dedb69441f9a53710005c5bcfcddb13348 100644 (file)
@@ -22,7 +22,7 @@ public class ExistsTransactionSuccessTest extends AbstractTransactionSuccessTest
         EXISTS);
 
     public ExistsTransactionSuccessTest() {
-        super(OBJECT, 99, 487);
+        super(OBJECT, 99);
     }
 
     @Test
@@ -32,7 +32,7 @@ public class ExistsTransactionSuccessTest extends AbstractTransactionSuccessTest
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getExists(), clone.getExists());
index 87ec05dfc58a54af5f4205759e472059fe0936c5..13b9d6e8a19f0957bb875327e966e55c4908dad8 100644 (file)
@@ -16,12 +16,12 @@ public class LocalHistoryFailureTest extends AbstractRequestFailureTest<LocalHis
     private static final LocalHistoryFailure OBJECT = new LocalHistoryFailure(HISTORY_IDENTIFIER, 0, CAUSE);
 
     public LocalHistoryFailureTest() {
-        super(OBJECT, 99, 392);
+        super(OBJECT, 99);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getCause(), clone.getCause());
index c9db386c38f764a169937518d18c1e392c6ad438..8afca0072c75c7451d7a982202b24e3316252ea5 100644 (file)
@@ -16,13 +16,13 @@ public class LocalHistorySuccessTest extends AbstractRequestSuccessTest<LocalHis
     private static final LocalHistorySuccess OBJECT = new LocalHistorySuccess(HISTORY_IDENTIFIER, 0);
 
     public LocalHistorySuccessTest() {
-        super(OBJECT, 96, 382);
+        super(OBJECT, 96);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
-        assertEquals(ABIVersion.MAGNESIUM, clone.getVersion());
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
+        assertEquals(ABIVersion.TEST_FUTURE_VERSION, clone.getVersion());
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
     }
index 462dddc483e9403b867185c533ce9f02090658f1..45ee0bd2584b5f5096d55bdab40410e26f94ceb6 100644 (file)
@@ -23,7 +23,7 @@ public class ModifyTransactionRequestEmptyTest extends AbstractTransactionReques
         ACTOR_REF, List.of(), PROTOCOL);
 
     public ModifyTransactionRequestEmptyTest() {
-        super(OBJECT, 108, 408);
+        super(OBJECT, 108);
     }
 
     @Test
@@ -45,7 +45,7 @@ public class ModifyTransactionRequestEmptyTest extends AbstractTransactionReques
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getReplyTo(), clone.getReplyTo());
index 70e5b0e65a35455bc4bd5087f50b3119293bbd5b..ec3838cf545f7474507a351d40b13353610c8070 100644 (file)
@@ -37,7 +37,7 @@ public class ModifyTransactionRequestTest extends AbstractTransactionRequestTest
         ACTOR_REF, MODIFICATIONS, PROTOCOL);
 
     public ModifyTransactionRequestTest() {
-        super(OBJECT, 140, 440);
+        super(OBJECT, 140);
     }
 
     @Test
@@ -59,7 +59,7 @@ public class ModifyTransactionRequestTest extends AbstractTransactionRequestTest
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getReplyTo(), clone.getReplyTo());
index 1ee66c75f606ca20a1b855ace6eb5bd343653336..8fb470d765e6fbe47b2a4c9c53f8dc82240265e5 100644 (file)
@@ -16,13 +16,13 @@ public class ModifyTransactionSuccessTest extends AbstractTransactionSuccessTest
     private static final ModifyTransactionSuccess OBJECT = new ModifyTransactionSuccess(TRANSACTION_IDENTIFIER, 0);
 
     public ModifyTransactionSuccessTest() {
-        super(OBJECT, 98, 486);
+        super(OBJECT, 98);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
-        assertEquals(ABIVersion.MAGNESIUM, clone.getVersion());
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
+        assertEquals(ABIVersion.TEST_FUTURE_VERSION, clone.getVersion());
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
     }
index eed21d001b579b6fb08d2e2b79d6a958d96e23c5..10f4f0eb7834208e21c51d344b73c5db06cb6a95 100644 (file)
@@ -17,7 +17,7 @@ public class ReadTransactionRequestTest extends AbstractReadTransactionRequestTe
         ACTOR_REF, PATH, SNAPSHOT_ONLY);
 
     public ReadTransactionRequestTest() {
-        super(OBJECT, 108, 618);
+        super(OBJECT, 108);
     }
 
     @Test
index b143d4a4546c8903b1dbe092cbffb70fc098c9eb..055b6f5c88e94522a923621fef0398d0f7958190 100644 (file)
@@ -18,7 +18,7 @@ public class ReadTransactionSuccessNoDataTest extends AbstractTransactionSuccess
         Optional.empty());
 
     public ReadTransactionSuccessNoDataTest() {
-        super(OBJECT, 99, 485);
+        super(OBJECT, 99);
     }
 
     @Test
@@ -28,7 +28,7 @@ public class ReadTransactionSuccessNoDataTest extends AbstractTransactionSuccess
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getData(), clone.getData());
index 1dd8d450e200b7734d2bfe0d9650dfb31508315e..9be6ec0118628a836a8c74481e5b9e31ca83aeee 100644 (file)
@@ -26,7 +26,7 @@ public class ReadTransactionSuccessTest extends AbstractTransactionSuccessTest<R
         Optional.of(NODE));
 
     public ReadTransactionSuccessTest() {
-        super(OBJECT, 129, 515);
+        super(OBJECT, 129);
     }
 
     @Test
@@ -36,7 +36,7 @@ public class ReadTransactionSuccessTest extends AbstractTransactionSuccessTest<R
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getData(), clone.getData());
index 432a9b0161917606da1bb80c0a1797ff66a8ad31..27b30d9e8b67290539fe2f5d99d871dbfe6b6b9c 100644 (file)
@@ -19,12 +19,12 @@ public class SkipTransactionsRequestTest extends AbstractTransactionRequestTest<
         ACTOR_REF, List.of(UnsignedLong.ONE));
 
     public SkipTransactionsRequestTest() {
-        super(OBJECT, 109, 403);
+        super(OBJECT, 109);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getReplyTo(), clone.getReplyTo());
index 083bdbb41f0edaab047a7f743b882e49ec78cf3d..3ff798d23120230e4e3ce3e6ac4e124a655d6e13 100644 (file)
@@ -16,12 +16,12 @@ public class SkipTransactionsResponseTest extends AbstractTransactionSuccessTest
     private static final SkipTransactionsResponse OBJECT = new SkipTransactionsResponse(TRANSACTION_IDENTIFIER, 0);
 
     public SkipTransactionsResponseTest() {
-        super(OBJECT, 98, 486);
+        super(OBJECT, 98);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
     }
index 4345aefb16587a6a8de65f2fcaf7ba93ca33fe54..c0e1ae8e1f221c563fa7292ea6c6a3cc381acfb3 100644 (file)
@@ -17,12 +17,12 @@ public class TransactionAbortRequestTest extends AbstractTransactionRequestTest<
         ACTOR_REF);
 
     public TransactionAbortRequestTest() {
-        super(OBJECT, 101, 400);
+        super(OBJECT, 101);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getReplyTo(), clone.getReplyTo());
index d2ff94444dea1dc43ae5c9fc02cba78a7386e13c..1ceab66a9557810ac0c460da5ad8a0f23ebd53f6 100644 (file)
@@ -16,12 +16,12 @@ public class TransactionAbortSuccessTest extends AbstractTransactionSuccessTest<
     private static final TransactionAbortSuccess OBJECT = new TransactionAbortSuccess(TRANSACTION_IDENTIFIER, 0);
 
     public TransactionAbortSuccessTest() {
-        super(OBJECT, 98, 485);
+        super(OBJECT, 98);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
     }
index 92874f3d7c2c2d46220f70434d0b42806e64c29e..ee84907d5413d246e2ecca90f99e138aabdb8a88 100644 (file)
@@ -17,12 +17,12 @@ public class TransactionCanCommitSuccessTest extends AbstractTransactionSuccessT
         0);
 
     public TransactionCanCommitSuccessTest() {
-        super(OBJECT, 99, 489);
+        super(OBJECT, 99);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
     }
index a435879b90a2471912e3566e35d35237af2820a7..ca1f8f8dd920d13ef7db101ea78ef1e4415f052a 100644 (file)
@@ -16,12 +16,12 @@ public class TransactionCommitSuccessTest extends AbstractTransactionSuccessTest
     private static final TransactionCommitSuccess OBJECT = new TransactionCommitSuccess(TRANSACTION_IDENTIFIER, 0);
 
     public TransactionCommitSuccessTest() {
-        super(OBJECT, 98, 486);
+        super(OBJECT, 98);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
     }
index 875bcfdcbaab86bf62f2102cb309845bb26428c8..a5b3401a7f92aabacecdee947646f46ee683e26e 100644 (file)
@@ -17,12 +17,12 @@ public class TransactionDoCommitRequestTest extends AbstractTransactionRequestTe
         ACTOR_REF);
 
     public TransactionDoCommitRequestTest() {
-        super(OBJECT, 102, 403);
+        super(OBJECT, 102);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getReplyTo(), clone.getReplyTo());
index 95fa449e6778954b7b53aa81553d3baa82e590f3..7e027ea2d396e8f8525e7e2aac95b8e951e9cee6 100644 (file)
@@ -16,12 +16,12 @@ public class TransactionFailureTest extends AbstractRequestFailureTest<Transacti
     private static final TransactionFailure OBJECT = new TransactionFailure(TRANSACTION_IDENTIFIER, 0, CAUSE);
 
     public TransactionFailureTest() {
-        super(OBJECT, 100, 392);
+        super(OBJECT, 100);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getCause(), clone.getCause());
index 12de83e564b85aecb34124c4468865948912f020..21605372c2d2074ac94c2e9c86cda77ebe9539dd 100644 (file)
@@ -17,12 +17,12 @@ public class TransactionPreCommitRequestTest extends AbstractTransactionRequestT
         ACTOR_REF);
 
     public TransactionPreCommitRequestTest() {
-        super(OBJECT, 102, 404);
+        super(OBJECT, 102);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getReplyTo(), clone.getReplyTo());
index 063c163d7ee0a28c0dcc4b4657b30aa3df11e720..5f8f29f45078da8c01c3265ade5c2cd52a4db1d8 100644 (file)
@@ -17,12 +17,12 @@ public class TransactionPreCommitSuccessTest extends AbstractTransactionSuccessT
         0);
 
     public TransactionPreCommitSuccessTest() {
-        super(OBJECT, 99, 489);
+        super(OBJECT, 99);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
     }
index 412f139d9572b13eccf7c0d873d6e55278b05246..7453f4461a5f87146c45f398e113142db9c56f4e 100644 (file)
@@ -17,12 +17,12 @@ public class TransactionPurgeRequestTest extends AbstractTransactionRequestTest<
         ACTOR_REF);
 
     public TransactionPurgeRequestTest() {
-        super(OBJECT, 101, 400);
+        super(OBJECT, 101);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
         assertEquals(OBJECT.getReplyTo(), clone.getReplyTo());
index 5d47e0e6ebf7d780e8a0c6527418974f12a85787..e8b4294d5e828e3560a62af0603d3d22a10ffcd0 100644 (file)
@@ -16,12 +16,12 @@ public class TransactionPurgeResponseTest extends AbstractTransactionSuccessTest
     private static final TransactionPurgeResponse OBJECT = new TransactionPurgeResponse(TRANSACTION_IDENTIFIER, 0);
 
     public TransactionPurgeResponseTest() {
-        super(OBJECT, 98, 486);
+        super(OBJECT, 98);
     }
 
     @Test
     public void cloneAsVersionTest() {
-        final var clone = OBJECT.cloneAsVersion(ABIVersion.MAGNESIUM);
+        final var clone = OBJECT.cloneAsVersion(ABIVersion.TEST_FUTURE_VERSION);
         assertEquals(OBJECT.getSequence(), clone.getSequence());
         assertEquals(OBJECT.getTarget(), clone.getTarget());
     }
index 3ab1e0fd400ecada7e4c218fa3c15e297955b17f..48ceabef81cd87259df989c49ac9cf917350c6cb 100644 (file)
@@ -21,7 +21,6 @@ import com.google.common.base.MoreObjects;
 import org.apache.commons.lang3.SerializationUtils;
 import org.junit.Before;
 import org.junit.Test;
-import org.opendaylight.controller.cluster.access.ABIVersion;
 
 public abstract class AbstractRequestTest<T extends Request<?, T>> {
     private static final ActorSystem SYSTEM = ActorSystem.create("test");
@@ -30,12 +29,10 @@ public abstract class AbstractRequestTest<T extends Request<?, T>> {
 
     private final T object;
     private final int expectedSize;
-    private final int legacySize;
 
-    protected AbstractRequestTest(final T object, final int baseSize, final int legacySize) {
+    protected AbstractRequestTest(final T object, final int baseSize) {
         this.object = requireNonNull(object);
         this.expectedSize = baseSize + ACTOR_REF_SIZE;
-        this.legacySize = legacySize + ACTOR_REF_SIZE;
     }
 
     protected final T object() {
@@ -60,8 +57,6 @@ public abstract class AbstractRequestTest<T extends Request<?, T>> {
 
     @Test
     public void serializationTest() {
-        assertEquals(legacySize, SerializationUtils.serialize(object.cloneAsVersion(ABIVersion.MAGNESIUM)).length);
-
         final byte[] bytes = SerializationUtils.serialize(object);
         assertEquals(expectedSize, bytes.length);
         @SuppressWarnings("unchecked")
index 3c1a591be8078732e96deb8ba50845c5870d2517..70132a6c05d0d2bb4da906d3358d5cae6512701b 100644 (file)
@@ -7,6 +7,8 @@
  */
 package org.opendaylight.controller.cluster.access.concepts;
 
+import static com.google.common.base.Verify.verifyNotNull;
+import static java.util.Objects.requireNonNull;
 import static org.junit.Assert.assertEquals;
 
 import java.io.DataInput;
@@ -21,7 +23,7 @@ public class FailureEnvelopeTest extends AbstractEnvelopeTest<FailureEnvelope> {
         final var cause = new RuntimeRequestException("msg", new RuntimeException());
         final int causeSize = SerializationUtils.serialize(cause).length;
         return new EnvelopeDetails<>(new FailureEnvelope(new MockFailure(OBJECT, cause, 42), 1L, 2L, 11L),
-            causeSize + 485);
+            causeSize + 216);
     }
 
     @Override
@@ -33,17 +35,19 @@ public class FailureEnvelopeTest extends AbstractEnvelopeTest<FailureEnvelope> {
         assertEquals(expectedCause.isRetriable(), actualCause.isRetriable());
     }
 
-    private static class MockRequestFailureProxy extends AbstractRequestFailureProxy<WritableIdentifier, MockFailure> {
+    private static class MockRequestFailureProxy implements RequestFailure.SerialForm<WritableIdentifier, MockFailure> {
         @java.io.Serial
         private static final long serialVersionUID = 5015515628523887221L;
 
+        private MockFailure message;
+
         @SuppressWarnings("checkstyle:RedundantModifier")
         public MockRequestFailureProxy() {
             //For Externalizable
         }
 
         private MockRequestFailureProxy(final MockFailure mockFailure) {
-            super(mockFailure);
+            message = requireNonNull(mockFailure);
         }
 
         @Override
@@ -56,6 +60,21 @@ public class FailureEnvelopeTest extends AbstractEnvelopeTest<FailureEnvelope> {
         public WritableIdentifier readTarget(final DataInput in) throws IOException {
             return TransactionIdentifier.readFrom(in);
         }
+
+        @Override
+        public MockFailure message() {
+            return verifyNotNull(message);
+        }
+
+        @Override
+        public void setMessage(final MockFailure message) {
+            this.message = requireNonNull(message);
+        }
+
+        @Override
+        public Object readResolve() {
+            return message();
+        }
     }
 
     private static class MockFailure extends RequestFailure<WritableIdentifier, MockFailure> {
@@ -67,7 +86,7 @@ public class FailureEnvelopeTest extends AbstractEnvelopeTest<FailureEnvelope> {
         }
 
         @Override
-        protected AbstractRequestFailureProxy<WritableIdentifier, MockFailure> externalizableProxy(
+        protected RequestFailure.SerialForm<WritableIdentifier, MockFailure> externalizableProxy(
                 final ABIVersion version) {
             return new MockRequestFailureProxy(this);
         }
index d566e0ec3b4f515903fa8894862bae9bb978a33e..f77500328d06a01ae1482c1a0fb39ebd1085e2d9 100644 (file)
@@ -38,8 +38,6 @@ import org.mockito.ArgumentCaptor;
 import org.mockito.Mock;
 import org.mockito.junit.MockitoJUnitRunner;
 import org.opendaylight.controller.cluster.access.ABIVersion;
-import org.opendaylight.controller.cluster.access.concepts.AbstractRequestFailureProxy;
-import org.opendaylight.controller.cluster.access.concepts.AbstractRequestProxy;
 import org.opendaylight.controller.cluster.access.concepts.FailureEnvelope;
 import org.opendaylight.controller.cluster.access.concepts.Request;
 import org.opendaylight.controller.cluster.access.concepts.RequestEnvelope;
@@ -64,8 +62,7 @@ public class ConnectingClientConnectionTest {
         }
 
         @Override
-        protected AbstractRequestFailureProxy<WritableIdentifier, MockFailure> externalizableProxy(
-                final ABIVersion version) {
+        protected SerialForm<WritableIdentifier, MockFailure> externalizableProxy(final ABIVersion version) {
             return null;
         }
 
@@ -88,7 +85,7 @@ public class ConnectingClientConnectionTest {
         }
 
         @Override
-        protected AbstractRequestProxy<WritableIdentifier, MockRequest> externalizableProxy(final ABIVersion version) {
+        protected Request.SerialForm<WritableIdentifier, MockRequest> externalizableProxy(final ABIVersion version) {
             return null;
         }
 
index 2d1afb81adea475069edba3193e873f2fe9e3ecf..b3bfdec66e9b0c184daeb7e4127495e59c66006d 100644 (file)
@@ -26,8 +26,6 @@ import org.junit.runner.RunWith;
 import org.mockito.Mock;
 import org.mockito.junit.MockitoJUnitRunner;
 import org.opendaylight.controller.cluster.access.ABIVersion;
-import org.opendaylight.controller.cluster.access.concepts.AbstractRequestFailureProxy;
-import org.opendaylight.controller.cluster.access.concepts.AbstractRequestProxy;
 import org.opendaylight.controller.cluster.access.concepts.Request;
 import org.opendaylight.controller.cluster.access.concepts.RequestException;
 import org.opendaylight.controller.cluster.access.concepts.RequestFailure;
@@ -47,8 +45,7 @@ public class ConnectionEntryTest {
         }
 
         @Override
-        protected AbstractRequestFailureProxy<WritableIdentifier, MockFailure> externalizableProxy(
-                final ABIVersion version) {
+        protected SerialForm<WritableIdentifier, MockFailure> externalizableProxy(final ABIVersion version) {
             return null;
         }
 
@@ -71,7 +68,7 @@ public class ConnectionEntryTest {
         }
 
         @Override
-        protected AbstractRequestProxy<WritableIdentifier, MockRequest> externalizableProxy(final ABIVersion version) {
+        protected Request.SerialForm<WritableIdentifier, MockRequest> externalizableProxy(final ABIVersion version) {
             return null;
         }
 
index 95089119e4a2c848d54299436a608f5f87cbec64..cdb1ac9c3a9ec5195d8ab869293070c0bc813338 100644 (file)
@@ -97,7 +97,7 @@ abstract class AbstractShardBackendResolver extends BackendInfoResolver<ShardBac
     // FIXME: we really need just ActorContext.findPrimaryShardAsync()
     AbstractShardBackendResolver(final ClientIdentifier clientId, final ActorUtils actorUtils) {
         this.actorUtils = requireNonNull(actorUtils);
-        connectFunction = ExplicitAsk.toScala(t -> new ConnectClientRequest(clientId, t, ABIVersion.MAGNESIUM,
+        connectFunction = ExplicitAsk.toScala(t -> new ConnectClientRequest(clientId, t, ABIVersion.CHLORINE_SR2,
             ABIVersion.current()));
     }
 
@@ -107,7 +107,7 @@ abstract class AbstractShardBackendResolver extends BackendInfoResolver<ShardBac
         return () -> staleBackendInfoCallbacks.remove(callback);
     }
 
-    protected void notifyStaleBackendInfoCallbacks(Long cookie) {
+    protected void notifyStaleBackendInfoCallbacks(final Long cookie) {
         staleBackendInfoCallbacks.forEach(callback -> callback.accept(cookie));
     }