Fix checkstyle issues to enforce it

Fix checkstyle issues to enforce it.

Change-Id: I4655246739b0fa44a69487314549fc00860c9ec3
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

diff --git a/opendaylight/config/config-persister-api/pom.xml b/opendaylight/config/config-persister-api/pom.xml
index 749c89413e674a57807db6c7768fa1ad598b38ee..7dc22818ab5fff93982ed35bae5fcd95fe2984f3 100644 (file)
--- a/opendaylight/config/config-persister-api/pom.xml
+++ b/opendaylight/config/config-persister-api/pom.xml
@@ -24,6 +24,13 @@
 
   <build>
     <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
+        <configuration>
+          <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
+        </configuration>
+      </plugin>
       <plugin>
         <groupId>org.apache.felix</groupId>
         <artifactId>maven-bundle-plugin</artifactId>

diff --git a/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigPusher.java b/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigPusher.java
index 106ab6b9f6a867e740498ae1e1e61ab3c1f67854..a7d1a7d94bca471a5b5797d0f4ef4401ab7ce364 100644 (file)
--- a/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigPusher.java
+++ b/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigPusher.java
@@ -8,6 +8,7 @@
 package org.opendaylight.controller.config.persist.api;
 
 import java.util.List;
+
 /*
  * The config pusher service pushes configs into the config subsystem
  */

diff --git a/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigSnapshotHolder.java b/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigSnapshotHolder.java
index ba13ebb8f051e65d31c5a663daee15b1034d0134..9c4145ce1a73ba09d92c284d1927346337d1c914 100644 (file)
--- a/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigSnapshotHolder.java
+++ b/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigSnapshotHolder.java
@@ -12,7 +12,7 @@ import java.util.SortedSet;
 public interface ConfigSnapshotHolder {
 
     /**
-     * Get XML node that should be pushed to netconf's edit-config
+     * Get XML node that should be pushed to netconf's edit-config.
      */
     String getConfigSnapshot();
 
@@ -22,5 +22,4 @@ public interface ConfigSnapshotHolder {
      * If no value is specified, return empty set instead of null
      */
     SortedSet<String> getCapabilities();
-
 }

diff --git a/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigSnapshotHolderImpl.java b/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigSnapshotHolderImpl.java
index 0bfb975dec0750de332deaa17d0eb14de1baafc5..05af40a8513831b8ab59f5be344a510a5fd5318a 100644 (file)
--- a/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigSnapshotHolderImpl.java
+++ b/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/ConfigSnapshotHolderImpl.java
@@ -15,7 +15,9 @@ public class ConfigSnapshotHolderImpl implements ConfigSnapshotHolder {
     private final SortedSet<String> caps;
     private final String fileName;
 
-    public ConfigSnapshotHolderImpl(final String configSnapshot, final SortedSet<String> capabilities, final String fileName) {
+    public ConfigSnapshotHolderImpl(final String configSnapshot,
+                                    final SortedSet<String> capabilities,
+                                    final String fileName) {
         this.snapshot = configSnapshot;
         this.caps = capabilities;
         this.fileName = fileName;
@@ -37,10 +39,9 @@ public class ConfigSnapshotHolderImpl implements ConfigSnapshotHolder {
 
     @Override
     public String toString() {
-        return "ConfigSnapshotHolderImpl{" +
-                "snapshot='" + snapshot + '\'' +
-                ", caps=" + caps +
-                ", fileName='" + fileName + '\'' +
-                '}';
+        return "snapshot='" + "ConfigSnapshotHolderImpl{"
+                + snapshot + '\'' + ", caps="
+                + caps + ", fileName='"
+                + fileName + '\'' + '}';
     }
 }

diff --git a/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/PropertiesProvider.java b/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/PropertiesProvider.java
index 156fa580ce0c2403c78451d73702237f46f5ad79..0bea336eaa7814b4413987512120c91e17129cd7 100644 (file)
--- a/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/PropertiesProvider.java
+++ b/opendaylight/config/config-persister-api/src/main/java/org/opendaylight/controller/config/persist/api/PropertiesProvider.java
@@ -15,10 +15,13 @@ public interface PropertiesProvider {
     String getProperty(String key);
 
     /**
+     * Get full key reporting.
+     *
      * @return prefix + key as used in getProperty method.
      */
     String getFullKeyForReporting(String key);
 
     String getPrefix();
+
     String getPropertyWithoutPrefix(String fullKey);
 }

diff --git a/opendaylight/config/config-persister-api/src/test/java/org/opendaylight/controller/config/persist/test/PropertiesProviderTest.java b/opendaylight/config/config-persister-api/src/test/java/org/opendaylight/controller/config/persist/test/PropertiesProviderTest.java
index d47cdbd7b507606db61182f4e62817e7e786931a..e88968125cf68126ed28a69a54bd6fd178de8bd3 100644 (file)
--- a/opendaylight/config/config-persister-api/src/test/java/org/opendaylight/controller/config/persist/test/PropertiesProviderTest.java
+++ b/opendaylight/config/config-persister-api/src/test/java/org/opendaylight/controller/config/persist/test/PropertiesProviderTest.java
@@ -9,14 +9,16 @@ package org.opendaylight.controller.config.persist.test;
 
 import java.util.HashMap;
 import java.util.Map;
+
 import org.opendaylight.controller.config.persist.api.PropertiesProvider;
 
 public class PropertiesProviderTest implements PropertiesProvider {
-    private final Map<String,String> properties = new HashMap<>();
+    private final Map<String, String> properties = new HashMap<>();
 
-    public void addProperty(final String key, final String value){
-        properties.put(key,value);
+    public void addProperty(final String key, final String value) {
+        properties.put(key, value);
     }
+
     @Override
     public String getProperty(final String key) {
         return properties.get(key);