Do not use MoreExecutors.sameThreadExecutor() 72/28772/5
authorRobert Varga <rovarga@cisco.com>
Sat, 24 Oct 2015 11:25:33 +0000 (13:25 +0200)
committerGerrit Code Review <gerrit@opendaylight.org>
Tue, 27 Oct 2015 19:19:40 +0000 (19:19 +0000)
This method is deprecated, replace it with proper service/executor.

Change-Id: I7257a28f28784313cafc250f2c2fd1c623332dec
Signed-off-by: Robert Varga <rovarga@cisco.com>
opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ConcurrentDOMDataBrokerTest.java
opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerRegistrationProxyTest.java
opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerRegistrationTest.java
opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerProxyTest.java
opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerRegistrationActorTest.java
opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/modification/AbstractModificationTest.java

index b1587bbcfb476f3bfdf9ae0de3cc19980b4f4083..7f481019ae853591b5d2d20434ec0ad0f91baa77 100644 (file)
@@ -82,7 +82,7 @@ public class ConcurrentDOMDataBrokerTest {
         doReturn("tx").when(transaction).getIdentifier();
 
         DOMStore store = new InMemoryDOMDataStore("OPER",
-            MoreExecutors.sameThreadExecutor());
+            MoreExecutors.newDirectExecutorService());
 
         coordinator = new ConcurrentDOMDataBroker(ImmutableMap.of(LogicalDatastoreType.OPERATIONAL, store), futureExecutor);
     }
index 6ab247c424e4f966c1a92c6865d40e220bbe449a..aa95e78d888ca1dfc7c0a0b699bfa26bfbea76dd 100644 (file)
@@ -254,7 +254,7 @@ public class DataChangeListenerRegistrationProxyTest extends AbstractActorTest {
                     "testFailedRegistration");
             doReturn(mockActor).when(mockActorSystem).actorOf(any(Props.class));
             ExecutionContextExecutor executor = ExecutionContexts.fromExecutor(
-                    MoreExecutors.sameThreadExecutor());
+                    MoreExecutors.directExecutor());
 
 
             ActorContext actorContext = mock(ActorContext.class);
index 1048ee10757d68f4efea28e51351e4110419ca00..a499ab3030a1597b66a2c3b5712e59d05570ac67 100644 (file)
@@ -25,7 +25,7 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
 import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
 
 public class DataChangeListenerRegistrationTest extends AbstractActorTest {
-  private static final InMemoryDOMDataStore store = new InMemoryDOMDataStore("OPER", MoreExecutors.sameThreadExecutor());
+  private static final InMemoryDOMDataStore store = new InMemoryDOMDataStore("OPER", MoreExecutors.newDirectExecutorService());
 
   static {
     store.onGlobalContextUpdated(TestModel.createTestContext());
index eed2a138432c9a4974292d41fa4c2ac65f509c9a..924f650e2caea19da8e65dc9bfec8b5aac8d271d 100644 (file)
@@ -171,7 +171,7 @@ public class DataTreeChangeListenerProxyTest extends AbstractActorTest {
                     "testFailedRegistration");
             doReturn(mockActor).when(mockActorSystem).actorOf(any(Props.class));
             ExecutionContextExecutor executor = ExecutionContexts.fromExecutor(
-                    MoreExecutors.sameThreadExecutor());
+                    MoreExecutors.directExecutor());
 
 
             ActorContext actorContext = mock(ActorContext.class);
index 569591179831b353594a22bae417c8fff9691cdc..0d336096ab8dd5857c85c32007e7719c582ce7ed 100644 (file)
@@ -20,7 +20,7 @@ import org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMDataStore;
 import org.opendaylight.yangtools.concepts.ListenerRegistration;
 
 public class DataTreeChangeListenerRegistrationActorTest extends AbstractActorTest {
-    private static final InMemoryDOMDataStore store = new InMemoryDOMDataStore("OPER", MoreExecutors.sameThreadExecutor());
+    private static final InMemoryDOMDataStore store = new InMemoryDOMDataStore("OPER", MoreExecutors.newDirectExecutorService());
 
     static {
         store.onGlobalContextUpdated(TestModel.createTestContext());
index abb2d31df32f2bce8200126b6261a16b7b467211..d02f78dc860210c5fad0e6bb0836bfa12ac53226 100644 (file)
@@ -26,7 +26,7 @@ public abstract class AbstractModificationTest {
 
   @Before
   public void setUp(){
-    store = new InMemoryDOMDataStore("test", MoreExecutors.sameThreadExecutor());
+    store = new InMemoryDOMDataStore("test", MoreExecutors.newDirectExecutorService());
     store.onGlobalContextUpdated(TestModel.createTestContext());
   }