From: Robert Varga Date: Wed, 10 Nov 2021 12:52:15 +0000 (+0100) Subject: Fixup assertions a bit X-Git-Tag: v4.0.7~29 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=07efe2f14bac8054dddca07b8d9b75238a0e14cd Fixup assertions a bit The tests are using different transaction mix, pass down explicit expected transaction count. Change-Id: I5007fe0ad90009fcafb727bac8d37bd07dfaae94 Signed-off-by: Robert Varga --- diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DistributedDataStoreRemotingIntegrationTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DistributedDataStoreRemotingIntegrationTest.java index 542a79840d..a1b3d4ecde 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DistributedDataStoreRemotingIntegrationTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DistributedDataStoreRemotingIntegrationTest.java @@ -387,7 +387,7 @@ public class DistributedDataStoreRemotingIntegrationTest extends AbstractTest { final var clientMeta = frontendMetadata.getClients().get(0); if (leaderDistributedDataStore.getActorUtils().getDatastoreContext().isUseTellBasedProtocol()) { - assertTellClientMetadata(clientMeta, numCars); + assertTellClientMetadata(clientMeta, numCars * 2); } else { assertAskClientMetadata(clientMeta); } @@ -405,7 +405,7 @@ public class DistributedDataStoreRemotingIntegrationTest extends AbstractTest { assertEquals(List.of(), clientMeta.getCurrentHistories()); } - private void assertTellClientMetadata(final FrontendClientMetadata clientMeta, final int numCars) { + private void assertTellClientMetadata(final FrontendClientMetadata clientMeta, final long lastPurged) { final var iterator = clientMeta.getCurrentHistories().iterator(); var metadata = iterator.next(); while (iterator.hasNext() && metadata.getHistoryId() != 1) { @@ -416,7 +416,7 @@ public class DistributedDataStoreRemotingIntegrationTest extends AbstractTest { assumeTrue(false); assertEquals(UnsignedLongBitmap.of(), metadata.getClosedTransactions()); - assertEquals("[[0.." + numCars * 2 + "]]", metadata.getPurgedTransactions().toString()); + assertEquals("[[0.." + lastPurged + "]]", metadata.getPurgedTransactions().ranges().toString()); } @Test @@ -460,7 +460,7 @@ public class DistributedDataStoreRemotingIntegrationTest extends AbstractTest { final var clientMeta = frontendMetadata.getClients().get(0); if (leaderDistributedDataStore.getActorUtils().getDatastoreContext().isUseTellBasedProtocol()) { - assertTellClientMetadata(clientMeta, numCars); + assertTellClientMetadata(clientMeta, numCars * 2 + 1); } else { assertAskClientMetadata(clientMeta); }