From: Robert Varga Date: Mon, 3 Apr 2023 12:03:34 +0000 (+0200) Subject: Clean up RpcErrorsException X-Git-Tag: v6.0.8~24 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=0b812fba3f5761351c6b3364ac79041ca57a95e0 Clean up RpcErrorsException Fix whitespace and use local variable type inference to improve sizing. Change-Id: I344305a59e3b0078d942636c339d1686c006e4a3 Signed-off-by: Robert Varga (cherry picked from commit fc3cdd82fa019e010afc624e1a0f1d56609c0a59) --- diff --git a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RpcErrorsException.java b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RpcErrorsException.java index 51fa0ce398..d75805c3fe 100644 --- a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RpcErrorsException.java +++ b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/RpcErrorsException.java @@ -5,7 +5,6 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ - package org.opendaylight.controller.remote.rpc; import java.io.Serializable; @@ -25,10 +24,11 @@ import org.opendaylight.yangtools.yang.common.RpcResultBuilder; * @author Thomas Pantelis */ public class RpcErrorsException extends DOMRpcException { - + @java.io.Serial private static final long serialVersionUID = 1L; private static class RpcErrorData implements Serializable { + @java.io.Serial private static final long serialVersionUID = 1L; final ErrorSeverity severity; @@ -56,7 +56,7 @@ public class RpcErrorsException extends DOMRpcException { public RpcErrorsException(final String message, final Iterable rpcErrors) { super(message); - for (final RpcError rpcError: rpcErrors) { + for (var rpcError : rpcErrors) { rpcErrorDataList.add(new RpcErrorData(rpcError.getSeverity(), rpcError.getErrorType(), rpcError.getTag(), rpcError.getApplicationTag(), rpcError.getMessage(), rpcError.getInfo(), rpcError.getCause())); @@ -64,8 +64,8 @@ public class RpcErrorsException extends DOMRpcException { } public Collection getRpcErrors() { - final Collection rpcErrors = new ArrayList<>(); - for (final RpcErrorData ed: rpcErrorDataList) { + final var rpcErrors = new ArrayList(); + for (var ed : rpcErrorDataList) { final RpcError rpcError = ed.severity == ErrorSeverity.ERROR ? RpcResultBuilder.newError(ed.errorType, ed.tag, ed.message, ed.applicationTag, ed.info, ed.cause) :