From: Giovanni Meo Date: Tue, 26 Nov 2013 11:37:38 +0000 (+0000) Subject: Merge "HostTracker hosts DB key scheme implementation" X-Git-Tag: jenkins-controller-bulk-release-prepare-only-2-1~347 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=0f14bf97fb20a4d506a7ed4826b2a6ed3b9ebeab;hp=1b50bf01cd8dab4b32ce696f58d722d6c81db1af Merge "HostTracker hosts DB key scheme implementation" --- diff --git a/opendaylight/config/config-api/src/main/resources/META-INF/yang/config.yang b/opendaylight/config/config-api/src/main/resources/META-INF/yang/config.yang index 5d6c11fbee..a0a4292adf 100644 --- a/opendaylight/config/config-api/src/main/resources/META-INF/yang/config.yang +++ b/opendaylight/config/config-api/src/main/resources/META-INF/yang/config.yang @@ -122,9 +122,7 @@ module config { the actual service-type which is actually required."; mandatory true; - type leafref { - path "/config:services/config:service/config:type"; - } + type service-type-ref; } leaf name { diff --git a/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/ModuleMXBeanEntry.java b/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/ModuleMXBeanEntry.java index 590081072b..70a4edde41 100644 --- a/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/ModuleMXBeanEntry.java +++ b/opendaylight/config/yang-jmx-generator/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/ModuleMXBeanEntry.java @@ -7,21 +7,8 @@ */ package org.opendaylight.controller.config.yangjmxgenerator; -import static com.google.common.base.Preconditions.checkNotNull; -import static com.google.common.base.Preconditions.checkState; -import static java.lang.String.format; -import static org.opendaylight.controller.config.yangjmxgenerator.ConfigConstants.createConfigQName; - -import java.util.Arrays; -import java.util.Collection; -import java.util.Collections; -import java.util.HashMap; -import java.util.Map; -import java.util.Map.Entry; -import java.util.Set; -import java.util.regex.Matcher; -import java.util.regex.Pattern; - +import com.google.common.annotations.VisibleForTesting; +import com.google.common.collect.Sets; import org.opendaylight.controller.config.yangjmxgenerator.attribute.AttributeIfc; import org.opendaylight.controller.config.yangjmxgenerator.attribute.DependencyAttribute; import org.opendaylight.controller.config.yangjmxgenerator.attribute.JavaAttribute; @@ -50,8 +37,20 @@ import org.opendaylight.yangtools.yang.model.api.UsesNode; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import com.google.common.annotations.VisibleForTesting; -import com.google.common.collect.Sets; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Map.Entry; +import java.util.Set; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +import static com.google.common.base.Preconditions.checkNotNull; +import static com.google.common.base.Preconditions.checkState; +import static java.lang.String.format; +import static org.opendaylight.controller.config.yangjmxgenerator.ConfigConstants.createConfigQName; /** * Represents part of yang model that describes a module. @@ -129,13 +128,13 @@ public class ModuleMXBeanEntry extends AbstractEntry { private final String nullableDescription, packageName, javaNamePrefix, namespace; - private final Map providedServices; + private final Map providedServices; private Collection runtimeBeans; public ModuleMXBeanEntry(IdentitySchemaNode id, Map yangToAttributes, String packageName, - Map providedServices2, String javaNamePrefix, + Map providedServices2, String javaNamePrefix, String namespace, Collection runtimeBeans) { this.globallyUniqueName = id.getQName().getLocalName(); this.yangToAttributes = yangToAttributes; @@ -180,7 +179,11 @@ public class ModuleMXBeanEntry extends AbstractEntry { return packageName; } - public Map getProvidedServices() { + /** + * @return services implemented by this module. Keys are fully qualified java names of generated + * ServiceInterface classes, values are identity local names. + */ + public Map getProvidedServices() { return providedServices; } @@ -313,7 +316,7 @@ public class ModuleMXBeanEntry extends AbstractEntry { checkState(moduleIdentity != null, "Cannot find identity " + moduleLocalNameFromXPath + " matching augmentation " + augmentation); - Map providedServices = findProvidedServices( + Map providedServices = findProvidedServices( moduleIdentity, currentModule, qNamesToSIEs, schemaContext); @@ -493,11 +496,11 @@ public class ModuleMXBeanEntry extends AbstractEntry { return yangToAttributes; } - private static Map findProvidedServices( + private static Map findProvidedServices( IdentitySchemaNode moduleIdentity, Module currentModule, Map qNamesToSIEs, SchemaContext schemaContext) { - Map result = new HashMap<>(); + Map result = new HashMap<>(); for (UnknownSchemaNode unknownNode : moduleIdentity .getUnknownSchemaNodes()) { if (ConfigConstants.PROVIDED_SERVICE_EXTENSION_QNAME @@ -506,8 +509,7 @@ public class ModuleMXBeanEntry extends AbstractEntry { .getNodeParameter(); ServiceInterfaceEntry sie = findSIE(prefixAndIdentityLocalName, currentModule, qNamesToSIEs, schemaContext); - result.put(sie.getFullyQualifiedName(), sie.getQName() - .getLocalName()); + result.put(sie.getFullyQualifiedName(), sie.getQName()); } } return result; diff --git a/opendaylight/config/yang-store-api/src/main/java/org/opendaylight/controller/config/yang/store/api/YangStoreSnapshot.java b/opendaylight/config/yang-store-api/src/main/java/org/opendaylight/controller/config/yang/store/api/YangStoreSnapshot.java index 40daf4018a..da8b5e4ed1 100644 --- a/opendaylight/config/yang-store-api/src/main/java/org/opendaylight/controller/config/yang/store/api/YangStoreSnapshot.java +++ b/opendaylight/config/yang-store-api/src/main/java/org/opendaylight/controller/config/yang/store/api/YangStoreSnapshot.java @@ -15,7 +15,8 @@ import org.opendaylight.yangtools.yang.model.api.Module; public interface YangStoreSnapshot extends AutoCloseable { - Map> getModuleMXBeanEntryMap(); + Map> getModuleMXBeanEntryMap(); Map> getModuleMap(); diff --git a/opendaylight/config/yang-store-impl/src/main/java/org/opendaylight/controller/config/yang/store/impl/ExtenderYangTracker.java b/opendaylight/config/yang-store-impl/src/main/java/org/opendaylight/controller/config/yang/store/impl/ExtenderYangTracker.java index 2ead596d05..fcdc10f109 100644 --- a/opendaylight/config/yang-store-impl/src/main/java/org/opendaylight/controller/config/yang/store/impl/ExtenderYangTracker.java +++ b/opendaylight/config/yang-store-impl/src/main/java/org/opendaylight/controller/config/yang/store/impl/ExtenderYangTracker.java @@ -18,6 +18,8 @@ import com.google.common.collect.Sets; import org.opendaylight.controller.config.yang.store.api.YangStoreException; import org.opendaylight.controller.config.yang.store.api.YangStoreService; import org.opendaylight.controller.config.yang.store.api.YangStoreSnapshot; +import org.opendaylight.controller.config.yangjmxgenerator.ModuleMXBeanEntry; +import org.opendaylight.yangtools.yang.model.api.Module; import org.osgi.framework.Bundle; import org.osgi.framework.BundleContext; import org.osgi.framework.BundleEvent; @@ -34,6 +36,7 @@ import java.util.Collection; import java.util.Collections; import java.util.Enumeration; import java.util.List; +import java.util.Map; import java.util.Set; import java.util.regex.Matcher; import java.util.regex.Pattern; @@ -107,38 +110,42 @@ public class ExtenderYangTracker extends BundleTracker implements YangSt proposedNewState.putAll(bundle, addedURLs); Preconditions.checkArgument(addedURLs.size() > 0, "No change can occur when no URLs are changed"); - boolean success; - String failureReason = null; + try(YangStoreSnapshotImpl snapshot = createSnapshot(mbeParser, proposedNewState)) { - updateCache(snapshot); - success = true; + onSnapshotSuccess(proposedNewState, snapshot); } catch(YangStoreException e) { - failureReason = e.toString(); - success = false; - } - if (success){ - // consistent state - // merge into - consistentBundlesToYangURLs.clear(); - consistentBundlesToYangURLs.putAll(proposedNewState); - inconsistentBundlesToYangURLs.clear(); - - logger.info("Yang store updated to new consistent state containing {} yang files", consistentBundlesToYangURLs.size()); - logger.trace("Yang store updated to new consistent state containing {}", consistentBundlesToYangURLs); - } else { - // inconsistent state - logger.debug("Yang store is falling back on last consistent state containing {}, inconsistent yang files {}, reason {}", - consistentBundlesToYangURLs, inconsistentBundlesToYangURLs, failureReason); - logger.warn("Yang store is falling back on last consistent state containing {} files, inconsistent yang files size is {}, reason {}", - consistentBundlesToYangURLs.size(), inconsistentBundlesToYangURLs.size(), failureReason); - inconsistentBundlesToYangURLs.putAll(bundle, addedURLs); + onSnapshotFailure(bundle, addedURLs, e); } } } return bundle; } - private void updateCache(YangStoreSnapshotImpl snapshot) { + private synchronized void onSnapshotFailure(Bundle bundle, List addedURLs, Exception failureReason) { + // inconsistent state + inconsistentBundlesToYangURLs.putAll(bundle, addedURLs); + + logger.debug("Yang store is falling back on last consistent state containing {}, inconsistent yang files {}, reason {}", + consistentBundlesToYangURLs, inconsistentBundlesToYangURLs, failureReason); + logger.warn("Yang store is falling back on last consistent state containing {} files, inconsistent yang files size is {}, reason {}", + consistentBundlesToYangURLs.size(), inconsistentBundlesToYangURLs.size(), failureReason.toString()); + cache.setInconsistentURLsForReporting(inconsistentBundlesToYangURLs.values()); + } + + private synchronized void onSnapshotSuccess(Multimap proposedNewState, YangStoreSnapshotImpl snapshot) { + // consistent state + // merge into + consistentBundlesToYangURLs.clear(); + consistentBundlesToYangURLs.putAll(proposedNewState); + inconsistentBundlesToYangURLs.clear(); + + updateCache(snapshot); + cache.setInconsistentURLsForReporting(Collections. emptySet()); + logger.info("Yang store updated to new consistent state containing {} yang files", consistentBundlesToYangURLs.size()); + logger.debug("Yang store updated to new consistent state containing {}", consistentBundlesToYangURLs); + } + + private synchronized void updateCache(YangStoreSnapshotImpl snapshot) { cache.cacheYangStore(consistentBundlesToYangURLs, snapshot); } @@ -153,6 +160,7 @@ public class ExtenderYangTracker extends BundleTracker implements YangSt */ @Override public synchronized void removedBundle(Bundle bundle, BundleEvent event, Object object) { + logger.debug("Removed bundle {} {} {}", bundle, event, object); inconsistentBundlesToYangURLs.removeAll(bundle); consistentBundlesToYangURLs.removeAll(bundle); } @@ -162,9 +170,10 @@ public class ExtenderYangTracker extends BundleTracker implements YangSt throws YangStoreException { Optional yangStoreOpt = cache.getSnapshotIfPossible(consistentBundlesToYangURLs); if (yangStoreOpt.isPresent()) { - logger.trace("Returning cached yang store {}", yangStoreOpt.get()); + logger.debug("Returning cached yang store {}", yangStoreOpt.get()); return yangStoreOpt.get(); } + YangStoreSnapshotImpl snapshot = createSnapshot(mbeParser, consistentBundlesToYangURLs); updateCache(snapshot); return snapshot; @@ -205,18 +214,27 @@ public class ExtenderYangTracker extends BundleTracker implements YangSt } class YangStoreCache { + private static final Logger logger = LoggerFactory.getLogger(YangStoreCache.class); + + @GuardedBy("this") + private Set cachedUrls = null; @GuardedBy("this") - private Set cachedUrls = Collections.emptySet(); + private Optional cachedYangStoreSnapshot = getInitialSnapshot(); @GuardedBy("this") - private Optional cachedYangStoreSnapshot = Optional.absent(); + private Collection inconsistentURLsForReporting = Collections.emptySet(); synchronized Optional getSnapshotIfPossible(Multimap bundlesToYangURLs) { Set urls = setFromMultimapValues(bundlesToYangURLs); - if (cachedUrls != null && cachedUrls.equals(urls)) { + + if (cachedUrls==null || cachedUrls.equals(urls)) { Preconditions.checkState(cachedYangStoreSnapshot.isPresent()); YangStoreSnapshot freshSnapshot = new YangStoreSnapshotImpl(cachedYangStoreSnapshot.get()); + if (inconsistentURLsForReporting.size() > 0){ + logger.warn("Some yang URLs are ignored: {}", inconsistentURLsForReporting); + } return Optional.of(freshSnapshot); } + return Optional.absent(); } @@ -228,7 +246,7 @@ class YangStoreCache { } synchronized void cacheYangStore(Multimap urls, - YangStoreSnapshotImpl yangStoreSnapshot) { + YangStoreSnapshot yangStoreSnapshot) { this.cachedUrls = setFromMultimapValues(urls); this.cachedYangStoreSnapshot = Optional.of(yangStoreSnapshot); } @@ -240,4 +258,32 @@ class YangStoreCache { cachedYangStoreSnapshot = Optional.absent(); } } + + public synchronized void setInconsistentURLsForReporting(Collection urls){ + inconsistentURLsForReporting = urls; + } + + private Optional getInitialSnapshot() { + YangStoreSnapshot initialSnapshot = new YangStoreSnapshot() { + @Override + public Map> getModuleMXBeanEntryMap() { + return Collections.emptyMap(); + } + + @Override + public Map> getModuleMap() { + return Collections.emptyMap(); + } + + @Override + public int countModuleMXBeanEntries() { + return 0; + } + + @Override + public void close() { + } + }; + return Optional.of(initialSnapshot); + } } diff --git a/opendaylight/config/yang-store-impl/src/main/java/org/opendaylight/controller/config/yang/store/impl/YangStoreSnapshotImpl.java b/opendaylight/config/yang-store-impl/src/main/java/org/opendaylight/controller/config/yang/store/impl/YangStoreSnapshotImpl.java index 7a5ca7debe..ea709e1a45 100644 --- a/opendaylight/config/yang-store-impl/src/main/java/org/opendaylight/controller/config/yang/store/impl/YangStoreSnapshotImpl.java +++ b/opendaylight/config/yang-store-impl/src/main/java/org/opendaylight/controller/config/yang/store/impl/YangStoreSnapshotImpl.java @@ -29,11 +29,15 @@ public class YangStoreSnapshotImpl implements YangStoreSnapshot { this.moduleMap = Collections.unmodifiableMap(moduleMap); } - public YangStoreSnapshotImpl(YangStoreSnapshotImpl yangStoreSnapshot) { - this.moduleMXBeanEntryMap = yangStoreSnapshot.moduleMXBeanEntryMap; - this.moduleMap = yangStoreSnapshot.moduleMap; + public YangStoreSnapshotImpl(YangStoreSnapshot yangStoreSnapshot) { + this.moduleMXBeanEntryMap = yangStoreSnapshot.getModuleMXBeanEntryMap(); + this.moduleMap = yangStoreSnapshot.getModuleMap(); } + /** + * @return all loaded config modules. Key of outer map is namespace of yang file. + * Key of inner map is name of module entry. Value is module entry. + */ @Override public Map> getModuleMXBeanEntryMap() { return moduleMXBeanEntryMap; diff --git a/opendaylight/config/yang-store-impl/src/test/java/org/opendaylight/controller/config/yang/store/impl/ExtenderYangTrackerCustomizerTest.java b/opendaylight/config/yang-store-impl/src/test/java/org/opendaylight/controller/config/yang/store/impl/ExtenderYangTrackerCustomizerTest.java index c4c523992f..b4054c242c 100644 --- a/opendaylight/config/yang-store-impl/src/test/java/org/opendaylight/controller/config/yang/store/impl/ExtenderYangTrackerCustomizerTest.java +++ b/opendaylight/config/yang-store-impl/src/test/java/org/opendaylight/controller/config/yang/store/impl/ExtenderYangTrackerCustomizerTest.java @@ -9,12 +9,14 @@ package org.opendaylight.controller.config.yang.store.impl; import com.google.common.base.Optional; import com.google.common.collect.Lists; +import com.google.common.collect.Maps; import org.junit.Before; import org.junit.Test; import org.mockito.Mock; import org.mockito.MockitoAnnotations; import org.opendaylight.controller.config.yang.store.api.YangStoreException; import org.opendaylight.controller.config.yang.store.api.YangStoreSnapshot; +import org.opendaylight.yangtools.yang.model.api.Module; import org.osgi.framework.Bundle; import org.osgi.framework.BundleContext; import org.osgi.framework.BundleListener; @@ -25,6 +27,7 @@ import java.net.URL; import java.util.Collections; import java.util.Enumeration; import java.util.List; +import java.util.Map; import java.util.regex.Pattern; import static org.junit.Assert.assertEquals; @@ -48,8 +51,28 @@ public class ExtenderYangTrackerCustomizerTest { @Mock private BundleContext bundleContext; + private Map> moduleMap = Maps.newHashMap(); + @Before public void setUp() throws YangStoreException { + + moduleMap.put("1", new Map.Entry() { + @Override + public Module getKey() { + return mock(Module.class); + } + + @Override + public String getValue() { + return "v"; + } + + @Override + public String setValue(String value) { + return "v"; + } + }); + MockitoAnnotations.initMocks(this); doNothing().when(bundleContext).addBundleListener(any(BundleListener.class)); doReturn(new Bundle[0]).when(bundleContext).getBundles(); @@ -59,7 +82,8 @@ public class ExtenderYangTrackerCustomizerTest { doReturn(22).when(yangStoreSnapshot).countModuleMXBeanEntries(); doReturn("mock yang store").when(yangStoreSnapshot).toString(); doNothing().when(yangStoreSnapshot).close(); - doReturn(Collections.emptyMap()).when(yangStoreSnapshot).getModuleMap(); + doReturn(moduleMap).when(yangStoreSnapshot).getModuleMap(); + doReturn(Collections.emptyMap()).when(yangStoreSnapshot).getModuleMXBeanEntryMap(); } @Test @@ -75,7 +99,7 @@ public class ExtenderYangTrackerCustomizerTest { returnedStore = tested.getYangStoreSnapshot(); - assertEquals(yangStoreSnapshot, returnedStore); + assertEquals(yangStoreSnapshot.getModuleMap(), returnedStore.getModuleMap()); tested.removedBundle(bundle, null, null); tested.getYangStoreSnapshot(); @@ -87,7 +111,7 @@ public class ExtenderYangTrackerCustomizerTest { tested.getYangStoreSnapshot(); } - verify(parser, times(7)).parseYangFiles(anyCollectionOf(InputStream.class)); + verify(parser, times(5)).parseYangFiles(anyCollectionOf(InputStream.class)); returnedStore = tested.getYangStoreSnapshot(); diff --git a/opendaylight/distribution/opendaylight/src/main/resources/configuration/config.ini b/opendaylight/distribution/opendaylight/src/main/resources/configuration/config.ini index 1db1d759f3..bfc3962040 100644 --- a/opendaylight/distribution/opendaylight/src/main/resources/configuration/config.ini +++ b/opendaylight/distribution/opendaylight/src/main/resources/configuration/config.ini @@ -22,7 +22,9 @@ netconf.tcp.port=8383 #netconf.tls.keystore= #netconf.tls.keystore.password= -netconf.config.persister.storageAdapterClass=org.opendaylight.controller.netconf.persist.impl.NoOpStorageAdapter +netconf.config.persister.storageAdapterClass=org.opendaylight.controller.config.persist.storage.file.FileStorageAdapter +fileStorage=configuration/controller.config +numberOfBackups=1 yangstore.blacklist=.*controller.model.* # Set Default start level for framework diff --git a/opendaylight/distribution/opendaylight/src/main/resources/configuration/controller.config b/opendaylight/distribution/opendaylight/src/main/resources/configuration/controller.config new file mode 100644 index 0000000000..fa0b5893d5 --- /dev/null +++ b/opendaylight/distribution/opendaylight/src/main/resources/configuration/controller.config @@ -0,0 +1,129 @@ +//START OF CONFIG-LAST + + + + prefix:schema-service-singleton + yang-schema-service + + + prefix:hash-map-data-store + hash-map-data-store + + + prefix:dom-broker-impl + dom-broker + + dom:dom-data-store + ref_hash-map-data-store + + + + prefix:binding-broker-impl + binding-broker-impl + + binding:binding-notification-service + ref_binding-notification-broker + + + binding:binding-data-broker + ref_binding-data-broker + + + + prefix:runtime-generated-mapping + runtime-mapping-singleton + + + prefix:binding-notification-broker + binding-notification-broker + + + prefix:binding-data-broker + binding-data-broker + + dom:dom-broker-osgi-registry + ref_dom-broker + + + binding:binding-dom-mapping-service + ref_runtime-mapping-singleton + + + + + + dom:schema-service + + ref_yang-schema-service + /config/modules/module[name='schema-service-singleton']/instance[name='yang-schema-service'] + + + + binding:binding-notification-service + + ref_binding-notification-broker + /config/modules/module[name='binding-notification-broker']/instance[name='binding-notification-broker'] + + + + dom:dom-data-store + + ref_hash-map-data-store + /config/modules/module[name='hash-map-data-store']/instance[name='hash-map-data-store'] + + + + binding:binding-broker-osgi-registry + + ref_binding-broker-impl + /config/modules/module[name='binding-broker-impl']/instance[name='binding-broker-impl'] + + + + binding-impl:binding-dom-mapping-service + + ref_runtime-mapping-singleton + /config/modules/module[name='runtime-generated-mapping']/instance[name='runtime-mapping-singleton'] + + + + dom:dom-broker-osgi-registry + + ref_dom-broker + /config/modules/module[name='dom-broker-impl']/instance[name='dom-broker'] + + + + binding:binding-data-broker + + ref_binding-data-broker + /config/modules/module[name='binding-data-broker']/instance[name='binding-data-broker'] + + + + + +//END OF SNAPSHOT +urn:opendaylight:l2:types?module=opendaylight-l2-types&revision=2013-08-27 +urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding?module=opendaylight-md-sal-binding&revision=2013-10-28 +urn:opendaylight:params:xml:ns:yang:controller:threadpool?module=threadpool&revision=2013-04-09 +urn:opendaylight:params:xml:ns:yang:controller:md:sal:dom?module=opendaylight-md-sal-dom&revision=2013-10-28 +urn:opendaylight:params:xml:ns:yang:controller:config?module=config&revision=2013-04-05 +urn:ietf:params:netconf:capability:candidate:1.0 +urn:ietf:params:xml:ns:yang:ietf-netconf-monitoring?module=ietf-netconf-monitoring&revision=2010-10-04 +urn:opendaylight:params:xml:ns:yang:controller:netty:eventexecutor?module=netty-event-executor&revision=2013-11-12 +urn:ietf:params:xml:ns:yang:rpc-context?module=rpc-context&revision=2013-06-17 +urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding:impl?module=opendaylight-sal-binding-broker-impl&revision=2013-10-28 +urn:ietf:params:xml:ns:yang:ietf-inet-types?module=ietf-inet-types&revision=2010-09-24 +urn:ietf:params:netconf:capability:rollback-on-error:1.0 +urn:ietf:params:xml:ns:yang:ietf-yang-types?module=ietf-yang-types&revision=2010-09-24 +urn:opendaylight:params:xml:ns:yang:controller:threadpool:impl?module=threadpool-impl&revision=2013-04-05 +urn:opendaylight:params:xml:ns:yang:controller:md:sal:dom:impl?module=opendaylight-sal-dom-broker-impl&revision=2013-10-28 +urn:opendaylight:params:xml:ns:yang:controller:logback:config?module=config-logging&revision=2013-07-16 +urn:opendaylight:yang:extension:yang-ext?module=yang-ext&revision=2013-07-09 +urn:opendaylight:params:xml:ns:yang:iana?module=iana&revision=2013-08-16 +urn:opendaylight:params:xml:ns:yang:controller:md:sal:common?module=opendaylight-md-sal-common&revision=2013-10-28 +http://netconfcentral.org/ns/toaster?module=toaster&revision=2009-11-20 +urn:opendaylight:params:xml:ns:yang:ieee754?module=ieee754&revision=2013-08-19 +urn:opendaylight:params:xml:ns:yang:nps-concepts?module=nps-concepts&revision=2013-09-30 +//END OF CONFIG diff --git a/opendaylight/md-sal/sal-binding-broker/pom.xml b/opendaylight/md-sal/sal-binding-broker/pom.xml index c356ff6b0e..a5e5c74f4c 100644 --- a/opendaylight/md-sal/sal-binding-broker/pom.xml +++ b/opendaylight/md-sal/sal-binding-broker/pom.xml @@ -16,7 +16,6 @@ - org.opendaylight.yangtools yang-maven-plugin diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplModule.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplModule.java new file mode 100644 index 0000000000..c3fe5f70f1 --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplModule.java @@ -0,0 +1,53 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-binding-broker-impl yang module local name: binding-broker-impl +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 17:33:01 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.binding.impl; + +import org.opendaylight.controller.sal.binding.impl.BindingAwareBrokerImpl; +import org.osgi.framework.BundleContext; + +/** +* +*/ +public final class BindingBrokerImplModule extends org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractBindingBrokerImplModule +{ + + private BundleContext bundleContext; + + public BindingBrokerImplModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { + super(identifier, dependencyResolver); + } + + public BindingBrokerImplModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, BindingBrokerImplModule oldModule, java.lang.AutoCloseable oldInstance) { + super(identifier, dependencyResolver, oldModule, oldInstance); + } + + @Override + public void validate(){ + super.validate(); + // Add custom validation for module attributes here. + } + + @Override + public java.lang.AutoCloseable createInstance() { + BindingAwareBrokerImpl broker = new BindingAwareBrokerImpl(getBundleContext()); + broker.setDataBroker(getDataBrokerDependency()); + broker.setNotifyBroker(getNotificationServiceDependency()); + broker.start(); + return broker; + } + + public BundleContext getBundleContext() { + return bundleContext; + } + + public void setBundleContext(BundleContext bundleContext) { + this.bundleContext = bundleContext; + } +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplModuleFactory.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplModuleFactory.java new file mode 100644 index 0000000000..53902510be --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplModuleFactory.java @@ -0,0 +1,39 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-binding-broker-impl yang module local name: binding-broker-impl +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 17:33:01 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.binding.impl; + +import org.opendaylight.controller.config.api.DependencyResolver; +import org.opendaylight.controller.config.api.DynamicMBeanWithInstance; +import org.opendaylight.controller.config.spi.Module; +import org.osgi.framework.BundleContext; + +/** +* +*/ +public class BindingBrokerImplModuleFactory extends org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractBindingBrokerImplModuleFactory +{ + + + @Override + public Module createModule(String instanceName, DependencyResolver dependencyResolver, BundleContext bundleContext) { + BindingBrokerImplModule module = (BindingBrokerImplModule) super.createModule(instanceName, dependencyResolver, bundleContext); + module.setBundleContext(bundleContext); + return module; + } + + @Override + public Module createModule(String instanceName, DependencyResolver dependencyResolver, + DynamicMBeanWithInstance old, BundleContext bundleContext) throws Exception { + BindingBrokerImplModule module = (BindingBrokerImplModule) super.createModule(instanceName, dependencyResolver, old, bundleContext); + module.setBundleContext(bundleContext); + return module; + } + +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplSingletonModule.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplSingletonModule.java deleted file mode 100644 index ab94db988c..0000000000 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplSingletonModule.java +++ /dev/null @@ -1,57 +0,0 @@ -/* - * Copyright (c) 2013 Cisco Systems, Inc. and others. All rights reserved. - * - * This program and the accompanying materials are made available under the - * terms of the Eclipse Public License v1.0 which accompanies this distribution, - * and is available at http://www.eclipse.org/legal/epl-v10.html - */ -package org.opendaylight.controller.config.yang.md.sal.binding.impl; - -import org.opendaylight.controller.sal.binding.impl.BindingAwareBrokerImpl; -import org.osgi.framework.BundleContext; - -import com.google.common.base.Preconditions; - -/** -* -*/ -public final class BindingBrokerImplSingletonModule extends org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractBindingBrokerImplSingletonModule -{ - - private BundleContext bundleContext; - - public BindingBrokerImplSingletonModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { - super(identifier, dependencyResolver); - } - - public BindingBrokerImplSingletonModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, BindingBrokerImplSingletonModule oldModule, java.lang.AutoCloseable oldInstance) { - super(identifier, dependencyResolver, oldModule, oldInstance); - } - - @Override - public void validate() { - super.validate(); - Preconditions.checkNotNull(getBundleContext()); - } - - - @Override - public boolean canReuseInstance(AbstractBindingBrokerImplSingletonModule oldModule) { - return true; - } - - - public java.lang.AutoCloseable createInstance() { - BindingAwareBrokerImpl broker = new BindingAwareBrokerImpl(getBundleContext()); - broker.start(); - return broker; - } - - public BundleContext getBundleContext() { - return bundleContext; - } - - public void setBundleContext(BundleContext bundleContext) { - this.bundleContext = bundleContext; - } -} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplSingletonModuleFactory.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplSingletonModuleFactory.java deleted file mode 100644 index b0a63108f2..0000000000 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/BindingBrokerImplSingletonModuleFactory.java +++ /dev/null @@ -1,56 +0,0 @@ -/* - * Copyright (c) 2013 Cisco Systems, Inc. and others. All rights reserved. - * - * This program and the accompanying materials are made available under the - * terms of the Eclipse Public License v1.0 which accompanies this distribution, - * and is available at http://www.eclipse.org/legal/epl-v10.html - */ - -package org.opendaylight.controller.config.yang.md.sal.binding.impl; - -import org.opendaylight.controller.config.api.DependencyResolver; -import org.opendaylight.controller.config.api.DependencyResolverFactory; -import org.opendaylight.controller.config.api.DynamicMBeanWithInstance; -import org.opendaylight.controller.config.api.ModuleIdentifier; -import org.opendaylight.controller.config.spi.Module; -import org.osgi.framework.BundleContext; - -import java.util.Collections; -import java.util.Set; - -/** -* -*/ -public class BindingBrokerImplSingletonModuleFactory extends - org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractBindingBrokerImplSingletonModuleFactory { - - private static final String SINGLETON_NAME = "binding-broker-singleton"; - public static ModuleIdentifier SINGLETON_IDENTIFIER = new ModuleIdentifier(NAME, SINGLETON_NAME); - - @Override - public Module createModule(String instanceName, DependencyResolver dependencyResolver, BundleContext bundleContext) { - throw new UnsupportedOperationException("Only default instance supported."); - } - - @Override - public Module createModule(String instanceName, DependencyResolver dependencyResolver, - DynamicMBeanWithInstance old, BundleContext bundleContext) throws Exception { - Module instance = super.createModule(instanceName, dependencyResolver, old, bundleContext); - ((BindingBrokerImplSingletonModule)instance).setBundleContext(bundleContext); - return instance; - } - - @Override - public Set getDefaultModules(DependencyResolverFactory dependencyResolverFactory, - BundleContext bundleContext) { - - DependencyResolver dependencyResolver = dependencyResolverFactory - .createDependencyResolver(SINGLETON_IDENTIFIER); - BindingBrokerImplSingletonModule instance = new BindingBrokerImplSingletonModule(SINGLETON_IDENTIFIER, - dependencyResolver); - instance.setBundleContext(bundleContext); - - return Collections.singleton(instance); - } - -} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/DataBrokerImplModule.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/DataBrokerImplModule.java new file mode 100644 index 0000000000..8cbfbb6da2 --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/DataBrokerImplModule.java @@ -0,0 +1,83 @@ +/** + * Generated file + + * Generated from: yang module name: opendaylight-sal-binding-broker-impl yang module local name: binding-data-broker + * Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator + * Generated at: Wed Nov 20 17:33:01 CET 2013 + * + * Do not modify this file unless it is present under src/main directory + */ +package org.opendaylight.controller.config.yang.md.sal.binding.impl; + +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; + +import org.opendaylight.controller.md.sal.common.impl.routing.AbstractDataReadRouter; +import org.opendaylight.controller.sal.binding.impl.DataBrokerImpl; +import org.opendaylight.controller.sal.binding.impl.connect.dom.BindingIndependentDataServiceConnector; +import org.opendaylight.controller.sal.binding.impl.connect.dom.BindingIndependentMappingService; +import org.opendaylight.controller.sal.core.api.Broker; +import org.opendaylight.controller.sal.core.api.data.DataProviderService; +import org.opendaylight.yangtools.yang.binding.DataObject; +import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; +import org.osgi.framework.BundleContext; + +import com.google.common.util.concurrent.MoreExecutors; + +/** +* +*/ +public final class DataBrokerImplModule extends + org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractDataBrokerImplModule { + + private BundleContext bundleContext; + + public DataBrokerImplModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, + org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { + super(identifier, dependencyResolver); + } + + public DataBrokerImplModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, + org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, + DataBrokerImplModule oldModule, java.lang.AutoCloseable oldInstance) { + super(identifier, dependencyResolver, oldModule, oldInstance); + } + + @Override + public void validate() { + super.validate(); + } + + @Override + public java.lang.AutoCloseable createInstance() { + DataBrokerImpl dataBindingBroker = new DataBrokerImpl(); + + // FIXME: obtain via dependency management + ExecutorService executor = Executors.newCachedThreadPool(); + ExecutorService listeningExecutor = MoreExecutors.listeningDecorator(executor); + dataBindingBroker.setExecutor(listeningExecutor); + + + + Broker domBroker = getDomBrokerDependency(); + BindingIndependentMappingService mappingService = getMappingServiceDependency(); + + if (domBroker != null && mappingService != null) { + BindingIndependentDataServiceConnector runtimeMapping = new BindingIndependentDataServiceConnector(); + runtimeMapping.setMappingService(mappingService); + runtimeMapping.setBaDataService(dataBindingBroker); + domBroker.registerProvider(runtimeMapping, getBundleContext()); + } + + return dataBindingBroker; + } + + public BundleContext getBundleContext() { + return bundleContext; + } + + public void setBundleContext(BundleContext bundleContext2) { + this.bundleContext = bundleContext2; + } +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/DataBrokerImplModuleFactory.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/DataBrokerImplModuleFactory.java new file mode 100644 index 0000000000..4022dd44ef --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/DataBrokerImplModuleFactory.java @@ -0,0 +1,38 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-binding-broker-impl yang module local name: binding-data-broker +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 17:33:01 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.binding.impl; + +import org.opendaylight.controller.config.api.DependencyResolver; +import org.opendaylight.controller.config.api.DynamicMBeanWithInstance; +import org.opendaylight.controller.config.spi.Module; +import org.osgi.framework.BundleContext; + +/** +* +*/ +public class DataBrokerImplModuleFactory extends org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractDataBrokerImplModuleFactory +{ + + @Override + public Module createModule(String instanceName, DependencyResolver dependencyResolver, BundleContext bundleContext) { + DataBrokerImplModule module = (DataBrokerImplModule) super.createModule(instanceName, dependencyResolver, bundleContext); + module.setBundleContext(bundleContext); + return module; + } + + @Override + public Module createModule(String instanceName, DependencyResolver dependencyResolver, + DynamicMBeanWithInstance old, BundleContext bundleContext) throws Exception { + DataBrokerImplModule module = (DataBrokerImplModule) super.createModule(instanceName, dependencyResolver, old, bundleContext); + module.setBundleContext(bundleContext); + return module; + } + +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/NotificationBrokerImplModule.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/NotificationBrokerImplModule.java new file mode 100644 index 0000000000..72231d17d1 --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/NotificationBrokerImplModule.java @@ -0,0 +1,48 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-binding-broker-impl yang module local name: binding-notification-broker +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 17:33:01 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.binding.impl; + +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; + +import org.opendaylight.controller.sal.binding.impl.NotificationBrokerImpl; + +import com.google.common.util.concurrent.ListeningExecutorService; +import com.google.common.util.concurrent.MoreExecutors; + +/** +* +*/ +public final class NotificationBrokerImplModule extends org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractNotificationBrokerImplModule +{ + + public NotificationBrokerImplModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { + super(identifier, dependencyResolver); + } + + public NotificationBrokerImplModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, NotificationBrokerImplModule oldModule, java.lang.AutoCloseable oldInstance) { + super(identifier, dependencyResolver, oldModule, oldInstance); + } + + @Override + public void validate(){ + super.validate(); + // Add custom validation for module attributes here. + } + + @Override + public java.lang.AutoCloseable createInstance() { + ExecutorService executor = Executors.newFixedThreadPool(5); + ListeningExecutorService listeningExecutor = MoreExecutors.listeningDecorator(executor); + NotificationBrokerImpl broker = new NotificationBrokerImpl(listeningExecutor); + return broker; + } +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/NotificationBrokerImplModuleFactory.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/NotificationBrokerImplModuleFactory.java new file mode 100644 index 0000000000..24ca0bbfaa --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/NotificationBrokerImplModuleFactory.java @@ -0,0 +1,19 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-binding-broker-impl yang module local name: binding-notification-broker +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 17:33:01 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.binding.impl; + +/** +* +*/ +public class NotificationBrokerImplModuleFactory extends org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractNotificationBrokerImplModuleFactory +{ + + +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RpcBrokerImplModule.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RpcBrokerImplModule.java new file mode 100644 index 0000000000..7824da8939 --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RpcBrokerImplModule.java @@ -0,0 +1,37 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-binding-broker-impl yang module local name: binding-rpc-broker +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 17:33:01 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.binding.impl; + +/** +* +*/ +public final class RpcBrokerImplModule extends org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractRpcBrokerImplModule +{ + + public RpcBrokerImplModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { + super(identifier, dependencyResolver); + } + + public RpcBrokerImplModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, RpcBrokerImplModule oldModule, java.lang.AutoCloseable oldInstance) { + super(identifier, dependencyResolver, oldModule, oldInstance); + } + + @Override + public void validate(){ + super.validate(); + // Add custom validation for module attributes here. + } + + @Override + public java.lang.AutoCloseable createInstance() { + //TODO:implement + throw new java.lang.UnsupportedOperationException("Unimplemented stub method"); + } +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RpcBrokerImplModuleFactory.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RpcBrokerImplModuleFactory.java new file mode 100644 index 0000000000..61c7364a43 --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RpcBrokerImplModuleFactory.java @@ -0,0 +1,19 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-binding-broker-impl yang module local name: binding-rpc-broker +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 17:33:01 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.binding.impl; + +/** +* +*/ +public class RpcBrokerImplModuleFactory extends org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractRpcBrokerImplModuleFactory +{ + + +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RuntimeMappingModule.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RuntimeMappingModule.java new file mode 100644 index 0000000000..6537b4c64d --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RuntimeMappingModule.java @@ -0,0 +1,63 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-binding-broker-impl yang module local name: runtime-generated-mapping +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 18:20:19 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.binding.impl; + +import javassist.ClassPool; + +import org.opendaylight.controller.sal.binding.dom.serializer.impl.RuntimeGeneratedMappingServiceImpl; +import org.osgi.framework.BundleContext; + +import com.google.common.base.Preconditions; + +/** +* +*/ +public final class RuntimeMappingModule extends org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractRuntimeMappingModule +{ + + private BundleContext bundleContext; + + public RuntimeMappingModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { + super(identifier, dependencyResolver); + } + + public RuntimeMappingModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, RuntimeMappingModule oldModule, java.lang.AutoCloseable oldInstance) { + super(identifier, dependencyResolver, oldModule, oldInstance); + } + + @Override + public void validate(){ + super.validate(); + Preconditions.checkNotNull(bundleContext); + // Add custom validation for module attributes here. + } + + @Override + public boolean canReuseInstance(AbstractRuntimeMappingModule oldModule) { + return true; + } + + @Override + public java.lang.AutoCloseable createInstance() { + RuntimeGeneratedMappingServiceImpl service = new RuntimeGeneratedMappingServiceImpl(); + ClassPool pool = new ClassPool(); // Should be default singleton + service.setPool(pool); + service.start(getBundleContext()); + return service; + } + + private BundleContext getBundleContext() { + return bundleContext; + } + + public void setBundleContext(BundleContext bundleContext) { + this.bundleContext = bundleContext; + } +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RuntimeMappingModuleFactory.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RuntimeMappingModuleFactory.java new file mode 100644 index 0000000000..f104c73ba3 --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/binding/impl/RuntimeMappingModuleFactory.java @@ -0,0 +1,58 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-binding-broker-impl yang module local name: runtime-generated-mapping +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 18:20:19 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.binding.impl; + +import java.util.Collections; +import java.util.Set; + +import org.opendaylight.controller.config.api.DependencyResolver; +import org.opendaylight.controller.config.api.DependencyResolverFactory; +import org.opendaylight.controller.config.api.DynamicMBeanWithInstance; +import org.opendaylight.controller.config.api.ModuleIdentifier; +import org.opendaylight.controller.config.spi.Module; +import org.osgi.framework.BundleContext; + +/** +* +*/ +public class RuntimeMappingModuleFactory extends org.opendaylight.controller.config.yang.md.sal.binding.impl.AbstractRuntimeMappingModuleFactory +{ + + + private static RuntimeMappingModule SINGLETON = null; + private static ModuleIdentifier IDENTIFIER = new ModuleIdentifier(NAME, "runtime-mapping-singleton"); + + @Override + public Module createModule(String instanceName, DependencyResolver dependencyResolver, BundleContext bundleContext) { + throw new UnsupportedOperationException("Only default instance supported"); + } + + @Override + public Module createModule(String instanceName, DependencyResolver dependencyResolver, + DynamicMBeanWithInstance old, BundleContext bundleContext) throws Exception { + RuntimeMappingModule module = (RuntimeMappingModule) super.createModule(instanceName, dependencyResolver, old, bundleContext); + module.setBundleContext(bundleContext); + return module; + } + + @Override + public Set getDefaultModules(DependencyResolverFactory dependencyResolverFactory, + BundleContext bundleContext) { + if(SINGLETON == null) { + DependencyResolver dependencyResolver = dependencyResolverFactory.createDependencyResolver(IDENTIFIER); + SINGLETON = new RuntimeMappingModule(IDENTIFIER , dependencyResolver); + SINGLETON.setBundleContext(bundleContext); + } + + + return Collections.singleton(SINGLETON); + } + +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/codegen/impl/RpcRoutingTableImpl.xtend b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/codegen/impl/RpcRoutingTableImpl.xtend index 02da174656..116a8177f9 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/codegen/impl/RpcRoutingTableImpl.xtend +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/codegen/impl/RpcRoutingTableImpl.xtend @@ -30,7 +30,7 @@ class RpcRoutingTableImpl implement } - override getRoute(InstanceIdentifier nodeInstance) { + override getRoute(InstanceIdentifier nodeInstance) { val ret = routes.get(nodeInstance); if(ret !== null) { return ret; @@ -44,6 +44,6 @@ class RpcRoutingTableImpl implement @SuppressWarnings("rawtypes") override updateRoute(InstanceIdentifier path, S service) { - routes.put(path as InstanceIdentifier,service); + routes.put(path as InstanceIdentifier,service); } } \ No newline at end of file diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/codegen/impl/RuntimeCodeGenerator.xtend b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/codegen/impl/RuntimeCodeGenerator.xtend index 93c192c0af..801e4984c0 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/codegen/impl/RuntimeCodeGenerator.xtend +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/codegen/impl/RuntimeCodeGenerator.xtend @@ -11,7 +11,6 @@ import javassist.ClassPool import org.opendaylight.yangtools.yang.binding.RpcService import javassist.CtClass -import static com.google.common.base.Preconditions.* import javassist.CtMethod import org.opendaylight.yangtools.yang.binding.InstanceIdentifier import org.opendaylight.yangtools.yang.binding.annotations.RoutingContext @@ -65,9 +64,7 @@ class RuntimeCodeGenerator implements org.opendaylight.controller.sal.binding.co } override getRouterFor(Class iface) { - val contexts = new HashSet> - - val instance = >withClassLoader(iface.classLoader) [ | + val instance = >withClassLoaderAndLock(iface.classLoader,lock) [ | val supertype = iface.asCtClass val metadata = supertype.rpcMetadata; val targetCls = createClass(iface.routerName, supertype) [ @@ -210,7 +207,7 @@ class RuntimeCodeGenerator implements org.opendaylight.controller.sal.binding.co ] val finalClass = targetCls.toClass(iface.classLoader, iface.protectionDomain) return new RuntimeGeneratedInvokerPrototype(supportedNotification, - finalClass as Class); + finalClass as Class>); } @@ -218,13 +215,16 @@ class RuntimeCodeGenerator implements org.opendaylight.controller.sal.binding.co protected def resolveInvokerClass(Class class1) { - val invoker = invokerClasses.get(class1); - if (invoker !== null) { - return invoker; - } - val newInvoker = generateListenerInvoker(class1); - invokerClasses.put(class1, newInvoker); - return newInvoker + return withClassLoaderAndLock(class1.classLoader,lock) [| + val invoker = invokerClasses.get(class1); + if (invoker !== null) { + return invoker; + } + val newInvoker = generateListenerInvoker(class1); + invokerClasses.put(class1, newInvoker); + return newInvoker + + ] } } @@ -235,7 +235,7 @@ package class RuntimeGeneratedInvoker implements NotificationInvoker { val NotificationListener delegate; @Property - var org.opendaylight.controller.sal.binding.api.NotificationListener invocationProxy; + var org.opendaylight.controller.sal.binding.api.NotificationListener invocationProxy; @Property var RuntimeGeneratedInvokerPrototype prototype; @@ -243,7 +243,7 @@ package class RuntimeGeneratedInvoker implements NotificationInvoker { new(NotificationListener delegate, RuntimeGeneratedInvokerPrototype prototype) { _delegate = delegate; _prototype = prototype; - _invocationProxy = prototype.protoClass.newInstance; + _invocationProxy = prototype.protoClass.newInstance as org.opendaylight.controller.sal.binding.api.NotificationListener; RuntimeCodeHelper.setDelegate(_invocationProxy, delegate); } @@ -262,7 +262,7 @@ package class RuntimeGeneratedInvokerPrototype { val Set> supportedNotifications; @Property - val Class protoClass; + val Class> protoClass; } package class RpcServiceMetadata { diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/BindingClassListener.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/BindingClassListener.java index c2b5635af3..c3f102ac45 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/BindingClassListener.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/BindingClassListener.java @@ -4,4 +4,5 @@ public interface BindingClassListener { void onBindingClassCaptured(Class cls); + void onBindingClassProcessed(Class cls); } diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/CodecMapping.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/CodecMapping.java index 19e9961760..35f48745f9 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/CodecMapping.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/CodecMapping.java @@ -30,8 +30,8 @@ public class CodecMapping { } } - public static void setClassToCaseMap(Class codec, - Map classToCaseRawCodec) { + public static void setClassToCaseMap(Class> codec, + Map,BindingCodec> classToCaseRawCodec) { Field instanceIdField; try { instanceIdField = codec.getField(CLASS_TO_CASE_MAP); @@ -47,8 +47,8 @@ public class CodecMapping { } - public static void setCompositeNodeToCaseMap(Class codec, - Map compositeToCase) { + public static void setCompositeNodeToCaseMap(Class> codec, + Map> compositeToCase) { Field instanceIdField; try { instanceIdField = codec.getField(COMPOSITE_TO_CASE); @@ -63,7 +63,7 @@ public class CodecMapping { } public static void setAugmentationCodec(Class, Object>> dataCodec, - BindingCodec augmentableCodec) { + BindingCodec augmentableCodec) { Field instanceIdField; try { instanceIdField = dataCodec.getField(AUGMENTATION_CODEC); diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/GeneratorListener.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/GeneratorListener.java index 3f74c9eaf4..0a8ea84cf6 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/GeneratorListener.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/GeneratorListener.java @@ -9,6 +9,8 @@ public interface GeneratorListener { + void onClassProcessed(Class cl); + void onCodecCreated(Class codec); void onValueCodecCreated(Class valueClass,Class valueCodec); void onChoiceCodecCreated(Class choiceClass,Class,Object>> choiceCodec); diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/InstanceIdentifierCodecImpl.xtend b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/InstanceIdentifierCodecImpl.xtend index fd02fde407..2706609806 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/InstanceIdentifierCodecImpl.xtend +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/InstanceIdentifierCodecImpl.xtend @@ -95,6 +95,7 @@ class InstanceIdentifierCodecImpl implements InstanceIdentifierCodec { return new NodeIdentifier(QName.create(previousQname,qname.localName)); } + @SuppressWarnings("rawtypes") private def dispatch PathArgument serializePathArgument(IdentifiableItem argument, QName previousQname) { val Map predicates = new HashMap(); val type = argument.type; @@ -111,7 +112,7 @@ class InstanceIdentifierCodecImpl implements InstanceIdentifierCodec { return new NodeIdentifierWithPredicates(QName.create(previousQname,qname.localName),predicates); } - def resolveQname(Class class1) { + def resolveQname(Class class1) { val qname = classToQName.get(class1); if(qname !== null) { return qname; @@ -119,5 +120,6 @@ class InstanceIdentifierCodecImpl implements InstanceIdentifierCodec { val qnameField = class1.getField("QNAME"); val qnameValue = qnameField.get(null) as QName; classToQName.put(class1,qnameValue); + return qnameValue; } } \ No newline at end of file diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/LazyGeneratedCodecRegistry.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/LazyGeneratedCodecRegistry.java index e8e4c4375d..b81100836f 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/LazyGeneratedCodecRegistry.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/LazyGeneratedCodecRegistry.java @@ -36,6 +36,7 @@ import org.opendaylight.yangtools.yang.binding.Augmentable; import org.opendaylight.yangtools.yang.binding.Augmentation; import org.opendaylight.yangtools.yang.binding.BindingCodec; import org.opendaylight.yangtools.yang.binding.DataContainer; +import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.binding.Identifier; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.data.api.CompositeNode; @@ -120,6 +121,9 @@ public class LazyGeneratedCodecRegistry implements // ReferencedTypeImpl typeref = new ReferencedTypeImpl(type.getPackageName(), type.getName()); @SuppressWarnings("rawtypes") WeakReference weakRef = typeToClass.get(typeref); + if(weakRef == null) { + LOG.error("Could not find loaded class for path: {} and type: {}",path,typeref.getFullyQualifiedName()); + } return weakRef.get(); } @@ -147,9 +151,29 @@ public class LazyGeneratedCodecRegistry implements // @Override @SuppressWarnings("rawtypes") public void bindingClassEncountered(Class cls) { + ConcreteType typeRef = Types.typeForClass(cls); + if(typeToClass.containsKey(typeRef)) { + return; + } + LOG.info("Binding Class {} encountered.",cls); WeakReference weakRef = new WeakReference<>(cls); typeToClass.put(typeRef, weakRef); + if(DataObject.class.isAssignableFrom(cls)) { + @SuppressWarnings({"unchecked","unused"}) + Object cdc = getCodecForDataObject((Class) cls); + } + } + + @Override + public void onClassProcessed(Class cls) { + ConcreteType typeRef = Types.typeForClass(cls); + if(typeToClass.containsKey(typeRef)) { + return; + } + LOG.info("Binding Class {} encountered.",cls); + WeakReference weakRef = new WeakReference<>((Class) cls); + typeToClass.put(typeRef, weakRef); } private DataSchemaNode getSchemaNode(List path) { @@ -280,6 +304,12 @@ public class LazyGeneratedCodecRegistry implements // ReferencedTypeImpl typeref = new ReferencedTypeImpl(caseNode.getValue().getPackageName(), caseNode .getValue().getName()); ChoiceCaseNode node = (ChoiceCaseNode) SchemaContextUtil.findDataSchemaNode(module, caseNode.getKey()); + if (node == null) { + LOG.error("YANGTools Bug: SchemaNode for {}, with path {} was not found in context.", + typeref.getFullyQualifiedName(), caseNode.getKey()); + continue; + } + @SuppressWarnings("rawtypes") ChoiceCaseCodecImpl value = new ChoiceCaseCodecImpl(node); typeToCaseNodes.putIfAbsent(typeref, value); @@ -300,7 +330,7 @@ public class LazyGeneratedCodecRegistry implements // BindingCodec, Object> delegate = newInstanceOf(choiceCodec); ChoiceCodecImpl newCodec = new ChoiceCodecImpl(delegate); choiceCodecs.put(choiceClass, newCodec); - CodecMapping.setClassToCaseMap(choiceCodec, (Map) classToCaseRawCodec); + CodecMapping.setClassToCaseMap(choiceCodec, (Map, BindingCodec>) classToCaseRawCodec); CodecMapping.setCompositeNodeToCaseMap(choiceCodec, newCodec.getCompositeToCase()); } @@ -540,7 +570,7 @@ public class LazyGeneratedCodecRegistry implements // public BindingCodec get(Object key) { if (key instanceof Class) { Class cls = (Class) key; - bindingClassEncountered(cls); + //bindingClassEncountered(cls); ChoiceCaseCodecImpl caseCodec = getCaseCodecFor(cls); return caseCodec.getDelegate(); } @@ -557,11 +587,6 @@ public class LazyGeneratedCodecRegistry implements // this.choiceCases = choiceCases; } - @Override - public Set> entrySet() { - return null; - } - @Override public BindingCodec get(Object key) { if (false == (key instanceof CompositeNode)) { @@ -575,6 +600,8 @@ public class LazyGeneratedCodecRegistry implements // } return null; } + + } /** @@ -585,7 +612,7 @@ public class LazyGeneratedCodecRegistry implements // * Key type */ @SuppressWarnings("rawtypes") - private static abstract class MapFacadeBase implements Map { + private static abstract class MapFacadeBase implements Map> { @Override public boolean containsKey(Object key) { @@ -613,7 +640,7 @@ public class LazyGeneratedCodecRegistry implements // } @Override - public Collection values() { + public Collection> values() { return null; } @@ -622,12 +649,12 @@ public class LazyGeneratedCodecRegistry implements // } @Override - public BindingCodec, Object> put(T key, BindingCodec value) { + public BindingCodec, Object> put(T key, BindingCodec value) { throw notModifiable(); } @Override - public void putAll(Map m) { + public void putAll(Map> m) { throw notModifiable(); } @@ -647,7 +674,8 @@ public class LazyGeneratedCodecRegistry implements // } @Override - public Set> entrySet() { + public Set>> entrySet() { + // TODO Auto-generated method stub return null; } diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/RuntimeGeneratedMappingServiceImpl.xtend b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/RuntimeGeneratedMappingServiceImpl.xtend index 4614c60ca1..0ddc2c88c8 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/RuntimeGeneratedMappingServiceImpl.xtend +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/RuntimeGeneratedMappingServiceImpl.xtend @@ -17,18 +17,9 @@ import java.util.Map.Entry import java.util.AbstractMap.SimpleEntry import org.opendaylight.yangtools.yang.model.api.SchemaPath import org.opendaylight.yangtools.yang.model.util.SchemaContextUtil -import java.util.ArrayList -import org.opendaylight.yangtools.yang.common.QName import org.opendaylight.yangtools.yang.binding.DataContainer -import static com.google.common.base.Preconditions.*; -import java.util.List -import org.opendaylight.yangtools.yang.data.api.Node -import org.opendaylight.yangtools.yang.data.impl.CompositeNodeTOImpl -import org.opendaylight.yangtools.yang.data.impl.SimpleNodeTOImpl -import org.opendaylight.yangtools.concepts.Delegator import java.util.concurrent.ConcurrentMap import org.opendaylight.yangtools.sal.binding.model.api.GeneratedType -import org.opendaylight.yangtools.yang.binding.BindingCodec import com.google.common.collect.HashMultimap import com.google.common.util.concurrent.SettableFuture import java.util.concurrent.Future @@ -39,8 +30,11 @@ import org.slf4j.LoggerFactory import org.opendaylight.controller.sal.binding.dom.serializer.api.ValueWithQName import org.opendaylight.controller.sal.binding.dom.serializer.api.DataContainerCodec import org.opendaylight.yangtools.binding.generator.util.Types +import org.osgi.framework.BundleContext +import java.util.Hashtable +import org.osgi.framework.ServiceRegistration -class RuntimeGeneratedMappingServiceImpl implements BindingIndependentMappingService, SchemaServiceListener { +class RuntimeGeneratedMappingServiceImpl implements BindingIndependentMappingService, SchemaServiceListener, AutoCloseable { @Property ClassPool pool; @@ -65,6 +59,8 @@ class RuntimeGeneratedMappingServiceImpl implements BindingIndependentMappingSer val promisedTypeDefinitions = HashMultimap.>create; val promisedSchemas = HashMultimap.>create; + + ServiceRegistration listenerRegistration override onGlobalContextUpdated(SchemaContext arg0) { recreateBindingContext(arg0); @@ -139,6 +135,10 @@ class RuntimeGeneratedMappingServiceImpl implements BindingIndependentMappingSer val ret = transformer.deserialize(node)?.value as DataObject; return ret; } + + override fromDataDom(org.opendaylight.yangtools.yang.data.api.InstanceIdentifier entry) { + return registry.instanceIdentifierCodec.deserialize(entry); + } private def void updateBindingFor(Map map, SchemaContext module) { for (entry : map.entrySet) { @@ -152,7 +152,7 @@ class RuntimeGeneratedMappingServiceImpl implements BindingIndependentMappingSer } } - public def void start() { + public def void start(BundleContext ctx) { binding = new TransformerGenerator(pool); registry = new LazyGeneratedCodecRegistry() registry.generator = binding @@ -162,7 +162,9 @@ class RuntimeGeneratedMappingServiceImpl implements BindingIndependentMappingSer binding.typeToDefinition = typeToDefinition binding.typeToSchemaNode = typeToSchemaNode binding.typeDefinitions = typeDefinitions - + if(ctx !== null) { + listenerRegistration = ctx.registerService(SchemaServiceListener,this,new Hashtable()); + } } private def getTypeDefinition(Type type) { @@ -215,4 +217,9 @@ class RuntimeGeneratedMappingServiceImpl implements BindingIndependentMappingSer } promisedSchemas.removeAll(builder); } + + override close() throws Exception { + listenerRegistration?.unregister(); + } + } diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend index 8e059aa22e..01390d7c41 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/dom/serializer/impl/TransformerGenerator.xtend @@ -95,6 +95,7 @@ class TransformerGenerator { return withClassLoaderAndLock(inputType.classLoader, lock) [ | val ret = getGeneratedClass(inputType) if (ret !== null) { + listener.onClassProcessed(inputType); return ret as Class, Object>>; } val ref = Types.typeForClass(inputType) @@ -102,6 +103,7 @@ class TransformerGenerator { val typeSpecBuilder = typeToDefinition.get(ref) val typeSpec = typeSpecBuilder.toInstance(); val newret = generateTransformerFor(inputType, typeSpec, node); + listener.onClassProcessed(inputType); return newret as Class, Object>>; ] } @@ -117,6 +119,7 @@ class TransformerGenerator { val typeSpecBuilder = typeToDefinition.get(ref) val typeSpec = typeSpecBuilder.toInstance(); val newret = generateAugmentationTransformerFor(inputType, typeSpec, node); + listener.onClassProcessed(inputType); return newret as Class, Object>>; ] } @@ -184,7 +187,7 @@ class TransformerGenerator { ] } - private def Class getGeneratedClass(Class cls) { + private def Class getGeneratedClass(Class cls) { try { return loadClassWithTCCL(cls.codecClassName) @@ -211,13 +214,15 @@ class TransformerGenerator { if (transformer !== null) { return transformer; } - val valueTransformer = generateValueTransformer(cls, type); - return valueTransformer; + return withClassLoaderAndLock(cls.classLoader,lock) [| + val valueTransformer = generateValueTransformer(cls, type); + return valueTransformer; + ] } private def generateKeyTransformerFor(Class inputType, GeneratedType typeSpec, ListSchemaNode node) { try { - log.info("Generating DOM Codec for {} with {}", inputType, inputType.classLoader) + //log.info("Generating DOM Codec for {} with {}", inputType, inputType.classLoader) val properties = typeSpec.allProperties; val ctCls = createClass(inputType.codecClassName) [ //staticField(Map,"AUGMENTATION_SERIALIZERS"); @@ -235,7 +240,7 @@ class TransformerGenerator { _resultName = QNAME; } java.util.List _childNodes = new java.util.ArrayList(); - «inputType.name» value = («inputType.name») $2; + «inputType.resolvedName» value = («inputType.name») $2; «FOR key : node.keyDefinition» «val propertyName = key.getterName» «val keyDef = node.getDataChildByName(key)» @@ -261,7 +266,7 @@ class TransformerGenerator { «val property = properties.get(propertyName)» «deserializeProperty(keyDef, property, propertyName)»; «ENDFOR» - «inputType.name» _value = new «inputType.name»(«node.keyDefinition.keyConstructorList»); + «inputType.resolvedName» _value = new «inputType.name»(«node.keyDefinition.keyConstructorList»); return _value; } ''' @@ -291,10 +296,10 @@ class TransformerGenerator { } } - private def Class> generateCaseCodec(Class inputType, GeneratedType type, + private def Class> generateCaseCodec(Class inputType, GeneratedType type, ChoiceCaseNode node) { try { - log.info("Generating DOM Codec for {} with {}", inputType, inputType.classLoader) + //log.info("Generating DOM Codec for {} with {}, TCCL is: {}", inputType, inputType.classLoader,Thread.currentThread.contextClassLoader) val ctCls = createClass(type.codecClassName) [ //staticField(Map,"AUGMENTATION_SERIALIZERS"); implementsType(BINDING_CODEC) @@ -308,7 +313,7 @@ class TransformerGenerator { «QName.name» _resultName = «QName.name».create($1,QNAME.getLocalName()); java.util.List _childNodes = new java.util.ArrayList(); «type.resolvedName» value = («type.resolvedName») $2; - «transformDataContainerBody(type.allProperties, node)» + «transformDataContainerBody(type,type.allProperties, node)» return ($r) _childNodes; } ''' @@ -349,9 +354,9 @@ class TransformerGenerator { } private def dispatch Class, Object>> generateTransformerFor( - Class inputType, GeneratedType typeSpec, SchemaNode node) { + Class inputType, GeneratedType typeSpec, SchemaNode node) { try { - log.info("Generating DOM Codec for {} with {}", inputType, inputType.classLoader) + //log.info("Generating DOM Codec for {} with {}", inputType, inputType.classLoader) val ctCls = createClass(typeSpec.codecClassName) [ //staticField(Map,"AUGMENTATION_SERIALIZERS"); staticQNameField(inputType); @@ -396,9 +401,9 @@ class TransformerGenerator { } private def Class, Object>> generateAugmentationTransformerFor( - Class inputType, GeneratedType type, AugmentationSchema node) { + Class inputType, GeneratedType type, AugmentationSchema node) { try { - log.info("Generating DOM Codec for {} with {}", inputType, inputType.classLoader) + //log.info("Generating DOM Codec for {} with {}", inputType, inputType.classLoader) val properties = type.allProperties val ctCls = createClass(type.codecClassName) [ //staticField(Map,"AUGMENTATION_SERIALIZERS"); @@ -446,7 +451,7 @@ class TransformerGenerator { return null; } java.util.Map _compositeNode = (java.util.Map) $2; - ////System.out.println(_localQName + " " + _compositeNode); + //System.out.println(_localQName + " " + _compositeNode); «type.builderName» _builder = new «type.builderName»(); «FOR child : node.childNodes» «val signature = properties.getFor(child)» @@ -475,9 +480,9 @@ class TransformerGenerator { } private def dispatch Class, Object>> generateTransformerFor( - Class inputType, GeneratedType typeSpec, ChoiceNode node) { + Class inputType, GeneratedType typeSpec, ChoiceNode node) { try { - log.info("Generating DOM Codec for {} with {}", inputType, inputType.classLoader) + //log.info("Generating DOM Codec for {} with {}", inputType, inputType.classLoader) val ctCls = createClass(typeSpec.codecClassName) [ //staticField(Map,"AUGMENTATION_SERIALIZERS"); //staticQNameField(inputType); @@ -500,7 +505,9 @@ class TransformerGenerator { return null; } java.util.Map.Entry _input = new «SimpleEntry.name»($1,_baValue); - return (java.util.List) _codec.serialize(_input); + Object _ret = _codec.serialize(_input); + //System.out.println("«typeSpec.name»#toDomStatic: " + _ret); + return («List.name») _ret; } ''' ] @@ -617,7 +624,7 @@ class TransformerGenerator { return null; } java.util.Map _compositeNode = (java.util.Map) $2; - ////System.out.println(_localQName + " " + _compositeNode); + //System.out.println(_localQName + " " + _compositeNode); «type.builderName» _builder = new «type.builderName»(); «deserializeDataNodeContainerBody(type, node)» «deserializeAugmentations» @@ -660,7 +667,7 @@ class TransformerGenerator { String propertyName) ''' java.util.List _dom_«propertyName» = _compositeNode.get(«QName.name».create(_localQName,"«schema.QName. localName»")); - ////System.out.println("«propertyName»#deCode"+_dom_«propertyName»); + //System.out.println("«propertyName»#deCode"+_dom_«propertyName»); java.util.List «propertyName» = new java.util.ArrayList(); if(_dom_«propertyName» != null) { java.util.List _serialized = new java.util.ArrayList(); @@ -668,15 +675,15 @@ class TransformerGenerator { boolean _hasNext = _iterator.hasNext(); while(_hasNext) { Object _listItem = _iterator.next(); - ////System.out.println(" item" + _listItem); + //System.out.println(" item" + _listItem); Object _value = «type.actualTypeArguments.get(0).serializer.resolvedName».fromDomStatic(_localQName,_listItem); - ////System.out.println(" value" + _value); + //System.out.println(" value" + _value); «propertyName».add(_value); _hasNext = _iterator.hasNext(); } } - ////System.out.println(" list" + «propertyName»); + //System.out.println(" list" + «propertyName»); ''' private def dispatch CharSequence deserializeProperty(LeafListSchemaNode schema, ParameterizedType type, @@ -737,29 +744,38 @@ class TransformerGenerator { val returnType = typeSpec.valueReturnType; if (returnType == null) { - val ctCls = createDummyImplementation(inputType, typeSpec); val ret = ctCls.toClassImpl(inputType.classLoader, inputType.protectionDomain) return ret as Class, Object>>; } + var hasBinding = false; + try { + val bindingCodecClass = loadClassWithTCCL(BINDING_CODEC.name); + hasBinding = bindingCodecClass !== null; + } catch (ClassNotFoundException e) { + hasBinding = false; + } + val hasYangBinding = hasBinding val ctCls = createClass(typeSpec.codecClassName) [ //staticField(Map,"AUGMENTATION_SERIALIZERS"); - implementsType(BINDING_CODEC) - staticField(it, INSTANCE_IDENTIFIER_CODEC, BindingCodec) - implementsType(BindingDeserializer.asCtClass) + if(hasYangBinding) { + implementsType(BINDING_CODEC) + staticField(it, INSTANCE_IDENTIFIER_CODEC, BindingCodec) + implementsType(BindingDeserializer.asCtClass) + } method(Object, "toDomValue", Object) [ modifiers = PUBLIC + FINAL + STATIC body = ''' { - ////System.out.println("«inputType.simpleName»#toDomValue: "+$1); + //System.out.println("«inputType.simpleName»#toDomValue: "+$1); if($1 == null) { return null; } «typeSpec.resolvedName» _encapsulatedValue = («typeSpec.resolvedName») $1; - ////System.out.println("«inputType.simpleName»#toDomValue:Enc: "+_encapsulatedValue); + //System.out.println("«inputType.simpleName»#toDomValue:Enc: "+_encapsulatedValue); «returnType.resolvedName» _value = _encapsulatedValue.getValue(); - ////System.out.println("«inputType.simpleName»#toDomValue:DeEnc: "+_value); + //System.out.println("«inputType.simpleName»#toDomValue:DeEnc: "+_value); Object _domValue = «serializeValue(returnType, "_value")»; return _domValue; } @@ -776,7 +792,7 @@ class TransformerGenerator { modifiers = PUBLIC + FINAL + STATIC body = ''' { - ////System.out.println("«inputType.simpleName»#fromDomValue: "+$1); + //System.out.println("«inputType.simpleName»#fromDomValue: "+$1); if($1 == null) { return null; @@ -849,13 +865,14 @@ class TransformerGenerator { return null; } - private def dispatch Class, Object>> generateValueTransformer( + private def dispatch Class generateValueTransformer( Class inputType, Enumeration typeSpec) { try { - log.info("Generating DOM Codec for {} with {}", inputType, inputType.classLoader) + //log.info("Generating DOM Codec for {} with {}", inputType, inputType.classLoader) val ctCls = createClass(typeSpec.codecClassName) [ //staticField(Map,"AUGMENTATION_SERIALIZERS"); - implementsType(BINDING_CODEC) + //implementsType(BINDING_CODEC) + method(Object, "toDomValue", Object) [ modifiers = PUBLIC + FINAL + STATIC body = ''' @@ -891,7 +908,7 @@ class TransformerGenerator { val ret = ctCls.toClassImpl(inputType.classLoader, inputType.protectionDomain) log.info("DOM Codec for {} was generated {}", inputType, ret) - return ret as Class, Object>>; + return ret; } catch (CodeGenerationException e) { throw new CodeGenerationException("Cannot compile Transformator for " + inputType, e); } catch (Exception e) { @@ -982,7 +999,7 @@ class TransformerGenerator { «QName.name» _resultName = «QName.name».create($1,QNAME.getLocalName()); java.util.List _childNodes = new java.util.ArrayList(); «type.resolvedName» value = («type.resolvedName») $2; - «transformDataContainerBody(type.allProperties, node)» + «transformDataContainerBody(type,type.allProperties, node)» «serializeAugmentations» return ($r) java.util.Collections.singletonMap(_resultName,_childNodes); } @@ -993,7 +1010,7 @@ class TransformerGenerator { «QName.name» _resultName = «QName.name».create($1,QNAME.getLocalName()); java.util.List _childNodes = new java.util.ArrayList(); «type.resolvedName» value = («type.resolvedName») $2; - «transformDataContainerBody(type.allProperties, node)» + «transformDataContainerBody(type,type.allProperties, node)» «serializeAugmentations» return ($r) java.util.Collections.singletonMap(_resultName,_childNodes); } @@ -1004,7 +1021,7 @@ class TransformerGenerator { «QName.name» _resultName = «QName.name».create($1,QNAME.getLocalName()); java.util.List _childNodes = new java.util.ArrayList(); «type.resolvedName» value = («type.resolvedName») $2; - «transformDataContainerBody(type.allProperties, node)» + «transformDataContainerBody(type,type.allProperties, node)» «serializeAugmentations» return ($r) java.util.Collections.singletonMap(_resultName,_childNodes); } @@ -1019,11 +1036,11 @@ class TransformerGenerator { } ''' - private def transformDataContainerBody(Map properties, DataNodeContainer node) { + private def transformDataContainerBody(Type type,Map properties, DataNodeContainer node) { val ret = ''' «FOR child : node.childNodes.filter[!augmenting]» «var signature = properties.getFor(child)» - //System.out.println("«signature.key»" + value.«signature.key»()); + //System.out.println("«type.name»#«signature.key»" + value.«signature.key»()); «serializeProperty(child, signature.value, signature.key)» «ENDFOR» ''' @@ -1152,11 +1169,11 @@ class TransformerGenerator { return '''«typeSpec.resolvedName»$Broker$Codec$DOM''' } - private def codecClassName(Class typeSpec) { + private def codecClassName(Class typeSpec) { return '''«typeSpec.name»$Broker$Codec$DOM''' } - private def dispatch HashMap getAllProperties(GeneratedType type) { + private def HashMap getAllProperties(GeneratedType type) { val ret = new HashMap(); type.collectAllProperties(ret); return ret; @@ -1186,12 +1203,11 @@ class TransformerGenerator { return type.asCtClass.name; } - def String getResolvedName(Class type) { + def String getResolvedName(Class type) { return type.asCtClass.name; } def CtClass asCtClass(Type type) { - val name = type.fullyQualifiedName val cls = loadClassWithTCCL(type.fullyQualifiedName) return cls.asCtClass; } diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/BindingAwareBrokerImpl.xtend b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/BindingAwareBrokerImpl.xtend index 31d5d0126f..1762aac090 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/BindingAwareBrokerImpl.xtend +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/BindingAwareBrokerImpl.xtend @@ -44,17 +44,18 @@ import static org.opendaylight.controller.sal.binding.impl.util.ClassLoaderUtils import java.util.concurrent.Executors import java.util.Collections import org.opendaylight.yangtools.yang.binding.DataObject -import org.opendaylight.controller.sal.binding.impl.connect.dom.ConnectorActivator +import java.util.concurrent.locks.ReentrantLock +import java.util.concurrent.Callable +import java.util.WeakHashMap +import javax.annotation.concurrent.GuardedBy class BindingAwareBrokerImpl implements BindingAwareBroker, AutoCloseable { private static val log = LoggerFactory.getLogger(BindingAwareBrokerImpl) - private InstanceIdentifier root = InstanceIdentifier.builder().toInstance(); - private val clsPool = ClassPool.getDefault() - private var RuntimeCodeGenerator generator; - + private static val clsPool = ClassPool.getDefault() + public static var RuntimeCodeGenerator generator; /** * Map of all Managed Direct Proxies @@ -68,28 +69,29 @@ class BindingAwareBrokerImpl implements BindingAwareBroker, AutoCloseable { * * */ - private val Map, RpcRouter> rpcRouters = new ConcurrentHashMap(); + private val Map, RpcRouter> rpcRouters = new WeakHashMap(); @Property - private var NotificationBrokerImpl notifyBroker - + private var NotificationProviderService notifyBroker + @Property - private var DataBrokerImpl dataBroker - + private var DataProviderService dataBroker + @Property var BundleContext brokerBundleContext - + ServiceRegistration notifyProviderRegistration - + ServiceRegistration notifyConsumerRegistration - + ServiceRegistration dataProviderRegistration - + ServiceRegistration dataConsumerRegistration - - ConnectorActivator connectorActivator - - + + private val proxyGenerationLock = new ReentrantLock; + + private val routerGenerationLock = new ReentrantLock; + public new(BundleContext bundleContext) { _brokerBundleContext = bundleContext; } @@ -99,27 +101,13 @@ class BindingAwareBrokerImpl implements BindingAwareBroker, AutoCloseable { initGenerator(); val executor = Executors.newCachedThreadPool; + // Initialization of notificationBroker log.info("Starting MD-SAL: Binding Aware Notification Broker"); - notifyBroker = new NotificationBrokerImpl(executor); - notifyBroker.invokerFactory = generator.invokerFactory; log.info("Starting MD-SAL: Binding Aware Data Broker"); - dataBroker = new DataBrokerImpl(); - dataBroker.executor = executor; - val brokerProperties = newProperties(); - - log.info("Starting MD-SAL: Binding Aware Data Broker"); - notifyProviderRegistration = brokerBundleContext.registerService(NotificationProviderService, notifyBroker, - brokerProperties) - notifyConsumerRegistration = brokerBundleContext.registerService(NotificationService, notifyBroker, brokerProperties) - dataProviderRegistration = brokerBundleContext.registerService(DataProviderService, dataBroker, brokerProperties) - dataConsumerRegistration = brokerBundleContext.registerService(DataBrokerService, dataBroker, brokerProperties) - - connectorActivator = new ConnectorActivator(dataBroker,brokerBundleContext); - connectorActivator.start(); log.info("MD-SAL: Binding Aware Broker Started"); } @@ -163,20 +151,37 @@ class BindingAwareBrokerImpl implements BindingAwareBroker, AutoCloseable { * If proxy class does not exist for supplied service class it will be generated automatically. */ private def getManagedDirectProxy(Class service) { - var RpcProxyContext existing = null + if ((existing = managedProxies.get(service)) != null) { return existing.proxy } - val proxyInstance = generator.getDirectProxyFor(service) - val rpcProxyCtx = new RpcProxyContext(proxyInstance.class) - val properties = new Hashtable() - rpcProxyCtx.proxy = proxyInstance as RpcService - - properties.salServiceType = SAL_SERVICE_TYPE_CONSUMER_PROXY - rpcProxyCtx.registration = brokerBundleContext.registerService(service, rpcProxyCtx.proxy as T, properties) - managedProxies.put(service, rpcProxyCtx) - return rpcProxyCtx.proxy + return withLock(proxyGenerationLock) [ | + val maybeProxy = managedProxies.get(service); + if (maybeProxy !== null) { + return maybeProxy.proxy; + } + + + val proxyInstance = generator.getDirectProxyFor(service) + val rpcProxyCtx = new RpcProxyContext(proxyInstance.class) + val properties = new Hashtable() + rpcProxyCtx.proxy = proxyInstance as RpcService + properties.salServiceType = SAL_SERVICE_TYPE_CONSUMER_PROXY + rpcProxyCtx.registration = brokerBundleContext.registerService(service, rpcProxyCtx.proxy as T, properties) + managedProxies.put(service, rpcProxyCtx) + return rpcProxyCtx.proxy + ] + } + + private static def T withLock(ReentrantLock lock, Callable method) { + try { + lock.lock(); + val ret = method.call; + return ret; + } finally { + lock.unlock(); + } } /** @@ -190,7 +195,7 @@ class BindingAwareBrokerImpl implements BindingAwareBroker, AutoCloseable { val osgiReg = context.bundleContext.registerService(type, service, properties); proxy.delegate = service; - return new RpcServiceRegistrationImpl(type, service, osgiReg,this); + return new RpcServiceRegistrationImpl(type, service, osgiReg, this); } def RoutedRpcRegistration registerRoutedRpcImplementation(Class type, T service, @@ -208,14 +213,20 @@ class BindingAwareBrokerImpl implements BindingAwareBroker, AutoCloseable { } // We created Router - val newRouter = generator.getRouterFor(type); - checkState(newRouter !== null); - rpcRouters.put(type, newRouter); - - // We create / update Direct Proxy for router - val proxy = getManagedDirectProxy(type); - proxy.delegate = newRouter.invocationProxy - return newRouter; + return withLock(routerGenerationLock) [ | + val maybeRouter = rpcRouters.get(type); + if (maybeRouter !== null) { + return maybeRouter as RpcRouter; + } + + val newRouter = generator.getRouterFor(type); + checkState(newRouter !== null); + rpcRouters.put(type, newRouter); + // We create / update Direct Proxy for router + val proxy = getManagedDirectProxy(type); + proxy.delegate = newRouter.invocationProxy + return newRouter; + ] } @@ -230,8 +241,8 @@ class BindingAwareBrokerImpl implements BindingAwareBroker, AutoCloseable { // Updating internal structure of registration routingTable.updateRoute(path, registration.instance) + // Update routing table / send announce to message bus - val success = paths.put(context, path); } @@ -263,32 +274,32 @@ class BindingAwareBrokerImpl implements BindingAwareBroker, AutoCloseable { routingTable.removeRoute(path) } } - + protected def void unregisterRpcService(RpcServiceRegistrationImpl registration) { val type = registration.serviceType; - + val proxy = managedProxies.get(type); - if(proxy.proxy.delegate === registration.instance) { + if (proxy.proxy.delegate === registration.instance) { proxy.proxy.delegate = null; } } - + def createDelegate(Class type) { getManagedDirectProxy(type); } - + def getRpcRouters() { return Collections.unmodifiableMap(rpcRouters); } - + override close() { dataConsumerRegistration.unregister() dataProviderRegistration.unregister() notifyConsumerRegistration.unregister() notifyProviderRegistration.unregister() } - + } class RoutedRpcRegistrationImpl extends AbstractObjectRegistration implements RoutedRpcRegistration { @@ -332,7 +343,7 @@ class RoutedRpcRegistrationImpl extends AbstractObjectRegi checkClosed() broker.unregisterPath(this, context, path); } - + override getServiceType() { return router.serviceType; } @@ -343,24 +354,25 @@ class RoutedRpcRegistrationImpl extends AbstractObjectRegi } } -class RpcServiceRegistrationImpl extends AbstractObjectRegistration implements RpcRegistration { + +class RpcServiceRegistrationImpl extends AbstractObjectRegistration implements RpcRegistration { val ServiceRegistration osgiRegistration; private var BindingAwareBrokerImpl broker; - + @Property val Class serviceType; - public new(Class type, T service, ServiceRegistration osgiReg,BindingAwareBrokerImpl broker) { + public new(Class type, T service, ServiceRegistration osgiReg, BindingAwareBrokerImpl broker) { super(service); this._serviceType = type; this.osgiRegistration = osgiReg; - this.broker= broker; + this.broker = broker; } override protected removeRegistration() { broker.unregisterRpcService(this); broker = null; } - + } diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/DataBrokerImpl.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/DataBrokerImpl.java index 7a1ca11fb6..2f4510d5b4 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/DataBrokerImpl.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/DataBrokerImpl.java @@ -2,6 +2,7 @@ package org.opendaylight.controller.sal.binding.impl; import java.util.concurrent.ExecutorService; import java.util.concurrent.Future; +import java.util.concurrent.atomic.AtomicLong; import org.opendaylight.controller.md.sal.common.api.data.DataReader; import org.opendaylight.controller.md.sal.common.impl.service.AbstractDataBroker; @@ -17,77 +18,85 @@ import org.opendaylight.yangtools.yang.common.RpcResult; public class DataBrokerImpl extends AbstractDataBroker, DataObject, DataChangeListener> implements - DataProviderService { + DataProviderService, AutoCloseable { + + + private final AtomicLong nextTransaction = new AtomicLong(); + public DataBrokerImpl() { setDataReadRouter(new BindingAwareDataReaderRouter()); } @Override public DataTransactionImpl beginTransaction() { - return new DataTransactionImpl(this); + String transactionId = "BA-" + nextTransaction.getAndIncrement(); + return new DataTransactionImpl(transactionId,this); } @Override + @Deprecated public T getData(DataStoreIdentifier store, Class rootType) { - // TODO Auto-generated method stub - return null; + throw new UnsupportedOperationException("Deprecated"); } @Override + @Deprecated public T getData(DataStoreIdentifier store, T filter) { - // TODO Auto-generated method stub - return null; + throw new UnsupportedOperationException("Deprecated"); } @Override + @Deprecated public T getCandidateData(DataStoreIdentifier store, Class rootType) { - // TODO Auto-generated method stub - return null; + throw new UnsupportedOperationException("Deprecated"); } @Override + @Deprecated public T getCandidateData(DataStoreIdentifier store, T filter) { - // TODO Auto-generated method stub - return null; + throw new UnsupportedOperationException("Deprecated"); } @Override + @Deprecated public RpcResult editCandidateData(DataStoreIdentifier store, DataRoot changeSet) { - // TODO Auto-generated method stub - return null; + throw new UnsupportedOperationException("Deprecated"); } @Override + @Deprecated public Future> commit(DataStoreIdentifier store) { - // TODO Auto-generated method stub - return null; + throw new UnsupportedOperationException("Deprecated"); } @Override + @Deprecated public DataObject getData(InstanceIdentifier data) { - // TODO Auto-generated method stub - return null; + throw new UnsupportedOperationException("Deprecated"); } @Override + @Deprecated public DataObject getConfigurationData(InstanceIdentifier data) { - // TODO Auto-generated method stub - return null; + throw new UnsupportedOperationException("Deprecated"); } @Override + @Deprecated public void registerChangeListener(InstanceIdentifier path, DataChangeListener changeListener) { - // TODO Auto-generated method stub - + throw new UnsupportedOperationException("Deprecated"); } @Override + @Deprecated public void unregisterChangeListener(InstanceIdentifier path, DataChangeListener changeListener) { - // TODO Auto-generated method stub - + throw new UnsupportedOperationException("Deprecated"); } - + @Override + public void close() throws Exception { + + } } \ No newline at end of file diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/DataTransactionImpl.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/DataTransactionImpl.java index f7967beaae..b0eb9eeb42 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/DataTransactionImpl.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/DataTransactionImpl.java @@ -15,8 +15,8 @@ public class DataTransactionImpl extends AbstractDataTransaction, NotificationListener> listeners; @Property var ExecutorService executor; - @Property - var RuntimeCodeGenerator generator; - - @Property - var NotificationInvokerFactory invokerFactory; - new(ExecutorService executor) { listeners = HashMultimap.create() this.executor = executor; @@ -108,7 +102,7 @@ class NotificationBrokerImpl implements NotificationProviderService { override registerNotificationListener( org.opendaylight.yangtools.yang.binding.NotificationListener listener) { - val invoker = invokerFactory.invokerFor(listener); + val invoker = BindingAwareBrokerImpl.generator.invokerFactory.invokerFor(listener); for (notifyType : invoker.supportedNotifications) { listeners.put(notifyType, invoker.invocationProxy) } @@ -125,6 +119,11 @@ class NotificationBrokerImpl implements NotificationProviderService { listeners.remove(notifyType, reg.invoker.invocationProxy) } } + + override close() { + //FIXME: implement properly. + } + } class GenericNotificationRegistration extends AbstractObjectRegistration> implements ListenerRegistration> { @@ -177,7 +176,9 @@ class NotifyTask implements Callable { override call() { try { + log.info("Delivering notification {} to {}",notification,listener); listener.onNotification(notification); + log.info("Notification delivered {} to {}",notification,listener); } catch (Exception e) { log.error("Unhandled exception thrown by listener: {}", listener, e); } diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/BindingIndependentDataServiceConnector.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/BindingIndependentDataServiceConnector.java index ff897aa41d..ccd6079cc9 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/BindingIndependentDataServiceConnector.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/BindingIndependentDataServiceConnector.java @@ -1,44 +1,64 @@ package org.opendaylight.controller.sal.binding.impl.connect.dom; +import java.util.Collection; import java.util.Collections; +import java.util.Map; import java.util.Map.Entry; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ConcurrentMap; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import org.opendaylight.controller.config.api.jmx.CommitStatus; +import org.opendaylight.controller.md.sal.common.api.RegistrationListener; import org.opendaylight.controller.md.sal.common.api.TransactionStatus; import org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler; -import org.opendaylight.controller.md.sal.common.api.data.DataModification; -import org.opendaylight.controller.md.sal.common.api.data.DataReader; import org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler.DataCommitTransaction; +import org.opendaylight.controller.md.sal.common.api.data.DataCommitHandlerRegistration; +import org.opendaylight.controller.md.sal.common.api.data.DataModification; import org.opendaylight.controller.sal.binding.api.data.DataProviderService; import org.opendaylight.controller.sal.binding.api.data.RuntimeDataProvider; import org.opendaylight.controller.sal.common.util.Rpcs; -import org.opendaylight.controller.sal.core.api.data.DataBrokerService; +import org.opendaylight.controller.sal.core.api.Provider; +import org.opendaylight.controller.sal.core.api.Broker.ProviderSession; import org.opendaylight.controller.sal.core.api.data.DataModificationTransaction; +import org.opendaylight.yangtools.concepts.Registration; import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.opendaylight.yangtools.yang.common.RpcError; import org.opendaylight.yangtools.yang.common.RpcResult; import org.opendaylight.yangtools.yang.data.api.CompositeNode; - -import com.google.common.base.Preconditions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class BindingIndependentDataServiceConnector implements // RuntimeDataProvider, // - DataCommitHandler, DataObject> { + Provider { + + private final Logger LOG = LoggerFactory.getLogger(BindingIndependentDataServiceConnector.class); private static final InstanceIdentifier ROOT = InstanceIdentifier.builder().toInstance(); + private static final org.opendaylight.yangtools.yang.data.api.InstanceIdentifier ROOT_BI = org.opendaylight.yangtools.yang.data.api.InstanceIdentifier + .builder().toInstance(); + private BindingIndependentMappingService mappingService; - private DataBrokerService biDataService; + private org.opendaylight.controller.sal.core.api.data.DataProviderService biDataService; private DataProviderService baDataService; + private ConcurrentMap domOpenedTransactions = new ConcurrentHashMap<>(); + private ConcurrentMap bindingOpenedTransactions = new ConcurrentHashMap<>(); + + private BindingToDomCommitHandler bindingToDomCommitHandler = new BindingToDomCommitHandler(); + private DomToBindingCommitHandler domToBindingCommitHandler = new DomToBindingCommitHandler(); + + private Registration, DataObject>> baCommitHandlerRegistration; + + private Registration> biCommitHandlerRegistration; + @Override public DataObject readOperationalData(InstanceIdentifier path) { - // TODO Auto-generated method stub org.opendaylight.yangtools.yang.data.api.InstanceIdentifier biPath = mappingService.toDataDom(path); CompositeNode result = biDataService.readOperationalData(biPath); return mappingService.dataObjectFromDataDom(path, result); @@ -51,15 +71,7 @@ public class BindingIndependentDataServiceConnector implements // return mappingService.dataObjectFromDataDom(path, result); } - @Override - public org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler.DataCommitTransaction, DataObject> requestCommit( - DataModification, DataObject> modification) { - - DataModificationTransaction translated = translateTransaction(modification); - return new WrappedTransaction(translated, modification); - } - - private DataModificationTransaction translateTransaction( + private DataModificationTransaction createBindingToDomTransaction( DataModification, DataObject> source) { DataModificationTransaction target = biDataService.beginTransaction(); for (Entry, DataObject> entry : source.getUpdatedConfigurationData() @@ -74,27 +86,133 @@ public class BindingIndependentDataServiceConnector implements // .toDataDom(entry); target.putOperationalData(biEntry.getKey(), biEntry.getValue()); } - for(InstanceIdentifier entry : source.getRemovedConfigurationData()) { + for (InstanceIdentifier entry : source.getRemovedConfigurationData()) { org.opendaylight.yangtools.yang.data.api.InstanceIdentifier biEntry = mappingService.toDataDom(entry); target.removeConfigurationData(biEntry); } - for(InstanceIdentifier entry : source.getRemovedOperationalData()) { + for (InstanceIdentifier entry : source.getRemovedOperationalData()) { org.opendaylight.yangtools.yang.data.api.InstanceIdentifier biEntry = mappingService.toDataDom(entry); target.removeOperationalData(biEntry); } return target; } - private class WrappedTransaction implements + private org.opendaylight.controller.sal.binding.api.data.DataModificationTransaction createDomToBindingTransaction( + DataModification source) { + org.opendaylight.controller.sal.binding.api.data.DataModificationTransaction target = baDataService + .beginTransaction(); + for (Entry entry : source + .getUpdatedConfigurationData().entrySet()) { + InstanceIdentifier baKey = mappingService.fromDataDom(entry.getKey()); + DataObject baData = mappingService.dataObjectFromDataDom(baKey, entry.getValue()); + target.putConfigurationData(baKey, baData); + } + for (Entry entry : source + .getUpdatedOperationalData().entrySet()) { + InstanceIdentifier baKey = mappingService.fromDataDom(entry.getKey()); + DataObject baData = mappingService.dataObjectFromDataDom(baKey, entry.getValue()); + target.putOperationalData(baKey, baData); + } + for (org.opendaylight.yangtools.yang.data.api.InstanceIdentifier entry : source.getRemovedConfigurationData()) { + InstanceIdentifier baEntry = mappingService.fromDataDom(entry); + target.removeConfigurationData(baEntry); + } + for (org.opendaylight.yangtools.yang.data.api.InstanceIdentifier entry : source.getRemovedOperationalData()) { + InstanceIdentifier baEntry = mappingService.fromDataDom(entry); + target.removeOperationalData(baEntry); + } + return target; + } + + public org.opendaylight.controller.sal.core.api.data.DataProviderService getBiDataService() { + return biDataService; + } + + public void setBiDataService(org.opendaylight.controller.sal.core.api.data.DataProviderService biDataService) { + this.biDataService = biDataService; + } + + public DataProviderService getBaDataService() { + return baDataService; + } + + public void setBaDataService(DataProviderService baDataService) { + this.baDataService = baDataService; + } + + public void start() { + baDataService.registerDataReader(ROOT, this); + baCommitHandlerRegistration = baDataService.registerCommitHandler(ROOT, bindingToDomCommitHandler); + biCommitHandlerRegistration = biDataService.registerCommitHandler(ROOT_BI, domToBindingCommitHandler); + baDataService.registerCommitHandlerListener(domToBindingCommitHandler); + } + + public void setMappingService(BindingIndependentMappingService mappingService) { + this.mappingService = mappingService; + } + + @Override + public Collection getProviderFunctionality() { + return Collections.emptyList(); + } + + @Override + public void onSessionInitiated(ProviderSession session) { + setBiDataService(session.getService(org.opendaylight.controller.sal.core.api.data.DataProviderService.class)); + start(); + } + + private class DomToBindingTransaction implements + DataCommitTransaction { + + private final org.opendaylight.controller.sal.binding.api.data.DataModificationTransaction backing; + private final DataModification modification; + + public DomToBindingTransaction( + org.opendaylight.controller.sal.binding.api.data.DataModificationTransaction backing, + DataModification modification) { + super(); + this.backing = backing; + this.modification = modification; + bindingOpenedTransactions.put(backing.getIdentifier(), this); + } + + @Override + public DataModification getModification() { + return modification; + } + + @Override + public RpcResult rollback() throws IllegalStateException { + // backing.cancel(); + return Rpcs. getRpcResult(true, null, Collections. emptySet()); + } + + @Override + public RpcResult finish() throws IllegalStateException { + Future> result = backing.commit(); + try { + RpcResult baResult = result.get(); + return Rpcs. getRpcResult(baResult.isSuccessful(), null, baResult.getErrors()); + } catch (InterruptedException e) { + throw new IllegalStateException("", e); + } catch (ExecutionException e) { + throw new IllegalStateException("", e); + } + } + } + + private class BindingToDomTransaction implements DataCommitTransaction, DataObject> { private DataModificationTransaction backing; private DataModification, DataObject> modification; - public WrappedTransaction(DataModificationTransaction backing, + public BindingToDomTransaction(DataModificationTransaction backing, DataModification, DataObject> modification) { this.backing = backing; this.modification = modification; + domOpenedTransactions.put(backing.getIdentifier(), this); } @Override @@ -106,46 +224,84 @@ public class BindingIndependentDataServiceConnector implements // public RpcResult finish() throws IllegalStateException { Future> result = backing.commit(); try { - RpcResult biresult = result.get(); + RpcResult biResult = result.get(); + return Rpcs. getRpcResult(biResult.isSuccessful(), null, biResult.getErrors()); } catch (InterruptedException e) { throw new IllegalStateException("", e); } catch (ExecutionException e) { throw new IllegalStateException("", e); + } finally { + domOpenedTransactions.remove(backing.getIdentifier()); } - return Rpcs. getRpcResult(true, null, Collections. emptySet()); } @Override public RpcResult rollback() throws IllegalStateException { - // backing.cancel(); + domOpenedTransactions.remove(backing.getIdentifier()); return Rpcs. getRpcResult(true, null, Collections. emptySet()); } - } - public DataBrokerService getBiDataService() { - return biDataService; - } + private class BindingToDomCommitHandler implements + DataCommitHandler, DataObject> { - public void setBiDataService(DataBrokerService biDataService) { - this.biDataService = biDataService; - } + @Override + public org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler.DataCommitTransaction, DataObject> requestCommit( + DataModification, DataObject> bindingTransaction) { - public DataProviderService getBaDataService() { - return baDataService; - } + /** + * Transaction was created as DOM transaction, in that case we do + * not need to forward it back. + */ + if (bindingOpenedTransactions.containsKey(bindingTransaction.getIdentifier())) { - public void setBaDataService(DataProviderService baDataService) { - this.baDataService = baDataService; + return CommitHandlersTransactions.allwaysSuccessfulTransaction(bindingTransaction); + } + DataModificationTransaction domTransaction = createBindingToDomTransaction(bindingTransaction); + BindingToDomTransaction wrapped = new BindingToDomTransaction(domTransaction, bindingTransaction); + LOG.info("Forwarding Binding Transaction: {} as DOM Transaction: {} .", bindingTransaction.getIdentifier(), + domTransaction.getIdentifier()); + return wrapped; + } } - public void start() { - baDataService.registerDataReader(ROOT, this); - baDataService.registerCommitHandler(ROOT, this); - } + private class DomToBindingCommitHandler implements // + RegistrationListener, DataObject>>, // + DataCommitHandler { - public void setMappingService(BindingIndependentMappingService mappingService) { - this.mappingService = mappingService; - } + @Override + public void onRegister(DataCommitHandlerRegistration, DataObject> registration) { + + org.opendaylight.yangtools.yang.data.api.InstanceIdentifier domPath = mappingService.toDataDom(registration.getPath()); + // FIXME: do registration based on only active commit handlers. + + } + @Override + public void onUnregister(DataCommitHandlerRegistration, DataObject> registration) { + // NOOP for now + // FIXME: do registration based on only active commit handlers. + } + + public org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler.DataCommitTransaction requestCommit( + DataModification domTransaction) { + Object identifier = domTransaction.getIdentifier(); + + /** + * We checks if the transcation was originated in this mapper. If it + * was originated in this mapper we are returing allways success + * commit hanlder to prevent creating loop in two-phase commit and + * duplicating data. + */ + if (domOpenedTransactions.containsKey(identifier)) { + return CommitHandlersTransactions.allwaysSuccessfulTransaction(domTransaction); + } + + org.opendaylight.controller.sal.binding.api.data.DataModificationTransaction baTransaction = createDomToBindingTransaction(domTransaction); + DomToBindingTransaction forwardedTransaction = new DomToBindingTransaction(baTransaction, domTransaction); + LOG.info("Forwarding DOM Transaction: {} as Binding Transaction: {}.", domTransaction.getIdentifier(), + baTransaction.getIdentifier()); + return forwardedTransaction; + } + } } diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/BindingIndependentMappingService.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/BindingIndependentMappingService.java index 8e61c9b3ee..9e175b8cb0 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/BindingIndependentMappingService.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/BindingIndependentMappingService.java @@ -17,6 +17,7 @@ public interface BindingIndependentMappingService { org.opendaylight.yangtools.yang.data.api.InstanceIdentifier toDataDom(InstanceIdentifier path); DataObject dataObjectFromDataDom(InstanceIdentifier path, CompositeNode result); - - + + InstanceIdentifier fromDataDom(org.opendaylight.yangtools.yang.data.api.InstanceIdentifier entry); + } diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/CommitHandlersTransactions.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/CommitHandlersTransactions.java new file mode 100644 index 0000000000..ea4837421d --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/CommitHandlersTransactions.java @@ -0,0 +1,40 @@ +package org.opendaylight.controller.sal.binding.impl.connect.dom; + +import java.util.Collections; + +import org.opendaylight.controller.md.sal.common.api.data.DataModification; +import org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler.DataCommitTransaction; +import org.opendaylight.controller.sal.common.util.Rpcs; +import org.opendaylight.yangtools.concepts.Path; +import org.opendaylight.yangtools.yang.common.RpcError; +import org.opendaylight.yangtools.yang.common.RpcResult; + +public class CommitHandlersTransactions { + + private static class AllwaysSuccessfulTransaction implements DataCommitTransaction { + + private final DataModification modification; + + public AllwaysSuccessfulTransaction(DataModification modification) { + this.modification = modification; + } + @Override + public RpcResult rollback() throws IllegalStateException { + return Rpcs.getRpcResult(true, null, Collections.emptyList()); + } + @Override + public RpcResult finish() throws IllegalStateException { + return Rpcs.getRpcResult(true, null, Collections.emptyList()); + } + + @Override + public DataModification getModification() { + return modification; + } + } + + + public static final

,D> AllwaysSuccessfulTransaction allwaysSuccessfulTransaction(DataModification modification) { + return new AllwaysSuccessfulTransaction<>(modification); + } +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/ConnectorActivator.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/ConnectorActivator.java deleted file mode 100644 index f69e664ee8..0000000000 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/ConnectorActivator.java +++ /dev/null @@ -1,80 +0,0 @@ -package org.opendaylight.controller.sal.binding.impl.connect.dom; - -import java.util.Collection; -import java.util.Collections; - -import javassist.ClassPool; - -import org.opendaylight.controller.sal.binding.api.data.DataProviderService; -import org.opendaylight.controller.sal.binding.dom.serializer.impl.RuntimeGeneratedMappingServiceImpl; -import org.opendaylight.controller.sal.binding.dom.serializer.impl.TransformerGenerator; -import org.opendaylight.controller.sal.core.api.Broker; -import org.opendaylight.controller.sal.core.api.Provider; -import org.opendaylight.controller.sal.core.api.Broker.ProviderSession; -import org.opendaylight.controller.sal.core.api.data.DataBrokerService; -import org.opendaylight.controller.sal.core.api.model.SchemaService; -import org.osgi.framework.BundleContext; -import org.osgi.framework.ServiceReference; -import org.osgi.util.tracker.ServiceTracker; -import org.osgi.util.tracker.ServiceTrackerCustomizer; - -public class ConnectorActivator implements Provider, ServiceTrackerCustomizer { - - BindingIndependentDataServiceConnector dataConnector; - BindingIndependentMappingService mappingService; - - private final DataProviderService baDataService; - private BundleContext context; - - private ServiceTracker brokerTracker; - - public ConnectorActivator(DataProviderService dataService, BundleContext context) { - baDataService = dataService; - this.context = context; - brokerTracker = new ServiceTracker<>(context, Broker.class, this); - } - - @Override - public Collection getProviderFunctionality() { - return Collections.emptySet(); - } - - @Override - public void onSessionInitiated(ProviderSession session) { - - RuntimeGeneratedMappingServiceImpl mappingImpl = new RuntimeGeneratedMappingServiceImpl(); - mappingImpl.setPool(new ClassPool()); - SchemaService schemaService = (session.getService(SchemaService.class)); - ClassPool pool = new ClassPool(); - mappingImpl.setBinding(new TransformerGenerator(pool)); - mappingImpl.start(); - schemaService.registerSchemaServiceListener(mappingImpl); - mappingService = mappingImpl; - dataConnector = new BindingIndependentDataServiceConnector(); - dataConnector.setBaDataService(baDataService); - dataConnector.setBiDataService(session.getService(DataBrokerService.class)); - dataConnector.setMappingService(mappingService); - dataConnector.start(); - } - - @Override - public Broker addingService(ServiceReference reference) { - Broker br= context.getService(reference); - br.registerProvider(this, context); - return br; - } - - @Override - public void modifiedService(ServiceReference reference, Broker service) { - // NOOP - } - - @Override - public void removedService(ServiceReference reference, Broker service) { - // NOOP - } - - public void start() { - brokerTracker.open(); - } -} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/DataModificationTracker.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/DataModificationTracker.java new file mode 100644 index 0000000000..3fc377f176 --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/connect/dom/DataModificationTracker.java @@ -0,0 +1,25 @@ +package org.opendaylight.controller.sal.binding.impl.connect.dom; + +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ConcurrentMap; + +import org.opendaylight.controller.md.sal.common.api.data.DataModification; +import org.opendaylight.yangtools.concepts.Path; + +import com.google.common.util.concurrent.JdkFutureAdapters; + +public final class DataModificationTracker

,D> { + + ConcurrentMap> trackedTransactions = new ConcurrentHashMap<>(); + + + public void startTrackingModification(DataModification modification) { + trackedTransactions.putIfAbsent(modification.getIdentifier(), modification); + + + } + + public boolean containsIdentifier(Object identifier) { + return trackedTransactions.containsKey(identifier); + } +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/spi/RpcRoutingContext.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/spi/RpcRoutingContext.java new file mode 100644 index 0000000000..e3a7235652 --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/spi/RpcRoutingContext.java @@ -0,0 +1,10 @@ +package org.opendaylight.controller.sal.binding.spi; + +import org.opendaylight.yangtools.yang.binding.BaseIdentity; +import org.opendaylight.yangtools.yang.binding.RpcService; + +public interface RpcRoutingContext { + + Class getContextType(); + Class getServiceType(); +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/yang/opendaylight-binding-broker-impl.yang b/opendaylight/md-sal/sal-binding-broker/src/main/yang/opendaylight-binding-broker-impl.yang index 72bae68d4c..38770c193c 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/yang/opendaylight-binding-broker-impl.yang +++ b/opendaylight/md-sal/sal-binding-broker/src/main/yang/opendaylight-binding-broker-impl.yang @@ -3,8 +3,10 @@ module opendaylight-sal-binding-broker-impl { namespace "urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding:impl"; prefix "binding-impl"; - import config { prefix config; revision-date 2013-04-05; } - import opendaylight-md-sal-binding {prefix sal;} + import config { prefix config; revision-date 2013-04-05; } + import opendaylight-md-sal-binding {prefix sal;} + import opendaylight-md-sal-dom {prefix dom;} + import opendaylight-md-sal-common {prefix common;} description "Service definition for Binding Aware MD-SAL."; @@ -14,39 +16,123 @@ module opendaylight-sal-binding-broker-impl { "Initial revision"; } - identity binding-broker-impl-singleton { + identity binding-dom-mapping-service { + base config:service-type; + config:java-class "org.opendaylight.controller.sal.binding.impl.connect.dom.BindingIndependentMappingService"; + } + + + identity binding-broker-impl { base config:module-type; config:provided-service sal:binding-broker-osgi-registry; - config:java-name-prefix BindingBrokerImplSingleton; + config:java-name-prefix BindingBrokerImpl; + } + + identity binding-data-broker { + base config:module-type; + config:provided-service sal:binding-data-broker; + config:provided-service sal:binding-data-consumer-broker; + config:java-name-prefix DataBrokerImpl; } - - grouping rpc-routing-table { - + identity binding-rpc-broker { + base config:module-type; + config:provided-service sal:binding-rpc-registry; + config:java-name-prefix RpcBrokerImpl; + } + + identity binding-notification-broker { + base config:module-type; + config:provided-service sal:binding-notification-service; + config:provided-service sal:binding-notification-subscription-service; + config:java-name-prefix NotificationBrokerImpl; } + identity runtime-generated-mapping { + base config:module-type; + config:provided-service binding-dom-mapping-service; + config:java-name-prefix RuntimeMapping; + } - grouping rpc-router { - leaf module { - type string; + augment "/config:modules/config:module/config:configuration" { + case binding-broker-impl { + when "/config:modules/config:module/config:type = 'binding-broker-impl'"; + + /* + container rpc-registry { + uses config:service-ref { + refine type { + mandatory true; + config:required-identity sal:binding-rpc-registry; + } + } + }*/ + + container data-broker { + uses config:service-ref { + refine type { + mandatory true; + config:required-identity sal:binding-data-broker; + } + } + } + + container notification-service { + uses config:service-ref { + refine type { + mandatory true; + config:required-identity sal:binding-notification-service; + } + } + } } - container routing-tables { - list routing-table { - uses rpc-routing-table; + } + + augment "/config:modules/config:module/config:configuration" { + case binding-data-broker { + when "/config:modules/config:module/config:type = 'binding-data-broker'"; + container dom-broker { + uses config:service-ref { + refine type { + mandatory true; + config:required-identity dom:dom-broker-osgi-registry; + } + } } + container mapping-service { + uses config:service-ref { + refine type { + mandatory true; + config:required-identity binding-dom-mapping-service; + } + } + } } } + + augment "/config:modules/config:module/config:state" { + case runtime-generated-mapping { + when "/config:modules/config:module/config:type = 'runtime-generated-mapping'"; + } + } augment "/config:modules/config:module/config:state" { - case binding-broker-impl-singleton { - when "/config:modules/config:module/config:type = 'binding-broker-impl-singleton'"; - - container rpc-routers { - list rpc-router { - uses rpc-router; - } - } + case binding-data-broker { + when "/config:modules/config:module/config:type = 'binding-data-broker'"; + uses common:data-state; + } + } + augment "/config:modules/config:module/config:state" { + case binding-rpc-broker { + when "/config:modules/config:module/config:type = 'binding-rpc-broker'"; + uses common:rpc-state; + } + } + augment "/config:modules/config:module/config:state" { + case binding-notification-broker { + when "/config:modules/config:module/config:type = 'binding-notification-broker'"; + uses common:notification-state; } } } \ No newline at end of file diff --git a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/AbstractDataServiceTest.java b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/AbstractDataServiceTest.java index 7d8a8f1fff..5b35861e9d 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/AbstractDataServiceTest.java +++ b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/AbstractDataServiceTest.java @@ -27,7 +27,7 @@ import com.google.common.util.concurrent.ListeningExecutorService; import com.google.common.util.concurrent.MoreExecutors; public abstract class AbstractDataServiceTest { - protected DataBrokerService biDataService; + protected org.opendaylight.controller.sal.core.api.data.DataProviderService biDataService; protected DataProviderService baDataService; /** @@ -67,7 +67,7 @@ public abstract class AbstractDataServiceTest { mappingService = mappingServiceImpl; File pathname = new File("target/gen-classes-debug"); //System.out.println("Generated classes are captured in " + pathname.getAbsolutePath()); - mappingServiceImpl.start(); + mappingServiceImpl.start(null); //mappingServiceImpl.getBinding().setClassFileCapturePath(pathname); connectorServiceImpl = new BindingIndependentDataServiceConnector(); diff --git a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug01Test.java b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug01Test.java index 4e7628fd06..f60ddb991d 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug01Test.java +++ b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug01Test.java @@ -1,22 +1,21 @@ package org.opendaylight.controller.sal.binding.test.bugfix; import java.util.ArrayList; -import java.util.Arrays; import java.util.Collections; import java.util.List; import java.util.Map; import java.util.concurrent.Callable; import java.util.concurrent.ExecutorService; import java.util.concurrent.Executors; -import java.util.concurrent.Future; + + import org.junit.Test; import org.opendaylight.controller.md.sal.common.api.TransactionStatus; import org.opendaylight.controller.sal.binding.test.AbstractDataServiceTest; import org.opendaylight.controller.sal.binding.api.data.DataModificationTransaction; -import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.Uri; -import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.OutputActionBuilder; -import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.PopMplsAction; +import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.DropAction; +import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.DropActionBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.PopMplsActionBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action; import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.ActionBuilder; @@ -24,9 +23,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.Flows import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.Flow; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.FlowBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.FlowKey; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.Instructions; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.InstructionsBuilder; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.Match; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.MatchBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instruction.instruction.ApplyActionsBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instruction.list.Instruction; @@ -35,10 +32,11 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.N import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeRef; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes; -import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodesBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey; import org.opendaylight.yang.gen.v1.urn.opendaylight.l2.types.rev130827.VlanId; import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.VlanMatchBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._4.match.TcpMatchBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.vlan.match.fields.VlanIdBuilder; import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; @@ -46,7 +44,6 @@ import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.common.RpcResult; import org.opendaylight.yangtools.yang.data.api.CompositeNode; -import com.google.common.collect.FluentIterable; import com.google.common.collect.ImmutableMap; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture; @@ -68,17 +65,7 @@ public class DOMCodecBug01Test extends AbstractDataServiceTest { private static final Map NODE_KEY_BI = Collections. singletonMap(NODE_ID_QNAME, NODE_ID); - private static final InstanceIdentifier NODES_INSTANCE_ID_BA = InstanceIdentifier.builder() // - .node(Nodes.class) // - .toInstance(); - - private static final org.opendaylight.yangtools.yang.data.api.InstanceIdentifier NODES_INSTANCE_ID_BI = // - org.opendaylight.yangtools.yang.data.api.InstanceIdentifier.builder() // - .node(Nodes.QNAME) // - .toInstance(); - - private static final InstanceIdentifier NODE_INSTANCE_ID_BA = InstanceIdentifier.builder() // - .node(Nodes.class) // + private static final InstanceIdentifier NODE_INSTANCE_ID_BA = InstanceIdentifier.builder(Nodes.class) // .child(Node.class, NODE_KEY).toInstance(); private static final org.opendaylight.yangtools.yang.data.api.InstanceIdentifier NODE_INSTANCE_ID_BI = // @@ -99,9 +86,8 @@ public class DOMCodecBug01Test extends AbstractDataServiceTest { .nodeWithKey(Flow.QNAME, FLOW_KEY_BI) // .toInstance(); private static final InstanceIdentifier FLOW_INSTANCE_ID_BA = // - InstanceIdentifier.builder() // - .node(Flows.class) // - .node(Flow.class, FLOW_KEY) // + InstanceIdentifier.builder(Flows.class) // + .child(Flow.class, FLOW_KEY) // .toInstance(); @@ -142,6 +128,7 @@ public class DOMCodecBug01Test extends AbstractDataServiceTest { ListenableFuture task3Future = listenablePool.submit(task3); + @SuppressWarnings("unchecked") ListenableFuture> compositeFuture = Futures.allAsList(task1Future,task2Future,task3Future); Thread.sleep(500); @@ -180,8 +167,6 @@ public class DOMCodecBug01Test extends AbstractDataServiceTest { flow.setKey(FLOW_KEY); flow.setMatch(match.build()); flow.setNode(NODE_REF); - - InstructionsBuilder instructions = new InstructionsBuilder(); InstructionBuilder instruction = new InstructionBuilder(); ApplyActionsBuilder applyActions = new ApplyActionsBuilder(); @@ -191,6 +176,7 @@ public class DOMCodecBug01Test extends AbstractDataServiceTest { actionList.add(new ActionBuilder().setAction(popMplsAction.build()).build()); applyActions.setAction(actionList ); + instruction.setInstruction(applyActions.build()); @@ -205,13 +191,37 @@ public class DOMCodecBug01Test extends AbstractDataServiceTest { assertNotNull(ret); assertEquals(TransactionStatus.COMMITED, ret.getResult()); } + + private void createFlow2() throws Exception { + DataModificationTransaction modification = baDataService.beginTransaction(); + long id = 123; + FlowKey key = new FlowKey(id, new NodeRef(NODE_INSTANCE_ID_BA)); + InstanceIdentifier path1; + FlowBuilder flow = new FlowBuilder(); + flow.setKey(key); + MatchBuilder match = new MatchBuilder(); + Ipv4MatchBuilder ipv4Match = new Ipv4MatchBuilder(); + // ipv4Match.setIpv4Destination(new Ipv4Prefix(cliInput.get(4))); + match.setLayer4Match(new TcpMatchBuilder().build()); + flow.setMatch(match.build()); + DropAction dropAction = new DropActionBuilder().build(); + // ActionBuilder action = new ActionBuilder(); + + // List actions = Collections + // .singletonList(action.build()); + // flow.setAction(actions); + flow.setPriority(2); + System.out.println("Putting the configuration Data................"); + path1 = InstanceIdentifier.builder(Flows.class).child(Flow.class, key).toInstance(); + // DataObject cls = (DataObject) modification.readConfigurationData(path1); + modification.putConfigurationData(path1, flow.build()); + modification.commit(); + + } private class CreateFlowTask implements Callable { - final Object startSyncObject; - public CreateFlowTask(Object startSync) { - startSyncObject = startSync; } @Override @@ -220,6 +230,7 @@ public class DOMCodecBug01Test extends AbstractDataServiceTest { //startSyncObject.wait(); //Thread.sleep(500); createFlow(); + createFlow2(); } catch (Exception e) { throw new RuntimeException(e); } @@ -228,10 +239,10 @@ public class DOMCodecBug01Test extends AbstractDataServiceTest { } private void verifyDataAreStoredProperly() { - CompositeNode biFlow = biDataService.readConfigurationData(FLOW_INSTANCE_ID_BI); + CompositeNode biFlows = biDataService.readConfigurationData(org.opendaylight.yangtools.yang.data.api.InstanceIdentifier.of(Flows.QNAME)); + assertNotNull(biFlows); + CompositeNode biFlow = biFlows.getFirstCompositeByName(Flow.QNAME); assertNotNull(biFlow); - CompositeNode biMatch = biFlow.getFirstCompositeByName(QName.create(Flow.QNAME, Match.QNAME.getLocalName())); - assertNotNull(biMatch); } diff --git a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug02Test.java b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug02Test.java index 773bab80f1..4df10bc135 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug02Test.java +++ b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug02Test.java @@ -1,8 +1,6 @@ package org.opendaylight.controller.sal.binding.test.bugfix; -import java.util.Arrays; import java.util.Collections; -import java.util.List; import java.util.Map; import java.util.concurrent.Callable; import java.util.concurrent.ExecutorService; @@ -13,43 +11,22 @@ import org.junit.Test; import org.opendaylight.controller.md.sal.common.api.TransactionStatus; import org.opendaylight.controller.sal.binding.test.AbstractDataServiceTest; import org.opendaylight.controller.sal.binding.api.data.DataModificationTransaction; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.Flows; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.Flow; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.FlowBuilder; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.FlowKey; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.Match; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.MatchBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeRef; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodesBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey; -import org.opendaylight.yang.gen.v1.urn.opendaylight.l2.types.rev130827.VlanId; -import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.VlanMatchBuilder; -import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.vlan.match.fields.VlanIdBuilder; -import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.common.RpcResult; -import org.opendaylight.yangtools.yang.data.api.CompositeNode; - -import com.google.common.collect.FluentIterable; -import com.google.common.collect.ImmutableMap; -import com.google.common.util.concurrent.Futures; -import com.google.common.util.concurrent.ListenableFuture; -import com.google.common.util.concurrent.ListeningExecutorService; -import com.google.common.util.concurrent.MoreExecutors; import static org.junit.Assert.*; public class DOMCodecBug02Test extends AbstractDataServiceTest { private static final QName NODE_ID_QNAME = QName.create(Node.QNAME, "id"); - private static final QName FLOW_ID_QNAME = QName.create(Flow.QNAME, "id"); - private static final QName FLOW_NODE_QNAME = QName.create(Flow.QNAME, "node"); - - private static final String FLOW_ID = "foo"; private static final String NODE_ID = "node:1"; private static final NodeKey NODE_KEY = new NodeKey(new NodeId(NODE_ID)); @@ -57,8 +34,7 @@ public class DOMCodecBug02Test extends AbstractDataServiceTest { private static final Map NODE_KEY_BI = Collections. singletonMap(NODE_ID_QNAME, NODE_ID); - private static final InstanceIdentifier NODES_INSTANCE_ID_BA = InstanceIdentifier.builder() // - .node(Nodes.class) // + private static final InstanceIdentifier NODES_INSTANCE_ID_BA = InstanceIdentifier.builder(Nodes.class) // .toInstance(); private static final org.opendaylight.yangtools.yang.data.api.InstanceIdentifier NODES_INSTANCE_ID_BI = // @@ -66,8 +42,7 @@ public class DOMCodecBug02Test extends AbstractDataServiceTest { .node(Nodes.QNAME) // .toInstance(); - private static final InstanceIdentifier NODE_INSTANCE_ID_BA = InstanceIdentifier.builder() // - .node(Nodes.class) // + private static final InstanceIdentifier NODE_INSTANCE_ID_BA = InstanceIdentifier.builder(Nodes.class) // .child(Node.class, NODE_KEY).toInstance(); private static final org.opendaylight.yangtools.yang.data.api.InstanceIdentifier NODE_INSTANCE_ID_BI = // diff --git a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug03Test.java b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug03Test.java index ae54591a23..2cd396dedc 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug03Test.java +++ b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug03Test.java @@ -1,13 +1,7 @@ package org.opendaylight.controller.sal.binding.test.bugfix; - -import java.util.Arrays; import java.util.Collections; -import java.util.List; import java.util.Map; -import java.util.concurrent.Callable; -import java.util.concurrent.ExecutorService; -import java.util.concurrent.Executors; -import java.util.concurrent.Future; + import org.junit.Test; import org.opendaylight.controller.md.sal.common.api.TransactionStatus; @@ -15,36 +9,24 @@ import org.opendaylight.controller.md.sal.common.api.data.DataChangeEvent; import org.opendaylight.controller.sal.binding.test.AbstractDataServiceTest; import org.opendaylight.controller.sal.binding.api.data.DataChangeListener; import org.opendaylight.controller.sal.binding.api.data.DataModificationTransaction; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.Flows; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.Flow; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.FlowBuilder; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.FlowKey; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowCapableNode; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowCapableNodeBuilder; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.Match; -import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.MatchBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.node.NodeConnector; +import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.node.NodeConnectorBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.node.NodeConnectorKey; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId; -import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeRef; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes; -import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodesBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey; -import org.opendaylight.yang.gen.v1.urn.opendaylight.l2.types.rev130827.VlanId; -import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.VlanMatchBuilder; -import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.vlan.match.fields.VlanIdBuilder; import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.common.RpcResult; import org.opendaylight.yangtools.yang.data.api.CompositeNode; -import com.google.common.collect.FluentIterable; -import com.google.common.collect.ImmutableMap; -import com.google.common.util.concurrent.Futures; -import com.google.common.util.concurrent.ListenableFuture; -import com.google.common.util.concurrent.ListeningExecutorService; -import com.google.common.util.concurrent.MoreExecutors; + import static org.junit.Assert.*; @@ -58,17 +40,11 @@ public class DOMCodecBug03Test extends AbstractDataServiceTest implements DataCh private static final Map NODE_KEY_BI = Collections. singletonMap(NODE_ID_QNAME, NODE_ID); - private static final InstanceIdentifier NODES_INSTANCE_ID_BA = InstanceIdentifier.builder() // - .node(Nodes.class) // + private static final InstanceIdentifier NODES_INSTANCE_ID_BA = InstanceIdentifier.builder(Nodes.class) // .toInstance(); - private static final org.opendaylight.yangtools.yang.data.api.InstanceIdentifier NODES_INSTANCE_ID_BI = // - org.opendaylight.yangtools.yang.data.api.InstanceIdentifier.builder() // - .node(Nodes.QNAME) // - .toInstance(); - private static final InstanceIdentifier NODE_INSTANCE_ID_BA = InstanceIdentifier.builder() // - .node(Nodes.class) // + private static final InstanceIdentifier NODE_INSTANCE_ID_BA = InstanceIdentifier.builder(NODES_INSTANCE_ID_BA) // .child(Node.class, NODE_KEY).toInstance(); private static final org.opendaylight.yangtools.yang.data.api.InstanceIdentifier NODE_INSTANCE_ID_BI = // @@ -76,7 +52,6 @@ public class DOMCodecBug03Test extends AbstractDataServiceTest implements DataCh .node(Nodes.QNAME) // .nodeWithKey(Node.QNAME, NODE_KEY_BI) // .toInstance(); - private static final NodeRef NODE_REF = new NodeRef(NODE_INSTANCE_ID_BA); private DataChangeEvent, DataObject> receivedChangeEvent; @@ -120,6 +95,49 @@ public class DOMCodecBug03Test extends AbstractDataServiceTest implements DataCh verifyNodes(nodes,original); + + testAddingNodeConnector(); + + + + testNodeRemove(); + + + } + + private void testAddingNodeConnector() throws Exception { + + NodeConnectorId ncId = new NodeConnectorId("openflow:1:bar"); + NodeConnectorKey nodeKey = new NodeConnectorKey(ncId ); + InstanceIdentifier ncInstanceId = InstanceIdentifier.builder(NODE_INSTANCE_ID_BA).child(NodeConnector.class, nodeKey).toInstance(); + NodeConnectorBuilder ncBuilder = new NodeConnectorBuilder(); + ncBuilder.setId(ncId); + ncBuilder.setKey(nodeKey); + NodeConnector connector = ncBuilder.build(); + DataModificationTransaction transaction = baDataService.beginTransaction(); + transaction.putOperationalData(ncInstanceId, connector); + RpcResult result = transaction.commit().get(); + assertEquals(TransactionStatus.COMMITED, result.getResult()); + Node node = (Node) baDataService.readOperationalData(NODE_INSTANCE_ID_BA); + assertNotNull(node); + assertNotNull(node.getNodeConnector()); + assertFalse(node.getNodeConnector().isEmpty()); + NodeConnector readedNc = node.getNodeConnector().get(0); + assertNotNull(readedNc); + + + + + } + + private void testNodeRemove() throws Exception { + DataModificationTransaction transaction = baDataService.beginTransaction(); + transaction.removeOperationalData(NODE_INSTANCE_ID_BA); + RpcResult result = transaction.commit().get(); + assertEquals(TransactionStatus.COMMITED, result.getResult()); + + Node node = (Node) baDataService.readOperationalData(NODE_INSTANCE_ID_BA); + assertNull(node); } private void verifyNodes(Nodes nodes,Node original) { diff --git a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/RpcRegistrationNullPointer.java b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/RpcRegistrationNullPointer.java new file mode 100644 index 0000000000..0c7f039642 --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/RpcRegistrationNullPointer.java @@ -0,0 +1,8 @@ +package org.opendaylight.controller.sal.binding.test.bugfix; + +public class RpcRegistrationNullPointer { + + + + +} diff --git a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/connect/dom/BrokerIntegrationTest.java b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/connect/dom/BrokerIntegrationTest.java index 7706cda750..e326fd0931 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/connect/dom/BrokerIntegrationTest.java +++ b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/connect/dom/BrokerIntegrationTest.java @@ -63,7 +63,7 @@ public class BrokerIntegrationTest extends AbstractDataServiceTest { assertNotNull(result2.getResult()); assertEquals(TransactionStatus.COMMITED, result.getResult()); - Nodes allNodes = (Nodes) baDataService.readConfigurationData(InstanceIdentifier.builder().node(Nodes.class) + Nodes allNodes = (Nodes) baDataService.readConfigurationData(InstanceIdentifier.builder(Nodes.class) .toInstance()); assertNotNull(allNodes); assertNotNull(allNodes.getNode()); @@ -100,7 +100,7 @@ public class BrokerIntegrationTest extends AbstractDataServiceTest { private static NodeRef createNodeRef(String string) { NodeKey key = new NodeKey(new NodeId(string)); - InstanceIdentifier path = InstanceIdentifier.builder().node(Nodes.class).node(Node.class, key) + InstanceIdentifier path = InstanceIdentifier.builder(Nodes.class).child(Node.class, key) .toInstance(); return new NodeRef(path); } diff --git a/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/connect/dom/ChangeOriginatedInDomBrokerTest.java b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/connect/dom/ChangeOriginatedInDomBrokerTest.java new file mode 100644 index 0000000000..63368bd6c8 --- /dev/null +++ b/opendaylight/md-sal/sal-binding-broker/src/test/java/org/opendaylight/controller/sal/binding/test/connect/dom/ChangeOriginatedInDomBrokerTest.java @@ -0,0 +1,190 @@ +package org.opendaylight.controller.sal.binding.test.connect.dom; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; + + + + + + + + + + + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.concurrent.Future; + + + + + + + + + + + +import org.junit.Test; +import org.opendaylight.controller.md.sal.common.api.TransactionStatus; +import org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler; +import org.opendaylight.controller.md.sal.common.api.data.DataModification; +import org.opendaylight.controller.sal.binding.impl.connect.dom.CommitHandlersTransactions; +import org.opendaylight.controller.sal.binding.test.AbstractDataServiceTest; +import org.opendaylight.controller.sal.core.api.data.DataModificationTransaction; +import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.PopMplsActionBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action; +import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.ActionBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.Flows; +import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.Flow; +import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.FlowBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.config.rev130819.flows.FlowKey; +import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.InstructionsBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.MatchBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instruction.instruction.ApplyActionsBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instruction.list.Instruction; +import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instruction.list.InstructionBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId; +import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeRef; +import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes; +import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node; +import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey; +import org.opendaylight.yang.gen.v1.urn.opendaylight.l2.types.rev130827.VlanId; +import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.VlanMatchBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.vlan.match.fields.VlanIdBuilder; +import org.opendaylight.yangtools.concepts.Registration; +import org.opendaylight.yangtools.yang.binding.DataObject; +import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; +import org.opendaylight.yangtools.yang.common.QName; +import org.opendaylight.yangtools.yang.common.RpcResult; +import org.opendaylight.yangtools.yang.data.api.CompositeNode; + +import com.google.common.collect.ImmutableMap; + +public class ChangeOriginatedInDomBrokerTest extends AbstractDataServiceTest { + + private static final QName NODE_ID_QNAME = QName.create(Node.QNAME, "id"); + private static final QName FLOW_ID_QNAME = QName.create(Flow.QNAME, "id"); + private static final QName FLOW_NODE_QNAME = QName.create(Flow.QNAME, "node"); + private static final long FLOW_ID = 1234; + private static final String NODE_ID = "node:1"; + + private DataModification, DataObject> modificationCapture; + + + private static final NodeKey NODE_KEY = new NodeKey(new NodeId(NODE_ID)); + + private static final Map NODE_KEY_BI = Collections. singletonMap(NODE_ID_QNAME, + NODE_ID); + + private static final InstanceIdentifier NODE_INSTANCE_ID_BA = InstanceIdentifier.builder(Nodes.class) // + .child(Node.class, NODE_KEY).toInstance(); + + private static final org.opendaylight.yangtools.yang.data.api.InstanceIdentifier NODE_INSTANCE_ID_BI = // + org.opendaylight.yangtools.yang.data.api.InstanceIdentifier.builder() // + .node(Nodes.QNAME) // + .nodeWithKey(Node.QNAME, NODE_KEY_BI) // + .toInstance(); + private static final NodeRef NODE_REF = new NodeRef(NODE_INSTANCE_ID_BA); + + private static final FlowKey FLOW_KEY = new FlowKey(FLOW_ID, NODE_REF); + + private static final Map FLOW_KEY_BI = // + ImmutableMap. of(FLOW_ID_QNAME, FLOW_ID, FLOW_NODE_QNAME, NODE_INSTANCE_ID_BI); + + private static final org.opendaylight.yangtools.yang.data.api.InstanceIdentifier FLOW_INSTANCE_ID_BI = // + org.opendaylight.yangtools.yang.data.api.InstanceIdentifier.builder() // + .node(Flows.QNAME) // + .nodeWithKey(Flow.QNAME, FLOW_KEY_BI) // + .toInstance(); + + private static final InstanceIdentifier FLOWS_PATH_BA = // + InstanceIdentifier.builder(Flows.class) // + .toInstance(); + + + private static final InstanceIdentifier FLOW_INSTANCE_ID_BA = // + InstanceIdentifier.builder(Flows.class) // + .child(Flow.class, FLOW_KEY) // + .toInstance(); + + @Test + public void simpleModifyOperation() throws Exception { + + registerCommitHandler(); + + CompositeNode domflow = createXmlFlow(); + DataModificationTransaction biTransaction = biDataService.beginTransaction(); + biTransaction.putConfigurationData(FLOW_INSTANCE_ID_BI, domflow); + RpcResult biResult = biTransaction.commit().get(); + + assertNotNull(modificationCapture); + Flow flow = (Flow) modificationCapture.getCreatedConfigurationData().get(FLOW_INSTANCE_ID_BA); + assertNotNull(flow); + assertNotNull(flow.getMatch()); + assertEquals(TransactionStatus.COMMITED, biResult.getResult()); + + } + + + + private void registerCommitHandler() { + DataCommitHandler, DataObject> flowTestCommitHandler = new DataCommitHandler, DataObject>() { + + + @Override + public org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler.DataCommitTransaction, DataObject> requestCommit( + DataModification, DataObject> modification) { + modificationCapture = modification; + return CommitHandlersTransactions.allwaysSuccessfulTransaction(modification); + } + + + }; + Registration, DataObject>> registration = baDataService.registerCommitHandler(FLOWS_PATH_BA, flowTestCommitHandler); + assertNotNull(registration); + } + + private CompositeNode createXmlFlow() { + + FlowBuilder flow = new FlowBuilder(); + MatchBuilder match = new MatchBuilder(); + VlanMatchBuilder vlanBuilder = new VlanMatchBuilder(); + VlanIdBuilder vlanIdBuilder = new VlanIdBuilder(); + VlanId vlanId = new VlanId(10); + vlanBuilder.setVlanId(vlanIdBuilder.setVlanId(vlanId).build()); + match.setVlanMatch(vlanBuilder.build()); + + flow.setKey(FLOW_KEY); + flow.setMatch(match.build()); + flow.setNode(NODE_REF); + InstructionsBuilder instructions = new InstructionsBuilder(); + InstructionBuilder instruction = new InstructionBuilder(); + ApplyActionsBuilder applyActions = new ApplyActionsBuilder(); + List actionList = new ArrayList<>(); + PopMplsActionBuilder popMplsAction = new PopMplsActionBuilder(); + popMplsAction.setEthernetType(34); + actionList.add(new ActionBuilder().setAction(popMplsAction.build()).build()); + + applyActions.setAction(actionList ); + + + + instruction.setInstruction(applyActions.build()); + + + List instructionList = Collections.singletonList(instruction.build()); + instructions.setInstruction(instructionList ); + + flow.setInstructions(instructions.build()); + + CompositeNode domFlow = mappingService.toDataDom(flow.build()); + return domFlow; + } +} diff --git a/opendaylight/md-sal/sal-binding-config/src/main/yang/opendaylight-md-sal-binding.yang b/opendaylight/md-sal/sal-binding-config/src/main/yang/opendaylight-md-sal-binding.yang index bf3d7abd1e..38f0da3ccc 100644 --- a/opendaylight/md-sal/sal-binding-config/src/main/yang/opendaylight-md-sal-binding.yang +++ b/opendaylight/md-sal/sal-binding-config/src/main/yang/opendaylight-md-sal-binding.yang @@ -23,6 +23,11 @@ module opendaylight-md-sal-binding { config:java-class "org.opendaylight.controller.sal.binding.api.data.DataProviderService"; } + identity binding-data-consumer-broker { + base "config:service-type"; + config:java-class "org.opendaylight.controller.sal.binding.api.data.DataBrokerService"; + } + identity binding-rpc-registry { base "config:service-type"; config:java-class "org.opendaylight.controller.sal.binding.api.RpcProviderRegistry"; @@ -33,4 +38,9 @@ module opendaylight-md-sal-binding { config:java-class "org.opendaylight.controller.sal.binding.api.NotificationProviderService"; } + identity binding-notification-subscription-service { + base "config:service-type"; + config:java-class "org.opendaylight.controller.sal.binding.api.NotificationService"; + } + } \ No newline at end of file diff --git a/opendaylight/md-sal/sal-binding-it/pom.xml b/opendaylight/md-sal/sal-binding-it/pom.xml index e242b9ecee..27d426791f 100644 --- a/opendaylight/md-sal/sal-binding-it/pom.xml +++ b/opendaylight/md-sal/sal-binding-it/pom.xml @@ -1,215 +1,252 @@ - 4.0.0 - - sal-parent - org.opendaylight.controller - 1.0-SNAPSHOT - - sal-binding-it - - scm:git:ssh://git.opendaylight.org:29418/controller.git - scm:git:ssh://git.opendaylight.org:29418/controller.git - https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL - + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> + 4.0.0 + + sal-parent + org.opendaylight.controller + 1.0-SNAPSHOT + + sal-binding-it + + scm:git:ssh://git.opendaylight.org:29418/controller.git + scm:git:ssh://git.opendaylight.org:29418/controller.git + https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL + - - 3.0.0 - 1.5.0 - - ../sal-binding-broker/target/jacoco.exec - ../sal-binding-broker/target/jacoco-it.exec - + + 3.0.0 + 1.5.0 + + ../sal-binding-broker/target/jacoco.exec + ../sal-binding-broker/target/jacoco-it.exec + 0.2.3-SNAPSHOT + 0.2.3-SNAPSHOT + - - - - org.ops4j.pax.exam - maven-paxexam-plugin - 1.2.4 - - - generate-config - - generate-depends-file - - - - - - org.jacoco - jacoco-maven-plugin - - org.opendaylight.controller.* - - - - pre-test - - prepare-agent - - - - post-test - test - - report - - - - - - - - - - org.eclipse.m2e - lifecycle-mapping - 1.0.0 - - - - - - - org.ops4j.pax.exam - - - maven-paxexam-plugin - - - [1.2.4,) - - - - generate-depends-file - - - - - - - - - - - - - org.jacoco - jacoco-maven-plugin - ${jacoco.version} - - ../sal-binding-broker/target/jacoco-it.exec - org.opendaylight.controller.* - - - - pre-test - - prepare-agent - - - - post-test - - true - - - - - - - + + + + org.ops4j.pax.exam + maven-paxexam-plugin + 1.2.4 + + + generate-config + + generate-depends-file + + + + + + org.jacoco + jacoco-maven-plugin + + org.opendaylight.controller.* + + + + pre-test + + prepare-agent + + + + post-test + test + + report + + + + + + + + + + org.eclipse.m2e + lifecycle-mapping + 1.0.0 + + + + + + + org.ops4j.pax.exam + + + maven-paxexam-plugin + + + [1.2.4,) + + + + generate-depends-file + + + + + + + + + + + + + org.jacoco + jacoco-maven-plugin + ${jacoco.version} + + ../sal-binding-broker/target/jacoco-it.exec + org.opendaylight.controller.* + + + + pre-test + + prepare-agent + + + + post-test + + true + + + + + + + - - - org.opendaylight.yangtools.thirdparty - xtend-lib-osgi - 2.4.3 - test - - - org.opendaylight.controller - sal-binding-broker-impl - 1.0-SNAPSHOT - provided - - - org.ops4j.pax.exam - pax-exam-container-native - ${exam.version} - test - - - org.ops4j.pax.exam - pax-exam-junit4 - ${exam.version} - test - - - org.ops4j.pax.exam - pax-exam - ${exam.version} - - compile - - - org.ops4j.pax.exam - pax-exam-link-mvn - ${exam.version} - test - - - equinoxSDK381 - org.eclipse.osgi - 3.8.1.v20120830-144521 - test - - - org.slf4j - log4j-over-slf4j - 1.7.2 - - - ch.qos.logback - logback-core - 1.0.9 - - - ch.qos.logback - logback-classic - 1.0.9 - - - org.mockito - mockito-all - test - - - org.opendaylight.controller.model - model-flow-service - 1.0-SNAPSHOT - provided - - - org.opendaylight.controller - config-manager - 0.2.3-SNAPSHOT - - - org.opendaylight.controller.model - model-flow-management - 1.0-SNAPSHOT - provided - - + + + org.opendaylight.yangtools.thirdparty + xtend-lib-osgi + 2.4.3 + test + + + org.opendaylight.controller + sal-binding-broker-impl + 1.0-SNAPSHOT + provided + + + org.ops4j.pax.exam + pax-exam-container-native + ${exam.version} + test + + + org.ops4j.pax.exam + pax-exam-junit4 + ${exam.version} + test + + + org.opendaylight.controller + config-netconf-connector + ${netconf.version} + test + + + org.opendaylight.controller + yang-store-impl + ${config.version} + + + org.opendaylight.controller + logback-config + ${config.version} + + + org.opendaylight.controller + config-persister-impl + ${config.version} + + + org.opendaylight.controller + config-persister-file-adapter + ${config.version} + + + org.opendaylight.controller + netconf-impl + ${netconf.version} + + + org.opendaylight.controller + netconf-client + ${netconf.version} + + + org.ops4j.pax.exam + pax-exam + ${exam.version} + + compile + + + org.ops4j.pax.exam + pax-exam-link-mvn + ${exam.version} + test + + + equinoxSDK381 + org.eclipse.osgi + 3.8.1.v20120830-144521 + test + + + org.slf4j + log4j-over-slf4j + 1.7.2 + + + ch.qos.logback + logback-core + 1.0.9 + + + ch.qos.logback + logback-classic + 1.0.9 + + + org.mockito + mockito-all + test + + + org.opendaylight.controller.model + model-flow-service + 1.0-SNAPSHOT + provided + + + org.opendaylight.controller + config-manager + 0.2.3-SNAPSHOT + + + org.opendaylight.controller.model + model-flow-management + 1.0-SNAPSHOT + provided + + org.opendaylight.yangtools.thirdparty antlr4-runtime-osgi-nohead 4.0 - - + + diff --git a/opendaylight/md-sal/sal-binding-it/src/main/java/org/opendaylight/controller/test/sal/binding/it/TestHelper.java b/opendaylight/md-sal/sal-binding-it/src/main/java/org/opendaylight/controller/test/sal/binding/it/TestHelper.java index 2f9c397632..0eace4daac 100644 --- a/opendaylight/md-sal/sal-binding-it/src/main/java/org/opendaylight/controller/test/sal/binding/it/TestHelper.java +++ b/opendaylight/md-sal/sal-binding-it/src/main/java/org/opendaylight/controller/test/sal/binding/it/TestHelper.java @@ -4,9 +4,12 @@ import static org.ops4j.pax.exam.CoreOptions.frameworkProperty; import static org.ops4j.pax.exam.CoreOptions.junitBundles; import static org.ops4j.pax.exam.CoreOptions.mavenBundle; import static org.ops4j.pax.exam.CoreOptions.repository; +import static org.ops4j.pax.exam.CoreOptions.repositories; +import static org.ops4j.pax.exam.CoreOptions.systemProperty; import org.ops4j.pax.exam.Option; import org.ops4j.pax.exam.options.DefaultCompositeOption; +import org.ops4j.pax.exam.util.PathUtils; public class TestHelper { @@ -15,62 +18,107 @@ public class TestHelper { public static final String CONTROLLER_MODELS = "org.opendaylight.controller.model"; public static final String YANGTOOLS_MODELS = "org.opendaylight.yangtools.model"; + private static final String OPENDAYLIGHT_SNAPSHOT = "http://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/"; + private static final String OPENDAYLIGHT_RELEASE = "http://nexus.opendaylight.org/content/repositories/opendaylight.release/"; public static Option mdSalCoreBundles() { return new DefaultCompositeOption( // - mavenBundle(YANGTOOLS, "concepts").versionAsInProject(), // - mavenBundle(YANGTOOLS, "yang-binding").versionAsInProject(), // - mavenBundle(YANGTOOLS, "yang-common").versionAsInProject(), // - mavenBundle(CONTROLLER, "sal-common").versionAsInProject(), // - mavenBundle(CONTROLLER, "sal-common-api").versionAsInProject(), // - mavenBundle(CONTROLLER, "sal-common-impl").versionAsInProject(), // - - mavenBundle("org.apache.commons", "commons-lang3").versionAsInProject(), - mavenBundle("com.google.guava", "guava").versionAsInProject(), // + mavenBundle(YANGTOOLS, "concepts").versionAsInProject(), // // + mavenBundle(YANGTOOLS, "yang-binding").versionAsInProject(), // // + mavenBundle(YANGTOOLS, "yang-common").versionAsInProject(), // // + mavenBundle(CONTROLLER, "sal-common").versionAsInProject(), // // + mavenBundle(CONTROLLER, "sal-common-api").versionAsInProject(), // // + mavenBundle(CONTROLLER, "sal-common-impl").versionAsInProject(), // // + + mavenBundle("org.apache.commons", "commons-lang3").versionAsInProject(), // + mavenBundle("com.google.guava", "guava").versionAsInProject(), // // mavenBundle(YANGTOOLS + ".thirdparty", "xtend-lib-osgi").versionAsInProject() // ); } public static Option configMinumumBundles() { return new DefaultCompositeOption( - mavenBundle(CONTROLLER, "config-api").versionAsInProject(), // - mavenBundle(CONTROLLER, "config-manager").versionAsInProject(), // - mavenBundle("commons-io", "commons-io").versionAsInProject() - ); + mavenBundle("org.opendaylight.bgpcep", "framework").versionAsInProject(), // + mavenBundle("org.opendaylight.bgpcep", "util").versionAsInProject(), // + mavenBundle("commons-codec", "commons-codec").versionAsInProject(), + + mavenBundle(CONTROLLER, "config-api").versionAsInProject(), // // + mavenBundle(CONTROLLER, "config-manager").versionAsInProject(), // // + mavenBundle("commons-io", "commons-io").versionAsInProject(), // + mavenBundle(CONTROLLER, "config-api").versionAsInProject(), // + mavenBundle(CONTROLLER, "config-manager").versionAsInProject(), // + mavenBundle(CONTROLLER, "config-util").versionAsInProject(), // + mavenBundle(CONTROLLER, "yang-jmx-generator").versionAsInProject(), // + mavenBundle(CONTROLLER, "yang-store-api").versionAsInProject(), // + mavenBundle(CONTROLLER, "yang-store-impl").versionAsInProject(), // + mavenBundle(CONTROLLER, "logback-config").versionAsInProject(), // + mavenBundle(CONTROLLER, "config-persister-api").versionAsInProject(), // + mavenBundle(CONTROLLER, "netconf-api").versionAsInProject(), // + + mavenBundle(CONTROLLER, "netconf-client").versionAsInProject(), // + mavenBundle(CONTROLLER, "netconf-util").versionAsInProject(), // + mavenBundle(CONTROLLER + ".thirdparty", "ganymed", "1.0-SNAPSHOT"), // + mavenBundle(CONTROLLER, "netconf-mapping-api").versionAsInProject(), // + + mavenBundle(CONTROLLER, "config-persister-impl").versionAsInProject(), // + + mavenBundle("io.netty", "netty-handler").versionAsInProject(), // + mavenBundle("io.netty", "netty-codec").versionAsInProject(), // + mavenBundle("io.netty", "netty-buffer").versionAsInProject(), // + mavenBundle("io.netty", "netty-transport").versionAsInProject(), // + mavenBundle("io.netty", "netty-common").versionAsInProject(), // + + mavenBundle("org.opendaylight.controller.thirdparty", "exificient", "0.9.2-SNAPSHOT"), // + + mavenBundle("org.apache.servicemix.bundles", "org.apache.servicemix.bundles.xerces", "2.11.0_1"), + mavenBundle("org.eclipse.birt.runtime.3_7_1", "org.apache.xml.resolver", "1.2.0"), + + mavenBundle(CONTROLLER, "config-netconf-connector").versionAsInProject(), // + mavenBundle(CONTROLLER, "netconf-impl").versionAsInProject(), // + + mavenBundle(CONTROLLER, "config-persister-file-adapter").versionAsInProject().noStart()); + } - + public static Option bindingAwareSalBundles() { return new DefaultCompositeOption( // - mavenBundle(CONTROLLER, "sal-binding-api").versionAsInProject(), // - mavenBundle(CONTROLLER, "sal-binding-config").versionAsInProject(), - mavenBundle(CONTROLLER, "sal-binding-broker-impl").versionAsInProject(), // - mavenBundle("org.javassist", "javassist").versionAsInProject(), // - mavenBundle(CONTROLLER, "sal-common-util").versionAsInProject(), // - - mavenBundle(YANGTOOLS, "yang-data-api").versionAsInProject(), // - mavenBundle(YANGTOOLS, "yang-data-impl").versionAsInProject(), // - mavenBundle(YANGTOOLS, "yang-model-api").versionAsInProject(), // - mavenBundle(YANGTOOLS, "yang-model-util").versionAsInProject(), // - mavenBundle(YANGTOOLS, "yang-parser-api").versionAsInProject(), - mavenBundle(YANGTOOLS, "yang-parser-impl").versionAsInProject(), - - - mavenBundle(YANGTOOLS, "binding-generator-spi").versionAsInProject(), // - mavenBundle(YANGTOOLS, "binding-model-api").versionAsInProject(), // - mavenBundle(YANGTOOLS, "binding-generator-util").versionAsInProject(), + mavenBundle(CONTROLLER, "sal-binding-api").versionAsInProject(), // // + mavenBundle(CONTROLLER, "sal-binding-config").versionAsInProject(), // + mavenBundle(CONTROLLER, "sal-binding-broker-impl").versionAsInProject(), // // + mavenBundle("org.javassist", "javassist").versionAsInProject(), // // + mavenBundle(CONTROLLER, "sal-common-util").versionAsInProject(), // // + + mavenBundle(YANGTOOLS, "yang-data-api").versionAsInProject(), // // + mavenBundle(YANGTOOLS, "yang-data-impl").versionAsInProject(), // // + mavenBundle(YANGTOOLS, "yang-model-api").versionAsInProject(), // // + mavenBundle(YANGTOOLS, "yang-model-util").versionAsInProject(), // // + mavenBundle(YANGTOOLS, "yang-parser-api").versionAsInProject(), // mavenBundle(YANGTOOLS, "yang-parser-impl").versionAsInProject(), - mavenBundle(YANGTOOLS, "binding-type-provider").versionAsInProject(), - mavenBundle(YANGTOOLS, "binding-generator-api").versionAsInProject(), - mavenBundle(YANGTOOLS, "binding-generator-spi").versionAsInProject(), + + mavenBundle(YANGTOOLS, "binding-generator-spi").versionAsInProject(), // // + mavenBundle(YANGTOOLS, "binding-model-api").versionAsInProject(), // // + mavenBundle(YANGTOOLS, "binding-generator-util").versionAsInProject(), // + mavenBundle(YANGTOOLS, "yang-parser-impl").versionAsInProject(), // + mavenBundle(YANGTOOLS, "binding-type-provider").versionAsInProject(), // + mavenBundle(YANGTOOLS, "binding-generator-api").versionAsInProject(), mavenBundle(YANGTOOLS, + "binding-generator-spi").versionAsInProject(), // mavenBundle(YANGTOOLS, "binding-generator-impl").versionAsInProject(), - - + mavenBundle(CONTROLLER, "sal-core-api").versionAsInProject().update(), // - mavenBundle(CONTROLLER, "sal-broker-impl").versionAsInProject(), // + mavenBundle(CONTROLLER, "sal-broker-impl").versionAsInProject(), // // mavenBundle(CONTROLLER, "sal-core-spi").versionAsInProject().update(), // - - mavenBundle(YANGTOOLS + ".thirdparty", "antlr4-runtime-osgi-nohead").versionAsInProject() // - ); + + mavenBundle(YANGTOOLS + ".thirdparty", "antlr4-runtime-osgi-nohead").versionAsInProject(), // // + + systemProperty("netconf.tcp.address").value("0.0.0.0"), // + systemProperty("netconf.tcp.port").value("18383"), // + systemProperty("netconf.config.persister.storageAdapterClass").value( + "org.opendaylight.controller.config.persist.storage.file.FileStorageAdapter"), // + systemProperty("fileStorage").value(PathUtils.getBaseDir() + "/src/test/resources/controller.config"), // + systemProperty("numberOfBackups").value("1") // + //systemProperty("yangstore.blacklist").value(".*controller.model.*") // + + ); } @@ -83,8 +131,8 @@ public class TestHelper { public static Option flowCapableModelBundles() { return new DefaultCompositeOption( // - mavenBundle(CONTROLLER_MODELS, "model-flow-base").versionAsInProject(), // - mavenBundle(CONTROLLER_MODELS, "model-flow-service").versionAsInProject(), // + mavenBundle(CONTROLLER_MODELS, "model-flow-base").versionAsInProject(), // // + mavenBundle(CONTROLLER_MODELS, "model-flow-service").versionAsInProject(), // // mavenBundle(CONTROLLER_MODELS, "model-inventory").versionAsInProject() // ); @@ -92,22 +140,18 @@ public class TestHelper { public static Option baseModelBundles() { return new DefaultCompositeOption( // - mavenBundle(YANGTOOLS_MODELS, "yang-ext").versionAsInProject(), // - mavenBundle(YANGTOOLS_MODELS, "ietf-inet-types").versionAsInProject(), // - mavenBundle(YANGTOOLS_MODELS, "ietf-yang-types").versionAsInProject(), // - mavenBundle(YANGTOOLS_MODELS, "opendaylight-l2-types").versionAsInProject(), // + mavenBundle(YANGTOOLS_MODELS, "yang-ext").versionAsInProject(), // // + mavenBundle(YANGTOOLS_MODELS, "ietf-inet-types").versionAsInProject(), // // + mavenBundle(YANGTOOLS_MODELS, "ietf-yang-types").versionAsInProject(), // // + mavenBundle(YANGTOOLS_MODELS, "opendaylight-l2-types").versionAsInProject(), // // mavenBundle(CONTROLLER_MODELS, "model-inventory").versionAsInProject()); } public static Option junitAndMockitoBundles() { return new DefaultCompositeOption( - // Repository required to load harmcrest (OSGi-fied version). - repository("http://repository.springsource.com/maven/bundles/external").id( - "com.springsource.repository.bundles.external"), - - // Mockito - mavenBundle("org.mockito", "mockito-all", "1.9.5"), - junitBundles(), + // Repository required to load harmcrest (OSGi-fied version). + // Mockito + mavenBundle("org.mockito", "mockito-all", "1.9.5"), junitBundles(), /* * Felix has implicit boot delegation enabled by default. It diff --git a/opendaylight/md-sal/sal-binding-it/src/test/java/org/opendaylight/controller/test/sal/binding/it/AbstractTest.java b/opendaylight/md-sal/sal-binding-it/src/test/java/org/opendaylight/controller/test/sal/binding/it/AbstractTest.java index 41b1e310a0..338561ab48 100644 --- a/opendaylight/md-sal/sal-binding-it/src/test/java/org/opendaylight/controller/test/sal/binding/it/AbstractTest.java +++ b/opendaylight/md-sal/sal-binding-it/src/test/java/org/opendaylight/controller/test/sal/binding/it/AbstractTest.java @@ -11,6 +11,7 @@ import org.ops4j.pax.exam.Configuration; import org.ops4j.pax.exam.Option; import org.ops4j.pax.exam.junit.PaxExam; import org.ops4j.pax.exam.options.DefaultCompositeOption; +import org.ops4j.pax.exam.util.Filter; import org.ops4j.pax.exam.util.PathUtils; import org.osgi.framework.BundleContext; @@ -24,8 +25,9 @@ public abstract class AbstractTest { public static final String YANGTOOLS_MODELS = "org.opendaylight.yangtools.model"; @Inject + @Filter(timeout=60*1000) BindingAwareBroker broker; - + @Inject BundleContext bundleContext; @@ -55,13 +57,14 @@ public abstract class AbstractTest { mavenBundle("org.slf4j", "log4j-over-slf4j").versionAsInProject(), // mavenBundle("ch.qos.logback", "logback-core").versionAsInProject(), // mavenBundle("ch.qos.logback", "logback-classic").versionAsInProject(), // + systemProperty("osgi.bundles.defaultStartLevel").value("4"), - configMinumumBundles(), + mdSalCoreBundles(), bindingAwareSalBundles(), - + configMinumumBundles(), // BASE Models baseModelBundles(), flowCapableModelBundles(), junitAndMockitoBundles()); } diff --git a/opendaylight/md-sal/sal-binding-it/src/test/resources/controller.config b/opendaylight/md-sal/sal-binding-it/src/test/resources/controller.config new file mode 100644 index 0000000000..28c3becc98 --- /dev/null +++ b/opendaylight/md-sal/sal-binding-it/src/test/resources/controller.config @@ -0,0 +1,123 @@ +//START OF CONFIG-LAST + + + + prefix:schema-service-singleton + yang-schema-service + + + prefix:hash-map-data-store + hash-map-data-store + + + prefix:dom-broker-impl + dom-broker + + dom:dom-data-store + ref_hash-map-data-store + + + + prefix:binding-broker-impl + binding-broker-impl + + binding:binding-notification-service + ref_binding-notification-broker + + + binding:binding-data-broker + ref_binding-data-broker + + + + prefix:runtime-generated-mapping + runtime-mapping-singleton + + + prefix:binding-notification-broker + binding-notification-broker + + + prefix:binding-data-broker + binding-data-broker + + dom:dom-broker-osgi-registry + ref_dom-broker + + + binding:binding-dom-mapping-service + ref_runtime-mapping-singleton + + + + + + dom:schema-service + + ref_yang-schema-service + /config/modules/module[name='schema-service-singleton']/instance[name='yang-schema-service'] + + + + binding:binding-notification-service + + ref_binding-notification-broker + /config/modules/module[name='binding-notification-broker']/instance[name='binding-notification-broker'] + + + + dom:dom-data-store + + ref_hash-map-data-store + /config/modules/module[name='hash-map-data-store']/instance[name='hash-map-data-store'] + + + + binding:binding-broker-osgi-registry + + ref_binding-broker-impl + /config/modules/module[name='binding-broker-impl']/instance[name='binding-broker-impl'] + + + + binding-impl:binding-dom-mapping-service + + ref_runtime-mapping-singleton + /config/modules/module[name='runtime-generated-mapping']/instance[name='runtime-mapping-singleton'] + + + + dom:dom-broker-osgi-registry + + ref_dom-broker + /config/modules/module[name='dom-broker-impl']/instance[name='dom-broker'] + + + + binding:binding-data-broker + + ref_binding-data-broker + /config/modules/module[name='binding-data-broker']/instance[name='binding-data-broker'] + + + + + + +//END OF SNAPSHOT +urn:opendaylight:l2:types?module=opendaylight-l2-types&revision=2013-08-27 +urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding?module=opendaylight-md-sal-binding&revision=2013-10-28 +urn:opendaylight:params:xml:ns:yang:controller:md:sal:dom?module=opendaylight-md-sal-dom&revision=2013-10-28 +urn:opendaylight:params:xml:ns:yang:controller:config?module=config&revision=2013-04-05 +urn:ietf:params:netconf:capability:candidate:1.0 +urn:ietf:params:xml:ns:yang:ietf-netconf-monitoring?module=ietf-netconf-monitoring&revision=2010-10-04 +urn:ietf:params:xml:ns:yang:rpc-context?module=rpc-context&revision=2013-06-17 +urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding:impl?module=opendaylight-sal-binding-broker-impl&revision=2013-10-28 +urn:ietf:params:xml:ns:yang:ietf-inet-types?module=ietf-inet-types&revision=2010-09-24 +urn:ietf:params:netconf:capability:rollback-on-error:1.0 +urn:ietf:params:xml:ns:yang:ietf-yang-types?module=ietf-yang-types&revision=2010-09-24 +urn:opendaylight:params:xml:ns:yang:controller:md:sal:dom:impl?module=opendaylight-sal-dom-broker-impl&revision=2013-10-28 +urn:opendaylight:params:xml:ns:yang:controller:logback:config?module=config-logging&revision=2013-07-16 +urn:opendaylight:yang:extension:yang-ext?module=yang-ext&revision=2013-07-09 +urn:opendaylight:params:xml:ns:yang:controller:md:sal:common?module=opendaylight-md-sal-common&revision=2013-10-28 +//END OF CONFIG diff --git a/opendaylight/md-sal/sal-binding-it/src/test/resources/logback.xml b/opendaylight/md-sal/sal-binding-it/src/test/resources/logback.xml index 2d63ce5744..1d17796373 100644 --- a/opendaylight/md-sal/sal-binding-it/src/test/resources/logback.xml +++ b/opendaylight/md-sal/sal-binding-it/src/test/resources/logback.xml @@ -7,7 +7,10 @@ - + + + + diff --git a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/RegistrationListener.java b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/RegistrationListener.java new file mode 100644 index 0000000000..f6efd57f06 --- /dev/null +++ b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/RegistrationListener.java @@ -0,0 +1,12 @@ +package org.opendaylight.controller.md.sal.common.api; + +import java.util.EventListener; + +import org.opendaylight.yangtools.concepts.Registration; + +public interface RegistrationListener> extends EventListener { + + void onRegister(T registration); + + void onUnregister(T registration); +} diff --git a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataCommitHandlerRegistration.java b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataCommitHandlerRegistration.java new file mode 100644 index 0000000000..85db5a0878 --- /dev/null +++ b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataCommitHandlerRegistration.java @@ -0,0 +1,9 @@ +package org.opendaylight.controller.md.sal.common.api.data; + +import org.opendaylight.yangtools.concepts.Path; +import org.opendaylight.yangtools.concepts.Registration; + +public interface DataCommitHandlerRegistration

,D> extends Registration>{ + + P getPath(); +} diff --git a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataProvisionService.java b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataProvisionService.java index 264d076b69..7d78fd283d 100644 --- a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataProvisionService.java +++ b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataProvisionService.java @@ -7,13 +7,17 @@ */ package org.opendaylight.controller.md.sal.common.api.data; -// FIXME: After 0.6 Release of YANGTools refactor to use Path marker interface for arguments. -// import org.opendaylight.yangtools.concepts.Path; +import org.opendaylight.controller.md.sal.common.api.RegistrationListener; +import org.opendaylight.yangtools.concepts.ListenerRegistration; +import org.opendaylight.yangtools.concepts.Path; import org.opendaylight.yangtools.concepts.Registration; -public interface DataProvisionService

*/, D> { +public interface DataProvisionService

, D> { public Registration> registerCommitHandler(P path, DataCommitHandler commitHandler); + + public ListenerRegistration>> + registerCommitHandlerListener(RegistrationListener> commitHandlerListener); } diff --git a/opendaylight/md-sal/sal-common-impl/src/main/java/org/opendaylight/controller/md/sal/common/impl/AbstractDataModification.java b/opendaylight/md-sal/sal-common-impl/src/main/java/org/opendaylight/controller/md/sal/common/impl/AbstractDataModification.java index c9e1d6e330..bee863321f 100644 --- a/opendaylight/md-sal/sal-common-impl/src/main/java/org/opendaylight/controller/md/sal/common/impl/AbstractDataModification.java +++ b/opendaylight/md-sal/sal-common-impl/src/main/java/org/opendaylight/controller/md/sal/common/impl/AbstractDataModification.java @@ -179,7 +179,7 @@ public abstract class AbstractDataModification

*/, D> imple if (operationalOriginal.containsKey(path)) { return true; } - D data = reader.readConfigurationData(path); + D data = reader.readOperationalData(path); if (data != null) { operationalOriginal.putIfAbsent(path, data); return true; diff --git a/opendaylight/md-sal/sal-common-impl/src/main/java/org/opendaylight/controller/md/sal/common/impl/service/AbstractDataBroker.xtend b/opendaylight/md-sal/sal-common-impl/src/main/java/org/opendaylight/controller/md/sal/common/impl/service/AbstractDataBroker.xtend index 74c4e0a148..e3d2b567a7 100644 --- a/opendaylight/md-sal/sal-common-impl/src/main/java/org/opendaylight/controller/md/sal/common/impl/service/AbstractDataBroker.xtend +++ b/opendaylight/md-sal/sal-common-impl/src/main/java/org/opendaylight/controller/md/sal/common/impl/service/AbstractDataBroker.xtend @@ -34,12 +34,18 @@ import java.util.Collection import com.google.common.collect.FluentIterable; import java.util.Set import com.google.common.collect.ImmutableList +import org.opendaylight.controller.md.sal.common.api.data.DataCommitHandlerRegistration +import org.opendaylight.controller.md.sal.common.api.RegistrationListener +import org.opendaylight.yangtools.concepts.util.ListenerRegistry +import java.util.concurrent.atomic.AtomicLong abstract class AbstractDataBroker

, D, DCL extends DataChangeListener> implements DataModificationTransactionFactory, // DataReader, // DataChangePublisher, // DataProvisionService { + private static val LOG = LoggerFactory.getLogger(AbstractDataBroker); + @Property var ExecutorService executor; @@ -47,17 +53,17 @@ DataProvisionService { var AbstractDataReadRouter dataReadRouter; Multimap> listeners = HashMultimap.create(); - Multimap> commitHandlers = HashMultimap.create(); - + Multimap> commitHandlers = HashMultimap.create(); + + val ListenerRegistry>> commitHandlerRegistrationListeners = new ListenerRegistry(); public new() { } protected def /*Iterator>,D>>*/ affectedCommitHandlers( HashSet

paths) { - return FluentIterable.from(commitHandlers.asMap.entrySet) - .filter[key.isAffectedBy(paths)] // - .transformAndConcat [value] // - .transform[instance].toList() + return FluentIterable.from(commitHandlers.asMap.entrySet).filter[key.isAffectedBy(paths)] // + .transformAndConcat[value] // + .transform[instance].toList() } override final readConfigurationData(P path) { @@ -69,8 +75,16 @@ DataProvisionService { } override final registerCommitHandler(P path, DataCommitHandler commitHandler) { - val registration = new DataCommitHandlerRegistration(path, commitHandler, this); + val registration = new DataCommitHandlerRegistrationImpl(path, commitHandler, this); commitHandlers.put(path, registration) + LOG.info("Registering Commit Handler {} for path: {}",commitHandler,path); + for(listener : commitHandlerRegistrationListeners) { + try { + listener.instance.onRegister(registration); + } catch (Exception e) { + LOG.error("Unexpected exception in listener {} during invoking onRegister",listener.instance,e); + } + } return registration; } @@ -87,13 +101,29 @@ DataProvisionService { return new CompositeObjectRegistration(reader, Arrays.asList(confReg, dataReg)); } + + override registerCommitHandlerListener(RegistrationListener> commitHandlerListener) { + val ret = commitHandlerRegistrationListeners.register(commitHandlerListener); + + return ret; + } + protected final def removeListener(DataChangeListenerRegistration registration) { listeners.remove(registration.path, registration); } - protected final def removeCommitHandler(DataCommitHandlerRegistration registration) { + protected final def removeCommitHandler(DataCommitHandlerRegistrationImpl registration) { commitHandlers.remove(registration.path, registration); + + LOG.info("Removing Commit Handler {} for path: {}",registration.instance,registration.path); + for(listener : commitHandlerRegistrationListeners) { + try { + listener.instance.onUnregister(registration); + } catch (Exception e) { + LOG.error("Unexpected exception in listener {} during invoking onUnregister",listener.instance,e); + } + } } protected final def getActiveCommitHandlers() { @@ -132,7 +162,7 @@ DataProvisionService { } @Data -package class ListenerStateCapture

, D,DCL extends DataChangeListener> { +package class ListenerStateCapture

, D, DCL extends DataChangeListener> { @Property P path; @@ -167,7 +197,9 @@ package class DataChangeListenerRegistration

, D, DCL extends D } -package class DataCommitHandlerRegistration

, D> extends AbstractObjectRegistration> { +package class DataCommitHandlerRegistrationImpl

, D> // +extends AbstractObjectRegistration> // +implements DataCommitHandlerRegistration { AbstractDataBroker dataBroker; @@ -184,10 +216,9 @@ package class DataCommitHandlerRegistration

, D> extends Abstra dataBroker.removeCommitHandler(this); dataBroker = null; } - } -package class TwoPhaseCommit

, D,DCL extends DataChangeListener> implements Callable> { +package class TwoPhaseCommit

, D, DCL extends DataChangeListener> implements Callable> { private static val log = LoggerFactory.getLogger(TwoPhaseCommit); @@ -214,15 +245,18 @@ package class TwoPhaseCommit

, D,DCL extends DataChangeListener val listeners = dataBroker.affectedListenersWithInitialState(affectedPaths); + val transactionId = transaction.identifier; + + log.info("Transaction: {} Started.",transactionId); // requesting commits - val Iterable> commitHandlers = dataBroker.affectedCommitHandlers(affectedPaths); + val Iterable> commitHandlers = dataBroker.affectedCommitHandlers(affectedPaths); val List> handlerTransactions = new ArrayList(); try { for (handler : commitHandlers) { handlerTransactions.add(handler.requestCommit(transaction)); } } catch (Exception e) { - log.error("Request Commit failded", e); + log.error("Transaction: {} Request Commit failed", transactionId,e); return rollback(handlerTransactions, e); } val List> results = new ArrayList(); @@ -232,25 +266,25 @@ package class TwoPhaseCommit

, D,DCL extends DataChangeListener } listeners.publishDataChangeEvent(); } catch (Exception e) { - log.error("Finish Commit failed", e); + log.error("Transaction: {} Finish Commit failed",transactionId, e); return rollback(handlerTransactions, e); } - - + log.info("Transaction: {} Finished succesfully.",transactionId); return Rpcs.getRpcResult(true, TransactionStatus.COMMITED, Collections.emptySet()); } - - def void publishDataChangeEvent(ImmutableList> listeners) { - for(listenerSet : listeners) { + + def void publishDataChangeEvent(ImmutableList> listeners) { + for (listenerSet : listeners) { val updatedConfiguration = dataBroker.readConfigurationData(listenerSet.path); val updatedOperational = dataBroker.readOperationalData(listenerSet.path); - - val changeEvent = new DataChangeEventImpl(transaction,listenerSet.initialConfigurationState,listenerSet.initialOperationalState,updatedOperational,updatedConfiguration); - for(listener : listenerSet.listeners) { + + val changeEvent = new DataChangeEventImpl(transaction, listenerSet.initialConfigurationState, + listenerSet.initialOperationalState, updatedOperational, updatedConfiguration); + for (listener : listenerSet.listeners) { try { listener.instance.onDataChanged(changeEvent); - + } catch (Exception e) { e.printStackTrace(); } @@ -267,6 +301,7 @@ package class TwoPhaseCommit

, D,DCL extends DataChangeListener return Rpcs.getRpcResult(false, TransactionStatus.FAILED, Collections.emptySet()); } } + public abstract class AbstractDataTransaction

, D> extends AbstractDataModification { @Property @@ -276,9 +311,9 @@ public abstract class AbstractDataTransaction

, D> extends Abst var AbstractDataBroker broker; - protected new(AbstractDataBroker dataBroker) { + protected new(Object identifier,AbstractDataBroker dataBroker) { super(dataBroker); - _identifier = new Object(); + _identifier = identifier; broker = dataBroker; status = TransactionStatus.NEW; diff --git a/opendaylight/md-sal/sal-dom-api/pom.xml b/opendaylight/md-sal/sal-dom-api/pom.xml index ca923f6baa..e52a7c302d 100644 --- a/opendaylight/md-sal/sal-dom-api/pom.xml +++ b/opendaylight/md-sal/sal-dom-api/pom.xml @@ -8,11 +8,73 @@ sal-core-api - scm:git:ssh://git.opendaylight.org:29418/controller.git - scm:git:ssh://git.opendaylight.org:29418/controller.git - https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL + scm:git:ssh://git.opendaylight.org:29418/controller.git + scm:git:ssh://git.opendaylight.org:29418/controller.git + https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL - + + + + org.apache.felix + maven-bundle-plugin + true + + + org.opendaylight.yangtools + yang-maven-plugin + 0.5.9-SNAPSHOT + + + + generate-sources + + + + + + org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator + + ${project.build.directory}/generated-sources/config + + + urn:opendaylight:params:xml:ns:yang:controller==org.opendaylight.controller.config.yang + + + + + true + + + + + + org.opendaylight.controller + yang-jmx-generator-plugin + 0.2.3-SNAPSHOT + + + + + org.codehaus.mojo + build-helper-maven-plugin + 1.8 + + + add-source + generate-sources + + add-source + + + + ${project.build.directory}/generated-sources/config + + + + + + + org.opendaylight.controller @@ -20,10 +82,14 @@ 1.0-SNAPSHOT + + org.opendaylight.controller + config-api + 0.2.3-SNAPSHOT + org.opendaylight.yangtools yang-data-api - 0.5.9-SNAPSHOT org.opendaylight.controller diff --git a/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/data/DataStore.java b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/data/DataStore.java new file mode 100644 index 0000000000..1062f5e535 --- /dev/null +++ b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/data/DataStore.java @@ -0,0 +1,12 @@ +package org.opendaylight.controller.sal.core.api.data; + +import org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler; +import org.opendaylight.controller.md.sal.common.api.data.DataReader; +import org.opendaylight.yangtools.yang.data.api.CompositeNode; +import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier; + +public interface DataStore extends // + DataReader, + DataCommitHandler { + +} diff --git a/opendaylight/md-sal/sal-dom-api/src/main/yang/opendaylight-md-sal-common.yang b/opendaylight/md-sal/sal-dom-api/src/main/yang/opendaylight-md-sal-common.yang new file mode 100644 index 0000000000..004574defa --- /dev/null +++ b/opendaylight/md-sal/sal-dom-api/src/main/yang/opendaylight-md-sal-common.yang @@ -0,0 +1,68 @@ +module opendaylight-md-sal-common { + yang-version 1; + namespace "urn:opendaylight:params:xml:ns:yang:controller:md:sal:common"; + prefix "md-sal-common"; + + description + "Common definition for MD-SAL."; + + revision "2013-10-28" { + description + "Initial revision"; + } + + grouping rpc-routing-table { + + leaf routing-context { + type string; + } + list routes { + leaf path { + type string; + } + leaf destination { + type string; + } + } + + } + + grouping rpc-router { + leaf module { + type string; + } + container routing-tables { + list routing-table { + uses rpc-routing-table; + } + } + } + + grouping rpc-state { + list rpc-router { + uses rpc-router; + } + } + + grouping notification-state { + container notifications { + leaf published { + type uint32; + } + } + } + + grouping data-state { + container transactions { + leaf created { + type uint32; + } + leaf successful { + type uint32; + } + leaf failed { + type uint32; + } + } + } +} \ No newline at end of file diff --git a/opendaylight/md-sal/sal-dom-api/src/main/yang/opendaylight-md-sal-dom.yang b/opendaylight/md-sal/sal-dom-api/src/main/yang/opendaylight-md-sal-dom.yang new file mode 100644 index 0000000000..b0417eb8a0 --- /dev/null +++ b/opendaylight/md-sal/sal-dom-api/src/main/yang/opendaylight-md-sal-dom.yang @@ -0,0 +1,35 @@ +module opendaylight-md-sal-dom { + yang-version 1; + namespace "urn:opendaylight:params:xml:ns:yang:controller:md:sal:dom"; + prefix "md-sal-dom"; + + import config { prefix config; revision-date 2013-04-05; } + + description + "Service definition for Binding Aware MD-SAL."; + + revision "2013-10-28" { + description + "Initial revision"; + } + + identity dom-broker-osgi-registry { + base "config:service-type"; + config:java-class "org.opendaylight.controller.sal.core.api.Broker"; + } + + identity dom-data-broker { + base "config:service-type"; + config:java-class "org.opendaylight.controller.sal.core.api.data.DataProviderService"; + } + + identity dom-data-store { + base "config:service-type"; + config:java-class "org.opendaylight.controller.sal.core.api.data.DataStore"; + } + + identity schema-service { + base "config:service-type"; + config:java-class "org.opendaylight.controller.sal.core.api.model.SchemaService"; + } +} \ No newline at end of file diff --git a/opendaylight/md-sal/sal-dom-broker/pom.xml b/opendaylight/md-sal/sal-dom-broker/pom.xml index 62dbe16e41..14ab057398 100644 --- a/opendaylight/md-sal/sal-dom-broker/pom.xml +++ b/opendaylight/md-sal/sal-dom-broker/pom.xml @@ -72,6 +72,43 @@ + + org.opendaylight.yangtools + yang-maven-plugin + 0.5.9-SNAPSHOT + + + + generate-sources + + + + + + org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator + + ${project.build.directory}/generated-sources/config + + + urn:opendaylight:params:xml:ns:yang:controller==org.opendaylight.controller.config.yang + + + + + true + + + + + + org.opendaylight.controller + yang-jmx-generator-plugin + 0.2.3-SNAPSHOT + + + + + org.apache.felix maven-bundle-plugin @@ -79,13 +116,32 @@ ${project.groupId}.${project.artifactId} - org.opendaylight.controller.sal.dom.broker.BrokerActivator - org.opendaylight.controller.sal.dom.broker.* + org.opendaylight.controller.sal.dom.broker.*, + org.opendaylight.controller.config.yang.md.sal.dom.impl + + org.codehaus.mojo + build-helper-maven-plugin + 1.8 + + + add-source + generate-sources + + add-source + + + + ${project.build.directory}/generated-sources/config + + + + + org.eclipse.xtend xtend-maven-plugin diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/DomBrokerImplModule.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/DomBrokerImplModule.java new file mode 100644 index 0000000000..9a4fc6ddc1 --- /dev/null +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/DomBrokerImplModule.java @@ -0,0 +1,55 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-dom-broker-impl yang module local name: dom-broker-impl +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 17:04:41 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.dom.impl; + +import org.opendaylight.controller.sal.core.api.data.DataStore; +import org.opendaylight.controller.sal.dom.broker.BrokerConfigActivator; +import org.opendaylight.controller.sal.dom.broker.BrokerImpl; +import org.osgi.framework.BundleContext; + +/** +* +*/ +public final class DomBrokerImplModule extends org.opendaylight.controller.config.yang.md.sal.dom.impl.AbstractDomBrokerImplModule +{ + + private BundleContext bundleContext; + + public DomBrokerImplModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { + super(identifier, dependencyResolver); + } + + public DomBrokerImplModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, DomBrokerImplModule oldModule, java.lang.AutoCloseable oldInstance) { + super(identifier, dependencyResolver, oldModule, oldInstance); + } + + @Override + public void validate(){ + super.validate(); + // Add custom validation for module attributes here. + } + + @Override + public java.lang.AutoCloseable createInstance() { + BrokerImpl broker = new BrokerImpl(); + BrokerConfigActivator activator = new BrokerConfigActivator(); + DataStore store = getDataStoreDependency(); + activator.start(broker, store,getBundleContext()); + return broker; + } + + private BundleContext getBundleContext() { + return this.bundleContext; + } + + public void setBundleContext(BundleContext bundleContext) { + this.bundleContext = bundleContext; + } +} diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/DomBrokerImplModuleFactory.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/DomBrokerImplModuleFactory.java new file mode 100644 index 0000000000..8e9e9f6ac7 --- /dev/null +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/DomBrokerImplModuleFactory.java @@ -0,0 +1,38 @@ +/** + * Generated file + + * Generated from: yang module name: opendaylight-sal-dom-broker-impl yang module local name: dom-broker-impl + * Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator + * Generated at: Wed Nov 20 17:04:41 CET 2013 + * + * Do not modify this file unless it is present under src/main directory + */ +package org.opendaylight.controller.config.yang.md.sal.dom.impl; + +import org.opendaylight.controller.config.api.DependencyResolver; +import org.opendaylight.controller.config.api.DynamicMBeanWithInstance; +import org.opendaylight.controller.config.spi.Module; +import org.osgi.framework.BundleContext; + +/** +* +*/ +public class DomBrokerImplModuleFactory extends + org.opendaylight.controller.config.yang.md.sal.dom.impl.AbstractDomBrokerImplModuleFactory { + + @Override + public Module createModule(String instanceName, DependencyResolver dependencyResolver, BundleContext bundleContext) { + DomBrokerImplModule module = (DomBrokerImplModule) super.createModule(instanceName, dependencyResolver, bundleContext); + module.setBundleContext(bundleContext); + return module; + } + + @Override + public Module createModule(String instanceName, DependencyResolver dependencyResolver, + DynamicMBeanWithInstance old, BundleContext bundleContext) throws Exception { + DomBrokerImplModule module = (DomBrokerImplModule) super.createModule(instanceName, dependencyResolver, old, bundleContext); + module.setBundleContext(bundleContext); + return module; + } + +} diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/HashMapDataStoreModule.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/HashMapDataStoreModule.java new file mode 100644 index 0000000000..4bcbb08963 --- /dev/null +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/HashMapDataStoreModule.java @@ -0,0 +1,39 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-dom-broker-impl yang module local name: hash-map-data-store +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 17:01:31 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.dom.impl; + +import org.opendaylight.controller.sal.dom.broker.impl.HashMapDataStore; + +/** +* +*/ +public final class HashMapDataStoreModule extends org.opendaylight.controller.config.yang.md.sal.dom.impl.AbstractHashMapDataStoreModule +{ + + public HashMapDataStoreModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { + super(identifier, dependencyResolver); + } + + public HashMapDataStoreModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, HashMapDataStoreModule oldModule, java.lang.AutoCloseable oldInstance) { + super(identifier, dependencyResolver, oldModule, oldInstance); + } + + @Override + public void validate(){ + super.validate(); + // Add custom validation for module attributes here. + } + + @Override + public java.lang.AutoCloseable createInstance() { + HashMapDataStore store = new HashMapDataStore(); + return store; + } +} diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/HashMapDataStoreModuleFactory.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/HashMapDataStoreModuleFactory.java new file mode 100644 index 0000000000..b9b6816a20 --- /dev/null +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/HashMapDataStoreModuleFactory.java @@ -0,0 +1,19 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-dom-broker-impl yang module local name: hash-map-data-store +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 17:01:31 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.dom.impl; + +/** +* +*/ +public class HashMapDataStoreModuleFactory extends org.opendaylight.controller.config.yang.md.sal.dom.impl.AbstractHashMapDataStoreModuleFactory +{ + + +} diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/SchemaServiceImplSingletonModule.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/SchemaServiceImplSingletonModule.java new file mode 100644 index 0000000000..6b597dea9e --- /dev/null +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/SchemaServiceImplSingletonModule.java @@ -0,0 +1,58 @@ +/** +* Generated file + +* Generated from: yang module name: opendaylight-sal-dom-broker-impl yang module local name: schema-service-singleton +* Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator +* Generated at: Wed Nov 20 17:01:31 CET 2013 +* +* Do not modify this file unless it is present under src/main directory +*/ +package org.opendaylight.controller.config.yang.md.sal.dom.impl; + +import org.opendaylight.controller.sal.dom.broker.SchemaServiceImpl; +import org.opendaylight.yangtools.yang.parser.impl.YangParserImpl; +import org.osgi.framework.BundleContext; + +/** +* +*/ +public final class SchemaServiceImplSingletonModule extends org.opendaylight.controller.config.yang.md.sal.dom.impl.AbstractSchemaServiceImplSingletonModule +{ + + BundleContext bundleContext; + + public SchemaServiceImplSingletonModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver) { + super(identifier, dependencyResolver); + } + + public SchemaServiceImplSingletonModule(org.opendaylight.controller.config.api.ModuleIdentifier identifier, org.opendaylight.controller.config.api.DependencyResolver dependencyResolver, SchemaServiceImplSingletonModule oldModule, java.lang.AutoCloseable oldInstance) { + super(identifier, dependencyResolver, oldModule, oldInstance); + } + + @Override + public boolean canReuseInstance(AbstractSchemaServiceImplSingletonModule oldModule) { + return true; + } + + public BundleContext getBundleContext() { + return bundleContext; + } + + public void setBundleContext(BundleContext bundleContext) { + this.bundleContext = bundleContext; + } + + @Override + public void validate(){ + super.validate(); + } + + @Override + public java.lang.AutoCloseable createInstance() { + SchemaServiceImpl newInstance = new SchemaServiceImpl(); + newInstance.setContext(getBundleContext()); + newInstance.setParser(new YangParserImpl()); + newInstance.start(); + return newInstance; + } +} diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/SchemaServiceImplSingletonModuleFactory.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/SchemaServiceImplSingletonModuleFactory.java new file mode 100644 index 0000000000..4b73656f72 --- /dev/null +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/config/yang/md/sal/dom/impl/SchemaServiceImplSingletonModuleFactory.java @@ -0,0 +1,46 @@ +/** + * Generated file + + * Generated from: yang module name: opendaylight-sal-dom-broker-impl yang module local name: schema-service-singleton + * Generated by: org.opendaylight.controller.config.yangjmxgenerator.plugin.JMXGenerator + * Generated at: Wed Nov 20 17:01:31 CET 2013 + * + * Do not modify this file unless it is present under src/main directory + */ +package org.opendaylight.controller.config.yang.md.sal.dom.impl; + +import java.util.Collections; +import java.util.Set; + +import org.opendaylight.controller.config.api.DependencyResolver; +import org.opendaylight.controller.config.api.DependencyResolverFactory; +import org.opendaylight.controller.config.api.ModuleIdentifier; +import org.opendaylight.controller.config.spi.Module; +import org.osgi.framework.BundleContext; + +/** +* +*/ +public class SchemaServiceImplSingletonModuleFactory extends + org.opendaylight.controller.config.yang.md.sal.dom.impl.AbstractSchemaServiceImplSingletonModuleFactory { + + private static final ModuleIdentifier IDENTIFIER = new ModuleIdentifier(NAME, "yang-schema-service"); + public static SchemaServiceImplSingletonModule SINGLETON; + + @Override + public Module createModule(String instanceName, DependencyResolver dependencyResolver, BundleContext bundleContext) { + throw new UnsupportedOperationException("Only default instance supported."); + } + + @Override + public Set getDefaultModules(DependencyResolverFactory dependencyResolverFactory, + BundleContext bundleContext) { + DependencyResolver dependencyResolver = dependencyResolverFactory.createDependencyResolver(IDENTIFIER); + + if (SINGLETON == null) { + SINGLETON = new SchemaServiceImplSingletonModule(IDENTIFIER, dependencyResolver); + SINGLETON.setBundleContext(bundleContext); + } + return Collections.singleton(SINGLETON); + } +} diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerActivator.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerActivator.java deleted file mode 100644 index 3af645a2b8..0000000000 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerActivator.java +++ /dev/null @@ -1,73 +0,0 @@ -package org.opendaylight.controller.sal.dom.broker; - -import java.util.Hashtable; - -import org.opendaylight.controller.sal.core.api.Broker; -import org.opendaylight.controller.sal.core.api.data.DataBrokerService; -import org.opendaylight.controller.sal.core.api.data.DataProviderService; -import org.opendaylight.controller.sal.core.api.model.SchemaService; -import org.opendaylight.controller.sal.core.api.mount.MountProvisionService; -import org.opendaylight.controller.sal.core.api.mount.MountService; -import org.opendaylight.controller.sal.dom.broker.impl.HashMapDataStore; -import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier; -import org.opendaylight.yangtools.yang.parser.impl.YangParserImpl; -import org.osgi.framework.BundleActivator; -import org.osgi.framework.BundleContext; -import org.osgi.framework.ServiceRegistration; - -public class BrokerActivator implements BundleActivator { - - private static final InstanceIdentifier ROOT = InstanceIdentifier.builder().toInstance(); - BrokerImpl broker; - private ServiceRegistration brokerReg; - private ServiceRegistration schemaReg; - private ServiceRegistration dataReg; - private ServiceRegistration dataProviderReg; - private SchemaServiceImpl schemaService; - private DataBrokerImpl dataService; - private MountPointManagerImpl mountService; - private ServiceRegistration mountReg; - private ServiceRegistration mountProviderReg; - private HashMapDataStore hashMapStore; - - @Override - public void start(BundleContext context) throws Exception { - Hashtable emptyProperties = new Hashtable(); - broker = new BrokerImpl(); - broker.setBundleContext(context); - - - schemaService = new SchemaServiceImpl(); - schemaService.setContext(context); - schemaService.setParser(new YangParserImpl()); - schemaService.start(); - schemaReg = context.registerService(SchemaService.class, schemaService, new Hashtable()); - - dataService = new DataBrokerImpl(); - dataService.setExecutor(broker.getExecutor()); - - dataReg = context.registerService(DataBrokerService.class, dataService, emptyProperties); - dataProviderReg = context.registerService(DataProviderService.class, dataService, emptyProperties); - - hashMapStore = new HashMapDataStore(); - - dataService.registerConfigurationReader(ROOT, hashMapStore); - dataService.registerCommitHandler(ROOT, hashMapStore); - dataService.registerOperationalReader(ROOT, hashMapStore); - - mountService = new MountPointManagerImpl(); - mountService.setDataBroker(dataService); - - mountReg = context.registerService(MountService.class, mountService, emptyProperties); - mountProviderReg = context.registerService(MountProvisionService.class, mountService, emptyProperties); - - brokerReg = context.registerService(Broker.class, broker, emptyProperties); - } - - @Override - public void stop(BundleContext context) throws Exception { - if (brokerReg != null) { - brokerReg.unregister(); - } - } -} diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerConfigActivator.xtend b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerConfigActivator.xtend new file mode 100644 index 0000000000..a6aa0ce32e --- /dev/null +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerConfigActivator.xtend @@ -0,0 +1,67 @@ +package org.opendaylight.controller.sal.dom.broker + +import org.osgi.framework.ServiceRegistration +import org.opendaylight.controller.sal.core.api.model.SchemaService +import org.opendaylight.controller.sal.core.api.data.DataBrokerService +import org.opendaylight.controller.sal.core.api.data.DataProviderService +import org.opendaylight.controller.sal.dom.broker.impl.HashMapDataStore +import org.opendaylight.controller.sal.core.api.mount.MountProvisionService +import org.opendaylight.controller.sal.core.api.mount.MountService +import org.osgi.framework.BundleContext +import java.util.Hashtable +import org.opendaylight.yangtools.yang.parser.impl.YangParserImpl +import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier +import org.opendaylight.controller.sal.core.api.data.DataStore + +class BrokerConfigActivator implements AutoCloseable { + + + private static val ROOT = InstanceIdentifier.builder().toInstance(); + + private var ServiceRegistration schemaReg; + private var ServiceRegistration dataReg; + private var ServiceRegistration dataProviderReg; + private var ServiceRegistration mountReg; + private var ServiceRegistration mountProviderReg; + + private var SchemaServiceImpl schemaService; + private var DataBrokerImpl dataService; + private var MountPointManagerImpl mountService; + + public def void start(BrokerImpl broker,DataStore store,BundleContext context) { + val emptyProperties = new Hashtable(); + broker.setBundleContext(context); + + + schemaService = new SchemaServiceImpl(); + schemaService.setContext(context); + schemaService.setParser(new YangParserImpl()); + schemaService.start(); + schemaReg = context.registerService(SchemaService, schemaService, emptyProperties); + + dataService = new DataBrokerImpl(); + dataService.setExecutor(broker.getExecutor()); + + dataReg = context.registerService(DataBrokerService, dataService, emptyProperties); + dataProviderReg = context.registerService(DataProviderService, dataService, emptyProperties); + + dataService.registerConfigurationReader(ROOT, store); + dataService.registerCommitHandler(ROOT, store); + dataService.registerOperationalReader(ROOT, store); + + mountService = new MountPointManagerImpl(); + mountService.setDataBroker(dataService); + + mountReg = context.registerService(MountService, mountService, emptyProperties); + mountProviderReg = context.registerService(MountProvisionService, mountService, emptyProperties); + } + + override def close() { + schemaReg?.unregister(); + dataReg?.unregister(); + dataProviderReg?.unregister(); + mountReg?.unregister(); + mountProviderReg?.unregister(); + } + +} \ No newline at end of file diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.xtend b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.xtend index 26fecef688..7ef594bad9 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.xtend +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/BrokerImpl.xtend @@ -30,7 +30,7 @@ import org.opendaylight.controller.sal.dom.broker.spi.RpcRouter import org.opendaylight.yangtools.concepts.ListenerRegistration import org.opendaylight.controller.sal.core.api.RpcRegistrationListener -public class BrokerImpl implements Broker { +public class BrokerImpl implements Broker, AutoCloseable { private static val log = LoggerFactory.getLogger(BrokerImpl); // Broker Generic Context @@ -43,6 +43,9 @@ public class BrokerImpl implements Broker { private var ExecutorService executor = Executors.newFixedThreadPool(5); @Property private var BundleContext bundleContext; + + @Property + private var AutoCloseable deactivator; @Property private var RpcRouter router; @@ -107,4 +110,9 @@ public class BrokerImpl implements Broker { sessions.remove(consumerContextImpl); providerSessions.remove(consumerContextImpl); } + + override close() throws Exception { + deactivator?.close(); + } + } diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/DataBrokerImpl.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/DataBrokerImpl.java index d95fdcc53d..1197ef34bd 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/DataBrokerImpl.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/DataBrokerImpl.java @@ -1,5 +1,7 @@ package org.opendaylight.controller.sal.dom.broker; +import java.util.concurrent.atomic.AtomicLong; + import org.opendaylight.controller.md.sal.common.api.data.DataReader; import org.opendaylight.controller.md.sal.common.impl.service.AbstractDataBroker; import org.opendaylight.controller.sal.common.DataStoreIdentifier; @@ -18,9 +20,12 @@ public class DataBrokerImpl extends AbstractDataBroker>> registerCommitHandlerListener( + RegistrationListener> commitHandlerListener) { + // TODO Auto-generated method stub + return null; + } } diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/SchemaServiceImpl.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/SchemaServiceImpl.java index ba558c51fd..531f9e86c2 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/SchemaServiceImpl.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/SchemaServiceImpl.java @@ -13,6 +13,8 @@ import java.util.zip.Checksum; import org.opendaylight.yangtools.yang.model.api.SchemaContext; import org.osgi.util.tracker.BundleTracker; import org.osgi.util.tracker.BundleTrackerCustomizer; +import org.osgi.util.tracker.ServiceTracker; +import org.osgi.util.tracker.ServiceTrackerCustomizer; import org.opendaylight.yangtools.yang.model.api.Module; import org.opendaylight.yangtools.yang.model.parser.api.YangModelParser; import org.opendaylight.yangtools.yang.parser.impl.YangParserImpl; @@ -20,6 +22,7 @@ import org.osgi.framework.Bundle; import org.osgi.framework.BundleActivator; import org.osgi.framework.BundleContext; import org.osgi.framework.BundleEvent; +import org.osgi.framework.ServiceReference; import org.opendaylight.yangtools.concepts.ListenerRegistration; import org.opendaylight.yangtools.concepts.util.ListenerRegistry; import org.opendaylight.controller.sal.core.api.model.SchemaService; @@ -34,9 +37,13 @@ import com.google.common.collect.Collections2; import com.google.common.collect.HashMultimap; import com.google.common.collect.Multimap; import com.google.common.collect.Sets; + import static com.google.common.base.Preconditions.*; -public class SchemaServiceImpl implements SchemaService, AutoCloseable { +public class SchemaServiceImpl implements // +SchemaService, // +ServiceTrackerCustomizer, // +AutoCloseable { private static final Logger logger = LoggerFactory.getLogger(SchemaServiceImpl.class); private ListenerRegistry listeners; @@ -54,6 +61,8 @@ public class SchemaServiceImpl implements SchemaService, AutoCloseable { private BundleTracker bundleTracker; private final YangStoreCache cache = new YangStoreCache(); + private ServiceTracker listenerTracker; + public ListenerRegistry getListeners() { return listeners; } @@ -84,9 +93,11 @@ public class SchemaServiceImpl implements SchemaService, AutoCloseable { if (listeners == null) { listeners = new ListenerRegistry<>(); } - + + listenerTracker = new ServiceTracker<>(context, SchemaServiceListener.class, this); bundleTracker = new BundleTracker(context, BundleEvent.RESOLVED | BundleEvent.UNRESOLVED, scanner); bundleTracker.open(); + listenerTracker.open(); } public SchemaContext getGlobalContext() { @@ -185,6 +196,18 @@ public class SchemaServiceImpl implements SchemaService, AutoCloseable { private void updateCache(SchemaContext snapshot) { cache.cacheYangStore(consistentBundlesToYangURLs, snapshot); + + Object[] services = listenerTracker.getServices(); + if(services != null) { + for(Object rawListener : services) { + SchemaServiceListener listener = (SchemaServiceListener) rawListener; + try { + listener.onGlobalContextUpdated(snapshot); + } catch (Exception e) { + logger.error("Exception occured during invoking listener",e); + } + } + } for (ListenerRegistration listener : listeners) { try { listener.getInstance().onGlobalContextUpdated(snapshot); @@ -220,6 +243,7 @@ public class SchemaServiceImpl implements SchemaService, AutoCloseable { proposedNewState.putAll(inconsistentBundlesToYangURLs); proposedNewState.putAll(bundle, addedURLs); boolean adding = true; + if (tryToUpdateState(addedURLs, proposedNewState, adding) == false) { inconsistentBundlesToYangURLs.putAll(bundle, addedURLs); } @@ -276,6 +300,26 @@ public class SchemaServiceImpl implements SchemaService, AutoCloseable { this.cachedUrls = setFromMultimapValues(urls); this.cachedContextSnapshot = ctx; } - + } + + @Override + public SchemaServiceListener addingService(ServiceReference reference) { + + SchemaServiceListener listener = context.getService(reference); + SchemaContext _ctxContext = getGlobalContext(); + if(getContext() != null) { + listener.onGlobalContextUpdated(_ctxContext); + } + return listener; + } + + @Override + public void modifiedService(ServiceReference reference, SchemaServiceListener service) { + // NOOP + } + + @Override + public void removedService(ServiceReference reference, SchemaServiceListener service) { + context.ungetService(reference); } } diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/HashMapDataStore.xtend b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/HashMapDataStore.xtend index 7d57819cbf..e7445e6965 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/HashMapDataStore.xtend +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/HashMapDataStore.xtend @@ -1,7 +1,5 @@ package org.opendaylight.controller.sal.dom.broker.impl -import org.opendaylight.controller.md.sal.common.api.data.DataReader -import org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler import org.opendaylight.controller.md.sal.common.api.data.DataModification import org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler.DataCommitTransaction import org.opendaylight.yangtools.yang.common.RpcResult @@ -12,10 +10,10 @@ import java.util.Collections import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier import org.opendaylight.yangtools.yang.data.api.CompositeNode import static extension org.opendaylight.controller.sal.dom.broker.impl.DataUtils.*; +import org.opendaylight.controller.sal.core.api.data.DataStore +import java.util.HashSet -class HashMapDataStore // -implements // -DataReader, DataCommitHandler { +class HashMapDataStore implements DataStore, AutoCloseable { val Map configuration = new ConcurrentHashMap(); val Map operational = new ConcurrentHashMap(); @@ -45,14 +43,32 @@ DataReader, DataCommitHandler map, InstanceIdentifier identifier) { + val affected = new HashSet(); + for(path : map.keySet) { + if(identifier.contains(path)) { + affected.add(path); + } + } + for(pathToRemove : affected) { + map.remove(pathToRemove); + } + + } + + override close() { + // NOOP + } + } class HashMapDataStoreTransaction implements // diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/osgi/DataProviderServiceProxy.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/osgi/DataProviderServiceProxy.java index 2fded87981..329219ebb0 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/osgi/DataProviderServiceProxy.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/osgi/DataProviderServiceProxy.java @@ -1,6 +1,8 @@ package org.opendaylight.controller.sal.dom.broker.osgi; +import org.opendaylight.controller.md.sal.common.api.RegistrationListener; import org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler; +import org.opendaylight.controller.md.sal.common.api.data.DataCommitHandlerRegistration; import org.opendaylight.controller.md.sal.common.api.data.DataReader; import org.opendaylight.controller.sal.common.DataStoreIdentifier; import org.opendaylight.controller.sal.core.api.data.DataChangeListener; @@ -74,4 +76,10 @@ public class DataProviderServiceProxy extends AbstractBrokerServiceProxy>> registerCommitHandlerListener( + RegistrationListener> commitHandlerListener) { + return addRegistration(getDelegate().registerCommitHandlerListener(commitHandlerListener)); + } } diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/yang/opendaylight-dom-broker-impl.yang b/opendaylight/md-sal/sal-dom-broker/src/main/yang/opendaylight-dom-broker-impl.yang new file mode 100644 index 0000000000..bf12ac4f01 --- /dev/null +++ b/opendaylight/md-sal/sal-dom-broker/src/main/yang/opendaylight-dom-broker-impl.yang @@ -0,0 +1,61 @@ +module opendaylight-sal-dom-broker-impl { + yang-version 1; + namespace "urn:opendaylight:params:xml:ns:yang:controller:md:sal:dom:impl"; + prefix "binding-impl"; + + import config { prefix config; revision-date 2013-04-05; } + import opendaylight-md-sal-dom {prefix sal;} + + description + "Service definition for Binding Aware MD-SAL."; + + revision "2013-10-28" { + description + "Initial revision"; + } + + identity dom-broker-impl { + base config:module-type; + config:provided-service sal:dom-broker-osgi-registry; + config:java-name-prefix DomBrokerImpl; + } + + identity hash-map-data-store { + base config:module-type; + config:provided-service sal:dom-data-store; + config:java-name-prefix HashMapDataStore; + } + + identity schema-service-singleton { + base config:module-type; + config:provided-service sal:schema-service; + config:java-name-prefix SchemaServiceImplSingleton; + } + + augment "/config:modules/config:module/config:configuration" { + case dom-broker-impl { + when "/config:modules/config:module/config:type = 'dom-broker-impl'"; + container data-store { + uses config:service-ref { + refine type { + mandatory true; + config:required-identity sal:dom-data-store; + } + } + } + } + } + + augment "/config:modules/config:module/config:state" { + case hash-map-data-store { + when "/config:modules/config:module/config:type = 'hash-map-data-store'"; + } + } + + augment "/config:modules/config:module/config:state" { + case schema-service-singleton { + when "/config:modules/config:module/config:type = 'schema-service-singleton'"; + } + } + +} \ No newline at end of file diff --git a/opendaylight/md-sal/samples/pom.xml b/opendaylight/md-sal/samples/pom.xml index 04e0a32ffb..6b87a22418 100644 --- a/opendaylight/md-sal/samples/pom.xml +++ b/opendaylight/md-sal/samples/pom.xml @@ -27,7 +27,7 @@ false - toaster-it + diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/fromxml/ObjectNameAttributeReadingStrategy.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/fromxml/ObjectNameAttributeReadingStrategy.java index bdb9391e2b..59dc11f0b8 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/fromxml/ObjectNameAttributeReadingStrategy.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/fromxml/ObjectNameAttributeReadingStrategy.java @@ -15,9 +15,12 @@ import org.opendaylight.controller.netconf.util.xml.XmlElement; import org.opendaylight.controller.netconf.util.xml.XmlNetconfConstants; import java.util.List; +import java.util.Map; public class ObjectNameAttributeReadingStrategy extends AbstractAttributeReadingStrategy { + private static final Object PREFIX_SEPARATOR = ":"; + public ObjectNameAttributeReadingStrategy(DependencyAttribute attributeIfc) { super(attributeIfc); } @@ -35,11 +38,28 @@ public class ObjectNameAttributeReadingStrategy extends AbstractAttributeReading private ObjectNameAttributeMappingStrategy.MappedDependency resolve(XmlElement firstChild) { XmlElement typeElement = firstChild.getOnlyChildElementWithSameNamespace(XmlNetconfConstants.TYPE_KEY); - String serviceName = typeElement.getTextContent(); + Map.Entry prefixNamespace = typeElement.findNamespaceOfTextContent(); + + String serviceName = checkPrefixAndExtractServiceName(typeElement, prefixNamespace); + XmlElement nameElement = firstChild.getOnlyChildElementWithSameNamespace(XmlNetconfConstants.NAME_KEY); String dependencyName = nameElement.getTextContent(); - return new ObjectNameAttributeMappingStrategy.MappedDependency(serviceName, dependencyName); + return new ObjectNameAttributeMappingStrategy.MappedDependency(prefixNamespace.getValue(), serviceName, + dependencyName); + } + + public static String checkPrefixAndExtractServiceName(XmlElement typeElement, Map.Entry prefixNamespace) { + String serviceName = typeElement.getTextContent(); + + Preconditions.checkState(prefixNamespace.equals("") == false, "Service %s value not prefixed with namespace", + XmlNetconfConstants.TYPE_KEY); + String prefix = prefixNamespace.getKey() + PREFIX_SEPARATOR; + Preconditions.checkState(serviceName.startsWith(prefix), + "Service %s not correctly prefixed, expected %s, but was %s", XmlNetconfConstants.TYPE_KEY, prefix, + serviceName); + serviceName = serviceName.substring(prefix.length()); + return serviceName; } } diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectMapper.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectMapper.java index d63e61cea8..3e63b92884 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectMapper.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectMapper.java @@ -74,8 +74,9 @@ public class ObjectMapper extends AttributeIfcSwitchStatement> caseDependencyAttribute( DependencyAttribute attributeIfc) { String serviceName = attributeIfc.getDependency().getSie().getQName().getLocalName(); + String namespace = attributeIfc.getDependency().getSie().getQName().getNamespace().toString(); return new ObjectNameAttributeMappingStrategy((SimpleType) attributeIfc.getOpenType(), dependencyTracker, - serviceName); + serviceName, namespace); } @Override diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectNameAttributeMappingStrategy.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectNameAttributeMappingStrategy.java index 1febf02a2d..f4d88c7c8e 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectNameAttributeMappingStrategy.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/mapping/ObjectNameAttributeMappingStrategy.java @@ -21,11 +21,13 @@ public class ObjectNameAttributeMappingStrategy extends private final Services tracker; private final String serviceName; + private final String namespace; - public ObjectNameAttributeMappingStrategy(SimpleType openType, Services dependencyTracker, String serviceName) { + public ObjectNameAttributeMappingStrategy(SimpleType openType, Services dependencyTracker, String serviceName, String namespace) { super(openType); this.tracker = dependencyTracker; this.serviceName = serviceName; + this.namespace = namespace; } @Override @@ -40,17 +42,18 @@ public class ObjectNameAttributeMappingStrategy extends Util.checkType(value, ObjectName.class); ObjectName on = (ObjectName) value; - String refName = tracker.addServiceEntry(serviceName, on); + String refName = tracker.addServiceEntry(namespace, serviceName, on); - return Optional.of(new MappedDependency(serviceName, refName)); + return Optional.of(new MappedDependency(namespace, serviceName, refName)); } public static class MappedDependency { - private final String serviceName, refName; + private final String namespace, serviceName, refName; - public MappedDependency(String serviceName, String refName) { + public MappedDependency(String namespace, String serviceName, String refName) { this.serviceName = serviceName; this.refName = refName; + this.namespace = namespace; } public String getServiceName() { @@ -61,10 +64,15 @@ public class ObjectNameAttributeMappingStrategy extends return refName; } + public String getNamespace() { + return namespace; + } + @Override public String toString() { final StringBuffer sb = new StringBuffer("MappedDependency{"); - sb.append("serviceName='").append(serviceName).append('\''); + sb.append("namespace='").append(namespace).append('\''); + sb.append(", serviceName='").append(serviceName).append('\''); sb.append(", refName='").append(refName).append('\''); sb.append('}'); return sb.toString(); diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/resolving/ObjectNameAttributeResolvingStrategy.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/resolving/ObjectNameAttributeResolvingStrategy.java index 5469015a23..c6f306b360 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/resolving/ObjectNameAttributeResolvingStrategy.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/resolving/ObjectNameAttributeResolvingStrategy.java @@ -39,8 +39,12 @@ public class ObjectNameAttributeResolvingStrategy extends AbstractAttributeResol Util.checkType(value, ObjectNameAttributeMappingStrategy.MappedDependency.class); ObjectNameAttributeMappingStrategy.MappedDependency mappedDep = (ObjectNameAttributeMappingStrategy.MappedDependency) value; - ServiceInstance byRefName = serviceTracker.getByServiceAndRefName(mappedDep.getServiceName(), - mappedDep.getRefName()); + String serviceName = mappedDep.getServiceName(); + String refName = mappedDep.getRefName(); + String namespace = mappedDep.getNamespace(); + logger.trace("Getting service instance by service name {} : {} and ref name {}", namespace, serviceName, refName); + + ServiceInstance byRefName = serviceTracker.getByServiceAndRefName(namespace, serviceName, refName); ObjectName on = ObjectNameUtil.createReadOnlyModuleON(byRefName.getModuleName(), byRefName.getInstanceName()); logger.debug("Attribute {} : {} parsed to type {}", attrName, value, getOpenType()); return Optional.of(on); diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/toxml/ObjectNameAttributeWritingStrategy.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/toxml/ObjectNameAttributeWritingStrategy.java index b88b6722c8..8563b781e3 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/toxml/ObjectNameAttributeWritingStrategy.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/toxml/ObjectNameAttributeWritingStrategy.java @@ -37,8 +37,11 @@ public class ObjectNameAttributeWritingStrategy implements AttributeWritingStrat String moduleName = ((ObjectNameAttributeMappingStrategy.MappedDependency) value).getServiceName(); String refName = ((ObjectNameAttributeMappingStrategy.MappedDependency) value).getRefName(); + String namespaceForType = ((ObjectNameAttributeMappingStrategy.MappedDependency) value).getNamespace(); - final Element typeElement = XmlUtil.createTextElement(document, XmlNetconfConstants.TYPE_KEY, moduleName); + Element typeElement = XmlUtil.createPrefixedTextElement(document, XmlNetconfConstants.TYPE_KEY, XmlNetconfConstants.PREFIX, + moduleName); + XmlUtil.addPrefixedNamespaceAttr(typeElement, XmlNetconfConstants.PREFIX, namespaceForType); innerNode.appendChild(typeElement); final Element nameElement = XmlUtil.createTextElement(document, XmlNetconfConstants.NAME_KEY, refName); diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/Config.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/Config.java index 8c7621a24b..f96b3acf20 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/Config.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/Config.java @@ -8,13 +8,6 @@ package org.opendaylight.controller.netconf.confignetconfconnector.mapping.config; -import java.util.Collection; -import java.util.HashMap; -import java.util.List; -import java.util.Map; -import java.util.Map.Entry; -import java.util.Set; - import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.collect.HashMultimap; @@ -22,23 +15,41 @@ import com.google.common.collect.Lists; import com.google.common.collect.Maps; import com.google.common.collect.Multimap; import org.opendaylight.controller.config.api.jmx.ObjectNameUtil; +import org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditStrategyType; import org.opendaylight.controller.netconf.util.xml.XmlElement; import org.opendaylight.controller.netconf.util.xml.XmlNetconfConstants; import org.opendaylight.controller.netconf.util.xml.XmlUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.w3c.dom.Document; import org.w3c.dom.Element; import javax.management.ObjectName; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Map.Entry; +import java.util.Set; import static com.google.common.base.Preconditions.checkState; import static java.lang.String.format; public class Config { + private final Logger logger = LoggerFactory.getLogger(Config.class); - private final Map> moduleConfigs; + private final Map> moduleConfigs; + private final Map moduleNamesToConfigs; public Config(Map> moduleConfigs) { this.moduleConfigs = moduleConfigs; + Map moduleNamesToConfigs = new HashMap<>(); + for (Entry> entry : moduleConfigs.entrySet()) { + moduleNamesToConfigs.putAll(entry.getValue()); + } + this.moduleNamesToConfigs = Collections.unmodifiableMap(moduleNamesToConfigs); } private Map>> getMappedInstances(Set instancesToMap, @@ -64,7 +75,7 @@ public class Config { // All found instances add to service tracker in advance // This way all instances will be serialized as all available // services when get-config is triggered - // (even if they are not used as services by other onstances) + // (even if they are not used as services by other instances) // = more user friendly addServices(serviceTracker, instances, mbeEntry.getValue().getProvidedServices()); @@ -76,10 +87,10 @@ public class Config { } private void addServices(Services serviceTracker, Collection instances, - Collection providedServices) { + Multimap providedServices) { for (ObjectName instanceOn : instances) { - for (String serviceName : providedServices) { - serviceTracker.addServiceEntry(serviceName, instanceOn); + for (Entry serviceName : providedServices.entries()) { + serviceTracker.addServiceEntry(serviceName.getKey(), serviceName.getValue(), instanceOn); } } } @@ -138,6 +149,7 @@ public class Config { return root; } + // TODO remove commented modules from output private void addEmptyModulesCommented(Document document, Element root, String moduleNamespace, Entry> moduleMappingEntry) { Element emptyModule = document.createElement(XmlNetconfConstants.MODULE_KEY); @@ -152,18 +164,19 @@ public class Config { // TODO refactor, replace string representing namespace with namespace class // TODO refactor, replace Map->Multimap with e.g. ConfigElementResolved // class - public Map> fromXml(XmlElement xml) { + public Map> fromXml(XmlElement xml, Set instancesForFillingServiceRefMapping, + EditStrategyType defaultEditStrategyType) { Map> retVal = Maps.newHashMap(); List recognisedChildren = Lists.newArrayList(); - Services serviceTracker = fromXmlServices(xml, recognisedChildren); + Services serviceTracker = fromXmlServices(xml, recognisedChildren, instancesForFillingServiceRefMapping); List moduleElements = fromXmlModules(xml, recognisedChildren); xml.checkUnrecognisedElements(recognisedChildren); for (XmlElement moduleElement : moduleElements) { - resolveModule(retVal, serviceTracker, moduleElement); + resolveModule(retVal, serviceTracker, moduleElement, defaultEditStrategyType); } return retVal; @@ -184,7 +197,7 @@ public class Config { } private void resolveModule(Map> retVal, Services serviceTracker, - XmlElement moduleElement) { + XmlElement moduleElement, EditStrategyType defaultStrategy) { XmlElement typeElement = moduleElement.getOnlyChildElementWithSameNamespace(XmlNetconfConstants.TYPE_KEY); Entry prefixToNamespace = typeElement.findNamespaceOfTextContent(); String moduleNamespace = prefixToNamespace.getValue(); @@ -203,24 +216,40 @@ public class Config { } ModuleElementResolved moduleElementResolved = moduleMapping.fromXml(moduleElement, serviceTracker, - instanceName, moduleNamespace); + instanceName, moduleNamespace, defaultStrategy); innerMap.put(factoryName, moduleElementResolved); } - private Services fromXmlServices(XmlElement xml, List recognisedChildren) { + private Services fromXmlServices(XmlElement xml, List recognisedChildren, Set instancesForFillingServiceRefMapping) { Optional servicesElement = xml.getOnlyChildElementOptionally(XmlNetconfConstants.SERVICES_KEY, XmlNetconfConstants.URN_OPENDAYLIGHT_PARAMS_XML_NS_YANG_CONTROLLER_CONFIG); - Map> mappedServices; + Map>> mappedServices; if (servicesElement.isPresent()) { mappedServices = Services.fromXml(servicesElement.get()); recognisedChildren.add(servicesElement.get()); } else { mappedServices = new HashMap<>(); } + Services services = Services.resolveServices(mappedServices); + // merge with what candidate db contains by default - ref_ + + for(ObjectName existingON: instancesForFillingServiceRefMapping) { + logger.trace("Filling services from {}", existingON); + // get all its services + String factoryName = ObjectNameUtil.getFactoryName(existingON); + ModuleConfig moduleConfig = moduleNamesToConfigs.get(factoryName); + + checkState(moduleConfig != null, "Cannot find ModuleConfig with name " + factoryName + " in " + moduleNamesToConfigs); + // Set services = ; + for (Entry serviceName : moduleConfig.getProvidedServices().entries()) { + + services.addServiceEntry(serviceName.getKey(), serviceName.getValue(), existingON); + } + } - return Services.resolveServices(mappedServices); + return services; } private String getFactoryName(String factoryNameWithPrefix, String prefixOrEmptyString) { diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/InstanceConfig.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/InstanceConfig.java index d1ba0b0206..33858746cb 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/InstanceConfig.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/InstanceConfig.java @@ -24,6 +24,7 @@ import org.opendaylight.controller.netconf.confignetconfconnector.mapping.attrib import org.opendaylight.controller.netconf.confignetconfconnector.mapping.attributes.resolving.ObjectResolver; import org.opendaylight.controller.netconf.confignetconfconnector.mapping.attributes.toxml.AttributeWritingStrategy; import org.opendaylight.controller.netconf.confignetconfconnector.mapping.attributes.toxml.ObjectXmlWriter; +import org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditStrategyType; import org.opendaylight.controller.netconf.util.xml.XmlElement; import org.opendaylight.controller.netconf.util.xml.XmlNetconfConstants; import org.slf4j.Logger; @@ -109,22 +110,25 @@ public final class InstanceConfig { depTracker).prepareResolving(yangToAttrConfig); for (Entry configDefEntry : mappedConfig.getConfiguration().entrySet()) { + AttributeConfigElement value = configDefEntry.getValue(); + String attributeName = configDefEntry.getKey(); try { - AttributeResolvingStrategy> attributeResolvingStrategy = resolvingStrategies - .get(configDefEntry.getKey()); + .get(attributeName); + logger.trace("Trying to set value {} of attribute {} with {}", value, attributeName, attributeResolvingStrategy); - configDefEntry.getValue().resolveValue(attributeResolvingStrategy, configDefEntry.getKey()); - configDefEntry.getValue().setJmxName( - yangToAttrConfig.get(configDefEntry.getKey()).getUpperCaseCammelCase()); + value.resolveValue(attributeResolvingStrategy, attributeName); + value.setJmxName( + yangToAttrConfig.get(attributeName).getUpperCaseCammelCase()); } catch (Exception e) { - throw new IllegalStateException("Unable to resolve value " + configDefEntry.getValue() - + " to attribute " + configDefEntry.getKey(), e); + throw new IllegalStateException("Unable to resolve value " + value + + " to attribute " + attributeName, e); } } } - public InstanceConfigElementResolved fromXml(XmlElement moduleElement, Services services, String moduleNamespace) { + public InstanceConfigElementResolved fromXml(XmlElement moduleElement, Services services, String moduleNamespace, + EditStrategyType defaultStrategy) { Map retVal = Maps.newHashMap(); Map strats = new ObjectXmlReader().prepareReading(yangToAttrConfig); @@ -149,7 +153,7 @@ public final class InstanceConfig { XmlNetconfConstants.URN_IETF_PARAMS_XML_NS_NETCONF_BASE_1_0); InstanceConfigElementResolved instanceConfigElementResolved = perInstanceEditStrategy.equals("") ? new InstanceConfigElementResolved( - retVal) : new InstanceConfigElementResolved(perInstanceEditStrategy, retVal); + retVal, defaultStrategy) : new InstanceConfigElementResolved(perInstanceEditStrategy, retVal, defaultStrategy); resolveConfiguration(instanceConfigElementResolved, services); return instanceConfigElementResolved; diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/InstanceConfigElementResolved.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/InstanceConfigElementResolved.java index 6624fc182e..e4bd9212e9 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/InstanceConfigElementResolved.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/InstanceConfigElementResolved.java @@ -25,20 +25,26 @@ public class InstanceConfigElementResolved { private final EditStrategyType editStrategy; private final Map configuration; - public InstanceConfigElementResolved(String strat, Map configuration) { - EditStrategyType valueOf = checkStrategy(strat); + public InstanceConfigElementResolved(String currentStrategy, Map configuration, EditStrategyType defaultStrategy) { + EditStrategyType valueOf = checkStrategy(currentStrategy, defaultStrategy); this.editStrategy = valueOf; this.configuration = configuration; } - EditStrategyType checkStrategy(String strat) { - EditStrategyType valueOf = EditStrategyType.valueOf(strat); - if (EditStrategyType.defaultStrategy().isEnforcing()) { + public InstanceConfigElementResolved(Map configuration, EditStrategyType defaultStrategy) { + editStrategy = defaultStrategy; + this.configuration = configuration; + } + + + EditStrategyType checkStrategy(String currentStrategy, EditStrategyType defaultStrategy) { + EditStrategyType valueOf = EditStrategyType.valueOf(currentStrategy); + if (defaultStrategy.isEnforcing()) { Preconditions .checkArgument( - valueOf == EditStrategyType.defaultStrategy(), + valueOf == defaultStrategy, "With " - + EditStrategyType.defaultStrategy() + + defaultStrategy + " as " + EditConfigXmlParser.DEFAULT_OPERATION_KEY + " operations on module elements are not permitted since the default option is restrictive"); @@ -46,10 +52,6 @@ public class InstanceConfigElementResolved { return valueOf; } - public InstanceConfigElementResolved(Map configuration) { - editStrategy = EditStrategyType.defaultStrategy(); - this.configuration = configuration; - } public EditConfigStrategy getEditStrategy() { return editStrategy.getFittingStrategy(); diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/ModuleConfig.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/ModuleConfig.java index 3a0c54754b..2e2a26400f 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/ModuleConfig.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/ModuleConfig.java @@ -8,38 +8,48 @@ package org.opendaylight.controller.netconf.confignetconfconnector.mapping.config; +import com.google.common.collect.HashMultimap; +import com.google.common.collect.Multimap; import org.opendaylight.controller.config.api.jmx.ObjectNameUtil; +import org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditStrategyType; import org.opendaylight.controller.netconf.util.xml.XmlElement; import org.opendaylight.controller.netconf.util.xml.XmlNetconfConstants; import org.opendaylight.controller.netconf.util.xml.XmlUtil; +import org.opendaylight.yangtools.yang.common.QName; import org.w3c.dom.Document; import org.w3c.dom.Element; import javax.management.ObjectName; import java.util.Collection; -import java.util.Collections; public class ModuleConfig { private final String moduleName; private final InstanceConfig instanceConfig; - private final Collection providedServices; + private final Multimap providedServices; - public ModuleConfig(String moduleName, InstanceConfig mbeanMapping, Collection providedServices) { + public ModuleConfig(String moduleName, InstanceConfig mbeanMapping, Collection providedServices) { this.moduleName = moduleName; this.instanceConfig = mbeanMapping; - this.providedServices = providedServices; + this.providedServices = mapServices(providedServices); } - public ModuleConfig(String key, InstanceConfig instanceConfig) { - this(key, instanceConfig, Collections. emptyList()); + private Multimap mapServices(Collection providedServices) { + Multimap mapped = HashMultimap.create(); + + for (QName providedService : providedServices) { + String key = providedService.getNamespace().toString(); + mapped.put(key, providedService.getLocalName()); + } + + return mapped; } public InstanceConfig getMbeanMapping() { return instanceConfig; } - public Collection getProvidedServices() { + public Multimap getProvidedServices() { return providedServices; } @@ -68,16 +78,16 @@ public class ModuleConfig { private String getPrefix(String namespace) { // if(namespace.contains(":")==false) - return "prefix"; + return XmlNetconfConstants.PREFIX; // return namespace.substring(namespace.lastIndexOf(':') + 1, // namespace.length()); } public ModuleElementResolved fromXml(XmlElement moduleElement, Services depTracker, String instanceName, - String moduleNamespace) { + String moduleNamespace, EditStrategyType defaultStrategy) { - InstanceConfigElementResolved ice = instanceConfig.fromXml(moduleElement, depTracker, moduleNamespace); + InstanceConfigElementResolved ice = instanceConfig.fromXml(moduleElement, depTracker, moduleNamespace, defaultStrategy); return new ModuleElementResolved(instanceName, ice); } diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/Services.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/Services.java index 7e4b6c2c06..e4fa6f504b 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/Services.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/config/Services.java @@ -8,13 +8,17 @@ package org.opendaylight.controller.netconf.confignetconfconnector.mapping.config; +import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Function; import com.google.common.base.Preconditions; import com.google.common.collect.Maps; import com.google.common.collect.Sets; +import org.opendaylight.controller.netconf.confignetconfconnector.mapping.attributes.fromxml.ObjectNameAttributeReadingStrategy; import org.opendaylight.controller.netconf.util.xml.XmlElement; import org.opendaylight.controller.netconf.util.xml.XmlNetconfConstants; import org.opendaylight.controller.netconf.util.xml.XmlUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.w3c.dom.Document; import org.w3c.dom.Element; @@ -29,6 +33,7 @@ import java.util.regex.Matcher; import java.util.regex.Pattern; public final class Services { + private static final Logger logger = LoggerFactory.getLogger(Services.class); private static final String PROVIDER_KEY = "provider"; private static final String NAME_KEY = "name"; @@ -38,23 +43,33 @@ public final class Services { private long suffix = 1; private final Map instanceToRef = Maps.newHashMap(); - private final Map> serviceNameToRefNameToInstance = Maps + private final Map>> namespaceToServiceNameToRefNameToInstance = Maps .newHashMap(); - public String addServiceEntry(String serviceName, ObjectName on) { + public String addServiceEntry(String namespace, String serviceName, ObjectName on) { String moduleName = on.getKeyProperty("moduleFactoryName"); String instanceName = on.getKeyProperty("instanceName"); - return addServiceEntry(serviceName, moduleName, instanceName); + String refName = addServiceEntry(namespace, serviceName, moduleName, instanceName); + logger.trace("Added service entry to tracker. Service name {}, ref name {}, module name {}, instance name {}", + serviceName, refName, moduleName, instanceName); + return refName; } - public String addServiceEntry(String serviceName, String moduleName, String instanceName) { + @VisibleForTesting + public String addServiceEntry(String namespace, String serviceName, String moduleName, String instanceName) { ServiceInstance serviceInstance = new ServiceInstance(moduleName, instanceName); serviceInstance.setServiceName(serviceName); String refName = instanceToRef.get(serviceInstance); + Map> serviceNameToRefNameToInstance = namespaceToServiceNameToRefNameToInstance.get(namespace); + if (serviceNameToRefNameToInstance == null) { + serviceNameToRefNameToInstance = Maps.newHashMap(); + namespaceToServiceNameToRefNameToInstance.put(namespace, serviceNameToRefNameToInstance); + } + Map refNameToInstance = serviceNameToRefNameToInstance.get(serviceName); if (refNameToInstance == null) { refNameToInstance = Maps.newHashMap(); @@ -93,7 +108,11 @@ public final class Services { return refNamesAsSet; } - public ServiceInstance getByServiceAndRefName(String serviceName, String refName) { + public ServiceInstance getByServiceAndRefName(String namespace, String serviceName, String refName) { + Map> serviceNameToRefNameToInstance = namespaceToServiceNameToRefNameToInstance.get(namespace); + Preconditions.checkArgument(serviceNameToRefNameToInstance != null, "No serviceInstances mapped to " + namespace + " , " + + serviceNameToRefNameToInstance.keySet()); + Map refNameToInstance = serviceNameToRefNameToInstance.get(serviceName); Preconditions.checkArgument(refNameToInstance != null, "No serviceInstances mapped to " + serviceName + " , " + serviceNameToRefNameToInstance.keySet()); @@ -106,20 +125,28 @@ public final class Services { // TODO hide getMappedServices, call it explicitly in toXml - public Map> getMappedServices() { - Map> retVal = Maps.newHashMap(); + public Map>> getMappedServices() { + Map>> retVal = Maps.newHashMap(); + + for (String namespace : namespaceToServiceNameToRefNameToInstance.keySet()) { - for (String serviceName : serviceNameToRefNameToInstance.keySet()) { + Map> serviceNameToRefNameToInstance = namespaceToServiceNameToRefNameToInstance + .get(namespace); + Map> innerRetVal = Maps.newHashMap(); - Map innerRetVal = Maps.transformValues(serviceNameToRefNameToInstance.get(serviceName), - new Function() { - @Nullable - @Override - public String apply(@Nullable ServiceInstance serviceInstance) { - return serviceInstance.toString(); - } - }); - retVal.put(serviceName, innerRetVal); + for (String serviceName : serviceNameToRefNameToInstance.keySet()) { + + Map innerInnerRetVal = Maps.transformValues( + serviceNameToRefNameToInstance.get(serviceName), new Function() { + @Nullable + @Override + public String apply(@Nullable ServiceInstance serviceInstance) { + return serviceInstance.toString(); + } + }); + innerRetVal.put(serviceName, innerInnerRetVal); + } + retVal.put(namespace, innerRetVal); } return retVal; @@ -127,35 +154,45 @@ public final class Services { // TODO hide resolveServices, call it explicitly in fromXml - public static Services resolveServices(Map> mappedServices) { + public static Services resolveServices(Map>> mappedServices) { Services tracker = new Services(); - for (Entry> serviceEntry : mappedServices.entrySet()) { + for (Entry>> namespaceEntry : mappedServices.entrySet()) { + String namespace = namespaceEntry.getKey(); - String serviceName = serviceEntry.getKey(); - for (Entry refEntry : serviceEntry.getValue().entrySet()) { + for (Entry> serviceEntry : namespaceEntry.getValue().entrySet()) { - Map refNameToInstance = tracker.serviceNameToRefNameToInstance - .get(serviceName); - if (refNameToInstance == null) { - refNameToInstance = Maps.newHashMap(); - tracker.serviceNameToRefNameToInstance.put(serviceName, refNameToInstance); - } + String serviceName = serviceEntry.getKey(); + for (Entry refEntry : serviceEntry.getValue().entrySet()) { - String refName = refEntry.getKey(); - Preconditions.checkState(false == refNameToInstance.containsKey(refName), - "Duplicate reference name to service " + refName + " under service " + serviceName); - ServiceInstance serviceInstance = ServiceInstance.fromString(refEntry.getValue()); - refNameToInstance.put(refName, serviceInstance); + Map> namespaceToServices = tracker.namespaceToServiceNameToRefNameToInstance.get(namespace); + if (namespaceToServices == null) { + namespaceToServices = Maps.newHashMap(); + tracker.namespaceToServiceNameToRefNameToInstance.put(namespace, namespaceToServices); + } + + Map refNameToInstance = namespaceToServices + .get(serviceName); + if (refNameToInstance == null) { + refNameToInstance = Maps.newHashMap(); + namespaceToServices.put(serviceName, refNameToInstance); + } - tracker.instanceToRef.put(serviceInstance, refEntry.getKey()); + String refName = refEntry.getKey(); + Preconditions.checkState(false == refNameToInstance.containsKey(refName), + "Duplicate reference name to service " + refName + " under service " + serviceName); + ServiceInstance serviceInstance = ServiceInstance.fromString(refEntry.getValue()); + refNameToInstance.put(refName, serviceInstance); + + tracker.instanceToRef.put(serviceInstance, refEntry.getKey()); + } } } return tracker; } - public static Map> fromXml(XmlElement xml) { - Map> retVal = Maps.newHashMap(); + public static Map>> fromXml(XmlElement xml) { + Map>> retVal = Maps.newHashMap(); List services = xml.getChildElements(SERVICE_KEY); xml.checkUnrecognisedElements(services); @@ -163,10 +200,20 @@ public final class Services { for (XmlElement service : services) { XmlElement typeElement = service.getOnlyChildElement(TYPE_KEY); - String serviceName = typeElement.getTextContent(); + Entry prefixNamespace = typeElement.findNamespaceOfTextContent(); + + Preconditions.checkState(prefixNamespace.getKey()!=null && prefixNamespace.getKey().equals("") == false, "Type attribute was not prefixed"); + + Map> namespaceToServices = retVal.get(prefixNamespace.getValue()); + if(namespaceToServices == null) { + namespaceToServices = Maps.newHashMap(); + retVal.put(prefixNamespace.getValue(), namespaceToServices); + } + + String serviceName = ObjectNameAttributeReadingStrategy.checkPrefixAndExtractServiceName(typeElement, prefixNamespace); Map innerMap = Maps.newHashMap(); - retVal.put(serviceName, innerMap); + namespaceToServices.put(serviceName, innerMap); List instances = service.getChildElements(XmlNetconfConstants.INSTANCE_KEY); service.checkUnrecognisedElements(instances, typeElement); @@ -197,29 +244,34 @@ public final class Services { } } - public Element toXml(Map> mappedServices, Document document) { + public Element toXml(Map>> mappedServices, Document document) { Element root = document.createElement(XmlNetconfConstants.SERVICES_KEY); XmlUtil.addNamespaceAttr(root, XmlNetconfConstants.URN_OPENDAYLIGHT_PARAMS_XML_NS_YANG_CONTROLLER_CONFIG); - for (Entry> serviceEntry : mappedServices.entrySet()) { - Element serviceElement = document.createElement(SERVICE_KEY); - root.appendChild(serviceElement); + for (String namespace : mappedServices.keySet()) { + + for (Entry> serviceEntry : mappedServices.get(namespace).entrySet()) { + Element serviceElement = document.createElement(SERVICE_KEY); + root.appendChild(serviceElement); - Element typeElement = XmlUtil.createTextElement(document, TYPE_KEY, serviceEntry.getKey()); - serviceElement.appendChild(typeElement); + Element typeElement = XmlUtil.createPrefixedTextElement(document, TYPE_KEY, XmlNetconfConstants.PREFIX, + serviceEntry.getKey()); + XmlUtil.addPrefixedNamespaceAttr(typeElement, XmlNetconfConstants.PREFIX, namespace); + serviceElement.appendChild(typeElement); - for (Entry instanceEntry : serviceEntry.getValue().entrySet()) { - Element instanceElement = document.createElement(XmlNetconfConstants.INSTANCE_KEY); - serviceElement.appendChild(instanceElement); + for (Entry instanceEntry : serviceEntry.getValue().entrySet()) { + Element instanceElement = document.createElement(XmlNetconfConstants.INSTANCE_KEY); + serviceElement.appendChild(instanceElement); - Element nameElement = XmlUtil.createTextElement(document, NAME_KEY, instanceEntry.getKey()); - instanceElement.appendChild(nameElement); + Element nameElement = XmlUtil.createTextElement(document, NAME_KEY, instanceEntry.getKey()); + instanceElement.appendChild(nameElement); - Element providerElement = XmlUtil.createTextElement(document, PROVIDER_KEY, instanceEntry.getValue()); - instanceElement.appendChild(providerElement); + Element providerElement = XmlUtil.createTextElement(document, PROVIDER_KEY, instanceEntry.getValue()); + instanceElement.appendChild(providerElement); + } } - } + } return root; } diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfig.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfig.java index be3b01db5d..101af48a89 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfig.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfig.java @@ -27,6 +27,7 @@ import org.opendaylight.controller.netconf.confignetconfconnector.mapping.config import org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.ModuleConfig; import org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.ModuleElementResolved; import org.opendaylight.controller.netconf.confignetconfconnector.operations.AbstractConfigNetconfOperation; +import org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfigXmlParser.EditConfigExecution; import org.opendaylight.controller.netconf.confignetconfconnector.transactions.TransactionProvider; import org.opendaylight.controller.netconf.util.xml.XmlElement; import org.opendaylight.controller.netconf.util.xml.XmlNetconfConstants; @@ -88,9 +89,9 @@ public class EditConfig extends AbstractConfigNetconfOperation { } private void executeTests(ConfigRegistryClient configRegistryClient, - EditConfigXmlParser.EditConfigExecution editConfigExecution) throws NetconfDocumentedException { + EditConfigExecution editConfigExecution) throws NetconfDocumentedException { try { - test(configRegistryClient, editConfigExecution.resolvedXmlElements); + test(configRegistryClient, editConfigExecution.getResolvedXmlElements(), editConfigExecution.getDefaultStrategy()); } catch (IllegalStateException | JmxAttributeValidationException | ValidationException e) { logger.warn("Test phase for {} failed", EditConfigXmlParser.EDIT_CONFIG, e); final Map errorInfo = new HashMap<>(); @@ -102,12 +103,12 @@ public class EditConfig extends AbstractConfigNetconfOperation { } private void test(ConfigRegistryClient configRegistryClient, - Map> resolvedModules) { + Map> resolvedModules, EditStrategyType editStrategyType) { ObjectName taON = transactionProvider.getTestTransaction(); try { // default strategy = replace wipes config - if (EditStrategyType.defaultStrategy() == EditStrategyType.replace) { + if (editStrategyType == EditStrategyType.replace) { transactionProvider.wipeTestTransaction(taON); } setOnTransaction(configRegistryClient, resolvedModules, taON); @@ -122,10 +123,10 @@ public class EditConfig extends AbstractConfigNetconfOperation { ObjectName taON = transactionProvider.getOrCreateTransaction(); // default strategy = replace wipes config - if (EditStrategyType.defaultStrategy() == EditStrategyType.replace) { + if (editConfigExecution.getDefaultStrategy() == EditStrategyType.replace) { transactionProvider.wipeTransaction(); } - setOnTransaction(configRegistryClient, editConfigExecution.resolvedXmlElements, taON); + setOnTransaction(configRegistryClient, editConfigExecution.getResolvedXmlElements(), taON); } private void setOnTransaction(ConfigRegistryClient configRegistryClient, @@ -147,14 +148,18 @@ public class EditConfig extends AbstractConfigNetconfOperation { } public static Config getConfigMapping(ConfigRegistryClient configRegistryClient, - Map> mBeanEntries) { + Map> mBeanEntries) { Map> factories = transform(configRegistryClient, mBeanEntries); + return new Config(factories); } // TODO refactor - private static Map> transform(final ConfigRegistryClient configRegistryClient, - Map> mBeanEntries) { + private static Map> transform + (final ConfigRegistryClient configRegistryClient, Map> mBeanEntries) { return Maps.transformEntries(mBeanEntries, new Maps.EntryTransformer, Map>() { @@ -164,9 +169,9 @@ public class EditConfig extends AbstractConfigNetconfOperation { new Maps.EntryTransformer() { @Override - public ModuleConfig transformEntry(String key, ModuleMXBeanEntry value) { - return new ModuleConfig(key, new InstanceConfig(configRegistryClient, value - .getAttributes())); + public ModuleConfig transformEntry(String key, ModuleMXBeanEntry moduleMXBeanEntry) { + return new ModuleConfig(key, new InstanceConfig(configRegistryClient, moduleMXBeanEntry + .getAttributes()), moduleMXBeanEntry.getProvidedServices().values()); } }); } @@ -184,7 +189,7 @@ public class EditConfig extends AbstractConfigNetconfOperation { EditConfigXmlParser.EditConfigExecution editConfigExecution; Config cfg = getConfigMapping(configRegistryClient, yangStoreSnapshot.getModuleMXBeanEntryMap()); try { - editConfigExecution = editConfigXmlParser.fromXml(xml, cfg); + editConfigExecution = editConfigXmlParser.fromXml(xml, cfg, transactionProvider, configRegistryClient); } catch (IllegalStateException e) { logger.warn("Error parsing xml", e); final Map errorInfo = new HashMap<>(); diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfigXmlParser.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfigXmlParser.java index d835dfd30f..3d4e5b6d0c 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfigXmlParser.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfigXmlParser.java @@ -12,17 +12,22 @@ import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.collect.Multimap; +import org.opendaylight.controller.config.util.ConfigRegistryClient; import org.opendaylight.controller.netconf.api.NetconfDocumentedException; import org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.Config; import org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.ModuleElementResolved; import org.opendaylight.controller.netconf.confignetconfconnector.operations.Datastore; +import org.opendaylight.controller.netconf.confignetconfconnector.transactions.TransactionProvider; import org.opendaylight.controller.netconf.util.xml.XmlElement; import org.opendaylight.controller.netconf.util.xml.XmlNetconfConstants; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import javax.management.ObjectName; import java.util.Arrays; +import java.util.Collections; import java.util.Map; +import java.util.Set; public class EditConfigXmlParser { @@ -38,10 +43,11 @@ public class EditConfigXmlParser { public EditConfigXmlParser() { } - EditConfigXmlParser.EditConfigExecution fromXml(final XmlElement xml, final Config cfgMapping) + EditConfigXmlParser.EditConfigExecution fromXml(final XmlElement xml, final Config cfgMapping, + TransactionProvider transactionProvider, ConfigRegistryClient configRegistryClient) throws NetconfDocumentedException { - EditStrategyType.resetDefaultStrategy(); + EditStrategyType editStrategyType = EditStrategyType.getDefaultStrategy(); xml.checkName(EditConfigXmlParser.EDIT_CONFIG); xml.checkNamespace(XmlNetconfConstants.URN_IETF_PARAMS_XML_NS_NETCONF_BASE_1_0); @@ -81,12 +87,22 @@ public class EditConfigXmlParser { // Default op Optional defaultContent = xml .getOnlyChildElementWithSameNamespaceOptionally(EditConfigXmlParser.DEFAULT_OPERATION_KEY); - if (defaultContent.isPresent()) - EditStrategyType.setDefaultStrategy(EditStrategyType.valueOf(defaultContent.get().getTextContent())); + if (defaultContent.isPresent()) { + String mergeStrategyString = defaultContent.get().getTextContent(); + logger.trace("Setting merge strategy to {}", mergeStrategyString); + editStrategyType = EditStrategyType.valueOf(mergeStrategyString); + } + Set instancesForFillingServiceRefMapping = Collections.emptySet(); + if (editStrategyType == EditStrategyType.merge) { + instancesForFillingServiceRefMapping = Datastore.getInstanceQueryStrategy(targetDatastore, transactionProvider) + .queryInstances(configRegistryClient); + logger.trace("Pre-filling services from following instances: {}", instancesForFillingServiceRefMapping); + } XmlElement configElement = xml.getOnlyChildElementWithSameNamespace(XmlNetconfConstants.CONFIG_KEY); - return new EditConfigXmlParser.EditConfigExecution(xml, cfgMapping, configElement, testOption); + return new EditConfigXmlParser.EditConfigExecution(xml, cfgMapping, configElement, testOption, + instancesForFillingServiceRefMapping, editStrategyType); } private void removeMountpointsFromConfig(XmlElement configElement, XmlElement mountpointsElement) { @@ -119,14 +135,17 @@ public class EditConfigXmlParser { @VisibleForTesting static class EditConfigExecution { - XmlElement editConfigXml; - Map> resolvedXmlElements; - TestOption testOption; + private final XmlElement editConfigXml; + private final Map> resolvedXmlElements; + private final TestOption testOption; + private final EditStrategyType defaultEditStrategyType; - EditConfigExecution(XmlElement xml, Config configResolver, XmlElement configElement, TestOption testOption) { + EditConfigExecution(XmlElement xml, Config configResolver, XmlElement configElement, TestOption testOption, Set instancesForFillingServiceRefMapping, + EditStrategyType defaultStrategy) { this.editConfigXml = xml; - this.resolvedXmlElements = configResolver.fromXml(configElement); + this.resolvedXmlElements = configResolver.fromXml(configElement, instancesForFillingServiceRefMapping, defaultStrategy); this.testOption = testOption; + this.defaultEditStrategyType = defaultStrategy; } boolean shouldTest() { @@ -136,5 +155,13 @@ public class EditConfigXmlParser { boolean shouldSet() { return testOption == TestOption.set || testOption == TestOption.testThenSet; } + + Map> getResolvedXmlElements() { + return resolvedXmlElements; + } + + EditStrategyType getDefaultStrategy() { + return defaultEditStrategyType; + } } } diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditStrategyType.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditStrategyType.java index a7a0518cc5..cb03342a1e 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditStrategyType.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditStrategyType.java @@ -11,8 +11,7 @@ package org.opendaylight.controller.netconf.confignetconfconnector.operations.ed import java.util.EnumSet; import java.util.Set; -import com.google.common.base.Preconditions; - +//FIXME: make thread safe public enum EditStrategyType { // can be default merge, replace, none, @@ -21,20 +20,8 @@ public enum EditStrategyType { private static final Set defaultStrats = EnumSet.of(merge, replace, none); - private static EditStrategyType defaultStrat = merge; - - public static EditStrategyType defaultStrategy() { - return defaultStrat; - } - - public static void setDefaultStrategy(EditStrategyType strat) { - Preconditions.checkArgument(strat.canBeDefault(), "Default edit strategy can be only of value " + defaultStrats - + ", but was " + strat); - defaultStrat = strat; - } - - public static void resetDefaultStrategy() { - setDefaultStrategy(EditStrategyType.merge); + public static EditStrategyType getDefaultStrategy() { + return merge; } public boolean isEnforcing() { @@ -53,16 +40,6 @@ public enum EditStrategyType { } } - private static final EnumSet defaults; - - static { - defaults = EnumSet.of(merge, replace, none); - } - - private boolean canBeDefault() { - return defaults.contains(this); - } - public EditConfigStrategy getFittingStrategy() { switch (this) { case merge: diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/getconfig/GetConfig.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/getconfig/GetConfig.java index 9b8c1503c7..79b3e26aec 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/getconfig/GetConfig.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/getconfig/GetConfig.java @@ -80,6 +80,7 @@ public class GetConfig extends AbstractConfigNetconfOperation { Element dataElement = document.createElement(XmlNetconfConstants.DATA_KEY); final Set instances = Datastore.getInstanceQueryStrategy(source, this.transactionProvider) .queryInstances(configRegistryClient); + final Config configMapping = new Config(transform(configRegistryClient, yangStoreSnapshot.getModuleMXBeanEntryMap())); dataElement = configMapping.toXml(instances, this.maybeNamespace, document, dataElement); diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/runtimerpc/RuntimeRpc.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/runtimerpc/RuntimeRpc.java index f838c6f9f5..7463bdd429 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/runtimerpc/RuntimeRpc.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/runtimerpc/RuntimeRpc.java @@ -127,6 +127,7 @@ public class RuntimeRpc extends AbstractConfigNetconfOperation { if (contextInstanceElement.isPresent() == false) return HandlingPriority.CANNOT_HANDLE; + // FIXME update xpath to instance to conform to config-api yang final RuntimeRpcElementResolved id = RuntimeRpcElementResolved.fromXpath(contextInstanceElement.get() .getTextContent(), netconfOperationName, netconfOperationNamespace); diff --git a/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/NetconfMappingTest.java b/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/NetconfMappingTest.java index d404a96468..de0ecdbf1e 100644 --- a/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/NetconfMappingTest.java +++ b/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/NetconfMappingTest.java @@ -143,6 +143,7 @@ public class NetconfMappingTest extends AbstractConfigTest { edit("netconfMessages/editConfig.xml"); checkBinaryLeafEdited(getConfigCandidate()); + // default-operation:none, should not affect binary leaf edit("netconfMessages/editConfig_none.xml"); checkBinaryLeafEdited(getConfigCandidate()); @@ -150,7 +151,6 @@ public class NetconfMappingTest extends AbstractConfigTest { // check after edit commit(); Element response = getConfigRunning(); - // System.out.println(Xml.toString(response)); checkBinaryLeafEdited(response); checkTypeConfigAttribute(response); diff --git a/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/ServiceTrackerTest.java b/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/ServiceTrackerTest.java index e07f9ce3e1..425ecf6d02 100644 --- a/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/ServiceTrackerTest.java +++ b/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/ServiceTrackerTest.java @@ -1,10 +1,10 @@ /* - * Copyright (c) 2013 Cisco Systems, Inc. and others. All rights reserved. - * - * This program and the accompanying materials are made available under the - * terms of the Eclipse Public License v1.0 which accompanies this distribution, - * and is available at http://www.eclipse.org/legal/epl-v10.html - */ +* Copyright (c) 2013 Cisco Systems, Inc. and others. All rights reserved. +* +* This program and the accompanying materials are made available under the +* terms of the Eclipse Public License v1.0 which accompanies this distribution, +* and is available at http://www.eclipse.org/legal/epl-v10.html +*/ package org.opendaylight.controller.netconf.confignetconfconnector; @@ -31,41 +31,41 @@ public class ServiceTrackerTest { @Test public void testOneInstanceMultipleServices() { Services services = new Services(); - services.addServiceEntry("s1", "module", "instance"); + services.addServiceEntry("nm", "s1", "module", "instance"); assertEquals(1, services.getMappedServices().size()); - services.addServiceEntry("s2", "module", "instance"); + services.addServiceEntry("nm2", "s2", "module", "instance"); assertEquals(2, services.getMappedServices().size()); } @Test public void testMultipleInstancesOneName() throws Exception { Services services = new Services(); - services.addServiceEntry("s1", "module", "instance"); + services.addServiceEntry("nm", "s1", "module", "instance"); assertEquals(1, services.getMappedServices().size()); - services.addServiceEntry("s1", "module2", "instance"); + services.addServiceEntry("nm", "s1", "module2", "instance"); assertEquals(1, services.getMappedServices().size()); - assertEquals(2, services.getMappedServices().get("s1").size()); - assertTrue(services.getMappedServices().get("s1").containsKey("ref_instance")); - assertTrue(services.getMappedServices().get("s1").containsKey("ref_instance_1")); + assertEquals(2, services.getMappedServices().get("nm").get("s1").size()); + assertTrue(services.getMappedServices().get("nm").get("s1").containsKey("ref_instance")); + assertTrue(services.getMappedServices().get("nm").get("s1").containsKey("ref_instance_1")); } @Test public void testMultipleInstancesOneName2() throws Exception { Services services = new Services(); - services.addServiceEntry("s1", "module", "instance_1"); - - services.addServiceEntry("s2", "module2", "instance"); - services.addServiceEntry("s2", "module3", "instance"); - services.addServiceEntry("s1", "module3", "instance"); - - assertEquals(2, services.getMappedServices().get("s1").size()); - assertEquals(2, services.getMappedServices().get("s2").size()); - assertTrue(services.getMappedServices().get("s1").containsKey("ref_instance_2")); - assertTrue(services.getMappedServices().get("s1").containsKey("ref_instance_1")); - assertTrue(services.getMappedServices().get("s2").containsKey("ref_instance")); - assertTrue(services.getMappedServices().get("s2").containsKey("ref_instance_2")); + services.addServiceEntry("nm", "s1", "module", "instance_1"); + + services.addServiceEntry("nm2", "s2", "module2", "instance"); + services.addServiceEntry("nm2", "s2", "module3", "instance"); + services.addServiceEntry("nm", "s1", "module3", "instance"); + + assertEquals(2, services.getMappedServices().get("nm").get("s1").size()); + assertEquals(2, services.getMappedServices().get("nm2").get("s2").size()); + assertTrue(services.getMappedServices().get("nm").get("s1").containsKey("ref_instance_2")); + assertTrue(services.getMappedServices().get("nm").get("s1").containsKey("ref_instance_1")); + assertTrue(services.getMappedServices().get("nm2").get("s2").containsKey("ref_instance")); + assertTrue(services.getMappedServices().get("nm2").get("s2").containsKey("ref_instance_2")); } } diff --git a/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfigTest.java b/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfigTest.java index 123c03e9a1..1b8e24702a 100644 --- a/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfigTest.java +++ b/opendaylight/netconf/config-netconf-connector/src/test/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/EditConfigTest.java @@ -31,7 +31,9 @@ import org.opendaylight.controller.netconf.util.xml.XmlElement; import org.opendaylight.controller.netconf.util.xml.XmlUtil; import javax.management.ObjectName; +import java.util.Collections; import java.util.Map; +import java.util.Set; import static org.mockito.Matchers.any; import static org.mockito.Matchers.anyMap; @@ -86,10 +88,12 @@ public class EditConfigTest { Config cfg = mock(Config.class); XmlElement xmlElement = mock(XmlElement.class); - doReturn(resolvedXmlElements).when(cfg).fromXml(xmlElement); + Set instancesForFillingServiceRefMapping = Collections.emptySet(); + EditStrategyType defaultStrategy = EditStrategyType.getDefaultStrategy(); + doReturn(resolvedXmlElements).when(cfg).fromXml(xmlElement, instancesForFillingServiceRefMapping, defaultStrategy); EditConfigExecution editConfigExecution = new EditConfigExecution(null, cfg, xmlElement, - EditConfigXmlParser.TestOption.testThenSet); + EditConfigXmlParser.TestOption.testThenSet, instancesForFillingServiceRefMapping, defaultStrategy); edit.getResponseInternal(XmlUtil.newDocument(), editConfigExecution); diff --git a/opendaylight/netconf/netconf-impl/src/main/java/org/opendaylight/controller/netconf/impl/osgi/NetconfOperationRouterImpl.java b/opendaylight/netconf/netconf-impl/src/main/java/org/opendaylight/controller/netconf/impl/osgi/NetconfOperationRouterImpl.java index 3dd6e6803b..54deb91837 100644 --- a/opendaylight/netconf/netconf-impl/src/main/java/org/opendaylight/controller/netconf/impl/osgi/NetconfOperationRouterImpl.java +++ b/opendaylight/netconf/netconf-impl/src/main/java/org/opendaylight/controller/netconf/impl/osgi/NetconfOperationRouterImpl.java @@ -7,14 +7,9 @@ */ package org.opendaylight.controller.netconf.impl.osgi; -import java.util.Collections; -import java.util.HashSet; -import java.util.Iterator; -import java.util.LinkedList; -import java.util.Set; -import java.util.TreeMap; -import java.util.TreeSet; - +import com.google.common.base.Preconditions; +import com.google.common.collect.Maps; +import com.google.common.collect.Sets; import org.opendaylight.controller.netconf.api.NetconfDocumentedException; import org.opendaylight.controller.netconf.api.NetconfOperationRouter; import org.opendaylight.controller.netconf.api.NetconfSession; @@ -36,9 +31,14 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.w3c.dom.Document; -import com.google.common.base.Preconditions; -import com.google.common.collect.Maps; -import com.google.common.collect.Sets; +import java.util.Collections; +import java.util.HashSet; +import java.util.Iterator; +import java.util.LinkedList; +import java.util.Map; +import java.util.Set; +import java.util.TreeMap; +import java.util.TreeSet; public class NetconfOperationRouterImpl implements NetconfOperationRouter { @@ -116,9 +116,33 @@ public class NetconfOperationRouterImpl implements NetconfOperationRouter { @Override public synchronized Document onNetconfMessage(Document message, NetconfSession session) throws NetconfDocumentedException { - NetconfOperationExecution netconfOperationExecution = getNetconfOperationWithHighestPriority( - message, session); - logger.debug("Forwarding netconf message {} to {}", XmlUtil.toString(message), + NetconfOperationExecution netconfOperationExecution = null; + + String messageAsString = XmlUtil.toString(message); + + try { + netconfOperationExecution = getNetconfOperationWithHighestPriority( + message, session); + } catch (IllegalArgumentException | IllegalStateException e) { + logger.warn("Unable to handle rpc {} on session {}", messageAsString, session, e); + + String errorMessage = String.format("Unable to handle rpc %s on session %s", messageAsString, session); + Map errorInfo = Maps.newHashMap(); + + NetconfDocumentedException.ErrorTag tag = null; + if (e instanceof IllegalArgumentException) { + errorInfo.put(NetconfDocumentedException.ErrorTag.operation_not_supported.toString(), e.getMessage()); + tag = NetconfDocumentedException.ErrorTag.operation_not_supported; + } else if (e instanceof IllegalStateException) { + errorInfo.put(NetconfDocumentedException.ErrorTag.operation_failed.toString(), e.getMessage()); + tag = NetconfDocumentedException.ErrorTag.operation_failed; + } + + throw new NetconfDocumentedException(errorMessage, e, NetconfDocumentedException.ErrorType.application, + tag, NetconfDocumentedException.ErrorSeverity.error, errorInfo); + } + + logger.debug("Forwarding netconf message {} to {}", messageAsString, netconfOperationExecution.operationWithHighestPriority); final LinkedList chain = new LinkedList<>(); @@ -147,7 +171,7 @@ public class NetconfOperationRouterImpl implements NetconfOperationRouter { TreeMap> sortedPriority = getSortedNetconfOperationsWithCanHandle( message, session); - Preconditions.checkState(sortedPriority.isEmpty() == false, "No %s available to handle message %s", + Preconditions.checkArgument(sortedPriority.isEmpty() == false, "No %s available to handle message %s", NetconfOperation.class.getName(), XmlUtil.toString(message)); HandlingPriority highestFoundPriority = sortedPriority.lastKey(); diff --git a/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/xml/XmlElement.java b/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/xml/XmlElement.java index c37b4abc62..212214cd2a 100644 --- a/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/xml/XmlElement.java +++ b/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/xml/XmlElement.java @@ -326,7 +326,7 @@ public class XmlElement { prefix = ""; } if (namespaces.containsKey(prefix) == false) { - throw new IllegalArgumentException("Cannot find namespace for " + element + ". Prefix from content is " + throw new IllegalArgumentException("Cannot find namespace for " + XmlUtil.toString(element) + ". Prefix from content is " + prefix + ". Found namespaces " + namespaces); } return Maps.immutableEntry(prefix, namespaces.get(prefix)); diff --git a/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/xml/XmlNetconfConstants.java b/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/xml/XmlNetconfConstants.java index 2a900e052b..7fb293f054 100644 --- a/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/xml/XmlNetconfConstants.java +++ b/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/xml/XmlNetconfConstants.java @@ -33,6 +33,8 @@ public class XmlNetconfConstants { public static final String NAME_KEY = "name"; public static final String NOTIFICATION_ELEMENT_NAME = "notification"; + public static final String PREFIX = "prefix"; + // // public static final String RFC4741_TARGET_NAMESPACE = "urn:ietf:params:xml:ns:netconf:base:1.0"; diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/editConfig.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/editConfig.xml index 904c0a6322..0611dceb3a 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/editConfig.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/editConfig.xml @@ -75,7 +75,7 @@ 44 - testing + prefix:testing ref_dep @@ -86,7 +86,7 @@ test2 - testing + prefix:testing ref_dep @@ -94,7 +94,7 @@ - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep'] diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/editConfig_none.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/editConfig_none.xml index 42021c59a3..c825536b7b 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/editConfig_none.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/editConfig_none.xml @@ -69,7 +69,7 @@ 44 - testing + prefix:testing ref_dep @@ -79,14 +79,14 @@ test2 - testing + prefix:testing ref_dep - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep'] diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_differentNamespaceTO.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_differentNamespaceTO.xml index efa4690f6f..82c218dd73 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_differentNamespaceTO.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_differentNamespaceTO.xml @@ -75,7 +75,7 @@ 44 - testing + prefix:testing ref_dep @@ -86,7 +86,7 @@ test2 - testing + prefix:testing ref_dep @@ -94,7 +94,7 @@ - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep'] diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_sameAttrDifferentNamespaces.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_sameAttrDifferentNamespaces.xml index 3dbb297c29..7c19b9f7b3 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_sameAttrDifferentNamespaces.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_sameAttrDifferentNamespaces.xml @@ -76,7 +76,7 @@ 44 - testing + prefix:testing ref_dep @@ -87,7 +87,7 @@ test2 - testing + prefix:testing ref_dep @@ -95,7 +95,7 @@ - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep'] diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_sameAttrDifferentNamespacesList.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_sameAttrDifferentNamespacesList.xml index 504ccff78f..84ae575559 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_sameAttrDifferentNamespacesList.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_sameAttrDifferentNamespacesList.xml @@ -75,7 +75,7 @@ 44 - testing + prefix:testing ref_dep @@ -86,7 +86,7 @@ test2 - testing + prefix:testing ref_dep @@ -94,7 +94,7 @@ - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep'] diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_typeNameConfigAttributeMatching.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_typeNameConfigAttributeMatching.xml index 8398fdb588..2d9e9edb2c 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_typeNameConfigAttributeMatching.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/namespaces/editConfig_typeNameConfigAttributeMatching.xml @@ -74,7 +74,7 @@ 44 - testing + prefix:testing ref_dep @@ -85,7 +85,7 @@ test2 - testing + prefix:testing ref_dep @@ -93,7 +93,7 @@ - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep'] diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised1.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised1.xml index 6b267c57a3..e675e86d07 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised1.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised1.xml @@ -23,7 +23,7 @@ - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep'] diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised2.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised2.xml index 8ca7ee724a..9407dd0c75 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised2.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised2.xml @@ -24,7 +24,7 @@ - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep'] diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised3.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised3.xml index d3705cc3c4..233ad23286 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised3.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised3.xml @@ -25,7 +25,7 @@ error l - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep'] diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised4.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised4.xml index a485574969..4593887f49 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised4.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised4.xml @@ -24,7 +24,7 @@ l - testing + prefix:testing error diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised5.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised5.xml index 654a183359..81c4137d4e 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised5.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised5.xml @@ -24,7 +24,7 @@ l - testing + prefix:testing ref_dep diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised6.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised6.xml index fc43a77406..528d5b06fc 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised6.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised6.xml @@ -23,7 +23,7 @@ - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep'] diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised7.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised7.xml index 1bea536934..a1e304b374 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised7.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised7.xml @@ -75,7 +75,7 @@ 44 - testing + prefix:testing ref_dep @@ -86,7 +86,7 @@ test2 - testing + prefix:testing ref_dep @@ -94,7 +94,7 @@ - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep'] diff --git a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised8.xml b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised8.xml index d0afb276aa..812882a2a9 100644 --- a/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised8.xml +++ b/opendaylight/netconf/netconf-util/src/test/resources/netconfMessages/unrecognised/editConfig_unrecognised8.xml @@ -75,7 +75,7 @@ error - testing + prefix:testing ref_dep @@ -86,7 +86,7 @@ test2 - testing + prefix:testing ref_dep @@ -94,7 +94,7 @@ - testing + prefix:testing ref_dep /config/modules/module[name='impl-dep']/instance[name='dep']