From: Robert Varga <rovarga@cisco.com>
Date: Wed, 30 Mar 2016 08:53:08 +0000 (+0200)
Subject: Simplify isolated leader check
X-Git-Tag: release/boron~274
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=15f11d24306fe2796411e8078a84fc82213bacf6

Simplify isolated leader check

Sonar warns about nested ifs, merge them.

Change-Id: I77fcee90b467bc141b79aa5f8fcccb7f8b4f2fe3
Signed-off-by: Robert Varga <rovarga@cisco.com>
---

diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java
index e58d4f57c6..a4ce0da482 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java
@@ -60,16 +60,15 @@ public class Leader extends AbstractLeader {
         isolatedLeaderCheck = Stopwatch.createStarted();
     }
 
-    @Override public RaftActorBehavior handleMessage(ActorRef sender, Object originalMessage) {
+    @Override
+    public RaftActorBehavior handleMessage(ActorRef sender, Object originalMessage) {
         Preconditions.checkNotNull(sender, "sender should not be null");
 
-        if (ISOLATED_LEADER_CHECK.equals(originalMessage)) {
-            if (isLeaderIsolated()) {
-                LOG.warn("{}: At least {} followers need to be active, Switching {} from Leader to IsolatedLeader",
-                        context.getId(), getMinIsolatedLeaderPeerCount(), leaderId);
+        if (ISOLATED_LEADER_CHECK.equals(originalMessage) && isLeaderIsolated()) {
+            LOG.warn("{}: At least {} followers need to be active, Switching {} from Leader to IsolatedLeader",
+                context.getId(), getMinIsolatedLeaderPeerCount(), leaderId);
 
-                return internalSwitchBehavior(RaftState.IsolatedLeader);
-            }
+            return internalSwitchBehavior(RaftState.IsolatedLeader);
         }
 
         return super.handleMessage(sender, originalMessage);