From: Robert Varga Date: Tue, 29 Nov 2022 21:07:21 +0000 (+0100) Subject: Add missing final keywords X-Git-Tag: v7.0.0~25 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=3f406c078a3fc91f1ea2199fe32d53e9e1064f4b Add missing final keywords We have a few ommissions here, fix that up. Change-Id: If633f22e293e7a0ca022d12bed8f39ec68ae05d0 Signed-off-by: Robert Varga --- diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/DatastoreSnapshot.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/DatastoreSnapshot.java index 31e4356bbc..ec32091809 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/DatastoreSnapshot.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/DatastoreSnapshot.java @@ -37,7 +37,7 @@ public final class DatastoreSnapshot implements Serializable { void resolveTo(@NonNull DatastoreSnapshot newDatastoreSnapshot); @Override - default void readExternal(ObjectInput in) throws IOException, ClassNotFoundException { + default void readExternal(final ObjectInput in) throws IOException, ClassNotFoundException { final var type = (String)in.readObject(); final var snapshot = (ShardManagerSnapshot) in.readObject(); @@ -51,7 +51,7 @@ public final class DatastoreSnapshot implements Serializable { } @Override - default void writeExternal(ObjectOutput out) throws IOException { + default void writeExternal(final ObjectOutput out) throws IOException { final var datastoreSnapshot = datastoreSnapshot(); out.writeObject(datastoreSnapshot.type); out.writeObject(datastoreSnapshot.shardManagerSnapshot); @@ -85,7 +85,7 @@ public final class DatastoreSnapshot implements Serializable { } @Override - public void resolveTo(DatastoreSnapshot newDatastoreSnapshot) { + public void resolveTo(final DatastoreSnapshot newDatastoreSnapshot) { datastoreSnapshot = requireNonNull(newDatastoreSnapshot); } @@ -101,8 +101,8 @@ public final class DatastoreSnapshot implements Serializable { private final ShardManagerSnapshot shardManagerSnapshot; private final @NonNull ImmutableList shardSnapshots; - public DatastoreSnapshot(@NonNull String type, @Nullable ShardManagerSnapshot shardManagerSnapshot, - @NonNull List shardSnapshots) { + public DatastoreSnapshot(final @NonNull String type, final @Nullable ShardManagerSnapshot shardManagerSnapshot, + final @NonNull List shardSnapshots) { this.type = requireNonNull(type); this.shardManagerSnapshot = shardManagerSnapshot; this.shardSnapshots = ImmutableList.copyOf(shardSnapshots); @@ -134,14 +134,14 @@ public final class DatastoreSnapshot implements Serializable { void resolveTo(String name, Snapshot snapshot); @Override - default void writeExternal(ObjectOutput out) throws IOException { + default void writeExternal(final ObjectOutput out) throws IOException { final var shardSnapshot = shardSnapshot(); out.writeObject(shardSnapshot.name); out.writeObject(shardSnapshot.snapshot); } @Override - default void readExternal(ObjectInput in) throws IOException, ClassNotFoundException { + default void readExternal(final ObjectInput in) throws IOException, ClassNotFoundException { resolveTo((String) in.readObject(), (Snapshot) in.readObject()); } } @@ -183,7 +183,7 @@ public final class DatastoreSnapshot implements Serializable { private final @NonNull String name; private final @NonNull Snapshot snapshot; - public ShardSnapshot(@NonNull String name, @NonNull Snapshot snapshot) { + public ShardSnapshot(final @NonNull String name, final @NonNull Snapshot snapshot) { this.name = requireNonNull(name); this.snapshot = requireNonNull(snapshot); }